From: Florian Fainelli <f.fainelli@gmail.com> To: John Crispin <blogic@openwrt.org>, Andrew Lunn <andrew@lunn.ch> Cc: "Fred Chang (?????????)" <Fred.Chang@mediatek.com>, "Steven Liu (?????????)" <steven.liu@mediatek.com>, netdev@vger.kernel.org, "Carlos Huang (?????????)" <Carlos.Huang@mediatek.com>, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, Matthias Brugger <matthias.bgg@gmail.com>, "David S. Miller" <davem@davemloft.net>, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH V2 03/12] net-next: mediatek: add embedded switch driver (ESW) Date: Fri, 26 Feb 2016 10:34:31 -0800 [thread overview] Message-ID: <56D09AB7.3000203@gmail.com> (raw) In-Reply-To: <56D06E3F.1020100@openwrt.org> On 26/02/16 07:24, John Crispin wrote: > > Hi, > > would the series be ok if we just dropped those parts and then have a > driver in the kernel that wont do much with the out of tree patches ? > > the problem here is that on one side people complain about vendors not > sending code upstream. once they start being a good citizen and provide > funding to send stuff upstream the feedback tends to be very bad as seen > here. I agree with David here, the feedback from Andrew is very constructive, you just don't like the feedback you are being given, which is a different thing. You can't always get a 12 series patches adding a new driver accepted after second try, look at all the recent submissions that occured, it took 5-6-7 maybe more submissions until things were in a shape where they could be merged. If for your next submission you get the feedback that switchdev/DSA is deprecated, and something new needs to be used, then I would agree that feedback is not acceptable, I doubt this will be the case unless we wait another 10 years to get these patches out. > we are planning on doing a DSA driver but one step at a time. this > kind of feedback will inevitably lead to vendors doing second thoughts > of upstream contributions. If you are planning on a DSA driver, which sounds like a good plan, then maybe drop the integrated switch parts for now, keep it as a local set of patches for your testing, and just get the basic CPU Ethernet MAC driver to work for data movement, so that part gets in, and later on, when your DSA driver is ready, that's one less thing to take care of. They ultimately are logically spearated drivers if you use DSA, a little less if you use switchdev. -- Florian
WARNING: multiple messages have this Message-ID (diff)
From: f.fainelli@gmail.com (Florian Fainelli) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH V2 03/12] net-next: mediatek: add embedded switch driver (ESW) Date: Fri, 26 Feb 2016 10:34:31 -0800 [thread overview] Message-ID: <56D09AB7.3000203@gmail.com> (raw) In-Reply-To: <56D06E3F.1020100@openwrt.org> On 26/02/16 07:24, John Crispin wrote: > > Hi, > > would the series be ok if we just dropped those parts and then have a > driver in the kernel that wont do much with the out of tree patches ? > > the problem here is that on one side people complain about vendors not > sending code upstream. once they start being a good citizen and provide > funding to send stuff upstream the feedback tends to be very bad as seen > here. I agree with David here, the feedback from Andrew is very constructive, you just don't like the feedback you are being given, which is a different thing. You can't always get a 12 series patches adding a new driver accepted after second try, look at all the recent submissions that occured, it took 5-6-7 maybe more submissions until things were in a shape where they could be merged. If for your next submission you get the feedback that switchdev/DSA is deprecated, and something new needs to be used, then I would agree that feedback is not acceptable, I doubt this will be the case unless we wait another 10 years to get these patches out. > we are planning on doing a DSA driver but one step at a time. this > kind of feedback will inevitably lead to vendors doing second thoughts > of upstream contributions. If you are planning on a DSA driver, which sounds like a good plan, then maybe drop the integrated switch parts for now, keep it as a local set of patches for your testing, and just get the basic CPU Ethernet MAC driver to work for data movement, so that part gets in, and later on, when your DSA driver is ready, that's one less thing to take care of. They ultimately are logically spearated drivers if you use DSA, a little less if you use switchdev. -- Florian
next prev parent reply other threads:[~2016-02-26 18:35 UTC|newest] Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-02-26 14:21 [PATCH V2 00/12] net-next: mediatek: add ethernet driver John Crispin 2016-02-26 14:21 ` John Crispin 2016-02-26 14:21 ` [PATCH V2 01/12] net-next: mediatek: Document ralink/mediatek SoC ethernet binding John Crispin 2016-02-26 14:21 ` John Crispin 2016-03-02 18:46 ` Rob Herring 2016-03-02 18:46 ` Rob Herring 2016-03-02 18:46 ` Rob Herring 2016-03-02 18:49 ` John Crispin 2016-03-02 18:49 ` John Crispin 2016-03-02 18:49 ` John Crispin 2016-02-26 14:21 ` [PATCH V2 02/12] net-next: mediatek: add the drivers core files John Crispin 2016-02-26 14:21 ` John Crispin 2016-02-26 14:21 ` John Crispin 2016-02-26 14:21 ` [PATCH V2 03/12] net-next: mediatek: add embedded switch driver (ESW) John Crispin 2016-02-26 14:21 ` John Crispin 2016-02-26 14:21 ` John Crispin 2016-02-26 15:18 ` Andrew Lunn 2016-02-26 15:18 ` Andrew Lunn 2016-02-26 15:24 ` John Crispin 2016-02-26 15:24 ` John Crispin 2016-02-26 17:05 ` Andrew Lunn 2016-02-26 17:05 ` Andrew Lunn 2016-02-26 17:44 ` David Miller 2016-02-26 17:44 ` David Miller 2016-02-26 17:36 ` David Miller 2016-02-26 17:36 ` David Miller 2016-02-26 18:34 ` Florian Fainelli [this message] 2016-02-26 18:34 ` Florian Fainelli 2016-02-26 16:25 ` Felix Fietkau 2016-02-26 16:25 ` Felix Fietkau 2016-02-26 17:29 ` Andrew Lunn 2016-02-26 17:29 ` Andrew Lunn 2016-02-26 17:43 ` David Miller 2016-02-26 17:43 ` David Miller 2016-02-26 17:35 ` David Miller 2016-02-26 17:35 ` David Miller 2016-02-26 14:21 ` [PATCH V2 04/12] net-next: mediatek: add gigabit switch driver (GSW) John Crispin 2016-02-26 14:21 ` John Crispin 2016-02-26 14:21 ` John Crispin 2016-02-26 14:21 ` [PATCH V2 05/12] net-next: mediatek: add support for rt2880 John Crispin 2016-02-26 14:21 ` John Crispin 2016-02-26 14:21 ` [PATCH V2 06/12] net-next: mediatek: add support for rt3050 John Crispin 2016-02-26 14:21 ` John Crispin 2016-02-26 14:21 ` John Crispin 2016-02-26 14:21 ` [PATCH V2 07/12] net-next: mediatek: add support for rt3883 John Crispin 2016-02-26 14:21 ` John Crispin 2016-02-26 14:21 ` [PATCH V2 08/12] net-next: mediatek: add support for mt7620 John Crispin 2016-02-26 14:21 ` John Crispin 2016-02-26 14:21 ` John Crispin 2016-02-26 14:21 ` [PATCH V2 09/12] net-next: mediatek: add support for mt7621 John Crispin 2016-02-26 14:21 ` John Crispin 2016-02-26 14:21 ` [PATCH V2 10/12] net-next: mediatek: add support for mt7623 John Crispin 2016-02-26 14:21 ` John Crispin 2016-02-26 14:21 ` [PATCH V2 11/12] net-next: mediatek: add Kconfig and Makefile John Crispin 2016-02-26 14:21 ` John Crispin 2016-02-27 3:29 ` kbuild test robot 2016-02-27 3:29 ` kbuild test robot 2016-02-27 3:29 ` kbuild test robot 2016-02-26 14:21 ` [PATCH V2 12/12] net-next: mediatek: add an entry to MAINTAINERS John Crispin 2016-02-26 14:21 ` John Crispin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=56D09AB7.3000203@gmail.com \ --to=f.fainelli@gmail.com \ --cc=Carlos.Huang@mediatek.com \ --cc=Fred.Chang@mediatek.com \ --cc=andrew@lunn.ch \ --cc=blogic@openwrt.org \ --cc=davem@davemloft.net \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=matthias.bgg@gmail.com \ --cc=netdev@vger.kernel.org \ --cc=steven.liu@mediatek.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.