All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Vivier <lvivier@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, Andrew Jones <drjones@redhat.com>
Cc: kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, thuth@redhat.com,
	dgibson@redhat.com, agraf@suse.de
Subject: Re: [kvm-unit-tests PATCH v2 2/2] powerpc: select endianness
Date: Mon, 29 Feb 2016 17:44:51 +0100	[thread overview]
Message-ID: <56D47583.8010706@redhat.com> (raw)
In-Reply-To: <56D46C9D.9050908@redhat.com>



On 29/02/2016 17:06, Paolo Bonzini wrote:
> 
> 
> On 26/02/2016 19:45, Andrew Jones wrote:
>>>> +	LOAD_REG_ADDR(r10,rtas_return_loc)
>>>> +	mtlr	r10
>>>> +
>>>>  	LOAD_REG_ADDR(r10, rtas_blob)
>>>> -//FIXME: change this bctrl to an rtas-prep, rfid, rtas-return sequence
>>>> -	mtctr	r10
>>>> -	nop
>>>> -	bctrl
>>>> +	B_BE(r10)
> 
> Note that this doesn't apply.  I've applied patch 1 though.

Yes, Drew has changed this part, and anyway I have to rework this.

Thanks,
Laurent

> Paolo
> 
>>>> +
>>>> +rtas_return_loc:
>>>> +	RETURN_FROM_BE
>>>>  	ld	r0, 16(r1)
>>>>  	mtlr	r0
>>>>  	blr
>> Besides my earlier comment about always needing rfid to prep for the
>> rtas call (which my FIXUP comment here poorly indicated), then this
>> looks good to me. Although I'm not sure I like the name RETURN_FROM_BE,
>> as sometimes we're returning to LE, and sometimes we're not. In the
>> not case, it's a bit confusing.

WARNING: multiple messages have this Message-ID (diff)
From: Laurent Vivier <lvivier@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, Andrew Jones <drjones@redhat.com>
Cc: kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, thuth@redhat.com,
	dgibson@redhat.com, agraf@suse.de
Subject: Re: [kvm-unit-tests PATCH v2 2/2] powerpc: select endianness
Date: Mon, 29 Feb 2016 16:44:51 +0000	[thread overview]
Message-ID: <56D47583.8010706@redhat.com> (raw)
In-Reply-To: <56D46C9D.9050908@redhat.com>



On 29/02/2016 17:06, Paolo Bonzini wrote:
> 
> 
> On 26/02/2016 19:45, Andrew Jones wrote:
>>>> +	LOAD_REG_ADDR(r10,rtas_return_loc)
>>>> +	mtlr	r10
>>>> +
>>>>  	LOAD_REG_ADDR(r10, rtas_blob)
>>>> -//FIXME: change this bctrl to an rtas-prep, rfid, rtas-return sequence
>>>> -	mtctr	r10
>>>> -	nop
>>>> -	bctrl
>>>> +	B_BE(r10)
> 
> Note that this doesn't apply.  I've applied patch 1 though.

Yes, Drew has changed this part, and anyway I have to rework this.

Thanks,
Laurent

> Paolo
> 
>>>> +
>>>> +rtas_return_loc:
>>>> +	RETURN_FROM_BE
>>>>  	ld	r0, 16(r1)
>>>>  	mtlr	r0
>>>>  	blr
>> Besides my earlier comment about always needing rfid to prep for the
>> rtas call (which my FIXUP comment here poorly indicated), then this
>> looks good to me. Although I'm not sure I like the name RETURN_FROM_BE,
>> as sometimes we're returning to LE, and sometimes we're not. In the
>> not case, it's a bit confusing.

  reply	other threads:[~2016-02-29 16:44 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-26 17:08 [kvm-unit-tests PATCH v2 0/2] powerpc: add little-endian support Laurent Vivier
2016-02-26 17:08 ` Laurent Vivier
2016-02-26 17:08 ` [kvm-unit-tests PATCH v2 1/2] powerpc: allow to build big-endian binaries on little-endian host Laurent Vivier
2016-02-26 17:08   ` Laurent Vivier
2016-02-26 17:41   ` Andrew Jones
2016-02-26 17:41     ` Andrew Jones
2016-02-26 17:42   ` Andrew Jones
2016-02-26 17:42     ` Andrew Jones
2016-02-26 17:08 ` [kvm-unit-tests PATCH v2 2/2] powerpc: select endianness Laurent Vivier
2016-02-26 17:08   ` Laurent Vivier
2016-02-26 18:45   ` Andrew Jones
2016-02-26 18:45     ` Andrew Jones
2016-02-29 13:24     ` Laurent Vivier
2016-02-29 13:24       ` Laurent Vivier
2016-02-29 16:06     ` Paolo Bonzini
2016-02-29 16:06       ` Paolo Bonzini
2016-02-29 16:44       ` Laurent Vivier [this message]
2016-02-29 16:44         ` Laurent Vivier
2016-02-29 17:53     ` Laurent Vivier
2016-02-29 17:53       ` Laurent Vivier
2019-05-15  0:28 [kvm-unit-tests PATCH v2 1/2] powerpc: Allow for a custom decr value to be specified to load on decr excp Suraj Jitindar Singh
2019-05-15  0:28 ` [kvm-unit-tests PATCH v2 1/2] powerpc: Allow for a custom decr value to be specified to load on decr Suraj Jitindar Singh
2019-05-15  0:28 ` [kvm-unit-tests PATCH v2 2/2] powerpc: Make h_cede_tm test run by default Suraj Jitindar Singh
2019-05-15  0:28   ` Suraj Jitindar Singh
2019-05-15 16:25   ` Laurent Vivier
2019-05-15 16:25     ` Laurent Vivier
2019-05-17 10:13   ` Thomas Huth
2019-05-17 10:13     ` Thomas Huth
2019-05-15 16:22 ` [kvm-unit-tests PATCH v2 1/2] powerpc: Allow for a custom decr value to be specified to load on decr excp Laurent Vivier
2019-05-15 16:22   ` [kvm-unit-tests PATCH v2 1/2] powerpc: Allow for a custom decr value to be specified to load on Laurent Vivier
2019-05-15 23:27   ` [kvm-unit-tests PATCH v2 1/2] powerpc: Allow for a custom decr value to be specified to load on decr excp Suraj Jitindar Singh
2019-05-15 23:27     ` [kvm-unit-tests PATCH v2 1/2] powerpc: Allow for a custom decr value to be specified to load on Suraj Jitindar Singh
2019-05-17 10:20     ` [kvm-unit-tests PATCH v2 1/2] powerpc: Allow for a custom decr value to be specified to load on decr excp Thomas Huth
2019-05-17 10:20       ` [kvm-unit-tests PATCH v2 1/2] powerpc: Allow for a custom decr value to be specified to load on Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56D47583.8010706@redhat.com \
    --to=lvivier@redhat.com \
    --cc=agraf@suse.de \
    --cc=dgibson@redhat.com \
    --cc=drjones@redhat.com \
    --cc=kvm-ppc@vger.kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.