From: David Daney <ddaney@caviumnetworks.com>
To: Jan Glauber <jglauber@cavium.com>
Cc: Wolfram Sang <wsa@the-dreams.de>, <linux-kernel@vger.kernel.org>,
<linux-i2c@vger.kernel.org>
Subject: Re: [PATCH] i2c-thunderx: fix compile error for x86_64
Date: Tue, 1 Mar 2016 09:02:21 -0800 [thread overview]
Message-ID: <56D5CB1D.7010104@caviumnetworks.com> (raw)
In-Reply-To: <1456840398-9275-1-git-send-email-jglauber@cavium.com>
On 03/01/2016 05:53 AM, Jan Glauber wrote:
> The i2c-thunderx driver only depends on 64BIT and PCI,
> because there is no reason to limit it to ARM64.
>
> Adjusting the check in the header file that selects Octeon
> or ThunderX values to check for CONFIG_I2C_THUNDERX
> instead of CONFIG_ARCH_THUNDER fixes the compile error
> on x86_64.
>
> Signed-off-by: Jan Glauber <jglauber@cavium.com>
Yes, CONFIG_ARCH_THUNDER must die wherever it is encountered.
Acked-by: David Daney <david.daney@cavium.com>
That said, since the previous patch set didn't build under some
configurations, can you fold this in, and submit a v2 that is complete
and stand alone?
Thanks,
David Daney
> ---
> drivers/i2c/busses/i2c-cavium.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-cavium.h b/drivers/i2c/busses/i2c-cavium.h
> index 8357997..c7398f4 100644
> --- a/drivers/i2c/busses/i2c-cavium.h
> +++ b/drivers/i2c/busses/i2c-cavium.h
> @@ -8,7 +8,7 @@
> #include <linux/pci.h>
>
> /* Register offsets */
> -#ifdef CONFIG_ARCH_THUNDER
> +#ifdef CONFIG_I2C_THUNDERX
> #define SW_TWSI 0x1000
> #define TWSI_INT 0x1010
> #define SW_TWSI_EXT 0x1018
>
WARNING: multiple messages have this Message-ID (diff)
From: David Daney <ddaney@caviumnetworks.com>
To: Jan Glauber <jglauber@cavium.com>
Cc: Wolfram Sang <wsa@the-dreams.de>,
linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org
Subject: Re: [PATCH] i2c-thunderx: fix compile error for x86_64
Date: Tue, 1 Mar 2016 09:02:21 -0800 [thread overview]
Message-ID: <56D5CB1D.7010104@caviumnetworks.com> (raw)
In-Reply-To: <1456840398-9275-1-git-send-email-jglauber@cavium.com>
On 03/01/2016 05:53 AM, Jan Glauber wrote:
> The i2c-thunderx driver only depends on 64BIT and PCI,
> because there is no reason to limit it to ARM64.
>
> Adjusting the check in the header file that selects Octeon
> or ThunderX values to check for CONFIG_I2C_THUNDERX
> instead of CONFIG_ARCH_THUNDER fixes the compile error
> on x86_64.
>
> Signed-off-by: Jan Glauber <jglauber@cavium.com>
Yes, CONFIG_ARCH_THUNDER must die wherever it is encountered.
Acked-by: David Daney <david.daney@cavium.com>
That said, since the previous patch set didn't build under some
configurations, can you fold this in, and submit a v2 that is complete
and stand alone?
Thanks,
David Daney
> ---
> drivers/i2c/busses/i2c-cavium.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-cavium.h b/drivers/i2c/busses/i2c-cavium.h
> index 8357997..c7398f4 100644
> --- a/drivers/i2c/busses/i2c-cavium.h
> +++ b/drivers/i2c/busses/i2c-cavium.h
> @@ -8,7 +8,7 @@
> #include <linux/pci.h>
>
> /* Register offsets */
> -#ifdef CONFIG_ARCH_THUNDER
> +#ifdef CONFIG_I2C_THUNDERX
> #define SW_TWSI 0x1000
> #define TWSI_INT 0x1010
> #define SW_TWSI_EXT 0x1018
>
next prev parent reply other threads:[~2016-03-01 17:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-29 13:46 [Resend PATCH 00/10] i2c-octeon and i2c-thunderx drivers Jan Glauber
2016-02-29 13:46 ` [Resend PATCH 01/10] i2c-octeon: Cleanup i2c-octeon driver Jan Glauber
2016-02-29 13:46 ` [Resend PATCH 02/10] i2c-octeon: Support I2C_M_RECV_LEN Jan Glauber
2016-02-29 13:46 ` [Resend PATCH 03/10] i2c-octeon: Enable high-level controller and improve on bus contention Jan Glauber
2016-02-29 13:46 ` [Resend PATCH 04/10] dt-bindings: i2c: add Octeon cn78xx TWSI Jan Glauber
2016-02-29 13:46 ` [Resend PATCH 05/10] i2c-octeon: Add support for cn78XX chips Jan Glauber
2016-02-29 13:46 ` [Resend PATCH 06/10] i2c-octeon: Flush TWSI writes with readback Jan Glauber
2016-02-29 13:46 ` [Resend PATCH 07/10] i2c-octeon: Faster operation when IFLG signals late Jan Glauber
2016-02-29 13:46 ` [Resend PATCH 08/10] i2c-octeon: Add workaround for chips with broken irqs Jan Glauber
2016-02-29 13:46 ` [Resend PATCH 09/10] i2c: split i2c-octeon driver and add ThunderX support Jan Glauber
2016-02-29 14:55 ` kbuild test robot
2016-02-29 14:55 ` kbuild test robot
2016-03-01 13:53 ` [PATCH] i2c-thunderx: fix compile error for x86_64 Jan Glauber
2016-03-01 17:02 ` David Daney [this message]
2016-03-01 17:02 ` David Daney
2016-02-29 13:46 ` [Resend PATCH 10/10] i2c: thunderx: add smbus support Jan Glauber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D5CB1D.7010104@caviumnetworks.com \
--to=ddaney@caviumnetworks.com \
--cc=jglauber@cavium.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.