From: Vlastimil Babka <vbabka@suse.cz> To: linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org> Cc: linux-kernel@vger.kernel.org, Andrea Arcangeli <aarcange@redhat.com>, "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>, Rik van Riel <riel@redhat.com>, Joonsoo Kim <iamjoonsoo.kim@lge.com>, Mel Gorman <mgorman@techsingularity.net>, David Rientjes <rientjes@google.com>, Michal Hocko <mhocko@suse.com>, Johannes Weiner <hannes@cmpxchg.org> Subject: Re: [PATCH v2 4/5] mm, kswapd: replace kswapd compaction with waking up kcompactd Date: Wed, 2 Mar 2016 13:27:37 +0100 [thread overview] Message-ID: <56D6DC39.4020608@suse.cz> (raw) In-Reply-To: <1454938691-2197-5-git-send-email-vbabka@suse.cz> A fixlet for things Joonsoo caught. ----8<---- From: Vlastimil Babka <vbabka@suse.cz> Date: Wed, 2 Mar 2016 11:50:16 +0100 Subject: mm-kswapd-replace-kswapd-compaction-with-waking-up-kcompactd-fix Change zone_balanced() check in balance_pgdat() to consider only base pages as that's the same what kswapd_shrink_zone() later does. So a zone that would be selected due to lack of high-order pages would not be reclaimed anyway, and just cause extra CPU churn. Also remove unnecessary variable testorder in kswapd_shrink_zone(). Reported-by: Joonsoo Kim <iamjoonsoo.kim@lge.com> Signed-off-by: Vlastimil Babka <vbabka@suse.cz> --- mm/vmscan.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index b8478a737ef5..23bc7e643ad8 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -3073,7 +3073,6 @@ static bool kswapd_shrink_zone(struct zone *zone, int classzone_idx, struct scan_control *sc) { - int testorder = sc->order; unsigned long balance_gap; bool lowmem_pressure; @@ -3094,7 +3093,7 @@ static bool kswapd_shrink_zone(struct zone *zone, * reclaim is necessary */ lowmem_pressure = (buffer_heads_over_limit && is_highmem(zone)); - if (!lowmem_pressure && zone_balanced(zone, testorder, false, + if (!lowmem_pressure && zone_balanced(zone, sc->order, false, balance_gap, classzone_idx)) return true; @@ -3109,7 +3108,7 @@ static bool kswapd_shrink_zone(struct zone *zone, * waits. */ if (zone_reclaimable(zone) && - zone_balanced(zone, testorder, false, 0, classzone_idx)) { + zone_balanced(zone, sc->order, false, 0, classzone_idx)) { clear_bit(ZONE_CONGESTED, &zone->flags); clear_bit(ZONE_DIRTY, &zone->flags); } @@ -3190,7 +3189,7 @@ static int balance_pgdat(pg_data_t *pgdat, int order, int classzone_idx) break; } - if (!zone_balanced(zone, order, true, 0, 0)) { + if (!zone_balanced(zone, order, false, 0, 0)) { end_zone = i; break; } else { -- 2.7.2
WARNING: multiple messages have this Message-ID (diff)
From: Vlastimil Babka <vbabka@suse.cz> To: linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org> Cc: linux-kernel@vger.kernel.org, Andrea Arcangeli <aarcange@redhat.com>, "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>, Rik van Riel <riel@redhat.com>, Joonsoo Kim <iamjoonsoo.kim@lge.com>, Mel Gorman <mgorman@techsingularity.net>, David Rientjes <rientjes@google.com>, Michal Hocko <mhocko@suse.com>, Johannes Weiner <hannes@cmpxchg.org> Subject: Re: [PATCH v2 4/5] mm, kswapd: replace kswapd compaction with waking up kcompactd Date: Wed, 2 Mar 2016 13:27:37 +0100 [thread overview] Message-ID: <56D6DC39.4020608@suse.cz> (raw) In-Reply-To: <1454938691-2197-5-git-send-email-vbabka@suse.cz> A fixlet for things Joonsoo caught. ----8<---- From: Vlastimil Babka <vbabka@suse.cz> Date: Wed, 2 Mar 2016 11:50:16 +0100 Subject: mm-kswapd-replace-kswapd-compaction-with-waking-up-kcompactd-fix Change zone_balanced() check in balance_pgdat() to consider only base pages as that's the same what kswapd_shrink_zone() later does. So a zone that would be selected due to lack of high-order pages would not be reclaimed anyway, and just cause extra CPU churn. Also remove unnecessary variable testorder in kswapd_shrink_zone(). Reported-by: Joonsoo Kim <iamjoonsoo.kim@lge.com> Signed-off-by: Vlastimil Babka <vbabka@suse.cz> --- mm/vmscan.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index b8478a737ef5..23bc7e643ad8 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -3073,7 +3073,6 @@ static bool kswapd_shrink_zone(struct zone *zone, int classzone_idx, struct scan_control *sc) { - int testorder = sc->order; unsigned long balance_gap; bool lowmem_pressure; @@ -3094,7 +3093,7 @@ static bool kswapd_shrink_zone(struct zone *zone, * reclaim is necessary */ lowmem_pressure = (buffer_heads_over_limit && is_highmem(zone)); - if (!lowmem_pressure && zone_balanced(zone, testorder, false, + if (!lowmem_pressure && zone_balanced(zone, sc->order, false, balance_gap, classzone_idx)) return true; @@ -3109,7 +3108,7 @@ static bool kswapd_shrink_zone(struct zone *zone, * waits. */ if (zone_reclaimable(zone) && - zone_balanced(zone, testorder, false, 0, classzone_idx)) { + zone_balanced(zone, sc->order, false, 0, classzone_idx)) { clear_bit(ZONE_CONGESTED, &zone->flags); clear_bit(ZONE_DIRTY, &zone->flags); } @@ -3190,7 +3189,7 @@ static int balance_pgdat(pg_data_t *pgdat, int order, int classzone_idx) break; } - if (!zone_balanced(zone, order, true, 0, 0)) { + if (!zone_balanced(zone, order, false, 0, 0)) { end_zone = i; break; } else { -- 2.7.2 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-03-02 12:27 UTC|newest] Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-02-08 13:38 [PATCH v2 0/5] introduce kcompactd and stop compacting in kswapd Vlastimil Babka 2016-02-08 13:38 ` Vlastimil Babka 2016-02-08 13:38 ` [PATCH v2 1/5] mm, kswapd: remove bogus check of balance_classzone_idx Vlastimil Babka 2016-02-08 13:38 ` Vlastimil Babka 2016-02-08 13:38 ` [PATCH v2 2/5] mm, compaction: introduce kcompactd Vlastimil Babka 2016-02-08 13:38 ` Vlastimil Babka 2016-03-02 6:09 ` Joonsoo Kim 2016-03-02 6:09 ` Joonsoo Kim 2016-03-02 12:25 ` Vlastimil Babka 2016-03-02 12:25 ` Vlastimil Babka 2016-02-08 13:38 ` [PATCH v2 3/5] mm, memory hotplug: small cleanup in online_pages() Vlastimil Babka 2016-02-08 13:38 ` Vlastimil Babka 2016-02-08 13:38 ` [PATCH v2 4/5] mm, kswapd: replace kswapd compaction with waking up kcompactd Vlastimil Babka 2016-02-08 13:38 ` Vlastimil Babka 2016-02-08 22:58 ` Andrew Morton 2016-02-08 22:58 ` Andrew Morton 2016-02-09 10:53 ` Vlastimil Babka 2016-02-09 10:53 ` Vlastimil Babka 2016-02-09 10:21 ` Vlastimil Babka 2016-02-09 10:21 ` Vlastimil Babka 2016-03-01 14:14 ` Vlastimil Babka 2016-03-01 14:14 ` Vlastimil Babka 2016-03-02 6:33 ` Joonsoo Kim 2016-03-02 6:33 ` Joonsoo Kim 2016-03-02 10:04 ` Vlastimil Babka 2016-03-02 10:04 ` Vlastimil Babka 2016-03-02 13:57 ` Joonsoo Kim 2016-03-02 13:57 ` Joonsoo Kim 2016-03-02 14:09 ` Vlastimil Babka 2016-03-02 14:09 ` Vlastimil Babka 2016-03-02 14:22 ` Joonsoo Kim 2016-03-02 14:22 ` Joonsoo Kim 2016-03-02 14:40 ` Vlastimil Babka 2016-03-02 14:40 ` Vlastimil Babka 2016-03-02 14:59 ` Joonsoo Kim 2016-03-02 14:59 ` Joonsoo Kim 2016-03-02 15:22 ` Vlastimil Babka 2016-03-02 15:22 ` Vlastimil Babka 2016-03-04 23:25 ` Andrew Morton 2016-03-04 23:25 ` Andrew Morton 2016-03-07 9:45 ` Vlastimil Babka 2016-03-07 9:45 ` Vlastimil Babka 2016-03-09 13:47 ` Vlastimil Babka 2016-03-09 13:47 ` Vlastimil Babka 2016-03-09 13:50 ` Vlastimil Babka 2016-03-09 13:50 ` Vlastimil Babka 2016-03-02 12:27 ` Vlastimil Babka [this message] 2016-03-02 12:27 ` Vlastimil Babka 2016-02-08 13:38 ` [PATCH v2 5/5] mm, compaction: adapt isolation_suitable flushing to kcompactd Vlastimil Babka 2016-02-08 13:38 ` Vlastimil Babka 2016-03-01 14:44 ` Vlastimil Babka 2016-03-01 14:44 ` Vlastimil Babka 2016-03-09 15:52 ` [PATCH v2 0/5] introduce kcompactd and stop compacting in kswapd Michal Hocko 2016-03-09 15:52 ` Michal Hocko 2016-03-10 8:38 ` Vlastimil Babka 2016-03-10 8:38 ` Vlastimil Babka
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=56D6DC39.4020608@suse.cz \ --to=vbabka@suse.cz \ --cc=aarcange@redhat.com \ --cc=akpm@linux-foundation.org \ --cc=hannes@cmpxchg.org \ --cc=iamjoonsoo.kim@lge.com \ --cc=kirill.shutemov@linux.intel.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mgorman@techsingularity.net \ --cc=mhocko@suse.com \ --cc=riel@redhat.com \ --cc=rientjes@google.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.