All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] libwebsockets : bump to v1.7.2
@ 2016-03-01 22:30 Sagaert Johan
  2016-03-01 22:34 ` Thomas Petazzoni
  0 siblings, 1 reply; 5+ messages in thread
From: Sagaert Johan @ 2016-03-01 22:30 UTC (permalink / raw)
  To: buildroot

drop patch to fix the library name
enable optional support for libev and libuv
add updated hash

Signed-off-by: Sagaert Johan <sagaert.johan@proximus.be>
---
 ...le-shared-library-build-when-BUILD_SHARED.patch | 107 ---------------------
 package/libwebsockets/libwebsockets.hash           |   2 +-
 package/libwebsockets/libwebsockets.mk             |  16 ++-
 3 files changed, 16 insertions(+), 109 deletions(-)
 delete mode 100644 package/libwebsockets/0001-cmake-disable-shared-library-build-when-BUILD_SHARED.patch

diff --git a/package/libwebsockets/0001-cmake-disable-shared-library-build-when-BUILD_SHARED.patch b/package/libwebsockets/0001-cmake-disable-shared-library-build-when-BUILD_SHARED.patch
deleted file mode 100644
index 95d1ad8..0000000
--- a/package/libwebsockets/0001-cmake-disable-shared-library-build-when-BUILD_SHARED.patch
+++ /dev/null
@@ -1,107 +0,0 @@
-From 045b035bd9ebbd45f40dda36b143ede869eb5f16 Mon Sep 17 00:00:00 2001
-From: Sagaert Johan <sagaert.johan@skynet.be>
-Date: Fri, 31 Oct 2014 12:25:48 +0100
-Subject: [PATCH 2/2] cmake: disable shared library build when
- BUILD_SHARED_LIBS is off
-
-Original patch from Samuel Martin, reworked by Sagaert Johan when
-updating libwebsockets.
-
-Signed-off-by: Samuel Martin <s.martin49@gmail.com>
-Signed-off-by: Sagaert Johan <sagaert.johan@skynet.be>
-[yann.morin.1998 at free.fr: further fix after the version bumped]
-Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
----
- CMakeLists.txt | 17 ++++++++++++-----
- 1 file changed, 12 insertions(+), 5 deletions(-)
-
-diff --git a/CMakeLists.txt b/CMakeLists.txt
-index 7978845..89853ce 100644
---- a/CMakeLists.txt
-+++ b/CMakeLists.txt
-@@ -372,14 +372,19 @@ source_group("Sources"          FILES ${SOURCES})
- #
- # Create the lib.
- #
-+set(_libs_websockets websockets)
- add_library(websockets STATIC
- 			${HDR_PRIVATE}
- 			${HDR_PUBLIC}
- 			${SOURCES})
-+
-+if(BUILD_SHARED_LIBS)
-+list(APPEND _libs_websockets websockets_shared)
- add_library(websockets_shared SHARED
- 			${HDR_PRIVATE}
- 			${HDR_PUBLIC}
- 			${SOURCES})
-+endif()
- 
- if (WIN32)
- 	# On Windows libs have the same file ending (.lib)
-@@ -400,15 +405,17 @@ endif(WIN32)
- 
- # We want the shared lib to be named "libwebsockets"
- # not "libwebsocket_shared".
-+if(BUILD_SHARED_LIBS)
- set_target_properties(websockets_shared
--		PROPERTIES 
-+		PROPERTIES
- 		OUTPUT_NAME websockets)
-+endif()
- 
- # Set the so version of the lib.
- # Equivalent to LDFLAGS=-version-info x:x:x
- if(CMAKE_COMPILER_IS_GNUCC OR CMAKE_COMPILER_IS_GNUCXX)
--	foreach(lib websockets websockets_shared)
--		set_target_properties(${lib} 
-+	foreach(lib ${_libs_websockets})
-+		set_target_properties(${lib}
- 			PROPERTIES
- 			SOVERSION ${SOVERSION})
- 	endforeach()
-@@ -460,7 +467,7 @@ if (NOT LWS_WITHOUT_EXTENSIONS)
- 	endif()
- 
- 	# Make sure ZLib is compiled before the libs.
--	foreach (lib websockets websockets_shared)
-+	foreach (lib ${_libs_websockets})
- 		add_dependencies(${lib} ZLIB)
- 	endforeach()
- 
-@@ -524,7 +531,7 @@ if (UNIX)
- endif()
- 
- # Setup the linking for all libs.
--foreach (lib websockets websockets_shared)
-+foreach (lib ${_libs_websockets})
- 	target_link_libraries(${lib} ${LIB_LIST})
- endforeach()
- 
-@@ -793,7 +800,7 @@
- set(LWS_INSTALL_CMAKE_DIR ${DEF_INSTALL_CMAKE_DIR} CACHE PATH "Installation directory for CMake files")
- 
- # Export targets (This is used for other CMake projects to easily find the libraries and include files).
--export(TARGETS websockets websockets_shared
-+export(TARGETS ${_libs_websockets}
-         FILE "${PROJECT_BINARY_DIR}/LibwebsocketsTargets.cmake")
- export(PACKAGE libwebsockets)
- 
-@@ -829,7 +835,7 @@
-                 ${PROJECT_BINARY_DIR}/LibwebsocketsConfigVersion.cmake 
-                 @ONLY)
- 
--set_target_properties(websockets websockets_shared 
-+set_target_properties(${_libs_websockets}
- 					PROPERTIES PUBLIC_HEADER "${HDR_PUBLIC}")
- 
- #
-@@ -837,7 +843,7 @@
- #
- 
- # Install libs and headers.
--install(TARGETS websockets websockets_shared
-+install(TARGETS ${_libs_websockets}
- 		EXPORT LibwebsocketsTargets
- 		LIBRARY DESTINATION "${LWS_INSTALL_LIB_DIR}${LIB_SUFFIX}" COMPONENT libraries
- 		ARCHIVE DESTINATION "${LWS_INSTALL_LIB_DIR}${LIB_SUFFIX}" COMPONENT libraries
diff --git a/package/libwebsockets/libwebsockets.hash b/package/libwebsockets/libwebsockets.hash
index eadff73..ff62669 100644
--- a/package/libwebsockets/libwebsockets.hash
+++ b/package/libwebsockets/libwebsockets.hash
@@ -1,2 +1,2 @@
 # Locally computed:
-sha256  63e14fbc768a22b01a3ade61a8e6a89ab0eac329b0f9fbb40ce9fb7210fcaa70  libwebsockets-v1.4-chrome43-firefox-36.tar.xz
+sha256  c7485cada05a7b00975260fe9d09de78cc5b78f28ae51ee4111c680c7a296835  libwebsockets-v1.7.2.tar.xz
diff --git a/package/libwebsockets/libwebsockets.mk b/package/libwebsockets/libwebsockets.mk
index 2f83748..1006ab8 100644
--- a/package/libwebsockets/libwebsockets.mk
+++ b/package/libwebsockets/libwebsockets.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-LIBWEBSOCKETS_VERSION = v1.4-chrome43-firefox-36
+LIBWEBSOCKETS_VERSION = v1.7.2
 LIBWEBSOCKETS_SOURCE = libwebsockets-$(LIBWEBSOCKETS_VERSION).tar.xz
 LIBWEBSOCKETS_SITE = http://git.libwebsockets.org/cgi-bin/cgit/libwebsockets/snapshot
 LIBWEBSOCKETS_LICENSE = LGPLv2.1 with exceptions
@@ -20,4 +20,18 @@ else
 LIBWEBSOCKETS_CONF_OPTS += -DLWS_WITH_SSL=OFF
 endif
 
+ifeq ($(BR2_PACKAGE_LIBEV),y)
+LIBWEBSOCKETS_DEPENDENCIES += libev
+LIBWEBSOCKETS_CONF_OPTS += -DLWS_WITH_LIBEV=ON
+else
+LIBWEBSOCKETS_CONF_OPTS += -DLWS_WITH_LIBEV=OFF
+endif
+
+ifeq ($(BR2_PACKAGE_LIBUV),y)
+LIBWEBSOCKETS_DEPENDENCIES += libuv
+LIBWEBSOCKETS_CONF_OPTS += -DLWS_WITH_LIBUV=ON
+else
+LIBWEBSOCKETS_CONF_OPTS += -DLWS_WITH_LIBUV=OFF
+endif
+
 $(eval $(cmake-package))
-- 
2.3.3

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH 1/1] libwebsockets : bump to v1.7.2
  2016-03-01 22:30 [Buildroot] [PATCH 1/1] libwebsockets : bump to v1.7.2 Sagaert Johan
@ 2016-03-01 22:34 ` Thomas Petazzoni
       [not found]   ` <56D63448.4080202@proximus.be>
  0 siblings, 1 reply; 5+ messages in thread
From: Thomas Petazzoni @ 2016-03-01 22:34 UTC (permalink / raw)
  To: buildroot

Johan,

On Tue,  1 Mar 2016 23:30:25 +0100, Sagaert Johan wrote:
> drop patch to fix the library name

Could you detail why the patch was dropped?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH 1/1] libwebsockets : bump to v1.7.2
       [not found]   ` <56D63448.4080202@proximus.be>
@ 2016-03-02  8:16     ` Thomas Petazzoni
  2016-03-02 13:30       ` Johan Sagaert
  0 siblings, 1 reply; 5+ messages in thread
From: Thomas Petazzoni @ 2016-03-02  8:16 UTC (permalink / raw)
  To: buildroot

Johan,

(Please keep the mailing list in Cc: when replying, thanks!)

On Wed, 2 Mar 2016 01:31:04 +0100, Johan Sagaert wrote:

> Just added some comment,
> Looks like the CMakeLists.txt has been seriously reworked.
> Did not encounter anything strange while building and using the new 
> version of the lib.

The patch was originally introduced to make sure that libwebsockets
would build fine in a BR2_STATIC_LIB=y configuration. Could you verify
that this is still the case with your update?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH 1/1] libwebsockets : bump to v1.7.2
  2016-03-02  8:16     ` Thomas Petazzoni
@ 2016-03-02 13:30       ` Johan Sagaert
  2016-03-02 20:23         ` Thomas Petazzoni
  0 siblings, 1 reply; 5+ messages in thread
From: Johan Sagaert @ 2016-03-02 13:30 UTC (permalink / raw)
  To: buildroot

Thomas

Op 2/03/2016 om 9:16 schreef Thomas Petazzoni:
> Johan,
>
> (Please keep the mailing list in Cc: when replying, thanks!)
>
> On Wed, 2 Mar 2016 01:31:04 +0100, Johan Sagaert wrote:
>
>> Just added some comment,
>> Looks like the CMakeLists.txt has been seriously reworked.
>> Did not encounter anything strange while building and using the new
>> version of the lib.
> The patch was originally introduced to make sure that libwebsockets
> would build fine in a BR2_STATIC_LIB=y configuration. Could you verify
> that this is still the case with your update?
>
> Thanks!
>
> Thomas
The static library libwebsockets.a is at .../staging/usr/lib  as well as 
the shared version
having both static and shared libraries enabled in Buildroot.

However when i select static only libraries i get the following build error:
I looks like the extention fails to build.

When adding :
ifeq ($(BR2_STATIC_LIBS),y)
LIBWEBSOCKETS_CONF_OPTS += -DLWS_WITH_SHARED=OFF
endif

libwebsockets.a builds fine, so i guess this is the way to go.

(should i disable the static build when shared libs are selected ?
both  static and shared are now build when shared libs only is selected 
in Buildroot. )

Regards Johan

libwebsockets-v1.7.2.tar.xz: OK (sha256: 
c7485cada05a7b00975260fe9d09de78cc5b78f28ae51ee4111c680c7a296835)
 >>> libwebsockets v1.7.2 Extracting
xzcat /home/johan/dl/libwebsockets-v1.7.2.tar.xz | tar 
--strip-components=1 -C 
/gitrepos/buildroot/output/build/libwebsockets-v1.7.2   -xf -
 >>> libwebsockets v1.7.2 Patching
 >>> libwebsockets v1.7.2 Configuring
(mkdir -p /gitrepos/buildroot/output/build/libwebsockets-v1.7.2/ && cd 
/gitrepos/buildroot/output/build/libwebsockets-v1.7.2/ && rm -f 
CMakeCache.txt && 
PATH="/gitrepos/buildroot/output/host/bin:/gitrepos/buildroot/output/host/sbin:/gitrepos/buildroot/output/host/usr/bin:/gitrepos/buildroot/output/host/usr/sbin:/root/google-cloud-sdk/bin:/home/buildroot12git/output/host/usr/bin:/home/buildroot12git/output/build/host-cmake-3.1.3/bin:/root/google-cloud-sdk/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin" 
/gitrepos/buildroot/output/host/usr/bin/cmake 
/gitrepos/buildroot/output/build/libwebsockets-v1.7.2/ 
-DCMAKE_TOOLCHAIN_FILE="/gitrepos/buildroot/output/host/usr/share/buildroot/toolchainfile.cmake" 
-DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX="/usr" 
-DCMAKE_COLOR_MAKEFILE=OFF -DBUILD_DOC=OFF -DBUILD_DOCS=OFF 
-DBUILD_EXAMPLE=OFF -DBUILD_EXAMPLES=OFF -DBUILD_TEST=OFF 
-DBUILD_TESTS=OFF -DBUILD_TESTING=OFF -DBUILD_SHARED_LIBS=OFF 
-DLWS_WITHOUT_TESTAPPS=ON -DLWS_IPV6=ON -DLWS_WITH_SSL=ON 
-DLWS_WITH_LIBEV=OFF -DLWS_WITH_LIBUV=OFF )
-- The C compiler identification is GNU 4.9.3
-- Check for working C compiler: 
/gitrepos/buildroot/output/host/usr/bin/arm-buildroot-linux-uclibcgnueabihf-gcc
-- Check for working C compiler: 
/gitrepos/buildroot/output/host/usr/bin/arm-buildroot-linux-uclibcgnueabihf-gcc 
-- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- 
CMAKE_TOOLCHAIN_FILE='/gitrepos/buildroot/output/host/usr/share/buildroot/toolchainfile.cmake'
-- Found Git: /usr/bin/git
Git commit hash: root at debian605-2016.02-2-gab6c851
-- Performing Test LWS_HAVE_inline
-- Performing Test LWS_HAVE_inline - Success
-- Performing Test LWS_HAVE___inline__
-- Performing Test LWS_HAVE___inline__ - Success
-- Performing Test LWS_HAVE___inline
-- Performing Test LWS_HAVE___inline - Success
-- Looking for bzero
-- Looking for bzero - found
-- Looking for fork
-- Looking for fork - found
-- Looking for getenv
-- Looking for getenv - found
-- Looking for malloc
-- Looking for malloc - found
-- Looking for memset
-- Looking for memset - found
-- Looking for realloc
-- Looking for realloc - found
-- Looking for socket
-- Looking for socket - found
-- Looking for strerror
-- Looking for strerror - found
-- Looking for vfork
-- Looking for vfork - found
-- Looking for getifaddrs
-- Looking for getifaddrs - found
-- Looking for dlfcn.h
-- Looking for dlfcn.h - not found
-- Looking for fcntl.h
-- Looking for fcntl.h - found
-- Looking for in6addr.h
-- Looking for in6addr.h - not found
-- Looking for inttypes.h
-- Looking for inttypes.h - found
-- Looking for memory.h
-- Looking for memory.h - found
-- Looking for netinet/in.h
-- Looking for netinet/in.h - found
-- Looking for stdint.h
-- Looking for stdint.h - found
-- Looking for stdlib.h
-- Looking for stdlib.h - found
-- Looking for strings.h
-- Looking for strings.h - found
-- Looking for string.h
-- Looking for string.h - found
-- Looking for sys/prctl.h
-- Looking for sys/prctl.h - found
-- Looking for sys/socket.h
-- Looking for sys/socket.h - found
-- Looking for sys/stat.h
-- Looking for sys/stat.h - found
-- Looking for sys/types.h
-- Looking for sys/types.h - found
-- Looking for unistd.h
-- Looking for unistd.h - found
-- Looking for vfork.h
-- Looking for vfork.h - not found
-- Looking for zlib.h
-- Looking for zlib.h - found
-- Looking for 4 include files stdlib.h, ..., float.h
-- Looking for 4 include files stdlib.h, ..., float.h - found
-- Performing Test LWS_HAVE_VISIBILITY
-- Performing Test LWS_HAVE_VISIBILITY - Success
-- Found ZLIB: 
/gitrepos/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabihf/sysroot/usr/lib/libz.a 
(found version "1.2.8")
zlib include dirs: 
/gitrepos/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabihf/sysroot/usr/include
zlib libraries: 
/gitrepos/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabihf/sysroot/usr/lib/libz.a
Compiling with SSL support
-- Found OpenSSL: 
/gitrepos/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabihf/sysroot/usr/lib/libssl.a;/gitrepos/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabihf/sysroot/usr/lib/libcrypto.a 
(found version "1.0.2g")
OpenSSL include dir: 
/gitrepos/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabihf/sysroot/usr/include
OpenSSL libraries: 
/gitrepos/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabihf/sysroot/usr/lib/libssl.a;/gitrepos/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabihf/sysroot/usr/lib/libcrypto.a
Generating API documentation
-- Looking for RPMTools... - rpmbuild NOT FOUND
---------------------------------------------------------------------
   Settings:  (For more help do cmake -LH <srcpath>)
---------------------------------------------------------------------
  LWS_WITH_STATIC = ON
  LWS_WITH_SHARED = ON
  LWS_WITH_SSL = ON (SSL Support)
  LWS_SSL_CLIENT_USE_OS_CA_CERTS = 1
  LWS_USE_WOLFSSL = OFF (wolfSSL/CyaSSL replacement for OpenSSL)
  LWS_WITHOUT_BUILTIN_SHA1 = OFF
  LWS_WITHOUT_BUILTIN_GETIFADDRS = OFF
  LWS_WITHOUT_CLIENT = OFF
  LWS_WITHOUT_SERVER = OFF
  LWS_LINK_TESTAPPS_DYNAMIC = OFF
  LWS_WITHOUT_TESTAPPS = ON
  LWS_WITHOUT_TEST_SERVER = OFF
  LWS_WITHOUT_TEST_SERVER_EXTPOLL = OFF
  LWS_WITHOUT_TEST_PING = OFF
  LWS_WITHOUT_TEST_ECHO = OFF
  LWS_WITHOUT_TEST_CLIENT = OFF
  LWS_WITHOUT_TEST_FRAGGLE = OFF
  LWS_WITHOUT_EXTENSIONS = OFF
  LWS_WITH_LATENCY = OFF
  LWS_WITHOUT_DAEMONIZE = ON
  LWS_USE_LIBEV =
  LWS_USE_LIBUV =
  LWS_IPV6 = ON
  LWS_WITH_HTTP2 = OFF
  LWS_MBED3 = OFF
  LWS_SSL_SERVER_WITH_ECDH_CERT = OFF
  LWS_MAX_SMP = 32
---------------------------------------------------------------------
-- Configuring done
-- Generating done
CMake Warning:
   Manually-specified variables were not used by the project:

     BUILD_DOC
     BUILD_DOCS
     BUILD_EXAMPLE
     BUILD_EXAMPLES
     BUILD_TEST
     BUILD_TESTING
     BUILD_TESTS


-- Build files have been written to: 
/gitrepos/buildroot/output/build/libwebsockets-v1.7.2
 >>> libwebsockets v1.7.2 Building
PATH="/gitrepos/buildroot/output/host/bin:/gitrepos/buildroot/output/host/sbin:/gitrepos/buildroot/output/host/usr/bin:/gitrepos/buildroot/output/host/usr/sbin:/root/google-cloud-sdk/bin:/home/buildroot12git/output/host/usr/bin:/home/buildroot12git/output/build/host-cmake-3.1.3/bin:/root/google-cloud-sdk/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin" 
/usr/bin/make -j5  -C /gitrepos/buildroot/output/build/libwebsockets-v1.7.2/
make[1]: Entering directory 
`/gitrepos/buildroot/output/build/libwebsockets-v1.7.2'
make[2]: Entering directory 
`/gitrepos/buildroot/output/build/libwebsockets-v1.7.2'
make[3]: Entering directory 
`/gitrepos/buildroot/output/build/libwebsockets-v1.7.2'
make[3]: Entering directory 
`/gitrepos/buildroot/output/build/libwebsockets-v1.7.2'
Scanning dependencies of target websockets
Scanning dependencies of target websockets_shared
make[3]: Leaving directory 
`/gitrepos/buildroot/output/build/libwebsockets-v1.7.2'
make[3]: Leaving directory 
`/gitrepos/buildroot/output/build/libwebsockets-v1.7.2'
make[3]: Entering directory 
`/gitrepos/buildroot/output/build/libwebsockets-v1.7.2'
[  2%] Building C object CMakeFiles/websockets.dir/lib/base64-decode.c.o
[  4%] Building C object CMakeFiles/websockets.dir/lib/handshake.c.o
make[3]: Entering directory 
`/gitrepos/buildroot/output/build/libwebsockets-v1.7.2'
[  7%] Building C object CMakeFiles/websockets.dir/lib/libwebsockets.c.o
[  9%] Building C object CMakeFiles/websockets.dir/lib/service.c.o
[ 11%] Building C object 
CMakeFiles/websockets_shared.dir/lib/base64-decode.c.o
[ 14%] Building C object CMakeFiles/websockets.dir/lib/pollfd.c.o
[ 16%] Building C object CMakeFiles/websockets_shared.dir/lib/handshake.c.o
[ 19%] Building C object CMakeFiles/websockets.dir/lib/output.c.o
[ 21%] Building C object 
CMakeFiles/websockets_shared.dir/lib/libwebsockets.c.o
[ 23%] Building C object CMakeFiles/websockets.dir/lib/parsers.c.o
[ 26%] Building C object CMakeFiles/websockets_shared.dir/lib/service.c.o
[ 28%] Building C object CMakeFiles/websockets.dir/lib/context.c.o
[ 30%] Building C object CMakeFiles/websockets.dir/lib/alloc.c.o
[ 33%] Building C object CMakeFiles/websockets_shared.dir/lib/pollfd.c.o
[ 35%] Building C object CMakeFiles/websockets.dir/lib/header.c.o
[ 38%] Building C object CMakeFiles/websockets.dir/lib/client.c.o
[ 40%] Building C object CMakeFiles/websockets_shared.dir/lib/output.c.o
[ 42%] Building C object CMakeFiles/websockets_shared.dir/lib/parsers.c.o
[ 45%] Building C object CMakeFiles/websockets_shared.dir/lib/context.c.o
[ 47%] Building C object CMakeFiles/websockets_shared.dir/lib/alloc.c.o
[ 50%] Building C object CMakeFiles/websockets.dir/lib/client-handshake.c.o
[ 52%] Building C object CMakeFiles/websockets_shared.dir/lib/header.c.o
[ 54%] Building C object CMakeFiles/websockets_shared.dir/lib/client.c.o
[ 57%] Building C object 
CMakeFiles/websockets_shared.dir/lib/client-handshake.c.o
[ 59%] Building C object 
CMakeFiles/websockets_shared.dir/lib/client-parser.c.o
[ 61%] Building C object CMakeFiles/websockets.dir/lib/client-parser.c.o
[ 64%] Building C object CMakeFiles/websockets_shared.dir/lib/ssl.c.o
[ 66%] Building C object CMakeFiles/websockets_shared.dir/lib/sha-1.c.o
[ 69%] Building C object 
CMakeFiles/websockets_shared.dir/lib/lws-plat-unix.c.o
[ 71%] Building C object CMakeFiles/websockets.dir/lib/ssl.c.o
[ 73%] Building C object CMakeFiles/websockets_shared.dir/lib/server.c.o
[ 76%] Building C object 
CMakeFiles/websockets_shared.dir/lib/server-handshake.c.o
[ 78%] Building C object CMakeFiles/websockets_shared.dir/lib/extension.c.o
[ 80%] Building C object 
CMakeFiles/websockets_shared.dir/lib/extension-permessage-deflate.c.o
[ 83%] Building C object CMakeFiles/websockets.dir/lib/sha-1.c.o
[ 85%] Building C object CMakeFiles/websockets.dir/lib/lws-plat-unix.c.o
[ 88%] Building C object CMakeFiles/websockets.dir/lib/server.c.o
[ 92%] Linking C shared library lib/libwebsockets.so
[ 92%] Building C object CMakeFiles/websockets.dir/lib/server-handshake.c.o
[ 95%] Building C object CMakeFiles/websockets.dir/lib/extension.c.o
[ 97%] Building C object 
CMakeFiles/websockets.dir/lib/extension-permessage-deflate.c.o
/gitrepos/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabihf/sysroot/usr/lib/libc.a(__uClibc_main.os): 
In function `__uClibc_fini':
__uClibc_main.c:(.text+0x12c): undefined reference to `__fini_array_end'
__uClibc_main.c:(.text+0x130): undefined reference to `__fini_array_start'
__uClibc_main.c:(.text+0x134): undefined reference to `__fini_array_start'
/gitrepos/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabihf/sysroot/usr/lib/libc.a(__uClibc_main.os): 
In function `__uClibc_main':
__uClibc_main.c:(.text+0x544): undefined reference to 
`__preinit_array_start'
__uClibc_main.c:(.text+0x548): undefined reference to `__preinit_array_end'
__uClibc_main.c:(.text+0x54c): undefined reference to 
`__preinit_array_start'
__uClibc_main.c:(.text+0x550): undefined reference to `__init_array_start'
__uClibc_main.c:(.text+0x554): undefined reference to `__init_array_end'
__uClibc_main.c:(.text+0x558): undefined reference to `__init_array_start'
/gitrepos/buildroot/output/host/usr/lib/gcc/arm-buildroot-linux-uclibcgnueabihf/4.9.3/../../../../arm-buildroot-linux-uclibcgnueabihf/bin/ld: 
lib/libwebsockets.so.7: hidden symbol `__init_array_end' isn't defined
/gitrepos/buildroot/output/host/usr/lib/gcc/arm-buildroot-linux-uclibcgnueabihf/4.9.3/../../../../arm-buildroot-linux-uclibcgnueabihf/bin/ld: 
final link failed: Bad value
collect2: error: ld returned 1 exit status
make[3]: *** [lib/libwebsockets.so.7] Error 1
make[3]: Leaving directory 
`/gitrepos/buildroot/output/build/libwebsockets-v1.7.2'
make[2]: *** [CMakeFiles/websockets_shared.dir/all] Error 2
make[2]: *** Waiting for unfinished jobs....
[100%] Linking C static library lib/libwebsockets.a
make[3]: Leaving directory 
`/gitrepos/buildroot/output/build/libwebsockets-v1.7.2'
[100%] Built target websockets
make[2]: Leaving directory 
`/gitrepos/buildroot/output/build/libwebsockets-v1.7.2'
make[1]: *** [all] Error 2
make[1]: Leaving directory 
`/gitrepos/buildroot/output/build/libwebsockets-v1.7.2'
make: *** 
[/gitrepos/buildroot/output/build/libwebsockets-v1.7.2/.stamp_built] Error 2
root at debian605:/gitrepos/buildroot#

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH 1/1] libwebsockets : bump to v1.7.2
  2016-03-02 13:30       ` Johan Sagaert
@ 2016-03-02 20:23         ` Thomas Petazzoni
  0 siblings, 0 replies; 5+ messages in thread
From: Thomas Petazzoni @ 2016-03-02 20:23 UTC (permalink / raw)
  To: buildroot

Johan,

On Wed, 2 Mar 2016 14:30:18 +0100, Johan Sagaert wrote:

> The static library libwebsockets.a is at .../staging/usr/lib  as well as 
> the shared version
> having both static and shared libraries enabled in Buildroot.
> 
> However when i select static only libraries i get the following build error:
> I looks like the extention fails to build.
> 
> When adding :
> ifeq ($(BR2_STATIC_LIBS),y)
> LIBWEBSOCKETS_CONF_OPTS += -DLWS_WITH_SHARED=OFF
> endif
> 
> libwebsockets.a builds fine, so i guess this is the way to go.

Right, but you didn't add this to your v2. Did I miss it?

> (should i disable the static build when shared libs are selected ?
> both  static and shared are now build when shared libs only is selected 
> in Buildroot. )

We have three cases in Buildroot:

BR2_STATIC_LIBS=y		=> only static lib should be built
BR2_SHARED_LIBS=y		=> only shared lib should be built
BR2_SHARED_STATIC_LIBS=y	=> both shared and static lib should be
built

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2016-03-02 20:23 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-01 22:30 [Buildroot] [PATCH 1/1] libwebsockets : bump to v1.7.2 Sagaert Johan
2016-03-01 22:34 ` Thomas Petazzoni
     [not found]   ` <56D63448.4080202@proximus.be>
2016-03-02  8:16     ` Thomas Petazzoni
2016-03-02 13:30       ` Johan Sagaert
2016-03-02 20:23         ` Thomas Petazzoni

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.