* UBIFS Dump Stack on Android
@ 2016-03-04 2:21 Han Xu
2016-03-04 19:20 ` Richard Weinberger
0 siblings, 1 reply; 2+ messages in thread
From: Han Xu @ 2016-03-04 2:21 UTC (permalink / raw)
To: Richard Weinberger; +Cc: linux-mtd
Hi Richard,
We found an issue on Kernel 4.1 when running Android on UBIFS. Android
required to enable SELINUX and exposed the issue, one ubifs_assert()
function failed and caused dump stack.
--- a/fs/ubifs/xattr.c
+++ b/fs/ubifs/xattr.c
@@ -309,7 +309,6 @@ static int setxattr(struct inode *host, const char
*name, const void *value,
union ubifs_key key;
int err, type;
ubifs_assert(mutex_is_locked(&host->i_mutex));
It may related to your recent code change
UBIFS: Kill unneeded locking in ubifs_init_security
We also noticed Google maintained Kernel 4.1 AOSP didn't cherry-pick
the patch either. Could you please help to check this issue, Thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: UBIFS Dump Stack on Android
2016-03-04 2:21 UBIFS Dump Stack on Android Han Xu
@ 2016-03-04 19:20 ` Richard Weinberger
0 siblings, 0 replies; 2+ messages in thread
From: Richard Weinberger @ 2016-03-04 19:20 UTC (permalink / raw)
To: Han Xu; +Cc: linux-mtd
Han,
Am 04.03.2016 um 03:21 schrieb Han Xu:
> Hi Richard,
>
> We found an issue on Kernel 4.1 when running Android on UBIFS. Android
> required to enable SELINUX and exposed the issue, one ubifs_assert()
> function failed and caused dump stack.
>
> --- a/fs/ubifs/xattr.c
> +++ b/fs/ubifs/xattr.c
> @@ -309,7 +309,6 @@ static int setxattr(struct inode *host, const char
> *name, const void *value,
> union ubifs_key key;
> int err, type;
>
> ubifs_assert(mutex_is_locked(&host->i_mutex));
>
> It may related to your recent code change
> UBIFS: Kill unneeded locking in ubifs_init_security
>
> We also noticed Google maintained Kernel 4.1 AOSP didn't cherry-pick
> the patch either. Could you please help to check this issue, Thanks.
>
Well, does reverting my patch make the issue go away?
How to do you trigger it?
Thanks,
//richard
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-03-04 19:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-04 2:21 UBIFS Dump Stack on Android Han Xu
2016-03-04 19:20 ` Richard Weinberger
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.