* [PATCH] leds: triggers: simplify led_trigger_store
@ 2016-03-08 22:08 Heiner Kallweit
2016-03-09 15:29 ` Jacek Anaszewski
0 siblings, 1 reply; 2+ messages in thread
From: Heiner Kallweit @ 2016-03-08 22:08 UTC (permalink / raw)
To: Jacek Anaszewski; +Cc: linux-leds
led_trigger_store can be significantly simplified by using sysfs_streq().
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/leds/led-triggers.c | 13 ++-----------
1 file changed, 2 insertions(+), 11 deletions(-)
diff --git a/drivers/leds/led-triggers.c b/drivers/leds/led-triggers.c
index e1e9334..2181581 100644
--- a/drivers/leds/led-triggers.c
+++ b/drivers/leds/led-triggers.c
@@ -34,9 +34,7 @@ ssize_t led_trigger_store(struct device *dev, struct device_attribute *attr,
const char *buf, size_t count)
{
struct led_classdev *led_cdev = dev_get_drvdata(dev);
- char trigger_name[TRIG_NAME_MAX];
struct led_trigger *trig;
- size_t len;
int ret = count;
mutex_lock(&led_cdev->led_access);
@@ -46,21 +44,14 @@ ssize_t led_trigger_store(struct device *dev, struct device_attribute *attr,
goto unlock;
}
- trigger_name[sizeof(trigger_name) - 1] = '\0';
- strncpy(trigger_name, buf, sizeof(trigger_name) - 1);
- len = strlen(trigger_name);
-
- if (len && trigger_name[len - 1] == '\n')
- trigger_name[len - 1] = '\0';
-
- if (!strcmp(trigger_name, "none")) {
+ if (sysfs_streq(buf, "none")) {
led_trigger_remove(led_cdev);
goto unlock;
}
down_read(&triggers_list_lock);
list_for_each_entry(trig, &trigger_list, next_trig) {
- if (!strcmp(trigger_name, trig->name)) {
+ if (sysfs_streq(buf, trig->name)) {
down_write(&led_cdev->trigger_lock);
led_trigger_set(led_cdev, trig);
up_write(&led_cdev->trigger_lock);
--
2.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] leds: triggers: simplify led_trigger_store
2016-03-08 22:08 [PATCH] leds: triggers: simplify led_trigger_store Heiner Kallweit
@ 2016-03-09 15:29 ` Jacek Anaszewski
0 siblings, 0 replies; 2+ messages in thread
From: Jacek Anaszewski @ 2016-03-09 15:29 UTC (permalink / raw)
To: Heiner Kallweit; +Cc: linux-leds
Hi Heiner,
Thanks for the patch. Applied to linux-leds.git.
Best regards,
Jacek Anaszewski
On 03/08/2016 11:08 PM, Heiner Kallweit wrote:
> led_trigger_store can be significantly simplified by using sysfs_streq().
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
> drivers/leds/led-triggers.c | 13 ++-----------
> 1 file changed, 2 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/leds/led-triggers.c b/drivers/leds/led-triggers.c
> index e1e9334..2181581 100644
> --- a/drivers/leds/led-triggers.c
> +++ b/drivers/leds/led-triggers.c
> @@ -34,9 +34,7 @@ ssize_t led_trigger_store(struct device *dev, struct device_attribute *attr,
> const char *buf, size_t count)
> {
> struct led_classdev *led_cdev = dev_get_drvdata(dev);
> - char trigger_name[TRIG_NAME_MAX];
> struct led_trigger *trig;
> - size_t len;
> int ret = count;
>
> mutex_lock(&led_cdev->led_access);
> @@ -46,21 +44,14 @@ ssize_t led_trigger_store(struct device *dev, struct device_attribute *attr,
> goto unlock;
> }
>
> - trigger_name[sizeof(trigger_name) - 1] = '\0';
> - strncpy(trigger_name, buf, sizeof(trigger_name) - 1);
> - len = strlen(trigger_name);
> -
> - if (len && trigger_name[len - 1] == '\n')
> - trigger_name[len - 1] = '\0';
> -
> - if (!strcmp(trigger_name, "none")) {
> + if (sysfs_streq(buf, "none")) {
> led_trigger_remove(led_cdev);
> goto unlock;
> }
>
> down_read(&triggers_list_lock);
> list_for_each_entry(trig, &trigger_list, next_trig) {
> - if (!strcmp(trigger_name, trig->name)) {
> + if (sysfs_streq(buf, trig->name)) {
> down_write(&led_cdev->trigger_lock);
> led_trigger_set(led_cdev, trig);
> up_write(&led_cdev->trigger_lock);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-03-09 15:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-08 22:08 [PATCH] leds: triggers: simplify led_trigger_store Heiner Kallweit
2016-03-09 15:29 ` Jacek Anaszewski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.