From: Sinan Kaya <okaya@codeaurora.org> To: Vinod Koul <vinod.koul@intel.com> Cc: dmaengine@vger.kernel.org, marc.zyngier@arm.com, mark.rutland@arm.com, timur@codeaurora.org, devicetree@vger.kernel.org, cov@codeaurora.org, jcm@redhat.com, shankerd@codeaurora.org, vikrams@codeaurora.org, eric.auger@linaro.org, agross@codeaurora.org, arnd@arndb.de, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V14 5/9] dma: qcom_hidma: implement lower level hardware interface Date: Fri, 11 Mar 2016 11:44:26 -0500 [thread overview] Message-ID: <56E2F5EA.10207@codeaurora.org> (raw) In-Reply-To: <20160311163221.GC13211@localhost> On 3/11/2016 11:32 AM, Vinod Koul wrote: >>>> memcpy(lldev->tre_ring + lldev->tre_write_offset, &tre->tre_local[0], >>>> > >> + TRE_SIZE); > This one > >>>> > >> + lldev->tx_status_list[tre->idx].err_code = 0; >>>> > >> + lldev->tx_status_list[tre->idx].err_info = 0; >>>> > >> + tre->queued = 1; >>>> > >> + lldev->pending_tre_count++; >> > >> > Is this the only one without alignment? I couldn't understand what you mean by >> > above one? > quoting Coding Style: > > Statements longer than 80 columns will be broken into sensible chunks, unless > exceeding 80 columns significantly increases readability and does not hide > information. > "Descendants are always substantially shorter than the parent and > are placed substantially to the right." > > Sorry for my poor English. I never got this rule. Which one is a "substantially" right? Can you give me an example? I need to understand how you'd write this to satisfy the above rule. like this: memcpy(lldev->tre_ring + lldev->tre_write_offset, &tre->tre_local[0], TRE_SIZE); or memcpy(lldev->tre_ring + lldev->tre_write_offset, &tre->tre_local[0], TRE_SIZE); or memcpy(lldev->tre_ring + lldev->tre_write_offset, &tre->tre_local[0], TRE_SIZE); or memcpy(lldev->tre_ring + lldev->tre_write_offset, &tre->tre_local[0], TRE_SIZE); -- Sinan Kaya Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
WARNING: multiple messages have this Message-ID (diff)
From: okaya@codeaurora.org (Sinan Kaya) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH V14 5/9] dma: qcom_hidma: implement lower level hardware interface Date: Fri, 11 Mar 2016 11:44:26 -0500 [thread overview] Message-ID: <56E2F5EA.10207@codeaurora.org> (raw) In-Reply-To: <20160311163221.GC13211@localhost> On 3/11/2016 11:32 AM, Vinod Koul wrote: >>>> memcpy(lldev->tre_ring + lldev->tre_write_offset, &tre->tre_local[0], >>>> > >> + TRE_SIZE); > This one > >>>> > >> + lldev->tx_status_list[tre->idx].err_code = 0; >>>> > >> + lldev->tx_status_list[tre->idx].err_info = 0; >>>> > >> + tre->queued = 1; >>>> > >> + lldev->pending_tre_count++; >> > >> > Is this the only one without alignment? I couldn't understand what you mean by >> > above one? > quoting Coding Style: > > Statements longer than 80 columns will be broken into sensible chunks, unless > exceeding 80 columns significantly increases readability and does not hide > information. > "Descendants are always substantially shorter than the parent and > are placed substantially to the right." > > Sorry for my poor English. I never got this rule. Which one is a "substantially" right? Can you give me an example? I need to understand how you'd write this to satisfy the above rule. like this: memcpy(lldev->tre_ring + lldev->tre_write_offset, &tre->tre_local[0], TRE_SIZE); or memcpy(lldev->tre_ring + lldev->tre_write_offset, &tre->tre_local[0], TRE_SIZE); or memcpy(lldev->tre_ring + lldev->tre_write_offset, &tre->tre_local[0], TRE_SIZE); or memcpy(lldev->tre_ring + lldev->tre_write_offset, &tre->tre_local[0], TRE_SIZE); -- Sinan Kaya Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2016-03-11 16:44 UTC|newest] Thread overview: 100+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-02-05 4:34 [PATCH V14 0/9] dma: add Qualcomm Technologies HIDMA driver Sinan Kaya 2016-02-05 4:34 ` Sinan Kaya 2016-02-05 4:34 ` [PATCH V14 1/9] dma: qcom_bam_dma: move to qcom directory Sinan Kaya 2016-02-05 4:34 ` Sinan Kaya 2016-03-11 2:13 ` Vinod Koul 2016-03-11 2:13 ` Vinod Koul 2016-02-05 4:34 ` [PATCH V14 2/9] dma: hidma: Add Device Tree binding Sinan Kaya 2016-02-05 4:34 ` Sinan Kaya 2016-02-05 4:34 ` Sinan Kaya 2016-03-11 2:16 ` Vinod Koul 2016-03-11 2:16 ` Vinod Koul 2016-02-05 4:34 ` [PATCH V14 3/9] dma: add Qualcomm Technologies HIDMA management driver Sinan Kaya 2016-02-05 4:34 ` Sinan Kaya 2016-03-11 2:16 ` Vinod Koul 2016-03-11 2:16 ` Vinod Koul 2016-02-05 4:34 ` [PATCH V14 4/9] dma: add Qualcomm Technologies HIDMA channel driver Sinan Kaya 2016-02-05 4:34 ` Sinan Kaya [not found] ` <1454646882-24369-5-git-send-email-okaya-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> 2016-03-11 2:17 ` Vinod Koul 2016-03-11 2:17 ` Vinod Koul 2016-03-11 2:17 ` Vinod Koul 2016-02-05 4:34 ` [PATCH V14 5/9] dma: qcom_hidma: implement lower level hardware interface Sinan Kaya 2016-02-05 4:34 ` Sinan Kaya 2016-03-11 2:06 ` Vinod Koul 2016-03-11 2:06 ` Vinod Koul 2016-03-11 3:08 ` Okaya-sgV2jX0FEOL9JmXXK+q4OQ 2016-03-11 3:08 ` Okaya at codeaurora.org 2016-03-11 3:08 ` Okaya 2016-03-11 16:02 ` Sinan Kaya 2016-03-11 16:02 ` Sinan Kaya [not found] ` <56E2EC1C.6040107-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> 2016-03-11 16:32 ` Vinod Koul 2016-03-11 16:32 ` Vinod Koul 2016-03-11 16:32 ` Vinod Koul 2016-03-11 16:44 ` Sinan Kaya [this message] 2016-03-11 16:44 ` Sinan Kaya 2016-03-11 19:29 ` Sinan Kaya 2016-03-11 19:29 ` Sinan Kaya 2016-03-11 21:59 ` Sinan Kaya 2016-03-11 21:59 ` Sinan Kaya 2016-03-13 16:00 ` Vinod Koul 2016-03-13 16:00 ` Vinod Koul 2016-03-14 13:53 ` Sinan Kaya 2016-03-14 13:53 ` Sinan Kaya 2016-03-13 15:59 ` Vinod Koul 2016-03-13 15:59 ` Vinod Koul 2016-03-14 13:56 ` Sinan Kaya 2016-03-14 13:56 ` Sinan Kaya 2016-02-05 4:34 ` [PATCH V14 6/9] dma: qcom_hidma: add debugfs hooks Sinan Kaya 2016-02-05 4:34 ` Sinan Kaya 2016-02-05 4:34 ` [PATCH V14 7/9] dma: qcom_hidma: add support for object hierarchy Sinan Kaya 2016-02-05 4:34 ` Sinan Kaya 2016-02-05 4:34 ` [PATCH V14 8/9] vfio, platform: add support for ACPI while detecting the reset driver Sinan Kaya 2016-02-05 4:34 ` Sinan Kaya [not found] ` <1454646882-24369-9-git-send-email-okaya-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> 2016-02-26 16:24 ` Sinan Kaya 2016-02-26 16:24 ` Sinan Kaya 2016-02-26 16:24 ` Sinan Kaya 2016-02-26 17:15 ` Eric Auger 2016-02-26 17:15 ` Eric Auger 2016-02-26 17:15 ` Eric Auger 2016-02-26 19:21 ` Sinan Kaya 2016-02-26 19:21 ` Sinan Kaya 2016-03-02 18:34 ` Sinan Kaya 2016-03-02 18:34 ` Sinan Kaya 2016-03-03 23:14 ` Eric Auger 2016-03-03 23:14 ` Eric Auger 2016-03-04 5:20 ` Sinan Kaya 2016-03-04 5:20 ` Sinan Kaya 2016-03-07 4:09 ` Eric Auger 2016-03-07 4:09 ` Eric Auger [not found] ` <56DCFEE0.6080101-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2016-03-07 15:30 ` Sinan Kaya 2016-03-07 15:30 ` Sinan Kaya 2016-03-07 15:30 ` Sinan Kaya 2016-03-08 4:46 ` Eric Auger 2016-03-08 4:46 ` Eric Auger 2016-03-08 5:07 ` Sinan Kaya 2016-03-08 5:07 ` Sinan Kaya 2016-03-08 15:44 ` Sinan Kaya 2016-03-08 15:44 ` Sinan Kaya 2016-02-05 4:34 ` [PATCH V14 9/9] vfio, platform: add QTI HIDMA " Sinan Kaya 2016-02-05 4:34 ` Sinan Kaya 2016-02-26 17:52 ` Eric Auger 2016-02-26 17:52 ` Eric Auger 2016-02-26 19:05 ` Sinan Kaya 2016-02-26 19:05 ` Sinan Kaya 2016-02-08 10:14 ` [PATCH V14 0/9] dma: add Qualcomm Technologies HIDMA driver Christoffer Dall 2016-02-08 10:14 ` Christoffer Dall 2016-02-08 14:24 ` Sinan Kaya 2016-02-08 14:24 ` Sinan Kaya 2016-02-08 17:00 ` Christoffer Dall 2016-02-08 17:00 ` Christoffer Dall 2016-02-26 16:21 ` Sinan Kaya 2016-02-26 16:21 ` Sinan Kaya 2016-02-26 16:52 ` Timur Tabi 2016-02-26 16:52 ` Timur Tabi 2016-03-02 18:40 ` Sinan Kaya 2016-03-02 18:40 ` Sinan Kaya [not found] ` <56D733BA.6030203-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> 2016-03-03 3:44 ` Vinod Koul 2016-03-03 3:44 ` Vinod Koul 2016-03-03 3:44 ` Vinod Koul 2016-03-03 15:22 ` Sinan Kaya 2016-03-03 15:22 ` Sinan Kaya
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=56E2F5EA.10207@codeaurora.org \ --to=okaya@codeaurora.org \ --cc=agross@codeaurora.org \ --cc=arnd@arndb.de \ --cc=cov@codeaurora.org \ --cc=devicetree@vger.kernel.org \ --cc=dmaengine@vger.kernel.org \ --cc=eric.auger@linaro.org \ --cc=jcm@redhat.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=marc.zyngier@arm.com \ --cc=mark.rutland@arm.com \ --cc=shankerd@codeaurora.org \ --cc=timur@codeaurora.org \ --cc=vikrams@codeaurora.org \ --cc=vinod.koul@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.