* [patch 1/2 net-next] mediatek: checking for IS_ERR() instead of NULL
@ 2016-03-15 7:18 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2016-03-15 7:18 UTC (permalink / raw)
To: Felix Fietkau, John Crispin
Cc: Matthias Brugger, netdev, linux-mediatek, kernel-janitors
of_phy_connect() returns NULL on error, it never returns error pointers.
Fixes: 656e705243fd ('net-next: mediatek: add support for MT7623 ethernet')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
index ba3afa5..9759fe5 100644
--- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
+++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
@@ -186,9 +186,9 @@ static int mtk_phy_connect_node(struct mtk_eth *eth, struct mtk_mac *mac,
phydev = of_phy_connect(eth->netdev[mac->id], phy_node,
mtk_phy_link_adjust, 0, phy_mode);
- if (IS_ERR(phydev)) {
+ if (!phydev) {
dev_err(eth->dev, "could not connect to PHY\n");
- return PTR_ERR(phydev);
+ return -ENODEV;
}
dev_info(eth->dev,
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [patch 1/2 net-next] mediatek: checking for IS_ERR() instead of NULL
@ 2016-03-15 7:18 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2016-03-15 7:18 UTC (permalink / raw)
To: Felix Fietkau, John Crispin
Cc: Matthias Brugger, netdev, linux-mediatek, kernel-janitors
of_phy_connect() returns NULL on error, it never returns error pointers.
Fixes: 656e705243fd ('net-next: mediatek: add support for MT7623 ethernet')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
index ba3afa5..9759fe5 100644
--- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
+++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
@@ -186,9 +186,9 @@ static int mtk_phy_connect_node(struct mtk_eth *eth, struct mtk_mac *mac,
phydev = of_phy_connect(eth->netdev[mac->id], phy_node,
mtk_phy_link_adjust, 0, phy_mode);
- if (IS_ERR(phydev)) {
+ if (!phydev) {
dev_err(eth->dev, "could not connect to PHY\n");
- return PTR_ERR(phydev);
+ return -ENODEV;
}
dev_info(eth->dev,
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [patch 1/2 net-next] mediatek: checking for IS_ERR() instead of NULL
2016-03-15 7:18 ` Dan Carpenter
@ 2016-03-15 7:27 ` John Crispin
-1 siblings, 0 replies; 6+ messages in thread
From: John Crispin @ 2016-03-15 7:27 UTC (permalink / raw)
To: Dan Carpenter, Felix Fietkau
Cc: Matthias Brugger, netdev, kernel-janitors, linux-mediatek
On 15/03/2016 08:18, Dan Carpenter wrote:
> of_phy_connect() returns NULL on error, it never returns error pointers.
>
> Fixes: 656e705243fd ('net-next: mediatek: add support for MT7623 ethernet')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
Acked-by: John Crispin <blogic@openwrt.org>
Thanks !
> diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> index ba3afa5..9759fe5 100644
> --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> @@ -186,9 +186,9 @@ static int mtk_phy_connect_node(struct mtk_eth *eth, struct mtk_mac *mac,
>
> phydev = of_phy_connect(eth->netdev[mac->id], phy_node,
> mtk_phy_link_adjust, 0, phy_mode);
> - if (IS_ERR(phydev)) {
> + if (!phydev) {
> dev_err(eth->dev, "could not connect to PHY\n");
> - return PTR_ERR(phydev);
> + return -ENODEV;
> }
>
> dev_info(eth->dev,
>
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch 1/2 net-next] mediatek: checking for IS_ERR() instead of NULL
@ 2016-03-15 7:27 ` John Crispin
0 siblings, 0 replies; 6+ messages in thread
From: John Crispin @ 2016-03-15 7:27 UTC (permalink / raw)
To: Dan Carpenter, Felix Fietkau
Cc: Matthias Brugger, netdev, kernel-janitors, linux-mediatek
On 15/03/2016 08:18, Dan Carpenter wrote:
> of_phy_connect() returns NULL on error, it never returns error pointers.
>
> Fixes: 656e705243fd ('net-next: mediatek: add support for MT7623 ethernet')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
Acked-by: John Crispin <blogic@openwrt.org>
Thanks !
> diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> index ba3afa5..9759fe5 100644
> --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> @@ -186,9 +186,9 @@ static int mtk_phy_connect_node(struct mtk_eth *eth, struct mtk_mac *mac,
>
> phydev = of_phy_connect(eth->netdev[mac->id], phy_node,
> mtk_phy_link_adjust, 0, phy_mode);
> - if (IS_ERR(phydev)) {
> + if (!phydev) {
> dev_err(eth->dev, "could not connect to PHY\n");
> - return PTR_ERR(phydev);
> + return -ENODEV;
> }
>
> dev_info(eth->dev,
>
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch 1/2 net-next] mediatek: checking for IS_ERR() instead of NULL
2016-03-15 7:18 ` Dan Carpenter
@ 2016-03-18 22:31 ` David Miller
-1 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2016-03-18 22:31 UTC (permalink / raw)
To: dan.carpenter
Cc: nbd, blogic, matthias.bgg, netdev, linux-mediatek, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Tue, 15 Mar 2016 10:18:49 +0300
> of_phy_connect() returns NULL on error, it never returns error pointers.
>
> Fixes: 656e705243fd ('net-next: mediatek: add support for MT7623 ethernet')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch 1/2 net-next] mediatek: checking for IS_ERR() instead of NULL
@ 2016-03-18 22:31 ` David Miller
0 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2016-03-18 22:31 UTC (permalink / raw)
To: dan.carpenter
Cc: nbd, blogic, matthias.bgg, netdev, linux-mediatek, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Tue, 15 Mar 2016 10:18:49 +0300
> of_phy_connect() returns NULL on error, it never returns error pointers.
>
> Fixes: 656e705243fd ('net-next: mediatek: add support for MT7623 ethernet')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-03-18 22:31 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-15 7:18 [patch 1/2 net-next] mediatek: checking for IS_ERR() instead of NULL Dan Carpenter
2016-03-15 7:18 ` Dan Carpenter
2016-03-15 7:27 ` John Crispin
2016-03-15 7:27 ` John Crispin
2016-03-18 22:31 ` David Miller
2016-03-18 22:31 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.