All of lore.kernel.org
 help / color / mirror / Atom feed
* [patch 2/2 net-next] mediatek: unlock on error in mtk_tx_map()
@ 2016-03-15  7:19 ` Dan Carpenter
  0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2016-03-15  7:19 UTC (permalink / raw)
  To: Felix Fietkau, John Crispin
  Cc: Matthias Brugger, netdev, linux-mediatek, kernel-janitors

There was a missing unlock on the error path.

Fixes: 656e705243fd ('net-next: mediatek: add support for MT7623 ethernet')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
index 9759fe5..c2c2e206 100644
--- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
+++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
@@ -661,6 +661,8 @@ err_dma:
 		itxd = mtk_qdma_phys_to_virt(ring, itxd->txd2);
 	} while (itxd != txd);
 
+	spin_unlock_irqrestore(&eth->page_lock, flags);
+
 	return -ENOMEM;
 }
 

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [patch 2/2 net-next] mediatek: unlock on error in mtk_tx_map()
@ 2016-03-15  7:19 ` Dan Carpenter
  0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2016-03-15  7:19 UTC (permalink / raw)
  To: Felix Fietkau, John Crispin
  Cc: Matthias Brugger, netdev, linux-mediatek, kernel-janitors

There was a missing unlock on the error path.

Fixes: 656e705243fd ('net-next: mediatek: add support for MT7623 ethernet')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
index 9759fe5..c2c2e206 100644
--- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
+++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
@@ -661,6 +661,8 @@ err_dma:
 		itxd = mtk_qdma_phys_to_virt(ring, itxd->txd2);
 	} while (itxd != txd);
 
+	spin_unlock_irqrestore(&eth->page_lock, flags);
+
 	return -ENOMEM;
 }
 

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [patch 2/2 net-next] mediatek: unlock on error in mtk_tx_map()
  2016-03-15  7:19 ` Dan Carpenter
@ 2016-03-15  7:27   ` John Crispin
  -1 siblings, 0 replies; 6+ messages in thread
From: John Crispin @ 2016-03-15  7:27 UTC (permalink / raw)
  To: Dan Carpenter, Felix Fietkau
  Cc: Matthias Brugger, netdev, kernel-janitors, linux-mediatek



On 15/03/2016 08:19, Dan Carpenter wrote:
> There was a missing unlock on the error path.
> 
> Fixes: 656e705243fd ('net-next: mediatek: add support for MT7623 ethernet')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 

Acked-by: John Crispin <blogic@openwrt.org>

Thanks !

> diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> index 9759fe5..c2c2e206 100644
> --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> @@ -661,6 +661,8 @@ err_dma:
>  		itxd = mtk_qdma_phys_to_virt(ring, itxd->txd2);
>  	} while (itxd != txd);
>  
> +	spin_unlock_irqrestore(&eth->page_lock, flags);
> +
>  	return -ENOMEM;
>  }
>  
> 
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [patch 2/2 net-next] mediatek: unlock on error in mtk_tx_map()
@ 2016-03-15  7:27   ` John Crispin
  0 siblings, 0 replies; 6+ messages in thread
From: John Crispin @ 2016-03-15  7:27 UTC (permalink / raw)
  To: Dan Carpenter, Felix Fietkau
  Cc: Matthias Brugger, netdev, kernel-janitors, linux-mediatek



On 15/03/2016 08:19, Dan Carpenter wrote:
> There was a missing unlock on the error path.
> 
> Fixes: 656e705243fd ('net-next: mediatek: add support for MT7623 ethernet')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 

Acked-by: John Crispin <blogic@openwrt.org>

Thanks !

> diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> index 9759fe5..c2c2e206 100644
> --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> @@ -661,6 +661,8 @@ err_dma:
>  		itxd = mtk_qdma_phys_to_virt(ring, itxd->txd2);
>  	} while (itxd != txd);
>  
> +	spin_unlock_irqrestore(&eth->page_lock, flags);
> +
>  	return -ENOMEM;
>  }
>  
> 
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [patch 2/2 net-next] mediatek: unlock on error in mtk_tx_map()
  2016-03-15  7:19 ` Dan Carpenter
@ 2016-03-18 22:31   ` David Miller
  -1 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2016-03-18 22:31 UTC (permalink / raw)
  To: dan.carpenter
  Cc: nbd, blogic, matthias.bgg, netdev, linux-mediatek, kernel-janitors

From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Tue, 15 Mar 2016 10:19:04 +0300

> There was a missing unlock on the error path.
> 
> Fixes: 656e705243fd ('net-next: mediatek: add support for MT7623 ethernet')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Applied.

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [patch 2/2 net-next] mediatek: unlock on error in mtk_tx_map()
@ 2016-03-18 22:31   ` David Miller
  0 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2016-03-18 22:31 UTC (permalink / raw)
  To: dan.carpenter
  Cc: nbd, blogic, matthias.bgg, netdev, linux-mediatek, kernel-janitors

From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Tue, 15 Mar 2016 10:19:04 +0300

> There was a missing unlock on the error path.
> 
> Fixes: 656e705243fd ('net-next: mediatek: add support for MT7623 ethernet')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Applied.

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-03-18 22:31 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-15  7:19 [patch 2/2 net-next] mediatek: unlock on error in mtk_tx_map() Dan Carpenter
2016-03-15  7:19 ` Dan Carpenter
2016-03-15  7:27 ` John Crispin
2016-03-15  7:27   ` John Crispin
2016-03-18 22:31 ` David Miller
2016-03-18 22:31   ` David Miller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.