Re: [PATCH 0/2] Add support for MAX31722/MAX31723 temperature sensors

[Guenter Roeck <linux@roeck-us.net>]

On 03/15/2016 05:58 AM, Breana, Tiberiu A wrote:
> Hello Guenter, hwmon,
>
> We have a dilemma as to wether this device driver belongs in IIO or hwmon:
> https://datasheets.maximintegrated.com/en/ds/MAX31722-MAX31723.pdf
>
> Could you please give us your opinion on this?

The chip has limit registers and an alarm signal output, suggesting that
its intended use is for hardware monitoring purposes.

The conversion time is between 50ms and 200ms, which suggests that the
faster ABI provided by iio isn't really beneficial.

Given all that, I think that hwmon would be a better place.

If you want to keep the driver in iio, I would suggest to consider enhancing
the iio-hwmon bridge with threshold/limit support if that is possible.
This would ensure that the chip can be used for its intended purpose.

Thanks,
Guenter

> Thanks,
>
> Tiberiu
>
>> -----Original Message-----
>> From: linux-iio-owner@vger.kernel.org [mailto:linux-iio-
>> owner@vger.kernel.org] On Behalf Of Jonathan Cameron
>> Sent: Wednesday, March 9, 2016 10:32 PM
>> To: Breana, Tiberiu A <tiberiu.a.breana@intel.com>; linux-
>> iio@vger.kernel.org
>> Subject: Re: [PATCH 0/2] Add support for MAX31722/MAX31723
>> temperature sensors
>>
>> On 09/03/16 13:30, Tiberiu Breana wrote:
>>> This patch set adds support for the MAX31722/MAX31723 temperature
>>> sensors / thermostats.
>>> Patch 1 adds basic support and power management.
>>> Patch 2 adds threshold interrupt support.
>>>
>>> Tiberiu Breana (2):
>>>    iio: temperature: Add support for MAX31722/MAX31723 temperature
>>>      sensors
>>>    iio: temperature: Add threshold interrupt support for max31722
>>>
>>>   drivers/iio/temperature/Kconfig    |  12 +
>>>   drivers/iio/temperature/Makefile   |   1 +
>>>   drivers/iio/temperature/max31722.c | 673
>>> +++++++++++++++++++++++++++++++++++++
>>>   3 files changed, 686 insertions(+)
>>>   create mode 100644 drivers/iio/temperature/max31722.c
>>>
>> Hi Tiberiu,
>>
>> When proposing a temperature sensor driver, we need some additional
>> justification for why it is suited for IIO rather than the more focused (and in
>> someways simpler) hwmon.
>>
>> So far we have had thermophiles that don't fit in as devices typically used for
>> hardware monitoring. Also in there are a few drivers which are for parts
>> where they are a cut down version of a more complex sensor (the
>> measurement specialties parts are either pressure sensors or humidty
>> sensors at least in terms of what they share interfaces with)
>>
>> Also, please cc the hwmon maintainers (and probably list) as we want their
>> agreement.
>>
>> Jonathan
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body
>> of a message to majordomo@vger.kernel.org More majordomo info at
>> http://vger.kernel.org/majordomo-info.html
>