* linux-4.5/drivers/net/wireless/broadcom/b43/phy_lp.c: 1851: maybe uninit data ?
@ 2016-03-15 10:50 David Binderman
2016-03-15 14:33 ` Larry Finger
0 siblings, 1 reply; 3+ messages in thread
From: David Binderman @ 2016-03-15 10:50 UTC (permalink / raw)
To: b43-dev
Hello there,
[linux-4.5/drivers/net/wireless/broadcom/b43/phy_lp.c:1851]: (error) Uninitialized struct member: gains.gm
[linux-4.5/drivers/net/wireless/broadcom/b43/phy_lp.c:1851]: (error) Uninitialized struct member: gains.pga
[linux-4.5/drivers/net/wireless/broadcom/b43/phy_lp.c:1851]: (error) Uninitialized struct member: gains.pad
[linux-4.5/drivers/net/wireless/broadcom/b43/phy_lp.c:1851]: (error) Uninitialized struct member: gains.dac
[linux-4.5/drivers/net/wireless/broadcom/b43/phy_lp.c:1853]: (error) Uninitialized struct member: gains.gm
[linux-4.5/drivers/net/wireless/broadcom/b43/phy_lp.c:1853]: (error) Uninitialized struct member: gains.pga
[linux-4.5/drivers/net/wireless/broadcom/b43/phy_lp.c:1853]: (error) Uninitialized struct member: gains.pad
[linux-4.5/drivers/net/wireless/broadcom/b43/phy_lp.c:1853]: (error) Uninitialized struct member: gains.dac
I've had a look at the code and I can't see how local structure 'gains' get initialised.
Regards
David Binderman
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: linux-4.5/drivers/net/wireless/broadcom/b43/phy_lp.c: 1851: maybe uninit data ?
2016-03-15 10:50 linux-4.5/drivers/net/wireless/broadcom/b43/phy_lp.c: 1851: maybe uninit data ? David Binderman
@ 2016-03-15 14:33 ` Larry Finger
0 siblings, 0 replies; 3+ messages in thread
From: Larry Finger @ 2016-03-15 14:33 UTC (permalink / raw)
To: David Binderman, linux-wireless, b43-dev
On 03/15/2016 05:50 AM, David Binderman wrote:
> Hello there,
>
> [linux-4.5/drivers/net/wireless/broadcom/b43/phy_lp.c:1851]: (error) Uninitialized struct member: gains.gm
> [linux-4.5/drivers/net/wireless/broadcom/b43/phy_lp.c:1851]: (error) Uninitialized struct member: gains.pga
> [linux-4.5/drivers/net/wireless/broadcom/b43/phy_lp.c:1851]: (error) Uninitialized struct member: gains.pad
> [linux-4.5/drivers/net/wireless/broadcom/b43/phy_lp.c:1851]: (error) Uninitialized struct member: gains.dac
>
> [linux-4.5/drivers/net/wireless/broadcom/b43/phy_lp.c:1853]: (error) Uninitialized struct member: gains.gm
> [linux-4.5/drivers/net/wireless/broadcom/b43/phy_lp.c:1853]: (error) Uninitialized struct member: gains.pga
> [linux-4.5/drivers/net/wireless/broadcom/b43/phy_lp.c:1853]: (error) Uninitialized struct member: gains.pad
> [linux-4.5/drivers/net/wireless/broadcom/b43/phy_lp.c:1853]: (error) Uninitialized struct member: gains.dac
>
> I've had a look at the code and I can't see how local structure 'gains' get initialised.
It does not get initialized; however, it is only used in calls to
lpphy_papd_cal() that does nothing. Thus, no harm, no foul.
You should prepare a patch that initializes it to zero in line 1837.
Larry
^ permalink raw reply [flat|nested] 3+ messages in thread
* linux-4.5/drivers/net/wireless/broadcom/b43/phy_lp.c: 1851: maybe uninit data ?
@ 2016-03-15 14:33 ` Larry Finger
0 siblings, 0 replies; 3+ messages in thread
From: Larry Finger @ 2016-03-15 14:33 UTC (permalink / raw)
To: David Binderman, linux-wireless, b43-dev
On 03/15/2016 05:50 AM, David Binderman wrote:
> Hello there,
>
> [linux-4.5/drivers/net/wireless/broadcom/b43/phy_lp.c:1851]: (error) Uninitialized struct member: gains.gm
> [linux-4.5/drivers/net/wireless/broadcom/b43/phy_lp.c:1851]: (error) Uninitialized struct member: gains.pga
> [linux-4.5/drivers/net/wireless/broadcom/b43/phy_lp.c:1851]: (error) Uninitialized struct member: gains.pad
> [linux-4.5/drivers/net/wireless/broadcom/b43/phy_lp.c:1851]: (error) Uninitialized struct member: gains.dac
>
> [linux-4.5/drivers/net/wireless/broadcom/b43/phy_lp.c:1853]: (error) Uninitialized struct member: gains.gm
> [linux-4.5/drivers/net/wireless/broadcom/b43/phy_lp.c:1853]: (error) Uninitialized struct member: gains.pga
> [linux-4.5/drivers/net/wireless/broadcom/b43/phy_lp.c:1853]: (error) Uninitialized struct member: gains.pad
> [linux-4.5/drivers/net/wireless/broadcom/b43/phy_lp.c:1853]: (error) Uninitialized struct member: gains.dac
>
> I've had a look at the code and I can't see how local structure 'gains' get initialised.
It does not get initialized; however, it is only used in calls to
lpphy_papd_cal() that does nothing. Thus, no harm, no foul.
You should prepare a patch that initializes it to zero in line 1837.
Larry
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-03-15 14:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-15 10:50 linux-4.5/drivers/net/wireless/broadcom/b43/phy_lp.c: 1851: maybe uninit data ? David Binderman
2016-03-15 14:33 ` Larry Finger
2016-03-15 14:33 ` Larry Finger
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.