From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/6 v2] i2c: designware_i2c: Add dw_i2c_enable() helper function
Date: Wed, 23 Mar 2016 07:16:27 +0100 [thread overview]
Message-ID: <56F234BB.8010709@denx.de> (raw)
In-Reply-To: <1458711988-3235-2-git-send-email-sr@denx.de>
On 03/23/2016 06:46 AM, Stefan Roese wrote:
> dw_i2c_enable() is used to dis-/en-able the I2C controller. It makes
> sense to add such a function, as the controller is dis-/en-abled
> multiple times in the code. Additionally, this function now checks,
> if the controller is really dis-/en-abled. This code is copied
> from the Linux I2C driver version.
>
> Signed-off-by: Stefan Roese <sr@denx.de>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Bin Meng <bmeng.cn@gmail.com>
> Cc: Marek Vasut <marex@denx.de>
> Cc: Heiko Schocher <hs@denx.de>
> ---
> v2:
> - Use true / false for binary values as suggested by Bin
>
> drivers/i2c/designware_i2c.c | 46 +++++++++++++++++++++++++-------------------
> 1 file changed, 26 insertions(+), 20 deletions(-)
>
> diff --git a/drivers/i2c/designware_i2c.c b/drivers/i2c/designware_i2c.c
> index e768cde..2b0c8cb 100644
> --- a/drivers/i2c/designware_i2c.c
> +++ b/drivers/i2c/designware_i2c.c
> @@ -34,6 +34,26 @@ static struct i2c_regs *i2c_get_base(struct i2c_adapter *adap)
> return NULL;
> }
>
> +static void dw_i2c_enable(struct i2c_regs *i2c_base, bool enable)
> +{
> + int timeout = 100;
> +
> + do {
> + writel(enable, &i2c_base->ic_enable);
I believe boolean true in C can be anything non-zero, not necessarily
one (1). It is safer to be explicit and do
enable = enable ? IC_ENABLE_0B : 0;
at the beginning of the function
> + if ((readl(&i2c_base->ic_enable_status) & 1) == enable)
Also drop this & 1 and make it IC_ENABLE_0B please.
> + return;
> +
> + /*
> + * Wait 10 times the signaling period of the highest I2C
> + * transfer supported by the driver (for 400KHz this is
> + * 25us) as described in the DesignWare I2C databook.
> + */
> + udelay(25);
> + } while (timeout--);
It's a shame we cannot flip this to wait_for_bit() :(
> + printf("timeout in %sabling I2C adapter\n", enable ? "en" : "dis");
> +}
[..]
Best regards,
Marek Vasut
next prev parent reply other threads:[~2016-03-23 6:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-23 5:46 [U-Boot] [PATCH 1/6 v2] i2c: designware_i2c: Add ic_enable_status to ic_regs struct Stefan Roese
2016-03-23 5:46 ` [U-Boot] [PATCH 2/6 v2] i2c: designware_i2c: Add dw_i2c_enable() helper function Stefan Roese
2016-03-23 6:16 ` Marek Vasut [this message]
2016-03-23 5:46 ` [U-Boot] [PATCH 3/6 v2] i2c: designware_i2c: Integrate set_speed() into dw_i2c_set_bus_speed() Stefan Roese
2016-03-23 5:46 ` [U-Boot] [PATCH 4/6 v2] i2c: designware_i2c: Prepare for DM driver conversion Stefan Roese
2016-03-28 7:33 ` Heiko Schocher
2016-04-12 13:22 ` Stefan Roese
2016-04-13 5:49 ` Heiko Schocher
2016-04-13 5:56 ` Stefan Roese
2016-04-13 7:00 ` Heiko Schocher
2016-04-13 7:05 ` Stefan Roese
2016-04-13 7:39 ` Heiko Schocher
2016-04-13 8:05 ` Bin Meng
2016-04-13 8:10 ` Stefan Roese
2016-03-23 5:46 ` [U-Boot] [PATCH 5/6 v2] i2c: designware_i2c: Add DM support Stefan Roese
2016-03-23 5:46 ` [U-Boot] [PATCH 6/6 v2] i2c: designware_i2c: Add support for PCI(e) based I2C cores (x86) Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56F234BB.8010709@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.