All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Andy Yan <andy.yan@rock-chips.com>
Cc: robh+dt@kernel.org, sre@kernel.org, heiko@sntech.de,
	john.stultz@linaro.org, arnd@arndb.de, galak@codeaurora.org,
	ijc+devicetree@hellion.org.uk, catalin.marinas@arm.com,
	olof@lixom.net, alexandre.belloni@free-electrons.com,
	dbaryshkov@gmail.com, jun.nie@linaro.org, pawel.moll@arm.com,
	will.deacon@arm.com, linux-rockchip@lists.infradead.org,
	matthias.bgg@gmail.com, devicetree@vger.kernel.org,
	linux-pm@vger.kernel.org, f.fainelli@gmail.com,
	linux@arm.linux.org.uk, mbrugger@suse.com,
	linux-arm-kernel@lists.infradead.org, lorenzo.pieralisi@arm.com,
	moritz.fischer@ettus.com, linux-kernel@vger.kernel.org,
	wxt@rock-chips.com, dwmw2@infradead.org, mark.rutland@arm.com
Subject: Re: [PATCH v6 1/4] dt-bindings: power: reset: add document for reboot-mode driver
Date: Thu, 24 Mar 2016 16:47:52 +0900	[thread overview]
Message-ID: <56F39BA8.30104@samsung.com> (raw)
In-Reply-To: <56F396FB.8030402@rock-chips.com>

On 24.03.2016 16:27, Andy Yan wrote:
>>> +- mode-normal: Normal reboot mode, system reboot with command "reboot".
>>> +- mode-recovery: Android Recovery mode, it is a mode to format the
>>> device or update a new image.
>>> +- mode-bootloader: Android fastboot mode, it's a mode to re-flash
>>> partitions on the Android based device.
>>> +- mode-loader: A bootloader mode, it's a mode used to download image
>>> on Rockchip platform,
>>> +              usually used in development.
>> The "bootloader" and "loader" examples are very confusing. Maybe just
>> name the first one as "mode-fastboot" and second as
>> "rockchip-download"? The term "loader" does not look for me as
>> anything related to uploading/downloading new firmware.
> 
>     About these two modes, we have a long discussion with Rob and John [0]
>     We keep them as what you see now to keep compatibility with exiting
> devices.
> 
>  [0] https://lkml.org/lkml/2016/2/2/128

To me these names are non-obvious and I would rather expect choosing
meaningful names when putting something into the mainline. The user
(Android) will use this mainline kernel release in a year or more (3
years for vendors?), so it will have plenty of time to adopt. :)

But this was already discussed and you got ack from Rob, so let's move
on. I don't mind.

Best regards,
Krzysztof

WARNING: multiple messages have this Message-ID (diff)
From: k.kozlowski@samsung.com (Krzysztof Kozlowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 1/4] dt-bindings: power: reset: add document for reboot-mode driver
Date: Thu, 24 Mar 2016 16:47:52 +0900	[thread overview]
Message-ID: <56F39BA8.30104@samsung.com> (raw)
In-Reply-To: <56F396FB.8030402@rock-chips.com>

On 24.03.2016 16:27, Andy Yan wrote:
>>> +- mode-normal: Normal reboot mode, system reboot with command "reboot".
>>> +- mode-recovery: Android Recovery mode, it is a mode to format the
>>> device or update a new image.
>>> +- mode-bootloader: Android fastboot mode, it's a mode to re-flash
>>> partitions on the Android based device.
>>> +- mode-loader: A bootloader mode, it's a mode used to download image
>>> on Rockchip platform,
>>> +              usually used in development.
>> The "bootloader" and "loader" examples are very confusing. Maybe just
>> name the first one as "mode-fastboot" and second as
>> "rockchip-download"? The term "loader" does not look for me as
>> anything related to uploading/downloading new firmware.
> 
>     About these two modes, we have a long discussion with Rob and John [0]
>     We keep them as what you see now to keep compatibility with exiting
> devices.
> 
>  [0] https://lkml.org/lkml/2016/2/2/128

To me these names are non-obvious and I would rather expect choosing
meaningful names when putting something into the mainline. The user
(Android) will use this mainline kernel release in a year or more (3
years for vendors?), so it will have plenty of time to adopt. :)

But this was already discussed and you got ack from Rob, so let's move
on. I don't mind.

Best regards,
Krzysztof

  reply	other threads:[~2016-03-24  7:48 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-22 11:35 [PATCH v6 0/4] add reboot mode driver Andy Yan
2016-03-22 11:35 ` Andy Yan
2016-03-22 11:35 ` Andy Yan
2016-03-22 11:36 ` [PATCH v6 1/4] dt-bindings: power: reset: add document for reboot-mode driver Andy Yan
2016-03-22 11:36   ` Andy Yan
2016-03-24  2:27   ` Krzysztof Kozlowski
2016-03-24  2:27     ` Krzysztof Kozlowski
2016-03-24  2:27     ` Krzysztof Kozlowski
2016-03-24  7:27     ` Andy Yan
2016-03-24  7:27       ` Andy Yan
2016-03-24  7:47       ` Krzysztof Kozlowski [this message]
2016-03-24  7:47         ` Krzysztof Kozlowski
2016-03-22 11:37 ` [PATCH v6 2/4] power: reset: add reboot mode driver Andy Yan
2016-03-22 11:37   ` Andy Yan
2016-03-22 11:37   ` Andy Yan
2016-03-24  2:50   ` Krzysztof Kozlowski
2016-03-24  2:50     ` Krzysztof Kozlowski
2016-03-24  8:03     ` Andy Yan
2016-03-24  8:03       ` Andy Yan
2016-03-28  6:34       ` Krzysztof Kozlowski
2016-03-28  6:34         ` Krzysztof Kozlowski
2016-03-28  7:40         ` Andy Yan
2016-03-28  7:40           ` Andy Yan
2016-03-28  8:05           ` Krzysztof Kozlowski
2016-03-28  8:05             ` Krzysztof Kozlowski
2016-06-21 11:01     ` Andy Yan
2016-06-21 11:01       ` Andy Yan
2016-06-21 11:01       ` Andy Yan
2016-06-21 11:39       ` Krzysztof Kozlowski
2016-06-21 11:39         ` Krzysztof Kozlowski
2016-03-22 11:38 ` [PATCH v6 3/4] ARM: dts: rockchip: add syscon-reboot-mode DT node Andy Yan
2016-03-22 11:38   ` Andy Yan
2016-03-22 11:38   ` Andy Yan
2016-03-22 11:38 ` [PATCH v6 4/4] ARM64: " Andy Yan
2016-03-22 11:38   ` Andy Yan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56F39BA8.30104@samsung.com \
    --to=k.kozlowski@samsung.com \
    --cc=alexandre.belloni@free-electrons.com \
    --cc=andy.yan@rock-chips.com \
    --cc=arnd@arndb.de \
    --cc=catalin.marinas@arm.com \
    --cc=dbaryshkov@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dwmw2@infradead.org \
    --cc=f.fainelli@gmail.com \
    --cc=galak@codeaurora.org \
    --cc=heiko@sntech.de \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=john.stultz@linaro.org \
    --cc=jun.nie@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux@arm.linux.org.uk \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=mark.rutland@arm.com \
    --cc=matthias.bgg@gmail.com \
    --cc=mbrugger@suse.com \
    --cc=moritz.fischer@ettus.com \
    --cc=olof@lixom.net \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=sre@kernel.org \
    --cc=will.deacon@arm.com \
    --cc=wxt@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.