From: Jose Abreu <Jose.Abreu@synopsys.com>
To: Mark Brown <broonie@kernel.org>, Jose Abreu <Jose.Abreu@synopsys.com>
Cc: <tixy@linaro.org>, <mark.rutland@arm.com>,
<alsa-devel@alsa-project.org>, <Alexey.Brodkin@synopsys.com>,
<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
<yitian.bu@tangramtek.com>, <wsa+renesas@sang-engineering.com>,
<laurent.pinchart+renesas@ideasonboard.com>, <tiwai@suse.com>,
<nariman@opensource.wolfsonmicro.com>,
<linux-snps-arc@lists.infradead.org>,
<devicetree@vger.kernel.org>, <Maruthi.Bayyavarapu@amd.com>,
<pawel.moll@arm.com>, <ijc+devicetree@hellion.org.uk>,
<Vineet.Gupta1@synopsys.com>, <buyitian@gmail.com>,
<robh+dt@kernel.org>, <perex@perex.cz>, <lgirdwood@gmail.com>,
<CARLOS.PALMINHA@synopsys.com>, <galak@codeaurora.org>,
<alexander.deucher@amd.com>
Subject: Re: [PATCH 2/3 v2] ASoC: dwc: Add I2S HDMI audio support
Date: Thu, 31 Mar 2016 10:37:20 +0100 [thread overview]
Message-ID: <56FCEFD0.8090509@synopsys.com> (raw)
In-Reply-To: <20160329182222.GC2350@sirena.org.uk>
Hi Mark,
On 29-03-2016 19:22, Mark Brown wrote:
> On Tue, Mar 29, 2016 at 07:03:01PM +0100, Jose Abreu wrote:
>
>> The major part of this patch is the adding of an ALSA platform driver so that
>> audio comes out of the box in AXS boards but we also added functionalities to
>> the i2s driver and performed one bug fix related with the mask/unmask of
>> interrupts. I will split the patches but they will depend on each other.
> If you want to add a new platform driver you need to add a new platform
> driver, not shove the code into an existing driver for a seperate IP.
>
I can separate the platform driver into a new file but they will have to be
compiled into the same module as the new additions to the i2s driver depend on
functions of the platform driver (see i2s_irq_handler()). Or should I divide
this into two modules and add a Kconfig option to the platform driver? Besides
this I first wanted the driver to be compiled into the same module so that it is
compatible with kernel 3.18 where simple audio card requires that platform
driver == cpu driver.
Best regards,
Jose Miguel Abreu
WARNING: multiple messages have this Message-ID (diff)
From: Jose Abreu <Jose.Abreu@synopsys.com>
To: Mark Brown <broonie@kernel.org>, Jose Abreu <Jose.Abreu@synopsys.com>
Cc: tixy@linaro.org, mark.rutland@arm.com,
alsa-devel@alsa-project.org, Alexey.Brodkin@synopsys.com,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
yitian.bu@tangramtek.com, wsa+renesas@sang-engineering.com,
laurent.pinchart+renesas@ideasonboard.com, tiwai@suse.com,
nariman@opensource.wolfsonmicro.com,
linux-snps-arc@lists.infradead.org, devicetree@vger.kernel.org,
Maruthi.Bayyavarapu@amd.com, pawel.moll@arm.com,
ijc+devicetree@hellion.org.uk, Vineet.Gupta1@synopsys.com,
buyitian@gmail.com, robh+dt@kernel.org, perex@perex.cz,
lgirdwood@gmail.com, CARLOS.PALMINHA@synopsys.com,
galak@codeaurora.org, alexander.deucher@amd.com
Subject: Re: [PATCH 2/3 v2] ASoC: dwc: Add I2S HDMI audio support
Date: Thu, 31 Mar 2016 10:37:20 +0100 [thread overview]
Message-ID: <56FCEFD0.8090509@synopsys.com> (raw)
In-Reply-To: <20160329182222.GC2350@sirena.org.uk>
Hi Mark,
On 29-03-2016 19:22, Mark Brown wrote:
> On Tue, Mar 29, 2016 at 07:03:01PM +0100, Jose Abreu wrote:
>
>> The major part of this patch is the adding of an ALSA platform driver so that
>> audio comes out of the box in AXS boards but we also added functionalities to
>> the i2s driver and performed one bug fix related with the mask/unmask of
>> interrupts. I will split the patches but they will depend on each other.
> If you want to add a new platform driver you need to add a new platform
> driver, not shove the code into an existing driver for a seperate IP.
>
I can separate the platform driver into a new file but they will have to be
compiled into the same module as the new additions to the i2s driver depend on
functions of the platform driver (see i2s_irq_handler()). Or should I divide
this into two modules and add a Kconfig option to the platform driver? Besides
this I first wanted the driver to be compiled into the same module so that it is
compatible with kernel 3.18 where simple audio card requires that platform
driver == cpu driver.
Best regards,
Jose Miguel Abreu
WARNING: multiple messages have this Message-ID (diff)
From: Jose.Abreu@synopsys.com (Jose Abreu)
To: linux-snps-arc@lists.infradead.org
Subject: [PATCH 2/3 v2] ASoC: dwc: Add I2S HDMI audio support
Date: Thu, 31 Mar 2016 10:37:20 +0100 [thread overview]
Message-ID: <56FCEFD0.8090509@synopsys.com> (raw)
In-Reply-To: <20160329182222.GC2350@sirena.org.uk>
Hi Mark,
On 29-03-2016 19:22, Mark Brown wrote:
> On Tue, Mar 29, 2016@07:03:01PM +0100, Jose Abreu wrote:
>
>> The major part of this patch is the adding of an ALSA platform driver so that
>> audio comes out of the box in AXS boards but we also added functionalities to
>> the i2s driver and performed one bug fix related with the mask/unmask of
>> interrupts. I will split the patches but they will depend on each other.
> If you want to add a new platform driver you need to add a new platform
> driver, not shove the code into an existing driver for a seperate IP.
>
I can separate the platform driver into a new file but they will have to be
compiled into the same module as the new additions to the i2s driver depend on
functions of the platform driver (see i2s_irq_handler()). Or should I divide
this into two modules and add a Kconfig option to the platform driver? Besides
this I first wanted the driver to be compiled into the same module so that it is
compatible with kernel 3.18 where simple audio card requires that platform
driver == cpu driver.
Best regards,
Jose Miguel Abreu
next prev parent reply other threads:[~2016-03-31 9:37 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-28 14:36 [PATCH 0/3 v2] Add I2S/ADV7511 audio support for ARC AXS10x boards Jose Abreu
2016-03-28 14:36 ` Jose Abreu
2016-03-28 14:36 ` Jose Abreu
2016-03-28 14:36 ` [PATCH 1/3 v2] drm/i2c/adv7511: Add audio support Jose Abreu
2016-03-28 14:36 ` Jose Abreu
2016-03-29 8:05 ` Archit Taneja
2016-03-29 8:05 ` Archit Taneja
2016-03-29 8:05 ` Archit Taneja
2016-03-29 10:52 ` Jose Abreu
2016-03-29 10:52 ` Jose Abreu
2016-03-29 10:52 ` Jose Abreu
2016-03-29 17:03 ` Archit Taneja
2016-03-29 17:03 ` Archit Taneja
2016-03-29 17:03 ` Archit Taneja
2016-03-31 12:57 ` Jose Abreu
2016-03-31 12:57 ` Jose Abreu
2016-03-31 12:57 ` Jose Abreu
2016-03-30 9:58 ` Emil Velikov
2016-03-30 9:58 ` Emil Velikov
2016-03-30 9:58 ` Emil Velikov
2016-04-01 17:10 ` Laurent Pinchart
2016-04-01 17:10 ` Laurent Pinchart
2016-04-01 17:10 ` Laurent Pinchart
2016-04-04 9:05 ` Jose Abreu
2016-04-04 9:05 ` Jose Abreu
2016-04-04 9:05 ` Jose Abreu
2016-04-04 21:41 ` Laurent Pinchart
2016-04-04 21:41 ` Laurent Pinchart
2016-04-04 21:41 ` Laurent Pinchart
2016-04-05 11:00 ` Jose Abreu
2016-04-05 11:00 ` Jose Abreu
2016-04-05 11:00 ` Jose Abreu
2016-04-05 16:03 ` Laurent Pinchart
2016-04-05 16:03 ` Laurent Pinchart
2016-04-05 16:03 ` Laurent Pinchart
2016-04-03 5:05 ` kbuild test robot
2016-04-03 5:05 ` kbuild test robot
2016-04-03 5:05 ` kbuild test robot
2016-03-28 14:36 ` [PATCH 2/3 v2] ASoC: dwc: Add I2S HDMI " Jose Abreu
2016-03-28 14:36 ` Jose Abreu
2016-03-28 14:36 ` Jose Abreu
2016-03-28 15:35 ` Alexey Brodkin
2016-03-28 15:35 ` Alexey Brodkin
2016-03-28 15:35 ` Alexey Brodkin
2016-03-28 16:07 ` Jose Abreu
2016-03-28 16:07 ` Jose Abreu
2016-03-28 16:07 ` Jose Abreu
2016-03-29 17:31 ` Mark Brown
2016-03-29 17:31 ` Mark Brown
2016-03-29 17:31 ` Mark Brown
2016-03-29 18:03 ` Jose Abreu
2016-03-29 18:22 ` Mark Brown
2016-03-29 18:22 ` Mark Brown
2016-03-29 18:22 ` Mark Brown
2016-03-31 9:37 ` Jose Abreu [this message]
2016-03-31 9:37 ` Jose Abreu
2016-03-31 9:37 ` Jose Abreu
2016-03-31 16:56 ` Mark Brown
2016-03-31 16:56 ` Mark Brown
2016-03-31 16:56 ` Mark Brown
2016-03-28 14:36 ` [PATCH 3/3 v2] arc: axs10x: Add support for Designware I2S on DT Jose Abreu
2016-03-28 14:36 ` Jose Abreu
2016-03-28 14:36 ` Jose Abreu
2016-03-29 17:00 ` [PATCH 0/3 v2] Add I2S/ADV7511 audio support for ARC AXS10x boards Mark Brown
2016-03-29 17:00 ` Mark Brown
2016-03-29 17:00 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56FCEFD0.8090509@synopsys.com \
--to=jose.abreu@synopsys.com \
--cc=Alexey.Brodkin@synopsys.com \
--cc=CARLOS.PALMINHA@synopsys.com \
--cc=Maruthi.Bayyavarapu@amd.com \
--cc=Vineet.Gupta1@synopsys.com \
--cc=alexander.deucher@amd.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=buyitian@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=nariman@opensource.wolfsonmicro.com \
--cc=pawel.moll@arm.com \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
--cc=tixy@linaro.org \
--cc=wsa+renesas@sang-engineering.com \
--cc=yitian.bu@tangramtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.