From: Harvey Hunt <harvey.hunt@imgtec.com>
To: Boris Brezillon <boris.brezillon@free-electrons.com>,
Roger Quadros <rogerq@ti.com>, Tony Lindgren <tony@atomide.com>,
Wenyou Yang <wenyou.yang@atmel.com>,
Josh Wu <rainyfeeling@outlook.com>,
Richard Weinberger <richard@nod.at>,
<linux-mtd@lists.infradead.org>,
David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Kamal Dasu <kdasu.kdev@gmail.com>, Han Xu <han.xu@nxp.com>,
Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
Stefan Agner <stefan@agner.ch>
Cc: <linux-omap@vger.kernel.org>,
Nicolas Ferre <nicolas.ferre@atmel.com>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Gregory CLEMENT <gregory.clement@free-electrons.com>,
Jason Cooper <jason@lakedaemon.net>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Andrew Lunn <andrew@lunn.ch>, Daniel Mack <daniel@zonque.org>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Robert Jarzmik <robert.jarzmik@free.fr>,
<bcm-kernel-feedback-list@broadcom.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
Chen-Yu Tsai <wens@csie.org>, <linux-sunxi@googlegroups.com>,
Zhou Wang <wangzhou1@hisilicon.com>,
Alex Smith <alex.smith@imgtec.com>
Subject: Re: [PATCH 01/12] mtd: nand: remove unneeded of_mtd.h inclusions
Date: Fri, 1 Apr 2016 14:09:27 +0100 [thread overview]
Message-ID: <56FE7307.6040903@imgtec.com> (raw)
In-Reply-To: <1459515272-31011-2-git-send-email-boris.brezillon@free-electrons.com>
Hi Boris,
On 01/04/16 13:54, Boris Brezillon wrote:
> Some drivers are including linux/of_mtd.h even if they don't use any of
> the of_get_nand_xxx() helpers.
>
> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> ---
> drivers/mtd/nand/jz4780_nand.c | 1 -
> drivers/mtd/nand/lpc32xx_mlc.c | 1 -
> drivers/mtd/nand/qcom_nandc.c | 1 -
> drivers/mtd/nand/sunxi_nand.c | 1 -
> drivers/mtd/nand/vf610_nfc.c | 1 -
> 5 files changed, 5 deletions(-)
>
> diff --git a/drivers/mtd/nand/jz4780_nand.c b/drivers/mtd/nand/jz4780_nand.c
> index e1c016c..23a1999 100644
> --- a/drivers/mtd/nand/jz4780_nand.c
> +++ b/drivers/mtd/nand/jz4780_nand.c
> @@ -17,7 +17,6 @@
> #include <linux/of.h>
> #include <linux/of_address.h>
> #include <linux/gpio/consumer.h>
> -#include <linux/of_mtd.h>
> #include <linux/platform_device.h>
> #include <linux/slab.h>
> #include <linux/mtd/mtd.h>
Looks good to me.
Acked-by: Harvey Hunt <harvey.hunt@imgtec.com>
Thanks,
Harvey
WARNING: multiple messages have this Message-ID (diff)
From: Harvey Hunt <harvey.hunt-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org>
To: Boris Brezillon
<boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Roger Quadros <rogerq-l0cyMroinI0@public.gmane.org>,
Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>,
Wenyou Yang <wenyou.yang-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>,
Josh Wu <rainyfeeling-1ViLX0X+lBJBDgjK7y7TUQ@public.gmane.org>,
Richard Weinberger <richard-/L3Ra7n9ekc@public.gmane.org>,
linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
David Woodhouse <dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
Brian Norris
<computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Kamal Dasu <kdasu.kdev-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Han Xu <han.xu-3arQi8VN3Tc@public.gmane.org>,
Ezequiel Garcia
<ezequiel.garcia-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Stefan Agner <stefan-XLVq0VzYD2Y@public.gmane.org>
Cc: linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Nicolas Ferre
<nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>,
Jean-Christophe Plagniol-Villard
<plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org>,
Alexandre Belloni
<alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Thomas Petazzoni
<thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Gregory CLEMENT
<gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>,
Sebastian Hesselbarth
<sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>,
Daniel Mack <daniel-cYrQPVfZoowdnm+yROfE0A@public.gmane.org>,
Haojian Zhuang
<haojian.zhuang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Robert Jarzmik <robert.jarzmik-GANU6spQydw@public.gmane.org>,
bcm-kernel-feedback-list-dY08KVG/lbpWk0Htik3J/w@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Maxime Ripard
<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org,
Zhou Wang <wangzhou1-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org>,
Alex Smith <alex.smith-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH 01/12] mtd: nand: remove unneeded of_mtd.h inclusions
Date: Fri, 1 Apr 2016 14:09:27 +0100 [thread overview]
Message-ID: <56FE7307.6040903@imgtec.com> (raw)
In-Reply-To: <1459515272-31011-2-git-send-email-boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Hi Boris,
On 01/04/16 13:54, Boris Brezillon wrote:
> Some drivers are including linux/of_mtd.h even if they don't use any of
> the of_get_nand_xxx() helpers.
>
> Signed-off-by: Boris Brezillon <boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
> ---
> drivers/mtd/nand/jz4780_nand.c | 1 -
> drivers/mtd/nand/lpc32xx_mlc.c | 1 -
> drivers/mtd/nand/qcom_nandc.c | 1 -
> drivers/mtd/nand/sunxi_nand.c | 1 -
> drivers/mtd/nand/vf610_nfc.c | 1 -
> 5 files changed, 5 deletions(-)
>
> diff --git a/drivers/mtd/nand/jz4780_nand.c b/drivers/mtd/nand/jz4780_nand.c
> index e1c016c..23a1999 100644
> --- a/drivers/mtd/nand/jz4780_nand.c
> +++ b/drivers/mtd/nand/jz4780_nand.c
> @@ -17,7 +17,6 @@
> #include <linux/of.h>
> #include <linux/of_address.h>
> #include <linux/gpio/consumer.h>
> -#include <linux/of_mtd.h>
> #include <linux/platform_device.h>
> #include <linux/slab.h>
> #include <linux/mtd/mtd.h>
Looks good to me.
Acked-by: Harvey Hunt <harvey.hunt-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org>
Thanks,
Harvey
WARNING: multiple messages have this Message-ID (diff)
From: harvey.hunt@imgtec.com (Harvey Hunt)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 01/12] mtd: nand: remove unneeded of_mtd.h inclusions
Date: Fri, 1 Apr 2016 14:09:27 +0100 [thread overview]
Message-ID: <56FE7307.6040903@imgtec.com> (raw)
In-Reply-To: <1459515272-31011-2-git-send-email-boris.brezillon@free-electrons.com>
Hi Boris,
On 01/04/16 13:54, Boris Brezillon wrote:
> Some drivers are including linux/of_mtd.h even if they don't use any of
> the of_get_nand_xxx() helpers.
>
> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> ---
> drivers/mtd/nand/jz4780_nand.c | 1 -
> drivers/mtd/nand/lpc32xx_mlc.c | 1 -
> drivers/mtd/nand/qcom_nandc.c | 1 -
> drivers/mtd/nand/sunxi_nand.c | 1 -
> drivers/mtd/nand/vf610_nfc.c | 1 -
> 5 files changed, 5 deletions(-)
>
> diff --git a/drivers/mtd/nand/jz4780_nand.c b/drivers/mtd/nand/jz4780_nand.c
> index e1c016c..23a1999 100644
> --- a/drivers/mtd/nand/jz4780_nand.c
> +++ b/drivers/mtd/nand/jz4780_nand.c
> @@ -17,7 +17,6 @@
> #include <linux/of.h>
> #include <linux/of_address.h>
> #include <linux/gpio/consumer.h>
> -#include <linux/of_mtd.h>
> #include <linux/platform_device.h>
> #include <linux/slab.h>
> #include <linux/mtd/mtd.h>
Looks good to me.
Acked-by: Harvey Hunt <harvey.hunt@imgtec.com>
Thanks,
Harvey
next prev parent reply other threads:[~2016-04-01 13:09 UTC|newest]
Thread overview: 88+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-01 12:54 [PATCH 00/12] mtd: get rid of of_mtd.{c,h} and of_get_nand_xx() Boris Brezillon
2016-04-01 12:54 ` Boris Brezillon
2016-04-01 12:54 ` Boris Brezillon
2016-04-01 12:54 ` [PATCH 01/12] mtd: nand: remove unneeded of_mtd.h inclusions Boris Brezillon
2016-04-01 12:54 ` Boris Brezillon
2016-04-01 12:54 ` Boris Brezillon
2016-04-01 13:09 ` Harvey Hunt [this message]
2016-04-01 13:09 ` Harvey Hunt
2016-04-01 13:09 ` Harvey Hunt
2016-04-12 22:22 ` Boris Brezillon
2016-04-12 22:22 ` Boris Brezillon
2016-04-12 22:22 ` Boris Brezillon
2016-04-01 12:54 ` [PATCH 02/12] mtd: nand: atmel: rely on generic DT parsing done in nand_scan_ident() Boris Brezillon
2016-04-01 12:54 ` Boris Brezillon
2016-04-01 12:54 ` Boris Brezillon
2016-04-13 12:31 ` Boris Brezillon
2016-04-13 12:31 ` Boris Brezillon
2016-04-13 12:31 ` Boris Brezillon
2016-04-13 12:55 ` Nicolas Ferre
2016-04-13 12:55 ` Nicolas Ferre
2016-04-13 12:55 ` Nicolas Ferre
2016-04-13 13:51 ` Boris Brezillon
2016-04-13 13:51 ` Boris Brezillon
2016-04-13 13:51 ` Boris Brezillon
2016-04-01 12:54 ` [PATCH 03/12] mtd: nand: omap2: " Boris Brezillon
2016-04-01 12:54 ` Boris Brezillon
2016-04-01 12:54 ` Boris Brezillon
2016-04-04 7:23 ` Roger Quadros
2016-04-04 7:23 ` Roger Quadros
2016-04-04 7:23 ` Roger Quadros
2016-04-12 22:22 ` Boris Brezillon
2016-04-12 22:22 ` Boris Brezillon
2016-04-12 22:22 ` Boris Brezillon
2016-04-01 12:54 ` [PATCH 04/12] mtd: nand: brcm: " Boris Brezillon
2016-04-01 12:54 ` Boris Brezillon
2016-04-01 12:54 ` Boris Brezillon
2016-04-12 22:31 ` Brian Norris
2016-04-12 22:31 ` Brian Norris
2016-04-12 22:31 ` Brian Norris
2016-04-13 7:42 ` Boris Brezillon
2016-04-13 7:42 ` Boris Brezillon
2016-04-13 7:42 ` Boris Brezillon
2016-04-01 12:54 ` [PATCH 05/12] mtd: nand: davinci: " Boris Brezillon
2016-04-01 12:54 ` Boris Brezillon
2016-04-01 12:54 ` Boris Brezillon
2016-04-01 12:54 ` [PATCH 06/12] mtd: nand: gpmi: " Boris Brezillon
2016-04-01 12:54 ` Boris Brezillon
2016-04-01 12:54 ` Boris Brezillon
2016-04-16 9:07 ` Boris Brezillon
2016-04-16 9:07 ` Boris Brezillon
2016-04-16 9:07 ` Boris Brezillon
2016-04-16 18:46 ` Han Xu
2016-04-01 12:54 ` [PATCH 07/12] mtd: nand: hisi504: " Boris Brezillon
2016-04-01 12:54 ` Boris Brezillon
2016-04-01 12:54 ` Boris Brezillon
2016-04-01 12:54 ` [PATCH 08/12] mtd: nand: lpc32xx: " Boris Brezillon
2016-04-01 12:54 ` Boris Brezillon
2016-04-01 12:54 ` Boris Brezillon
2016-04-01 12:54 ` [PATCH 09/12] mtd: nand: mxc: " Boris Brezillon
2016-04-01 12:54 ` Boris Brezillon
2016-04-01 12:54 ` Boris Brezillon
2016-04-01 12:54 ` [PATCH 10/12] mtd: nand: pxa3xx: " Boris Brezillon
2016-04-01 12:54 ` Boris Brezillon
2016-04-01 12:54 ` Boris Brezillon
2016-04-13 14:48 ` Ezequiel Garcia
2016-04-13 14:48 ` Ezequiel Garcia
2016-04-13 14:48 ` Ezequiel Garcia
2016-04-13 14:53 ` Boris Brezillon
2016-04-13 14:53 ` Boris Brezillon
2016-04-13 14:53 ` Boris Brezillon
2016-04-01 12:54 ` [PATCH 11/12] mtd: nand: sh_flctl: " Boris Brezillon
2016-04-01 12:54 ` Boris Brezillon
2016-04-01 12:54 ` Boris Brezillon
2016-04-01 12:54 ` [PATCH 12/12] mtd: nand: move of_get_nand_xxx() helpers into nand_base.c Boris Brezillon
2016-04-01 12:54 ` Boris Brezillon
2016-04-01 12:54 ` Boris Brezillon
2016-04-01 14:13 ` kbuild test robot
2016-04-01 14:13 ` kbuild test robot
2016-04-01 14:13 ` kbuild test robot
2016-04-01 15:34 ` Boris Brezillon
2016-04-01 15:34 ` Boris Brezillon
2016-04-01 15:34 ` Boris Brezillon
2016-04-06 23:33 ` [PATCH 00/12] mtd: get rid of of_mtd.{c,h} and of_get_nand_xx() Franklin S Cooper Jr.
2016-04-06 23:33 ` Franklin S Cooper Jr.
2016-04-06 23:33 ` Franklin S Cooper Jr.
2016-04-22 9:14 ` Boris Brezillon
2016-04-22 9:14 ` Boris Brezillon
2016-04-22 9:14 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56FE7307.6040903@imgtec.com \
--to=harvey.hunt@imgtec.com \
--cc=alex.smith@imgtec.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=daniel@zonque.org \
--cc=dwmw2@infradead.org \
--cc=ezequiel.garcia@free-electrons.com \
--cc=gregory.clement@free-electrons.com \
--cc=han.xu@nxp.com \
--cc=haojian.zhuang@gmail.com \
--cc=jason@lakedaemon.net \
--cc=kdasu.kdev@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=maxime.ripard@free-electrons.com \
--cc=nicolas.ferre@atmel.com \
--cc=plagnioj@jcrosoft.com \
--cc=rainyfeeling@outlook.com \
--cc=richard@nod.at \
--cc=robert.jarzmik@free.fr \
--cc=rogerq@ti.com \
--cc=sebastian.hesselbarth@gmail.com \
--cc=stefan@agner.ch \
--cc=thomas.petazzoni@free-electrons.com \
--cc=tony@atomide.com \
--cc=wangzhou1@hisilicon.com \
--cc=wens@csie.org \
--cc=wenyou.yang@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.