* [PATCH] infiniband: use the ISCSI_LOGIN_CURRENT_STAGE macro
@ 2022-11-16 9:45 Maurizio Lombardi
2022-11-17 17:31 ` Mike Christie
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Maurizio Lombardi @ 2022-11-16 9:45 UTC (permalink / raw)
To: sagi; +Cc: jgg, linux-rdma, target-devel
Use the proper macro to get the current_stage value.
Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>
---
drivers/infiniband/ulp/isert/ib_isert.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/infiniband/ulp/isert/ib_isert.c b/drivers/infiniband/ulp/isert/ib_isert.c
index b360a1527cd1..75404885cf98 100644
--- a/drivers/infiniband/ulp/isert/ib_isert.c
+++ b/drivers/infiniband/ulp/isert/ib_isert.c
@@ -993,9 +993,8 @@ isert_rx_login_req(struct isert_conn *isert_conn)
* login request PDU.
*/
login->leading_connection = (!login_req->tsih) ? 1 : 0;
- login->current_stage =
- (login_req->flags & ISCSI_FLAG_LOGIN_CURRENT_STAGE_MASK)
- >> 2;
+ login->current_stage = ISCSI_LOGIN_CURRENT_STAGE(
+ login_req->flags);
login->version_min = login_req->min_version;
login->version_max = login_req->max_version;
memcpy(login->isid, login_req->isid, 6);
--
2.31.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] infiniband: use the ISCSI_LOGIN_CURRENT_STAGE macro
2022-11-16 9:45 [PATCH] infiniband: use the ISCSI_LOGIN_CURRENT_STAGE macro Maurizio Lombardi
@ 2022-11-17 17:31 ` Mike Christie
2022-11-20 11:52 ` Sagi Grimberg
2022-11-21 19:01 ` Jason Gunthorpe
2 siblings, 0 replies; 4+ messages in thread
From: Mike Christie @ 2022-11-17 17:31 UTC (permalink / raw)
To: Maurizio Lombardi, sagi; +Cc: jgg, linux-rdma, target-devel
On 11/16/22 3:45 AM, Maurizio Lombardi wrote:
> Use the proper macro to get the current_stage value.
>
> Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>
> ---
> drivers/infiniband/ulp/isert/ib_isert.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/infiniband/ulp/isert/ib_isert.c b/drivers/infiniband/ulp/isert/ib_isert.c
> index b360a1527cd1..75404885cf98 100644
> --- a/drivers/infiniband/ulp/isert/ib_isert.c
> +++ b/drivers/infiniband/ulp/isert/ib_isert.c
> @@ -993,9 +993,8 @@ isert_rx_login_req(struct isert_conn *isert_conn)
> * login request PDU.
> */
> login->leading_connection = (!login_req->tsih) ? 1 : 0;
> - login->current_stage =
> - (login_req->flags & ISCSI_FLAG_LOGIN_CURRENT_STAGE_MASK)
> - >> 2;
> + login->current_stage = ISCSI_LOGIN_CURRENT_STAGE(
> + login_req->flags);
> login->version_min = login_req->min_version;
> login->version_max = login_req->max_version;
> memcpy(login->isid, login_req->isid, 6);
Reviewed-by: Mike Christie <michael.christie@oracle.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] infiniband: use the ISCSI_LOGIN_CURRENT_STAGE macro
2022-11-16 9:45 [PATCH] infiniband: use the ISCSI_LOGIN_CURRENT_STAGE macro Maurizio Lombardi
2022-11-17 17:31 ` Mike Christie
@ 2022-11-20 11:52 ` Sagi Grimberg
2022-11-21 19:01 ` Jason Gunthorpe
2 siblings, 0 replies; 4+ messages in thread
From: Sagi Grimberg @ 2022-11-20 11:52 UTC (permalink / raw)
To: Maurizio Lombardi; +Cc: jgg, linux-rdma, target-devel
title prefix should be:
iser-target: use the...
> Use the proper macro to get the current_stage value.
>
> Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>
> ---
> drivers/infiniband/ulp/isert/ib_isert.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/infiniband/ulp/isert/ib_isert.c b/drivers/infiniband/ulp/isert/ib_isert.c
> index b360a1527cd1..75404885cf98 100644
> --- a/drivers/infiniband/ulp/isert/ib_isert.c
> +++ b/drivers/infiniband/ulp/isert/ib_isert.c
> @@ -993,9 +993,8 @@ isert_rx_login_req(struct isert_conn *isert_conn)
> * login request PDU.
> */
> login->leading_connection = (!login_req->tsih) ? 1 : 0;
> - login->current_stage =
> - (login_req->flags & ISCSI_FLAG_LOGIN_CURRENT_STAGE_MASK)
> - >> 2;
> + login->current_stage = ISCSI_LOGIN_CURRENT_STAGE(
> + login_req->flags);
> login->version_min = login_req->min_version;
> login->version_max = login_req->max_version;
> memcpy(login->isid, login_req->isid, 6);
Acked-by: Sagi Grimberg <sagi@grimberg.me>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] infiniband: use the ISCSI_LOGIN_CURRENT_STAGE macro
2022-11-16 9:45 [PATCH] infiniband: use the ISCSI_LOGIN_CURRENT_STAGE macro Maurizio Lombardi
2022-11-17 17:31 ` Mike Christie
2022-11-20 11:52 ` Sagi Grimberg
@ 2022-11-21 19:01 ` Jason Gunthorpe
2 siblings, 0 replies; 4+ messages in thread
From: Jason Gunthorpe @ 2022-11-21 19:01 UTC (permalink / raw)
To: Maurizio Lombardi; +Cc: sagi, linux-rdma, target-devel
On Wed, Nov 16, 2022 at 10:45:35AM +0100, Maurizio Lombardi wrote:
> Use the proper macro to get the current_stage value.
>
> Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>
> Reviewed-by: Mike Christie <michael.christie@oracle.com>
> Acked-by: Sagi Grimberg <sagi@grimberg.me>
> ---
> drivers/infiniband/ulp/isert/ib_isert.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
Applied to for-next, thanks
Jason
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-11-21 19:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-16 9:45 [PATCH] infiniband: use the ISCSI_LOGIN_CURRENT_STAGE macro Maurizio Lombardi
2022-11-17 17:31 ` Mike Christie
2022-11-20 11:52 ` Sagi Grimberg
2022-11-21 19:01 ` Jason Gunthorpe
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.