* [PATCH 1/3] xen/xsm: remove unnecessary #define
@ 2018-10-09 0:28 Xin Li
2018-10-09 6:56 ` Jan Beulich
2018-10-09 6:59 ` Jan Beulich
0 siblings, 2 replies; 9+ messages in thread
From: Xin Li @ 2018-10-09 0:28 UTC (permalink / raw)
To: xen-devel
Cc: Sergey Dyasli, Stefano Stabellini, Wei Liu,
Konrad Rzeszutek Wilk, George Dunlap, Xin Li, Tim Deegan,
Jan Beulich, Andrew Cooper, Ming Lu, Daniel De Graaf
this #define is unnecessary since XSM_INLINE is redefined in
xsm/dummy.h, it's a risk of build breakage, so remove it.
Signed-off-by: Xin Li <xin.li@citrix.com>
---
CC: Daniel De Graaf <dgdegra@tycho.nsa.gov>
CC: George Dunlap <George.Dunlap@eu.citrix.com>
CC: Jan Beulich <JBeulich@suse.com>
CC: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
CC: Stefano Stabellini <sstabellini@kernel.org>
CC: Tim Deegan <tim@xen.org>
CC: Wei Liu <wei.liu2@citrix.com>
CC: Sergey Dyasli <sergey.dyasli@citrix.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
CC: Ming Lu <ming.lu@citrix.com>
v5:
1. move the removal of #define to this new patch.
2. fix wrong git author
---
xen/xsm/dummy.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/xen/xsm/dummy.c b/xen/xsm/dummy.c
index 3290d04527..06a674fad0 100644
--- a/xen/xsm/dummy.c
+++ b/xen/xsm/dummy.c
@@ -11,7 +11,6 @@
*/
#define XSM_NO_WRAPPERS
-#define XSM_INLINE /* */
#include <xsm/dummy.h>
struct xsm_operations dummy_xsm_ops;
--
2.18.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 1/3] xen/xsm: remove unnecessary #define
2018-10-09 0:28 [PATCH 1/3] xen/xsm: remove unnecessary #define Xin Li
@ 2018-10-09 6:56 ` Jan Beulich
2018-10-09 7:47 ` Xin Li (Talons)
2018-10-09 6:59 ` Jan Beulich
1 sibling, 1 reply; 9+ messages in thread
From: Jan Beulich @ 2018-10-09 6:56 UTC (permalink / raw)
To: Xin Li
Cc: Sergey Dyasli, Stefano Stabellini, Wei Liu,
Konrad Rzeszutek Wilk, George Dunlap, Andrew Cooper, Tim Deegan,
xen-devel, Xin Li, Ming Lu, Daniel de Graaf
>>> On 09.10.18 at 02:28, <talons.lee@gmail.com> wrote:
> v5:
> 1. move the removal of #define to this new patch.
> 2. fix wrong git author
Thanks, but one more formal request: Would you please include the
version of a patch/series in side the square brackets of the mail
subject, like everyone else does? This allows to easily identify what
belongs where without having to open each mail.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/3] xen/xsm: remove unnecessary #define
2018-10-09 0:28 [PATCH 1/3] xen/xsm: remove unnecessary #define Xin Li
2018-10-09 6:56 ` Jan Beulich
@ 2018-10-09 6:59 ` Jan Beulich
2018-10-09 7:50 ` Xin Li (Talons)
1 sibling, 1 reply; 9+ messages in thread
From: Jan Beulich @ 2018-10-09 6:59 UTC (permalink / raw)
To: Xin Li
Cc: Sergey Dyasli, Stefano Stabellini, Wei Liu,
Konrad Rzeszutek Wilk, George Dunlap, Andrew Cooper, Tim Deegan,
xen-devel, Xin Li, Ming Lu, Daniel de Graaf
>>> On 09.10.18 at 02:28, <talons.lee@gmail.com> wrote:
> this #define is unnecessary since XSM_INLINE is redefined in
> xsm/dummy.h, it's a risk of build breakage, so remove it.
>
> Signed-off-by: Xin Li <xin.li@citrix.com>
>
> ---
> CC: Daniel De Graaf <dgdegra@tycho.nsa.gov>
> CC: George Dunlap <George.Dunlap@eu.citrix.com>
> CC: Jan Beulich <JBeulich@suse.com>
> CC: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> CC: Stefano Stabellini <sstabellini@kernel.org>
> CC: Tim Deegan <tim@xen.org>
> CC: Wei Liu <wei.liu2@citrix.com>
> CC: Sergey Dyasli <sergey.dyasli@citrix.com>
> CC: Andrew Cooper <andrew.cooper3@citrix.com>
> CC: Ming Lu <ming.lu@citrix.com>
>
> v5:
> 1. move the removal of #define to this new patch.
> 2. fix wrong git author
Oh, and please, when you send new versions, add previously
provided (of course unless they've been invalidated meanwhile)
tags, to aid both committers and future readers/reviewers.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/3] xen/xsm: remove unnecessary #define
2018-10-09 6:56 ` Jan Beulich
@ 2018-10-09 7:47 ` Xin Li (Talons)
0 siblings, 0 replies; 9+ messages in thread
From: Xin Li (Talons) @ 2018-10-09 7:47 UTC (permalink / raw)
To: Jan Beulich, Xin Li
Cc: Sergey Dyasli, Stefano Stabellini, Wei Liu,
Konrad Rzeszutek Wilk, Andrew Cooper, Tim (Xen.org),
George Dunlap, xen-devel, Ming Lu, Daniel de Graaf
> >>> On 09.10.18 at 02:28, <talons.lee@gmail.com> wrote:
> > v5:
> > 1. move the removal of #define to this new patch.
> > 2. fix wrong git author
>
> Thanks, but one more formal request: Would you please include the version of
> a patch/series in side the square brackets of the mail subject, like everyone
> else does? This allows to easily identify what belongs where without having to
> open each mail.
OK. I will follow this style to resend path set v5.
Re: [Xen-devel] [PATCH v3 1/2] x86: fix comment on super page alignment requirement
>
> Jan
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/3] xen/xsm: remove unnecessary #define
2018-10-09 6:59 ` Jan Beulich
@ 2018-10-09 7:50 ` Xin Li (Talons)
2018-10-09 9:02 ` Jan Beulich
0 siblings, 1 reply; 9+ messages in thread
From: Xin Li (Talons) @ 2018-10-09 7:50 UTC (permalink / raw)
To: Jan Beulich, Xin Li
Cc: Sergey Dyasli, Stefano Stabellini, Wei Liu,
Konrad Rzeszutek Wilk, Andrew Cooper, Tim (Xen.org),
George Dunlap, xen-devel, Ming Lu, Daniel de Graaf
> > ---
> > CC: Daniel De Graaf <dgdegra@tycho.nsa.gov>
> > CC: George Dunlap <George.Dunlap@eu.citrix.com>
> > CC: Jan Beulich <JBeulich@suse.com>
> > CC: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> > CC: Stefano Stabellini <sstabellini@kernel.org>
> > CC: Tim Deegan <tim@xen.org>
> > CC: Wei Liu <wei.liu2@citrix.com>
> > CC: Sergey Dyasli <sergey.dyasli@citrix.com>
> > CC: Andrew Cooper <andrew.cooper3@citrix.com>
> > CC: Ming Lu <ming.lu@citrix.com>
> >
> > v5:
> > 1. move the removal of #define to this new patch.
> > 2. fix wrong git author
>
> Oh, and please, when you send new versions, add previously provided (of
> course unless they've been invalidated meanwhile) tags, to aid both committers
> and future readers/reviewers.
>
Do you mean all the changes from v1 to v5, like:
v1:
xxx
v2:
xxx
..
v5
> Jan
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/3] xen/xsm: remove unnecessary #define
2018-10-09 7:50 ` Xin Li (Talons)
@ 2018-10-09 9:02 ` Jan Beulich
0 siblings, 0 replies; 9+ messages in thread
From: Jan Beulich @ 2018-10-09 9:02 UTC (permalink / raw)
To: Xin Li, Xin Li
Cc: Sergey Dyasli, Stefano Stabellini, Wei Liu,
Konrad Rzeszutek Wilk, Andrew Cooper, Tim Deegan, george.dunlap,
xen-devel, Ming Lu, Daniel de Graaf
>>> On 09.10.18 at 09:50, <xin.li@citrix.com> wrote:
>> > ---
>> > CC: Daniel De Graaf <dgdegra@tycho.nsa.gov>
>> > CC: George Dunlap <George.Dunlap@eu.citrix.com>
>> > CC: Jan Beulich <JBeulich@suse.com>
>> > CC: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>> > CC: Stefano Stabellini <sstabellini@kernel.org>
>> > CC: Tim Deegan <tim@xen.org>
>> > CC: Wei Liu <wei.liu2@citrix.com>
>> > CC: Sergey Dyasli <sergey.dyasli@citrix.com>
>> > CC: Andrew Cooper <andrew.cooper3@citrix.com>
>> > CC: Ming Lu <ming.lu@citrix.com>
>> >
>> > v5:
>> > 1. move the removal of #define to this new patch.
>> > 2. fix wrong git author
>>
>> Oh, and please, when you send new versions, add previously provided (of
>> course unless they've been invalidated meanwhile) tags, to aid both
> committers
>> and future readers/reviewers.
>>
> Do you mean all the changes from v1 to v5, like:
>
> v1:
> xxx
>
> v2:
> xxx
> ..
>
> v5
No, this is occasionally helpful, but not what I mean. I gave my R-b
on v4, so you should have recorded it in v5.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/3] xen/xsm: remove unnecessary #define
2018-10-08 10:59 Xin Li
2018-10-08 11:55 ` Jan Beulich
@ 2018-10-08 13:18 ` Wei Liu
1 sibling, 0 replies; 9+ messages in thread
From: Wei Liu @ 2018-10-08 13:18 UTC (permalink / raw)
To: Xin Li
Cc: Sergey Dyasli, Stefano Stabellini, Wei Liu,
Konrad Rzeszutek Wilk, George Dunlap, Xin Li, root, Tim Deegan,
xen-devel, Jan Beulich, Andrew Cooper, Ming Lu, Daniel De Graaf
On Mon, Oct 08, 2018 at 06:59:01PM +0800, Xin Li wrote:
> From: root <root@lcy2-dt16.xenrtcloud>
This needs to be deleted while committing.
Wei.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/3] xen/xsm: remove unnecessary #define
2018-10-08 10:59 Xin Li
@ 2018-10-08 11:55 ` Jan Beulich
2018-10-08 13:18 ` Wei Liu
1 sibling, 0 replies; 9+ messages in thread
From: Jan Beulich @ 2018-10-08 11:55 UTC (permalink / raw)
To: Xin Li
Cc: Sergey Dyasli, Stefano Stabellini, Wei Liu,
Konrad Rzeszutek Wilk, George Dunlap, Andrew Cooper, root,
Tim Deegan, xen-devel, Xin Li, Ming Lu, Daniel de Graaf
>>> On 08.10.18 at 12:59, <talons.lee@gmail.com> wrote:
> From: root <root@lcy2-dt16.xenrtcloud>
>
> this #define is unnecessary since XSM_INLINE is redefined in
> xsm/dummy.h, so remove it.
And it is actually a latent risk of build breakage, if the other one got
updated without this one following suit.
> Signed-off-by: Xin Li <xin.li@citrix.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 1/3] xen/xsm: remove unnecessary #define
@ 2018-10-08 10:59 Xin Li
2018-10-08 11:55 ` Jan Beulich
2018-10-08 13:18 ` Wei Liu
0 siblings, 2 replies; 9+ messages in thread
From: Xin Li @ 2018-10-08 10:59 UTC (permalink / raw)
To: xen-devel
Cc: Sergey Dyasli, Stefano Stabellini, Wei Liu,
Konrad Rzeszutek Wilk, George Dunlap, Xin Li, root, Tim Deegan,
Jan Beulich, Andrew Cooper, Ming Lu, Daniel De Graaf
From: root <root@lcy2-dt16.xenrtcloud>
this #define is unnecessary since XSM_INLINE is redefined in
xsm/dummy.h, so remove it.
Signed-off-by: Xin Li <xin.li@citrix.com>
---
CC: Daniel De Graaf <dgdegra@tycho.nsa.gov>
CC: George Dunlap <George.Dunlap@eu.citrix.com>
CC: Jan Beulich <JBeulich@suse.com>
CC: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
CC: Stefano Stabellini <sstabellini@kernel.org>
CC: Tim Deegan <tim@xen.org>
CC: Wei Liu <wei.liu2@citrix.com>
CC: Sergey Dyasli <sergey.dyasli@citrix.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
CC: Ming Lu <ming.lu@citrix.com>
v5: move the removal of #define to this new patch.
---
xen/xsm/dummy.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/xen/xsm/dummy.c b/xen/xsm/dummy.c
index 3290d04527..06a674fad0 100644
--- a/xen/xsm/dummy.c
+++ b/xen/xsm/dummy.c
@@ -11,7 +11,6 @@
*/
#define XSM_NO_WRAPPERS
-#define XSM_INLINE /* */
#include <xsm/dummy.h>
struct xsm_operations dummy_xsm_ops;
--
2.18.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 9+ messages in thread
end of thread, other threads:[~2018-10-09 9:02 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-09 0:28 [PATCH 1/3] xen/xsm: remove unnecessary #define Xin Li
2018-10-09 6:56 ` Jan Beulich
2018-10-09 7:47 ` Xin Li (Talons)
2018-10-09 6:59 ` Jan Beulich
2018-10-09 7:50 ` Xin Li (Talons)
2018-10-09 9:02 ` Jan Beulich
-- strict thread matches above, loose matches on Subject: below --
2018-10-08 10:59 Xin Li
2018-10-08 11:55 ` Jan Beulich
2018-10-08 13:18 ` Wei Liu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.