All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: "Pali Rohár" <pali@kernel.org>, "Marek Behún" <marek.behun@nic.cz>
Cc: u-boot@lists.denx.de
Subject: Re: [PATCH] arm: mvebu: a38x: Fix 5200000 baudrate
Date: Thu, 2 Sep 2021 14:18:45 +0200	[thread overview]
Message-ID: <56b69cf6-abbd-1e69-088c-490842368dd2@denx.de> (raw)
In-Reply-To: <20210902100051.12306-1-pali@kernel.org>

On 02.09.21 12:00, Pali Rohár wrote:
> Fix baudrate value 5150000 which was added in commit ead4864fa6cc ("arm:
> mvebu: a38x: Define supported UART baudrates").
> 
> Exact value for divisor 3 with 250 MHz TCLK is 5208333 baudrate. In above
> commit I incorrectly rounded it to 5150000 value due to testing with
> USB-UART hw which incorrectly reported exact value and divisor configured
> on other other end of UART link.
> 
> Fix this value to 520000 baudrate which is more close to the exact hardware
> value and also has less fraction parts.
> 
> Signed-off-by: Pali Rohár <pali@kernel.org>
> Fixes: ead4864fa6cc ("arm: mvebu: a38x: Define supported UART baudrates")

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

> ---
>   include/configs/mv-common.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/configs/mv-common.h b/include/configs/mv-common.h
> index 53d7acbb1034..6036bf4fa5d7 100644
> --- a/include/configs/mv-common.h
> +++ b/include/configs/mv-common.h
> @@ -45,7 +45,7 @@
>   					  230400, 460800, 500000, 576000, \
>   					  921600, 1000000, 1152000, 1500000, \
>   					  2000000, 2500000, 3125000, 4000000, \
> -					  5150000 }
> +					  5200000 }
>   #endif
>   
>   /* auto boot */
> 


Viele Grüße,
Stefan

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de

      reply	other threads:[~2021-09-02 12:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-02 10:00 [PATCH] arm: mvebu: a38x: Fix 5200000 baudrate Pali Rohár
2021-09-02 12:18 ` Stefan Roese [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56b69cf6-abbd-1e69-088c-490842368dd2@denx.de \
    --to=sr@denx.de \
    --cc=marek.behun@nic.cz \
    --cc=pali@kernel.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.