* [PATCH] arm: mvebu: a38x: Fix 5200000 baudrate
@ 2021-09-02 10:00 Pali Rohár
2021-09-02 12:18 ` Stefan Roese
0 siblings, 1 reply; 2+ messages in thread
From: Pali Rohár @ 2021-09-02 10:00 UTC (permalink / raw)
To: Stefan Roese, Marek Behún; +Cc: u-boot
Fix baudrate value 5150000 which was added in commit ead4864fa6cc ("arm:
mvebu: a38x: Define supported UART baudrates").
Exact value for divisor 3 with 250 MHz TCLK is 5208333 baudrate. In above
commit I incorrectly rounded it to 5150000 value due to testing with
USB-UART hw which incorrectly reported exact value and divisor configured
on other other end of UART link.
Fix this value to 520000 baudrate which is more close to the exact hardware
value and also has less fraction parts.
Signed-off-by: Pali Rohár <pali@kernel.org>
Fixes: ead4864fa6cc ("arm: mvebu: a38x: Define supported UART baudrates")
---
include/configs/mv-common.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/configs/mv-common.h b/include/configs/mv-common.h
index 53d7acbb1034..6036bf4fa5d7 100644
--- a/include/configs/mv-common.h
+++ b/include/configs/mv-common.h
@@ -45,7 +45,7 @@
230400, 460800, 500000, 576000, \
921600, 1000000, 1152000, 1500000, \
2000000, 2500000, 3125000, 4000000, \
- 5150000 }
+ 5200000 }
#endif
/* auto boot */
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] arm: mvebu: a38x: Fix 5200000 baudrate
2021-09-02 10:00 [PATCH] arm: mvebu: a38x: Fix 5200000 baudrate Pali Rohár
@ 2021-09-02 12:18 ` Stefan Roese
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Roese @ 2021-09-02 12:18 UTC (permalink / raw)
To: Pali Rohár, Marek Behún; +Cc: u-boot
On 02.09.21 12:00, Pali Rohár wrote:
> Fix baudrate value 5150000 which was added in commit ead4864fa6cc ("arm:
> mvebu: a38x: Define supported UART baudrates").
>
> Exact value for divisor 3 with 250 MHz TCLK is 5208333 baudrate. In above
> commit I incorrectly rounded it to 5150000 value due to testing with
> USB-UART hw which incorrectly reported exact value and divisor configured
> on other other end of UART link.
>
> Fix this value to 520000 baudrate which is more close to the exact hardware
> value and also has less fraction parts.
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
> Fixes: ead4864fa6cc ("arm: mvebu: a38x: Define supported UART baudrates")
Reviewed-by: Stefan Roese <sr@denx.de>
Thanks,
Stefan
> ---
> include/configs/mv-common.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/configs/mv-common.h b/include/configs/mv-common.h
> index 53d7acbb1034..6036bf4fa5d7 100644
> --- a/include/configs/mv-common.h
> +++ b/include/configs/mv-common.h
> @@ -45,7 +45,7 @@
> 230400, 460800, 500000, 576000, \
> 921600, 1000000, 1152000, 1500000, \
> 2000000, 2500000, 3125000, 4000000, \
> - 5150000 }
> + 5200000 }
> #endif
>
> /* auto boot */
>
Viele Grüße,
Stefan
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-02 12:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-02 10:00 [PATCH] arm: mvebu: a38x: Fix 5200000 baudrate Pali Rohár
2021-09-02 12:18 ` Stefan Roese
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.