[Buildroot] [PATCH 1/1] package/freeradius-server: requires MD4 in openssl

[Buildroot] [PATCH 1/1] package/freeradius-server: requires MD4 in openssl

[Fabrice Fontaine]

Enable MD4 in openssl to avoid the following build failure raised since
the addition of the package in commit
736c4c1655d93652a9a7e79235bbe726b3d46176:

In file included from src/lib/md4.c:16:
src/lib/md4.c: In function 'fr_md4_calc':
src/freeradius-devel/md4.h:76:33: error: unknown type name 'MD4_CTX'; did you mean 'FR_MD4_CTX'?
   76 | #  define FR_MD4_CTX            MD4_CTX
      |                                 ^~~~~~~

Fixes:
 - http://autobuild.buildroot.org/results/a8aa12a8129056391f975820ea3d1d62241ac051

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/freeradius-server/Config.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/freeradius-server/Config.in b/package/freeradius-server/Config.in
index 52a50bd3a7..d51d92714d 100644
--- a/package/freeradius-server/Config.in
+++ b/package/freeradius-server/Config.in
@@ -4,6 +4,7 @@ config BR2_PACKAGE_FREERADIUS_SERVER
 	depends on !BR2_STATIC_LIBS # libtalloc
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	depends on BR2_TOOLCHAIN_USES_GLIBC
+	select BR2_PACKAGE_LIBOPENSSL_ENABLE_MD4 if BR2_PACKAGE_LIBOPENSSL
 	select BR2_PACKAGE_LIBTALLOC
 	help
 	  FreeRADIUS is an open source server which implements
-- 
2.35.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/freeradius-server: requires MD4 in openssl

[Arnout Vandecappelle]

On 28/07/2022 10:24, Fabrice Fontaine wrote:
> Enable MD4 in openssl to avoid the following build failure raised since
> the addition of the package in commit
> 736c4c1655d93652a9a7e79235bbe726b3d46176:
> 
> In file included from src/lib/md4.c:16:
> src/lib/md4.c: In function 'fr_md4_calc':
> src/freeradius-devel/md4.h:76:33: error: unknown type name 'MD4_CTX'; did you mean 'FR_MD4_CTX'?
>     76 | #  define FR_MD4_CTX            MD4_CTX
>        |                                 ^~~~~~~

  Would there instead be a way to convince freeradius not to use MD4? Using MD4 
these days is really a bad idea...

  Regards,
  Arnout

> 
> Fixes:
>   - http://autobuild.buildroot.org/results/a8aa12a8129056391f975820ea3d1d62241ac051
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>   package/freeradius-server/Config.in | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/package/freeradius-server/Config.in b/package/freeradius-server/Config.in
> index 52a50bd3a7..d51d92714d 100644
> --- a/package/freeradius-server/Config.in
> +++ b/package/freeradius-server/Config.in
> @@ -4,6 +4,7 @@ config BR2_PACKAGE_FREERADIUS_SERVER
>   	depends on !BR2_STATIC_LIBS # libtalloc
>   	depends on BR2_TOOLCHAIN_HAS_THREADS
>   	depends on BR2_TOOLCHAIN_USES_GLIBC
> +	select BR2_PACKAGE_LIBOPENSSL_ENABLE_MD4 if BR2_PACKAGE_LIBOPENSSL
>   	select BR2_PACKAGE_LIBTALLOC
>   	help
>   	  FreeRADIUS is an open source server which implements
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/freeradius-server: requires MD4 in openssl

[Thomas Petazzoni via buildroot]

On Thu, 28 Jul 2022 10:24:38 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> Enable MD4 in openssl to avoid the following build failure raised since
> the addition of the package in commit
> 736c4c1655d93652a9a7e79235bbe726b3d46176:
> 
> In file included from src/lib/md4.c:16:
> src/lib/md4.c: In function 'fr_md4_calc':
> src/freeradius-devel/md4.h:76:33: error: unknown type name 'MD4_CTX'; did you mean 'FR_MD4_CTX'?
>    76 | #  define FR_MD4_CTX            MD4_CTX
>       |                                 ^~~~~~~
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/a8aa12a8129056391f975820ea3d1d62241ac051
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/freeradius-server/Config.in | 1 +
>  1 file changed, 1 insertion(+)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/freeradius-server: requires MD4 in openssl

[Thomas Petazzoni via buildroot]

On Thu, 28 Jul 2022 21:39:09 +0200
Arnout Vandecappelle <arnout@mind.be> wrote:

> > In file included from src/lib/md4.c:16:
> > src/lib/md4.c: In function 'fr_md4_calc':
> > src/freeradius-devel/md4.h:76:33: error: unknown type name 'MD4_CTX'; did you mean 'FR_MD4_CTX'?
> >     76 | #  define FR_MD4_CTX            MD4_CTX
> >        |                                 ^~~~~~~  
> 
>   Would there instead be a way to convince freeradius not to use MD4? Using MD4 
> these days is really a bad idea...

I agree, but for the time being, since freeradius-server uses it, from
a packaging point of view, we don't have much choice but to enable MD4
support. That being said, it would certainly be good to look into
freeradius and see if usage of MD4 can be disabled/removed.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot