All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: Ping#3: [PATCH v3] x86/HVM: don't #GP/#SS on wrapping virt->linear translations
Date: Mon, 4 Dec 2017 16:39:11 +0000	[thread overview]
Message-ID: <56e7c11d-1eff-b5bf-73fe-e6bd1f36871f@citrix.com> (raw)
In-Reply-To: <5A252E9B020000780019440F@prv-mh.provo.novell.com>

On 04/12/17 10:16, Jan Beulich wrote:
>>>> On 25.08.17 at 16:59,  wrote:
>>>>> On 10.08.17 at 09:19, <JBeulich@suse.com> wrote:
>>>>>> On 10.07.17 at 12:39, <JBeulich@suse.com> wrote:
>>>> Real hardware wraps silently in most cases, so we should behave the
>>>> same. Also split real and VM86 mode handling, as the latter really
>>>> ought to have limit checks applied.
>>>>
>>>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>>>> ---
>>>> v3: Restore 32-bit wrap check for AMD.
>>>> v2: Extend to non-64-bit modes. Reduce 64-bit check to a single
>>>>     is_canonical_address() invocation.
> Same here - I think I've been carrying this for long enough.

I'm not sure what to say.  I'm not comfortable taking this change
without a regression test in place, which also serves to demonstrate the
correctness of the change.

Its simply a matter of time, not any other objection to the change.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply	other threads:[~2017-12-04 16:47 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-10 10:39 [PATCH v3] x86/HVM: don't #GP/#SS on wrapping virt->linear translations Jan Beulich
2017-08-10  7:19 ` Ping: " Jan Beulich
2017-08-25 14:59   ` Ping#2: " Jan Beulich
2017-12-04 10:16   ` Ping#3: " Jan Beulich
2017-12-04 16:39     ` Andrew Cooper [this message]
2017-12-06  7:44       ` Jan Beulich
2018-02-28 14:51       ` Ping: " Jan Beulich
2017-09-05 12:26 ` Andrew Cooper
2017-09-05 13:30   ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56e7c11d-1eff-b5bf-73fe-e6bd1f36871f@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.