From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>,
xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v3] x86/HVM: don't #GP/#SS on wrapping virt->linear translations
Date: Tue, 5 Sep 2017 13:26:50 +0100 [thread overview]
Message-ID: <6d0f9c48-bbea-d3cd-8fb4-3f25d0951aa9@citrix.com> (raw)
In-Reply-To: <59637569020000780016A34F@prv-mh.provo.novell.com>
On 10/07/17 11:39, Jan Beulich wrote:
> Real hardware wraps silently in most cases, so we should behave the
> same. Also split real and VM86 mode handling, as the latter really
> ought to have limit checks applied.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
The change looks ok, but this is a subtle adjustment with a lot of
changes in boundary cases.
ISTR you had an XTF test for some of these? I'd feel rather more
confident if we could get that into automation.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-09-05 12:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-10 10:39 [PATCH v3] x86/HVM: don't #GP/#SS on wrapping virt->linear translations Jan Beulich
2017-08-10 7:19 ` Ping: " Jan Beulich
2017-08-25 14:59 ` Ping#2: " Jan Beulich
2017-12-04 10:16 ` Ping#3: " Jan Beulich
2017-12-04 16:39 ` Andrew Cooper
2017-12-06 7:44 ` Jan Beulich
2018-02-28 14:51 ` Ping: " Jan Beulich
2017-09-05 12:26 ` Andrew Cooper [this message]
2017-09-05 13:30 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d0f9c48-bbea-d3cd-8fb4-3f25d0951aa9@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.