From: Dave Hansen <dave.hansen@intel.com> To: Zhangfei Gao <zhangfei.gao@foxmail.com>, Joerg Roedel <joro@8bytes.org>, Fenghua Yu <fenghua.yu@intel.com>, jean-philippe <jean-philippe@linaro.org> Cc: Ravi V Shankar <ravi.v.shankar@intel.com>, Tony Luck <tony.luck@intel.com>, Ashok Raj <ashok.raj@intel.com>, Peter Zijlstra <peterz@infradead.org>, Dave Hansen <dave.hansen@linux.intel.com>, x86 <x86@kernel.org>, linux-kernel <linux-kernel@vger.kernel.org>, iommu <iommu@lists.linux-foundation.org>, Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>, Andy Lutomirski <luto@kernel.org>, Josh Poimboeuf <jpoimboe@redhat.com>, Thomas Gleixner <tglx@linutronix.de> Subject: Re: [PATCH v4 05/11] iommu/sva: Assign a PASID to mm on PASID allocation and free it on mm exit Date: Mon, 11 Apr 2022 07:10:43 -0700 [thread overview] Message-ID: <56ed509d-a7cf-1fde-676c-a28eb204989b@intel.com> (raw) In-Reply-To: <tencent_F6830A1196DB4C6A904D7C691F0D961D1108@qq.com> On 4/11/22 07:00, Zhangfei Gao wrote: > with this patchset, each time after sbin/nginx, ioasid is freed > immediately. lynx test will alloc the same ioasid=1. That doesn't seem right. Isn't 'sbin/nginx' still running when lynx runs? How can they get the same ioasid? This sounds like a refcounting problem, like that the ioasid wasn't properly refcounted as nginx forked into the background. > To verify, hack comment mm_pasid_drop in __mmput will make the issue > disappear. > > log: after sbin/nginx. > [ 96.526730] Call trace: > [ 96.526732] dump_backtrace+0xe4/0xf0 > [ 96.526741] show_stack+0x20/0x70 > [ 96.526744] dump_stack_lvl+0x8c/0xb8 > [ 96.526751] dump_stack+0x18/0x34 > [ 96.526754] ioasid_free+0xdc/0xfc > [ 96.526757] mmput+0x138/0x160 > [ 96.526760] do_exit+0x284/0x9d0 > [ 96.526765] do_group_exit+0x3c/0xa8 > [ 96.526767] __wake_up_parent+0x0/0x38 > [ 96.526770] invoke_syscall+0x4c/0x110 > [ 96.526775] el0_svc_common.constprop.0+0x68/0x128 > [ 96.526778] do_el0_svc+0x2c/0x90 > [ 96.526781] el0_svc+0x30/0x98 > [ 96.526783] el0t_64_sync_handler+0xb0/0xb8 > [ 96.526785] el0t_64_sync+0x18c/0x190 Is there nothing before this call trace? Usually there will be at least some warning text.
WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <dave.hansen@intel.com> To: Zhangfei Gao <zhangfei.gao@foxmail.com>, Joerg Roedel <joro@8bytes.org>, Fenghua Yu <fenghua.yu@intel.com>, jean-philippe <jean-philippe@linaro.org> Cc: Ravi V Shankar <ravi.v.shankar@intel.com>, Tony Luck <tony.luck@intel.com>, Ashok Raj <ashok.raj@intel.com>, Peter Zijlstra <peterz@infradead.org>, x86 <x86@kernel.org>, linux-kernel <linux-kernel@vger.kernel.org>, iommu <iommu@lists.linux-foundation.org>, Ingo Molnar <mingo@redhat.com>, Dave Hansen <dave.hansen@linux.intel.com>, Andy Lutomirski <luto@kernel.org>, Josh Poimboeuf <jpoimboe@redhat.com>, Borislav Petkov <bp@alien8.de>, Thomas Gleixner <tglx@linutronix.de> Subject: Re: [PATCH v4 05/11] iommu/sva: Assign a PASID to mm on PASID allocation and free it on mm exit Date: Mon, 11 Apr 2022 07:10:43 -0700 [thread overview] Message-ID: <56ed509d-a7cf-1fde-676c-a28eb204989b@intel.com> (raw) In-Reply-To: <tencent_F6830A1196DB4C6A904D7C691F0D961D1108@qq.com> On 4/11/22 07:00, Zhangfei Gao wrote: > with this patchset, each time after sbin/nginx, ioasid is freed > immediately. lynx test will alloc the same ioasid=1. That doesn't seem right. Isn't 'sbin/nginx' still running when lynx runs? How can they get the same ioasid? This sounds like a refcounting problem, like that the ioasid wasn't properly refcounted as nginx forked into the background. > To verify, hack comment mm_pasid_drop in __mmput will make the issue > disappear. > > log: after sbin/nginx. > [ 96.526730] Call trace: > [ 96.526732] dump_backtrace+0xe4/0xf0 > [ 96.526741] show_stack+0x20/0x70 > [ 96.526744] dump_stack_lvl+0x8c/0xb8 > [ 96.526751] dump_stack+0x18/0x34 > [ 96.526754] ioasid_free+0xdc/0xfc > [ 96.526757] mmput+0x138/0x160 > [ 96.526760] do_exit+0x284/0x9d0 > [ 96.526765] do_group_exit+0x3c/0xa8 > [ 96.526767] __wake_up_parent+0x0/0x38 > [ 96.526770] invoke_syscall+0x4c/0x110 > [ 96.526775] el0_svc_common.constprop.0+0x68/0x128 > [ 96.526778] do_el0_svc+0x2c/0x90 > [ 96.526781] el0_svc+0x30/0x98 > [ 96.526783] el0t_64_sync_handler+0xb0/0xb8 > [ 96.526785] el0t_64_sync+0x18c/0x190 Is there nothing before this call trace? Usually there will be at least some warning text. _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2022-04-11 14:11 UTC|newest] Thread overview: 214+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-02-07 23:02 [PATCH v4 00/11] Re-enable ENQCMD and PASID MSR Fenghua Yu 2022-02-07 23:02 ` Fenghua Yu 2022-02-07 23:02 ` [PATCH v4 01/11] iommu/sva: Rename CONFIG_IOMMU_SVA_LIB to CONFIG_IOMMU_SVA Fenghua Yu 2022-02-07 23:02 ` Fenghua Yu 2022-02-08 2:39 ` Lu Baolu 2022-02-08 2:39 ` Lu Baolu 2022-02-15 10:54 ` [tip: x86/pasid] " tip-bot2 for Fenghua Yu 2022-02-07 23:02 ` [PATCH v4 02/11] mm: Change CONFIG option for mm->pasid field Fenghua Yu 2022-02-07 23:02 ` Fenghua Yu 2022-02-08 2:40 ` Lu Baolu 2022-02-08 2:40 ` Lu Baolu 2022-02-15 10:54 ` [tip: x86/pasid] " tip-bot2 for Fenghua Yu 2022-02-07 23:02 ` [PATCH v4 03/11] iommu/ioasid: Introduce a helper to check for valid PASIDs Fenghua Yu 2022-02-07 23:02 ` Fenghua Yu 2022-02-08 2:40 ` Lu Baolu 2022-02-08 2:40 ` Lu Baolu 2022-02-15 10:54 ` [tip: x86/pasid] " tip-bot2 for Fenghua Yu 2022-02-07 23:02 ` [PATCH v4 04/11] kernel/fork: Initialize mm's PASID Fenghua Yu 2022-02-07 23:02 ` Fenghua Yu 2022-02-14 17:23 ` Thomas Gleixner 2022-02-14 17:23 ` Thomas Gleixner 2022-02-15 10:54 ` [tip: x86/pasid] " tip-bot2 for Fenghua Yu 2022-02-07 23:02 ` [PATCH v4 05/11] iommu/sva: Assign a PASID to mm on PASID allocation and free it on mm exit Fenghua Yu 2022-02-07 23:02 ` Fenghua Yu 2022-02-08 2:41 ` Lu Baolu 2022-02-08 2:41 ` Lu Baolu 2022-02-08 15:01 ` Fenghua Yu 2022-02-08 15:01 ` Fenghua Yu 2022-02-10 3:16 ` Jacob Pan 2022-02-10 3:16 ` Jacob Pan 2022-02-10 16:27 ` Fenghua Yu 2022-02-10 16:27 ` Fenghua Yu 2022-02-10 17:24 ` Luck, Tony 2022-02-10 17:24 ` Luck, Tony 2022-02-10 18:31 ` Fenghua Yu 2022-02-10 18:31 ` Fenghua Yu 2022-02-10 23:52 ` Fenghua Yu 2022-02-10 23:52 ` Fenghua Yu 2022-02-10 18:49 ` Jacob Pan 2022-02-10 18:49 ` Jacob Pan 2022-02-10 23:15 ` Fenghua Yu 2022-02-10 23:15 ` Fenghua Yu 2022-02-11 22:00 ` Dave Hansen 2022-02-11 22:00 ` Dave Hansen 2022-02-14 17:24 ` Thomas Gleixner 2022-02-14 17:24 ` Thomas Gleixner 2022-02-15 9:55 ` Joerg Roedel 2022-02-15 9:55 ` Joerg Roedel 2022-04-11 14:00 ` Zhangfei Gao 2022-04-11 14:10 ` Dave Hansen [this message] 2022-04-11 14:10 ` Dave Hansen 2022-04-11 14:20 ` zhangfei.gao 2022-04-11 14:20 ` zhangfei.gao 2022-04-11 14:36 ` Dave Hansen 2022-04-11 14:36 ` Dave Hansen 2022-04-11 14:44 ` zhangfei.gao 2022-04-11 14:44 ` zhangfei.gao 2022-04-11 14:52 ` Dave Hansen 2022-04-11 14:52 ` Dave Hansen 2022-04-11 15:13 ` zhangfei.gao 2022-04-11 15:13 ` zhangfei.gao 2022-04-12 7:04 ` zhangfei.gao 2022-04-12 7:04 ` zhangfei.gao 2022-04-12 13:41 ` Fenghua Yu 2022-04-12 13:41 ` Fenghua Yu 2022-04-12 14:39 ` Dave Hansen 2022-04-12 14:39 ` Dave Hansen 2022-04-15 9:59 ` Fenghua Yu 2022-04-15 9:59 ` Fenghua Yu 2022-04-12 15:35 ` zhangfei.gao 2022-04-12 15:35 ` zhangfei.gao 2022-04-14 10:08 ` zhangfei.gao 2022-04-14 10:08 ` zhangfei.gao 2022-04-15 9:51 ` Fenghua Yu 2022-04-15 9:51 ` Fenghua Yu 2022-04-15 10:14 ` zhangfei.gao 2022-04-15 10:14 ` zhangfei.gao 2022-04-15 10:14 ` zhangfei.gao 2022-04-15 10:50 ` Fenghua Yu 2022-04-15 10:50 ` Fenghua Yu 2022-04-15 11:52 ` zhangfei.gao 2022-04-15 11:52 ` zhangfei.gao 2022-04-15 12:37 ` Fenghua Yu 2022-04-15 12:37 ` Fenghua Yu 2022-04-16 1:30 ` zhangfei.gao 2022-04-16 1:30 ` zhangfei.gao 2022-04-15 19:07 ` Fenghua Yu 2022-04-15 19:07 ` Fenghua Yu 2022-04-15 21:00 ` Jacob Pan 2022-04-15 21:00 ` Jacob Pan 2022-04-16 1:43 ` zhangfei.gao 2022-04-16 1:43 ` zhangfei.gao 2022-04-18 18:14 ` Jacob Pan 2022-04-18 18:14 ` Jacob Pan 2022-04-19 1:02 ` zhangfei.gao 2022-04-19 1:02 ` zhangfei.gao 2022-04-18 6:34 ` Tian, Kevin 2022-04-18 6:34 ` Tian, Kevin 2022-04-18 18:11 ` Jacob Pan 2022-04-18 18:11 ` Jacob Pan 2022-04-20 16:45 ` Jean-Philippe Brucker 2022-04-20 16:45 ` Jean-Philippe Brucker 2022-04-21 6:47 ` zhangfei.gao 2022-04-21 6:47 ` zhangfei.gao 2022-04-22 9:03 ` zhangfei.gao 2022-04-22 9:03 ` zhangfei.gao 2022-04-22 10:11 ` Jean-Philippe Brucker 2022-04-22 10:11 ` Jean-Philippe Brucker 2022-04-22 13:15 ` zhangfei.gao 2022-04-22 13:15 ` zhangfei.gao 2022-04-22 15:50 ` Jean-Philippe Brucker 2022-04-22 15:50 ` Jean-Philippe Brucker 2022-04-23 11:13 ` zhangfei.gao 2022-04-23 11:13 ` zhangfei.gao 2022-04-24 2:58 ` Zhangfei Gao 2022-04-24 2:58 ` Zhangfei Gao 2022-04-24 9:52 ` Zhangfei Gao 2022-04-24 9:52 ` Zhangfei Gao 2022-04-25 13:53 ` Jean-Philippe Brucker 2022-04-25 13:53 ` Jean-Philippe Brucker 2022-04-25 14:18 ` Dave Hansen 2022-04-25 14:18 ` Dave Hansen 2022-04-25 14:26 ` Jean-Philippe Brucker 2022-04-25 14:26 ` Jean-Philippe Brucker 2022-04-25 15:34 ` Jacob Pan 2022-04-25 15:34 ` Jacob Pan 2022-04-25 16:13 ` Jean-Philippe Brucker 2022-04-25 16:13 ` Jean-Philippe Brucker 2022-04-25 22:32 ` Jacob Pan 2022-04-25 22:32 ` Jacob Pan 2022-04-26 4:20 ` Fenghua Yu 2022-04-26 4:20 ` Fenghua Yu 2022-04-26 5:04 ` Zhangfei Gao 2022-04-26 5:04 ` Zhangfei Gao 2022-04-28 0:54 ` Fenghua Yu 2022-04-28 0:54 ` Fenghua Yu 2022-04-28 8:43 ` Jean-Philippe Brucker 2022-04-28 8:43 ` Jean-Philippe Brucker 2022-04-28 15:09 ` Dave Hansen 2022-04-28 15:09 ` Dave Hansen 2022-04-28 15:28 ` Fenghua Yu 2022-04-28 15:28 ` Fenghua Yu 2022-04-28 15:42 ` Dave Hansen 2022-04-28 15:42 ` Dave Hansen 2022-04-28 16:01 ` Jean-Philippe Brucker 2022-04-28 16:01 ` Jean-Philippe Brucker 2022-04-28 16:35 ` Dave Hansen 2022-04-28 16:35 ` Dave Hansen 2022-04-26 4:28 ` Zhangfei Gao 2022-04-26 4:28 ` Zhangfei Gao 2022-04-26 4:36 ` Fenghua Yu 2022-04-26 4:36 ` Fenghua Yu 2022-04-26 5:19 ` Zhangfei Gao 2022-04-26 5:19 ` Zhangfei Gao 2022-04-25 15:55 ` Dave Hansen 2022-04-25 15:55 ` Dave Hansen 2022-04-25 16:40 ` Jean-Philippe Brucker 2022-04-25 16:40 ` Jean-Philippe Brucker 2022-04-26 15:27 ` Dave Hansen 2022-04-26 15:27 ` Dave Hansen 2022-04-26 16:48 ` Jean-Philippe Brucker 2022-04-26 16:48 ` Jean-Philippe Brucker 2022-04-26 23:31 ` Dave Hansen 2022-04-26 23:31 ` Dave Hansen 2022-04-28 8:39 ` Jean-Philippe Brucker 2022-04-28 8:39 ` Jean-Philippe Brucker 2022-04-29 7:53 ` Baolu Lu 2022-04-29 7:53 ` Baolu Lu 2022-04-29 13:51 ` Fenghua Yu 2022-04-29 13:51 ` Fenghua Yu 2022-04-29 14:34 ` Jean-Philippe Brucker 2022-04-29 14:34 ` Jean-Philippe Brucker 2022-04-29 22:19 ` Fenghua Yu 2022-04-29 22:19 ` Fenghua Yu 2022-04-30 7:33 ` Baolu Lu 2022-04-30 7:33 ` Baolu Lu 2022-05-03 7:49 ` Jean-Philippe Brucker 2022-05-03 7:49 ` Jean-Philippe Brucker 2022-05-06 5:36 ` Baolu Lu 2022-05-06 5:36 ` Baolu Lu 2022-04-12 14:36 ` Dave Hansen 2022-04-12 14:36 ` Dave Hansen 2022-04-12 15:10 ` Jean-Philippe Brucker 2022-04-12 15:10 ` Jean-Philippe Brucker 2022-04-12 15:35 ` Dave Hansen 2022-04-12 15:35 ` Dave Hansen 2022-04-13 11:14 ` Lu Baolu 2022-04-13 11:14 ` Lu Baolu 2022-04-25 2:57 ` zhangfei.gao 2022-04-25 2:57 ` zhangfei.gao 2022-02-15 10:54 ` [tip: x86/pasid] " tip-bot2 for Fenghua Yu 2022-02-07 23:02 ` [PATCH v4 06/11] x86/fpu: Clear PASID when copying fpstate Fenghua Yu 2022-02-07 23:02 ` Fenghua Yu 2022-02-15 10:54 ` [tip: x86/pasid] " tip-bot2 for Fenghua Yu 2022-02-07 23:02 ` [PATCH v4 07/11] sched: Define and initialize a flag to identify valid PASID in the task Fenghua Yu 2022-02-07 23:02 ` Fenghua Yu 2022-02-15 10:54 ` [tip: x86/pasid] " tip-bot2 for Peter Zijlstra 2022-02-07 23:02 ` [PATCH v4 08/11] x86/traps: Demand-populate PASID MSR via #GP Fenghua Yu 2022-02-07 23:02 ` Fenghua Yu 2022-02-15 10:54 ` [tip: x86/pasid] " tip-bot2 for Fenghua Yu 2022-02-07 23:02 ` [PATCH v4 09/11] x86/cpufeatures: Re-enable ENQCMD Fenghua Yu 2022-02-07 23:02 ` Fenghua Yu 2022-02-15 10:54 ` [tip: x86/pasid] " tip-bot2 for Fenghua Yu 2022-02-07 23:02 ` [PATCH v4 10/11] tools/objtool: Check for use of the ENQCMD instruction in the kernel Fenghua Yu 2022-02-07 23:02 ` Fenghua Yu 2022-02-15 10:54 ` [tip: x86/pasid] " tip-bot2 for Fenghua Yu 2022-03-09 7:55 ` [tip: x86/core] " tip-bot2 for Fenghua Yu 2022-03-15 10:44 ` tip-bot2 for Fenghua Yu 2022-02-07 23:02 ` [PATCH v4 11/11] docs: x86: Change documentation for SVA (Shared Virtual Addressing) Fenghua Yu 2022-02-07 23:02 ` Fenghua Yu 2022-02-14 17:25 ` Thomas Gleixner 2022-02-14 17:25 ` Thomas Gleixner 2022-02-15 10:54 ` [tip: x86/pasid] Documentation/x86: Update " tip-bot2 for Fenghua Yu 2022-02-11 20:04 ` [PATCH v4 00/11] Re-enable ENQCMD and PASID MSR Fenghua Yu 2022-02-11 20:04 ` Fenghua Yu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=56ed509d-a7cf-1fde-676c-a28eb204989b@intel.com \ --to=dave.hansen@intel.com \ --cc=ashok.raj@intel.com \ --cc=bp@alien8.de \ --cc=dave.hansen@linux.intel.com \ --cc=fenghua.yu@intel.com \ --cc=iommu@lists.linux-foundation.org \ --cc=jean-philippe@linaro.org \ --cc=joro@8bytes.org \ --cc=jpoimboe@redhat.com \ --cc=linux-kernel@vger.kernel.org \ --cc=luto@kernel.org \ --cc=mingo@redhat.com \ --cc=peterz@infradead.org \ --cc=ravi.v.shankar@intel.com \ --cc=tglx@linutronix.de \ --cc=tony.luck@intel.com \ --cc=x86@kernel.org \ --cc=zhangfei.gao@foxmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.