All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Riesch <michael.riesch@wolfvision.net>
To: Peter Geis <pgwipeout@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Heiko Stuebner <heiko@sntech.de>,
	"open list:ARM/Rockchip SoC..."
	<linux-rockchip@lists.infradead.org>,
	Johan Jonker <jbx6244@gmail.com>,
	devicetree <devicetree@vger.kernel.org>,
	arm-mail-list <linux-arm-kernel@lists.infradead.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 5/7] arm64: dts: rockchip: add rk356x dwc3 usb3 nodes
Date: Mon, 28 Feb 2022 14:37:51 +0100	[thread overview]
Message-ID: <56f8b74d-d9a1-7c6b-67f2-29586956670d@wolfvision.net> (raw)
In-Reply-To: <CAMdYzYoEEY6-kGVDeWj9AoA98BL5hxnc_4CnUPiuStUnSrFXLA@mail.gmail.com>

Hi Peter,

On 2/28/22 1:57 PM, Peter Geis wrote:
> [...]
>>> +
>>> +&usb_host0_xhci {
>>> +     phys = <&usb2phy0_otg>;
>>> +     phy-names = "usb2-phy";
>>> +     extcon = <&usb2phy0>;
>>
>> I wonder what the correct place for this extcon property is. You defined
>> it on SoC (RK3566) level, in my patch for the RK3568 EVB1 it is added on
>> board level. Is this common to all RK356x variants?
> 
> Yes, the usb2phy is always available as an extcon unless you make a
> device that doesn't have usb2 capability.
> In that case you'd have to override the device anyways.
> If we want to turn on default role otg here, we'd need this defined
> here as well or things break.

OK, so it seems to me that the extcon could or should enter the
rk356x.dtsi (and can be removed from the rk3566.dtsi and the
rk3568-evb1-v10.dts in this series). Is that correct?

Best regards,
Michael

> [...]

WARNING: multiple messages have this Message-ID (diff)
From: Michael Riesch <michael.riesch@wolfvision.net>
To: Peter Geis <pgwipeout@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Heiko Stuebner <heiko@sntech.de>,
	"open list:ARM/Rockchip SoC..."
	<linux-rockchip@lists.infradead.org>,
	Johan Jonker <jbx6244@gmail.com>,
	devicetree <devicetree@vger.kernel.org>,
	arm-mail-list <linux-arm-kernel@lists.infradead.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 5/7] arm64: dts: rockchip: add rk356x dwc3 usb3 nodes
Date: Mon, 28 Feb 2022 14:37:51 +0100	[thread overview]
Message-ID: <56f8b74d-d9a1-7c6b-67f2-29586956670d@wolfvision.net> (raw)
In-Reply-To: <CAMdYzYoEEY6-kGVDeWj9AoA98BL5hxnc_4CnUPiuStUnSrFXLA@mail.gmail.com>

Hi Peter,

On 2/28/22 1:57 PM, Peter Geis wrote:
> [...]
>>> +
>>> +&usb_host0_xhci {
>>> +     phys = <&usb2phy0_otg>;
>>> +     phy-names = "usb2-phy";
>>> +     extcon = <&usb2phy0>;
>>
>> I wonder what the correct place for this extcon property is. You defined
>> it on SoC (RK3566) level, in my patch for the RK3568 EVB1 it is added on
>> board level. Is this common to all RK356x variants?
> 
> Yes, the usb2phy is always available as an extcon unless you make a
> device that doesn't have usb2 capability.
> In that case you'd have to override the device anyways.
> If we want to turn on default role otg here, we'd need this defined
> here as well or things break.

OK, so it seems to me that the extcon could or should enter the
rk356x.dtsi (and can be removed from the rk3566.dtsi and the
rk3568-evb1-v10.dts in this series). Is that correct?

Best regards,
Michael

> [...]

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

WARNING: multiple messages have this Message-ID (diff)
From: Michael Riesch <michael.riesch@wolfvision.net>
To: Peter Geis <pgwipeout@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Heiko Stuebner <heiko@sntech.de>,
	"open list:ARM/Rockchip SoC..."
	<linux-rockchip@lists.infradead.org>,
	Johan Jonker <jbx6244@gmail.com>,
	devicetree <devicetree@vger.kernel.org>,
	arm-mail-list <linux-arm-kernel@lists.infradead.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 5/7] arm64: dts: rockchip: add rk356x dwc3 usb3 nodes
Date: Mon, 28 Feb 2022 14:37:51 +0100	[thread overview]
Message-ID: <56f8b74d-d9a1-7c6b-67f2-29586956670d@wolfvision.net> (raw)
In-Reply-To: <CAMdYzYoEEY6-kGVDeWj9AoA98BL5hxnc_4CnUPiuStUnSrFXLA@mail.gmail.com>

Hi Peter,

On 2/28/22 1:57 PM, Peter Geis wrote:
> [...]
>>> +
>>> +&usb_host0_xhci {
>>> +     phys = <&usb2phy0_otg>;
>>> +     phy-names = "usb2-phy";
>>> +     extcon = <&usb2phy0>;
>>
>> I wonder what the correct place for this extcon property is. You defined
>> it on SoC (RK3566) level, in my patch for the RK3568 EVB1 it is added on
>> board level. Is this common to all RK356x variants?
> 
> Yes, the usb2phy is always available as an extcon unless you make a
> device that doesn't have usb2 capability.
> In that case you'd have to override the device anyways.
> If we want to turn on default role otg here, we'd need this defined
> here as well or things break.

OK, so it seems to me that the extcon could or should enter the
rk356x.dtsi (and can be removed from the rk3566.dtsi and the
rk3568-evb1-v10.dts in this series). Is that correct?

Best regards,
Michael

> [...]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-02-28 13:38 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-27 15:30 [PATCH v3 0/7] enable usb support on rk356x Peter Geis
2022-02-27 15:30 ` Peter Geis
2022-02-27 15:30 ` Peter Geis
2022-02-27 15:30 ` [PATCH v3 1/7] dt-bindings: soc: grf: fix rk3568 usb definitions Peter Geis
2022-02-27 15:30   ` Peter Geis
2022-02-27 15:30   ` Peter Geis
2022-02-27 15:30 ` [PATCH v3 2/7] dt-bindings: soc: grf: add rk3566-pipe-grf compatible Peter Geis
2022-02-27 15:30   ` Peter Geis
2022-02-27 15:30   ` Peter Geis
2022-02-27 15:30 ` [PATCH v3 3/7] soc: rockchip: set dwc3 clock for rk3566 Peter Geis
2022-02-27 15:30   ` Peter Geis
2022-02-27 15:30   ` Peter Geis
2022-02-27 15:30 ` [PATCH v3 4/7] usb: dwc3: core: do not use 3.0 clock when operating in 2.0 mode Peter Geis
2022-02-27 15:30   ` Peter Geis
2022-02-27 15:30 ` [PATCH v3 5/7] arm64: dts: rockchip: add rk356x dwc3 usb3 nodes Peter Geis
2022-02-27 15:30   ` Peter Geis
2022-02-27 15:30   ` Peter Geis
2022-02-27 17:50   ` Johan Jonker
2022-02-27 17:50     ` Johan Jonker
2022-02-27 17:50     ` Johan Jonker
2022-02-27 22:44     ` Peter Geis
2022-02-27 22:44       ` Peter Geis
2022-02-27 22:44       ` Peter Geis
2022-02-28  9:10       ` Johan Jonker
2022-02-28  9:10         ` Johan Jonker
2022-02-28  9:10         ` Johan Jonker
2022-02-28 13:02         ` Peter Geis
2022-02-28 13:02           ` Peter Geis
2022-02-28 13:02           ` Peter Geis
2022-02-28 13:16           ` Johan Jonker
2022-02-28 13:16             ` Johan Jonker
2022-02-28 13:16             ` Johan Jonker
2022-02-28  7:23   ` Michael Riesch
2022-02-28  7:23     ` Michael Riesch
2022-02-28  7:23     ` Michael Riesch
2022-02-28 12:57     ` Peter Geis
2022-02-28 12:57       ` Peter Geis
2022-02-28 12:57       ` Peter Geis
2022-02-28 13:37       ` Michael Riesch [this message]
2022-02-28 13:37         ` Michael Riesch
2022-02-28 13:37         ` Michael Riesch
2022-02-28 14:10         ` Peter Geis
2022-02-28 14:10           ` Peter Geis
2022-02-28 14:10           ` Peter Geis
2022-03-01 13:44           ` Michael Riesch
2022-03-01 13:44             ` Michael Riesch
2022-03-01 13:44             ` Michael Riesch
2022-02-27 15:30 ` [PATCH v3 6/7] arm64: dts: rockchip: enable dwc3 on quartz64-a Peter Geis
2022-02-27 15:30   ` Peter Geis
2022-02-27 15:30   ` Peter Geis
2022-02-27 15:30 ` [PATCH v3 7/7] arm64: dts: rockchip: add usb3 support to rk3568-evb1-v10 Peter Geis
2022-02-27 15:30   ` Peter Geis
2022-02-27 15:30   ` Peter Geis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56f8b74d-d9a1-7c6b-67f2-29586956670d@wolfvision.net \
    --to=michael.riesch@wolfvision.net \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=jbx6244@gmail.com \
    --cc=krzysztof.kozlowski@canonical.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=pgwipeout@gmail.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.