From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Lino Sanfilippo <LinoSanfilippo@gmx.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
vz@mleia.com, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org,
linux-serial <linux-serial@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
lukas@wunner.de, p.rosenberger@kunbus.com,
Lino Sanfilippo <l.sanfilippo@kunbus.com>
Subject: Re: [PATCH 8/8] serial: 8250: lpc18xx: Remove redundant sanity check for RS485 flags
Date: Sat, 25 Jun 2022 13:18:43 +0300 (EEST) [thread overview]
Message-ID: <56f9df76-5514-2aa8-54cc-f0589023fe2@linux.intel.com> (raw)
In-Reply-To: <20220622154659.8710-9-LinoSanfilippo@gmx.de>
[-- Attachment #1: Type: text/plain, Size: 472 bytes --]
On Wed, 22 Jun 2022, Lino Sanfilippo wrote:
> From: Lino Sanfilippo <l.sanfilippo@kunbus.com>
>
> Before the drivers rs485_config() function is called the serial core
> already ensures that only one of both options RTS on send or RTS after send
> is set. So remove the concerning sanity check in the driver function to
> avoid redundancy.
>
> Signed-off-by: Lino Sanfilippo <l.sanfilippo@kunbus.com>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
--
i.
WARNING: multiple messages have this Message-ID (diff)
From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Lino Sanfilippo <LinoSanfilippo@gmx.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
vz@mleia.com, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org,
linux-serial <linux-serial@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
lukas@wunner.de, p.rosenberger@kunbus.com,
Lino Sanfilippo <l.sanfilippo@kunbus.com>
Subject: Re: [PATCH 8/8] serial: 8250: lpc18xx: Remove redundant sanity check for RS485 flags
Date: Sat, 25 Jun 2022 13:18:43 +0300 (EEST) [thread overview]
Message-ID: <56f9df76-5514-2aa8-54cc-f0589023fe2@linux.intel.com> (raw)
In-Reply-To: <20220622154659.8710-9-LinoSanfilippo@gmx.de>
[-- Attachment #1: Type: text/plain, Size: 472 bytes --]
On Wed, 22 Jun 2022, Lino Sanfilippo wrote:
> From: Lino Sanfilippo <l.sanfilippo@kunbus.com>
>
> Before the drivers rs485_config() function is called the serial core
> already ensures that only one of both options RTS on send or RTS after send
> is set. So remove the concerning sanity check in the driver function to
> avoid redundancy.
>
> Signed-off-by: Lino Sanfilippo <l.sanfilippo@kunbus.com>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
--
i.
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-06-25 10:18 UTC|newest]
Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-22 15:46 [PATCH 0/8] Fixes and cleanup for RS485 Lino Sanfilippo
2022-06-22 15:46 ` Lino Sanfilippo
2022-06-22 15:46 ` [PATCH 1/8] serial: core: only get RS485 termination gpio if supported Lino Sanfilippo
2022-06-22 15:46 ` Lino Sanfilippo
2022-06-22 17:04 ` Andy Shevchenko
2022-06-22 17:04 ` Andy Shevchenko
2022-06-23 1:59 ` Lino Sanfilippo
2022-06-23 1:59 ` Lino Sanfilippo
2022-06-23 9:45 ` Andy Shevchenko
2022-06-23 9:45 ` Andy Shevchenko
2022-06-23 16:08 ` Lino Sanfilippo
2022-06-23 16:08 ` Lino Sanfilippo
2022-06-23 16:32 ` Andy Shevchenko
2022-06-23 16:32 ` Andy Shevchenko
2022-06-23 20:19 ` Lino Sanfilippo
2022-06-23 20:19 ` Lino Sanfilippo
2022-06-25 19:49 ` Lukas Wunner
2022-06-27 9:05 ` Ilpo Järvinen
2022-06-27 9:05 ` Ilpo Järvinen
2022-07-02 16:50 ` Lino Sanfilippo
2022-07-02 16:50 ` Lino Sanfilippo
2022-06-22 15:46 ` [PATCH 2/8] serial: core, 8250: set RS485 termination gpio in serial core Lino Sanfilippo
2022-06-22 15:46 ` Lino Sanfilippo
2022-06-22 17:06 ` Andy Shevchenko
2022-06-22 17:06 ` Andy Shevchenko
2022-06-23 2:03 ` Lino Sanfilippo
2022-06-23 2:03 ` Lino Sanfilippo
2022-06-25 10:40 ` Ilpo Järvinen
2022-06-25 10:40 ` Ilpo Järvinen
2022-06-26 15:41 ` Lino Sanfilippo
2022-06-26 15:41 ` Lino Sanfilippo
2022-06-25 19:58 ` Lukas Wunner
2022-06-26 13:36 ` Lino Sanfilippo
2022-06-26 13:36 ` Lino Sanfilippo
2022-06-28 8:31 ` Ilpo Järvinen
2022-06-28 8:31 ` Ilpo Järvinen
2022-06-22 15:46 ` [PATCH 3/8] serial: core: move sanitizing of RS485 delays into own function Lino Sanfilippo
2022-06-22 15:46 ` Lino Sanfilippo
2022-06-23 16:25 ` Andy Shevchenko
2022-06-23 16:25 ` Andy Shevchenko
2022-06-23 20:17 ` Lino Sanfilippo
2022-06-23 20:17 ` Lino Sanfilippo
2022-06-25 9:37 ` Ilpo Järvinen
2022-06-25 9:37 ` Ilpo Järvinen
2022-06-22 15:46 ` [PATCH 4/8] serial: core: sanitize RS485 delays read from device tree Lino Sanfilippo
2022-06-22 15:46 ` Lino Sanfilippo
2022-06-25 10:05 ` Ilpo Järvinen
2022-06-25 10:05 ` Ilpo Järvinen
2022-06-26 14:25 ` Lino Sanfilippo
2022-06-26 14:25 ` Lino Sanfilippo
2022-06-22 15:46 ` [PATCH 5/8] dt_bindings: rs485: Correct delay values Lino Sanfilippo
2022-06-22 15:46 ` Lino Sanfilippo
2022-06-23 16:29 ` Andy Shevchenko
2022-06-23 16:29 ` Andy Shevchenko
2022-06-23 20:17 ` Lino Sanfilippo
2022-06-23 20:17 ` Lino Sanfilippo
2022-06-25 9:54 ` Ilpo Järvinen
2022-06-25 9:54 ` Ilpo Järvinen
2022-06-27 9:23 ` Ilpo Järvinen
2022-06-27 9:23 ` Ilpo Järvinen
2022-06-28 10:03 ` Andy Shevchenko
2022-06-28 10:03 ` Andy Shevchenko
2022-06-29 23:50 ` Lino Sanfilippo
2022-06-29 23:50 ` Lino Sanfilippo
2022-06-22 15:46 ` [PATCH 6/8] serial: 8250_dwlib: remove redundant sanity check for RS485 flags Lino Sanfilippo
2022-06-22 15:46 ` Lino Sanfilippo
2022-06-25 10:21 ` Ilpo Järvinen
2022-06-25 10:21 ` Ilpo Järvinen
2022-06-22 15:46 ` [PATCH 7/8] serial: ar933x: Remove redundant assignment in rs485_config Lino Sanfilippo
2022-06-22 15:46 ` Lino Sanfilippo
2022-06-25 10:14 ` Ilpo Järvinen
2022-06-25 10:14 ` Ilpo Järvinen
2022-06-26 14:09 ` Lino Sanfilippo
2022-06-26 14:09 ` Lino Sanfilippo
2022-06-27 8:14 ` Ilpo Järvinen
2022-06-27 8:14 ` Ilpo Järvinen
2022-06-30 0:33 ` Lino Sanfilippo
2022-06-30 0:33 ` Lino Sanfilippo
2022-06-22 15:46 ` [PATCH 8/8] serial: 8250: lpc18xx: Remove redundant sanity check for RS485 flags Lino Sanfilippo
2022-06-22 15:46 ` Lino Sanfilippo
2022-06-25 10:18 ` Ilpo Järvinen [this message]
2022-06-25 10:18 ` Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56f9df76-5514-2aa8-54cc-f0589023fe2@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=LinoSanfilippo@gmx.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=l.sanfilippo@kunbus.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=p.rosenberger@kunbus.com \
--cc=robh+dt@kernel.org \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.