* af_packet: tone down the Tx-ring unsupported spew.
@ 2016-04-04 19:11 Dave Jones
2016-04-04 19:24 ` Daniel Borkmann
2016-04-06 20:05 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Dave Jones @ 2016-04-04 19:11 UTC (permalink / raw)
To: netdev
Trinity and other fuzzers can hit this WARN on far too easily,
resulting in a tainted kernel that hinders automated fuzzing.
Replace it with a rate-limited printk.
Signed-off-by: Dave Jones <davej@codemonkey.org.uk>
diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c
index 1ecfa710ca98..f12c17f355d9 100644
--- a/net/packet/af_packet.c
+++ b/net/packet/af_packet.c
@@ -4151,7 +4151,7 @@ static int packet_set_ring(struct sock *sk, union tpacket_req_u *req_u,
/* Opening a Tx-ring is NOT supported in TPACKET_V3 */
if (!closing && tx_ring && (po->tp_version > TPACKET_V2)) {
- WARN(1, "Tx-ring is not supported.\n");
+ net_warn_ratelimited("Tx-ring is not supported.\n");
goto out;
}
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: af_packet: tone down the Tx-ring unsupported spew.
2016-04-04 19:11 af_packet: tone down the Tx-ring unsupported spew Dave Jones
@ 2016-04-04 19:24 ` Daniel Borkmann
2016-04-06 20:05 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Daniel Borkmann @ 2016-04-04 19:24 UTC (permalink / raw)
To: Dave Jones; +Cc: netdev
On 04/04/2016 09:11 PM, Dave Jones wrote:
> Trinity and other fuzzers can hit this WARN on far too easily,
> resulting in a tainted kernel that hinders automated fuzzing.
>
> Replace it with a rate-limited printk.
>
> Signed-off-by: Dave Jones <davej@codemonkey.org.uk>
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: af_packet: tone down the Tx-ring unsupported spew.
2016-04-04 19:11 af_packet: tone down the Tx-ring unsupported spew Dave Jones
2016-04-04 19:24 ` Daniel Borkmann
@ 2016-04-06 20:05 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2016-04-06 20:05 UTC (permalink / raw)
To: davej; +Cc: netdev
From: Dave Jones <davej@codemonkey.org.uk>
Date: Mon, 4 Apr 2016 15:11:50 -0400
> Trinity and other fuzzers can hit this WARN on far too easily,
> resulting in a tainted kernel that hinders automated fuzzing.
>
> Replace it with a rate-limited printk.
>
> Signed-off-by: Dave Jones <davej@codemonkey.org.uk>
Looks good, thanks Dave.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-04-06 20:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-04 19:11 af_packet: tone down the Tx-ring unsupported spew Dave Jones
2016-04-04 19:24 ` Daniel Borkmann
2016-04-06 20:05 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.