* [Intel-wired-lan] [PATCH] ixgbe: Fix flag issue in generic CSUM patch
@ 2016-04-04 23:03 Alexander Duyck
2016-04-04 23:25 ` Samudrala, Sridhar
0 siblings, 1 reply; 2+ messages in thread
From: Alexander Duyck @ 2016-04-04 23:03 UTC (permalink / raw)
To: intel-wired-lan
This patch fixes a minor flags issue where we had lost NETIF_F_HW_TC and
were setting NETIF_F_SCTP_CRC in two different spots when we only wanted to
enable it in the if statement.
Signed-off-by: Alexander Duyck <aduyck@mirantis.com>
---
This should fix both the one issue I saw and the NETIF_F_HW_TC issue that
Sridar saw with the generic CSUM patch.
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
index 51ce426ce510..30903c5517af 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
@@ -9214,7 +9214,6 @@ skip_sriov:
NETIF_F_RXHASH |
NETIF_F_RXCSUM |
NETIF_F_HW_CSUM |
- NETIF_F_SCTP_CRC |
NETIF_F_HW_VLAN_CTAG_TX |
NETIF_F_HW_VLAN_CTAG_RX |
NETIF_F_HW_VLAN_CTAG_FILTER;
@@ -9228,7 +9227,8 @@ skip_sriov:
NETIF_F_HW_L2FW_DOFFLOAD;
if (hw->mac.type >= ixgbe_mac_82599EB)
- netdev->hw_features |= NETIF_F_NTUPLE;
+ netdev->hw_features |= NETIF_F_NTUPLE |
+ NETIF_F_HW_TC;
netdev->vlan_features |= NETIF_F_SG |
NETIF_F_TSO |
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Intel-wired-lan] [PATCH] ixgbe: Fix flag issue in generic CSUM patch
2016-04-04 23:03 [Intel-wired-lan] [PATCH] ixgbe: Fix flag issue in generic CSUM patch Alexander Duyck
@ 2016-04-04 23:25 ` Samudrala, Sridhar
0 siblings, 0 replies; 2+ messages in thread
From: Samudrala, Sridhar @ 2016-04-04 23:25 UTC (permalink / raw)
To: intel-wired-lan
On 4/4/2016 4:03 PM, Alexander Duyck wrote:
> This patch fixes a minor flags issue where we had lost NETIF_F_HW_TC and
> were setting NETIF_F_SCTP_CRC in two different spots when we only wanted to
> enable it in the if statement.
>
> Signed-off-by: Alexander Duyck <aduyck@mirantis.com>
Acked-by: Sridhar Samudrala <sridhar.samudrala@intel.com>
> ---
>
> This should fix both the one issue I saw and the NETIF_F_HW_TC issue that
> Sridar saw with the generic CSUM patch.
>
> drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
> index 51ce426ce510..30903c5517af 100644
> --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
> +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
> @@ -9214,7 +9214,6 @@ skip_sriov:
> NETIF_F_RXHASH |
> NETIF_F_RXCSUM |
> NETIF_F_HW_CSUM |
> - NETIF_F_SCTP_CRC |
> NETIF_F_HW_VLAN_CTAG_TX |
> NETIF_F_HW_VLAN_CTAG_RX |
> NETIF_F_HW_VLAN_CTAG_FILTER;
> @@ -9228,7 +9227,8 @@ skip_sriov:
> NETIF_F_HW_L2FW_DOFFLOAD;
>
> if (hw->mac.type >= ixgbe_mac_82599EB)
> - netdev->hw_features |= NETIF_F_NTUPLE;
> + netdev->hw_features |= NETIF_F_NTUPLE |
> + NETIF_F_HW_TC;
>
> netdev->vlan_features |= NETIF_F_SG |
> NETIF_F_TSO |
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-04-04 23:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-04 23:03 [Intel-wired-lan] [PATCH] ixgbe: Fix flag issue in generic CSUM patch Alexander Duyck
2016-04-04 23:25 ` Samudrala, Sridhar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.