From: Nikolay Aleksandrov via Bridge <bridge@lists.linux-foundation.org>
To: Xin Long <lucien.xin@gmail.com>,
network dev <netdev@vger.kernel.org>,
bridge@lists.linux-foundation.org
Cc: davem@davemloft.net
Subject: Re: [PATCHv3 net-next 2/6] bridge: simplify the forward_delay_store by calling store_bridge_parm
Date: Sat, 9 Apr 2016 14:31:00 +0200 [thread overview]
Message-ID: <5708F604.6080201@cumulusnetworks.com> (raw)
In-Reply-To: <6197a35a2eb6df2caf90edcbf1b49da12077f659.1460131308.git.lucien.xin@gmail.com>
On 04/08/2016 06:03 PM, Xin Long wrote:
> There are some repetitive codes in forward_delay_store, we can remove
> them by calling store_bridge_parm.
>
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
> ---
> net/bridge/br_sysfs_br.c | 27 ++++++++++-----------------
> 1 file changed, 10 insertions(+), 17 deletions(-)
>
Reviewed-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
WARNING: multiple messages have this Message-ID (diff)
From: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
To: Xin Long <lucien.xin@gmail.com>,
network dev <netdev@vger.kernel.org>,
bridge@lists.linux-foundation.org
Cc: davem@davemloft.net
Subject: Re: [Bridge] [PATCHv3 net-next 2/6] bridge: simplify the forward_delay_store by calling store_bridge_parm
Date: Sat, 9 Apr 2016 14:31:00 +0200 [thread overview]
Message-ID: <5708F604.6080201@cumulusnetworks.com> (raw)
In-Reply-To: <6197a35a2eb6df2caf90edcbf1b49da12077f659.1460131308.git.lucien.xin@gmail.com>
On 04/08/2016 06:03 PM, Xin Long wrote:
> There are some repetitive codes in forward_delay_store, we can remove
> them by calling store_bridge_parm.
>
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
> ---
> net/bridge/br_sysfs_br.c | 27 ++++++++++-----------------
> 1 file changed, 10 insertions(+), 17 deletions(-)
>
Reviewed-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
next prev parent reply other threads:[~2016-04-09 12:31 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-08 16:03 [PATCHv3 net-next 0/6] bridge: support sending rntl info when we set attributes through sysfs/ioctl Xin Long
2016-04-08 16:03 ` [Bridge] " Xin Long
2016-04-08 16:03 ` [PATCHv3 net-next 1/6] bridge: simplify the flush_store by calling store_bridge_parm Xin Long
2016-04-08 16:03 ` [Bridge] " Xin Long
2016-04-08 16:03 ` [PATCHv3 net-next 2/6] bridge: simplify the forward_delay_store " Xin Long
2016-04-08 16:03 ` [Bridge] " Xin Long
2016-04-08 16:03 ` [PATCHv3 net-next 3/6] bridge: simplify the stp_state_store " Xin Long
2016-04-08 16:03 ` [Bridge] " Xin Long
2016-04-08 16:03 ` [PATCHv3 net-next 4/6] bridge: a netlink notification should be sent when those attributes are changed by br_sysfs_br Xin Long
2016-04-08 16:03 ` [Bridge] " Xin Long
2016-04-08 16:03 ` [PATCHv3 net-next 5/6] bridge: a netlink notification should be sent when those attributes are changed by br_sysfs_if Xin Long
2016-04-08 16:03 ` [Bridge] " Xin Long
2016-04-08 16:03 ` [PATCHv3 net-next 6/6] bridge: a netlink notification should be sent when those attributes are changed by ioctl Xin Long
2016-04-08 16:03 ` [Bridge] " Xin Long
2016-04-09 12:49 ` Nikolay Aleksandrov via Bridge
2016-04-09 12:49 ` [Bridge] " Nikolay Aleksandrov
2016-04-09 12:45 ` [PATCHv3 net-next 5/6] bridge: a netlink notification should be sent when those attributes are changed by br_sysfs_if Nikolay Aleksandrov via Bridge
2016-04-09 12:45 ` [Bridge] " Nikolay Aleksandrov
2016-04-09 12:41 ` [PATCHv3 net-next 4/6] bridge: a netlink notification should be sent when those attributes are changed by br_sysfs_br Nikolay Aleksandrov via Bridge
2016-04-09 12:41 ` [Bridge] " Nikolay Aleksandrov
2016-04-09 12:33 ` [PATCHv3 net-next 3/6] bridge: simplify the stp_state_store by calling store_bridge_parm Nikolay Aleksandrov via Bridge
2016-04-09 12:33 ` [Bridge] " Nikolay Aleksandrov
2016-04-09 12:31 ` Nikolay Aleksandrov via Bridge [this message]
2016-04-09 12:31 ` [Bridge] [PATCHv3 net-next 2/6] bridge: simplify the forward_delay_store " Nikolay Aleksandrov
2016-04-09 12:27 ` [PATCHv3 net-next 1/6] bridge: simplify the flush_store " Nikolay Aleksandrov via Bridge
2016-04-09 12:27 ` [Bridge] " Nikolay Aleksandrov
2016-04-09 12:55 ` [PATCHv3 net-next 0/6] bridge: support sending rntl info when we set attributes through sysfs/ioctl Nikolay Aleksandrov via Bridge
2016-04-09 12:55 ` [Bridge] " Nikolay Aleksandrov
2016-04-14 2:42 ` David Miller
2016-04-14 2:42 ` [Bridge] " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5708F604.6080201@cumulusnetworks.com \
--to=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=lucien.xin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.