* [Intel-gfx] [RFC] drm/i915/rc6: Access RC6 regs with forcewake
@ 2022-04-22 13:37 Badal Nilawar
2022-04-22 15:34 ` Matt Roper
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Badal Nilawar @ 2022-04-22 13:37 UTC (permalink / raw)
To: intel-gfx; +Cc: chris
To access RC6 related MMIO regs use intel_uncore_write(), which grabs
forcewake if reg requires a forcewake.
Signed-off-by: Badal Nilawar <badal.nilawar@intel.com>
---
drivers/gpu/drm/i915/gt/intel_rc6.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_rc6.c b/drivers/gpu/drm/i915/gt/intel_rc6.c
index b4770690e794..9edaad3f19b5 100644
--- a/drivers/gpu/drm/i915/gt/intel_rc6.c
+++ b/drivers/gpu/drm/i915/gt/intel_rc6.c
@@ -55,7 +55,7 @@ static struct drm_i915_private *rc6_to_i915(struct intel_rc6 *rc)
static void set(struct intel_uncore *uncore, i915_reg_t reg, u32 val)
{
- intel_uncore_write_fw(uncore, reg, val);
+ intel_uncore_write(uncore, reg, val);
}
static void gen11_rc6_enable(struct intel_rc6 *rc6)
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Intel-gfx] [RFC] drm/i915/rc6: Access RC6 regs with forcewake
2022-04-22 13:37 [Intel-gfx] [RFC] drm/i915/rc6: Access RC6 regs with forcewake Badal Nilawar
@ 2022-04-22 15:34 ` Matt Roper
2022-04-25 4:25 ` Nilawar, Badal
2022-04-22 19:20 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2022-04-22 23:03 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2 siblings, 1 reply; 5+ messages in thread
From: Matt Roper @ 2022-04-22 15:34 UTC (permalink / raw)
To: Badal Nilawar; +Cc: intel-gfx, chris
On Fri, Apr 22, 2022 at 07:07:52PM +0530, Badal Nilawar wrote:
> To access RC6 related MMIO regs use intel_uncore_write(), which grabs
> forcewake if reg requires a forcewake.
>
> Signed-off-by: Badal Nilawar <badal.nilawar@intel.com>
> ---
> drivers/gpu/drm/i915/gt/intel_rc6.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_rc6.c b/drivers/gpu/drm/i915/gt/intel_rc6.c
> index b4770690e794..9edaad3f19b5 100644
> --- a/drivers/gpu/drm/i915/gt/intel_rc6.c
> +++ b/drivers/gpu/drm/i915/gt/intel_rc6.c
> @@ -55,7 +55,7 @@ static struct drm_i915_private *rc6_to_i915(struct intel_rc6 *rc)
>
> static void set(struct intel_uncore *uncore, i915_reg_t reg, u32 val)
> {
> - intel_uncore_write_fw(uncore, reg, val);
> + intel_uncore_write(uncore, reg, val);
The set() function is primarily used within the *_rc6_enable() functions.
Those are all called via intel_rc6_enable() which has already
grabbed explicit forcewake before calling them:
intel_uncore_forcewake_get(uncore, FORCEWAKE_ALL);
so there's no need to grab an additional reference on every register
access. Likewise, the call in vlv_residency_raw() doesn't need
forcewake because its own caller (intel_rc6_residency_ns) has already
acquired it.
I think the call in intel_rc6_unpark() is the only one that might be
questionable from a very quick skim of the code. So rather than
needlessly grabbing forcewake in all the other spots, it's probably
better to just replace that single call with a direct call to
intel_uncore_write() if it actually is problematic.
Even better, we might just want to drop the set() wrapper completely and
replace all instances with the appropriate intel_uncore_write[_fw]
calls; I don't really see the slightly shorter lines the wrapper gives
us as being worth the deviation from the rest of the driver's code
(especially if it's causing us confusion about what the intendended
forcewake semantics are).
Matt
> }
>
> static void gen11_rc6_enable(struct intel_rc6 *rc6)
> --
> 2.25.1
>
--
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
(916) 356-2795
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/rc6: Access RC6 regs with forcewake
2022-04-22 13:37 [Intel-gfx] [RFC] drm/i915/rc6: Access RC6 regs with forcewake Badal Nilawar
2022-04-22 15:34 ` Matt Roper
@ 2022-04-22 19:20 ` Patchwork
2022-04-22 23:03 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2022-04-22 19:20 UTC (permalink / raw)
To: Badal Nilawar; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 5346 bytes --]
== Series Details ==
Series: drm/i915/rc6: Access RC6 regs with forcewake
URL : https://patchwork.freedesktop.org/series/102995/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11544 -> Patchwork_102995v1
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/index.html
Participating hosts (45 -> 41)
------------------------------
Missing (4): fi-bsw-kefka fi-bsw-cyan fi-bsw-nick fi-bsw-n3050
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_102995v1:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@i915_selftest@live@reset:
- {bat-rpls-1}: [PASS][1] -> [DMESG-WARN][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11544/bat-rpls-1/igt@i915_selftest@live@reset.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/bat-rpls-1/igt@i915_selftest@live@reset.html
Known issues
------------
Here are the changes found in Patchwork_102995v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live@hangcheck:
- bat-dg1-5: [PASS][3] -> [DMESG-FAIL][4] ([i915#4494] / [i915#4957])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11544/bat-dg1-5/igt@i915_selftest@live@hangcheck.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/bat-dg1-5/igt@i915_selftest@live@hangcheck.html
* igt@i915_selftest@live@slpc:
- bat-dg1-5: [PASS][5] -> [INCOMPLETE][6] ([i915#5198])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11544/bat-dg1-5/igt@i915_selftest@live@slpc.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/bat-dg1-5/igt@i915_selftest@live@slpc.html
* igt@runner@aborted:
- fi-bdw-5557u: NOTRUN -> [FAIL][7] ([i915#4312])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/fi-bdw-5557u/igt@runner@aborted.html
#### Possible fixes ####
* igt@core_hotunplug@unbind-rebind:
- {bat-rpls-2}: [DMESG-WARN][8] ([i915#4391]) -> [PASS][9]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11544/bat-rpls-2/igt@core_hotunplug@unbind-rebind.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/bat-rpls-2/igt@core_hotunplug@unbind-rebind.html
* igt@gem_exec_suspend@basic-s3@smem:
- fi-bdw-5557u: [INCOMPLETE][10] ([i915#146]) -> [PASS][11]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11544/fi-bdw-5557u/igt@gem_exec_suspend@basic-s3@smem.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/fi-bdw-5557u/igt@gem_exec_suspend@basic-s3@smem.html
* igt@i915_selftest@live@perf:
- {fi-tgl-dsi}: [DMESG-WARN][12] -> [PASS][13] +17 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11544/fi-tgl-dsi/igt@i915_selftest@live@perf.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/fi-tgl-dsi/igt@i915_selftest@live@perf.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b:
- {bat-adlp-6}: [DMESG-WARN][14] ([i915#3576]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11544/bat-adlp-6/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/bat-adlp-6/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- {bat-adlm-1}: [DMESG-WARN][16] -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11544/bat-adlm-1/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/bat-adlm-1/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#146]: https://gitlab.freedesktop.org/drm/intel/issues/146
[i915#3576]: https://gitlab.freedesktop.org/drm/intel/issues/3576
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391
[i915#4494]: https://gitlab.freedesktop.org/drm/intel/issues/4494
[i915#4957]: https://gitlab.freedesktop.org/drm/intel/issues/4957
[i915#5198]: https://gitlab.freedesktop.org/drm/intel/issues/5198
[i915#5607]: https://gitlab.freedesktop.org/drm/intel/issues/5607
Build changes
-------------
* Linux: CI_DRM_11544 -> Patchwork_102995v1
CI-20190529: 20190529
CI_DRM_11544: 5f9019934f9819738661f0618a29865abed617f4 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6449: 704da775abb83faa9324a665fe2992ab90f4ab03 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_102995v1: 5f9019934f9819738661f0618a29865abed617f4 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
a063f5f643f0 drm/i915/rc6: Access RC6 regs with forcewake
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/index.html
[-- Attachment #2: Type: text/html, Size: 6051 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/rc6: Access RC6 regs with forcewake
2022-04-22 13:37 [Intel-gfx] [RFC] drm/i915/rc6: Access RC6 regs with forcewake Badal Nilawar
2022-04-22 15:34 ` Matt Roper
2022-04-22 19:20 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
@ 2022-04-22 23:03 ` Patchwork
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2022-04-22 23:03 UTC (permalink / raw)
To: Badal Nilawar; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 44083 bytes --]
== Series Details ==
Series: drm/i915/rc6: Access RC6 regs with forcewake
URL : https://patchwork.freedesktop.org/series/102995/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11544_full -> Patchwork_102995v1_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_102995v1_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_102995v1_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Participating hosts (12 -> 11)
------------------------------
Missing (1): shard-rkl
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_102995v1_full:
### IGT changes ###
#### Possible regressions ####
* igt@kms_flip@flip-vs-suspend-interruptible@a-edp1:
- shard-tglb: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11544/shard-tglb6/igt@kms_flip@flip-vs-suspend-interruptible@a-edp1.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-tglb2/igt@kms_flip@flip-vs-suspend-interruptible@a-edp1.html
Known issues
------------
Here are the changes found in Patchwork_102995v1_full that come from known issues:
### CI changes ###
#### Possible fixes ####
* boot:
- shard-glk: ([PASS][3], [PASS][4], [PASS][5], [PASS][6], [PASS][7], [PASS][8], [PASS][9], [PASS][10], [FAIL][11], [PASS][12], [PASS][13], [PASS][14], [PASS][15], [PASS][16], [PASS][17], [PASS][18], [PASS][19], [PASS][20], [PASS][21], [PASS][22], [PASS][23], [FAIL][24], [FAIL][25], [PASS][26], [PASS][27]) ([i915#4392]) -> ([PASS][28], [PASS][29], [PASS][30], [PASS][31], [PASS][32], [PASS][33], [PASS][34], [PASS][35], [PASS][36], [PASS][37], [PASS][38], [PASS][39], [PASS][40], [PASS][41], [PASS][42], [PASS][43], [PASS][44], [PASS][45], [PASS][46], [PASS][47], [PASS][48], [PASS][49], [PASS][50], [PASS][51], [PASS][52])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11544/shard-glk1/boot.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11544/shard-glk1/boot.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11544/shard-glk1/boot.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11544/shard-glk2/boot.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11544/shard-glk2/boot.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11544/shard-glk3/boot.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11544/shard-glk3/boot.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11544/shard-glk4/boot.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11544/shard-glk4/boot.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11544/shard-glk4/boot.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11544/shard-glk5/boot.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11544/shard-glk5/boot.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11544/shard-glk5/boot.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11544/shard-glk6/boot.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11544/shard-glk6/boot.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11544/shard-glk6/boot.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11544/shard-glk7/boot.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11544/shard-glk7/boot.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11544/shard-glk8/boot.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11544/shard-glk8/boot.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11544/shard-glk8/boot.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11544/shard-glk9/boot.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11544/shard-glk9/boot.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11544/shard-glk9/boot.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11544/shard-glk9/boot.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-glk6/boot.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-glk1/boot.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-glk1/boot.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-glk1/boot.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-glk2/boot.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-glk2/boot.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-glk3/boot.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-glk3/boot.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-glk3/boot.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-glk4/boot.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-glk4/boot.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-glk4/boot.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-glk5/boot.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-glk5/boot.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-glk9/boot.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-glk9/boot.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-glk8/boot.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-glk8/boot.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-glk8/boot.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-glk7/boot.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-glk7/boot.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-glk5/boot.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-glk7/boot.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-glk6/boot.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-glk6/boot.html
### IGT changes ###
#### Issues hit ####
* igt@feature_discovery@psr2:
- shard-iclb: [PASS][53] -> [SKIP][54] ([i915#658])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11544/shard-iclb2/igt@feature_discovery@psr2.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-iclb7/igt@feature_discovery@psr2.html
* igt@gem_ccs@ctrl-surf-copy-new-ctx:
- shard-glk: NOTRUN -> [SKIP][55] ([fdo#109271]) +135 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-glk3/igt@gem_ccs@ctrl-surf-copy-new-ctx.html
* igt@gem_ctx_param@set-priority-not-supported:
- shard-iclb: NOTRUN -> [SKIP][56] ([fdo#109314])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-iclb7/igt@gem_ctx_param@set-priority-not-supported.html
* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-apl: [PASS][57] -> [FAIL][58] ([i915#2842])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11544/shard-apl6/igt@gem_exec_fair@basic-none-solo@rcs0.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-apl4/igt@gem_exec_fair@basic-none-solo@rcs0.html
* igt@gem_exec_fair@basic-none@vcs0:
- shard-kbl: [PASS][59] -> [FAIL][60] ([i915#2842])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11544/shard-kbl6/igt@gem_exec_fair@basic-none@vcs0.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-kbl7/igt@gem_exec_fair@basic-none@vcs0.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [PASS][61] -> [FAIL][62] ([i915#2842])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11544/shard-glk8/igt@gem_exec_fair@basic-pace-share@rcs0.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-glk8/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_fair@basic-pace@vecs0:
- shard-glk: NOTRUN -> [FAIL][63] ([i915#2842]) +3 similar issues
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-glk7/igt@gem_exec_fair@basic-pace@vecs0.html
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-iclb: [PASS][64] -> [FAIL][65] ([i915#2849])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11544/shard-iclb5/igt@gem_exec_fair@basic-throttle@rcs0.html
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-iclb3/igt@gem_exec_fair@basic-throttle@rcs0.html
* igt@gem_exec_flush@basic-batch-kernel-default-wb:
- shard-snb: [PASS][66] -> [SKIP][67] ([fdo#109271]) +1 similar issue
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11544/shard-snb5/igt@gem_exec_flush@basic-batch-kernel-default-wb.html
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-snb6/igt@gem_exec_flush@basic-batch-kernel-default-wb.html
* igt@gem_exec_whisper@basic-queues-all:
- shard-glk: [PASS][68] -> [DMESG-WARN][69] ([i915#118])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11544/shard-glk8/igt@gem_exec_whisper@basic-queues-all.html
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-glk8/igt@gem_exec_whisper@basic-queues-all.html
* igt@gem_huc_copy@huc-copy:
- shard-iclb: NOTRUN -> [SKIP][70] ([i915#2190])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-iclb8/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@parallel-multi:
- shard-glk: NOTRUN -> [SKIP][71] ([fdo#109271] / [i915#4613]) +2 similar issues
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-glk6/igt@gem_lmem_swapping@parallel-multi.html
* igt@gem_lmem_swapping@random:
- shard-skl: NOTRUN -> [SKIP][72] ([fdo#109271] / [i915#4613])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-skl10/igt@gem_lmem_swapping@random.html
* igt@gem_lmem_swapping@verify-ccs:
- shard-apl: NOTRUN -> [SKIP][73] ([fdo#109271] / [i915#4613])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-apl7/igt@gem_lmem_swapping@verify-ccs.html
* igt@gem_pwrite@basic-exhaustion:
- shard-skl: NOTRUN -> [WARN][74] ([i915#2658])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-skl10/igt@gem_pwrite@basic-exhaustion.html
* igt@gem_render_copy@yf-tiled-to-vebox-y-tiled:
- shard-iclb: NOTRUN -> [SKIP][75] ([i915#768])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-iclb8/igt@gem_render_copy@yf-tiled-to-vebox-y-tiled.html
* igt@gem_ringfill@engines-basic@vecs0:
- shard-skl: [PASS][76] -> [DMESG-WARN][77] ([i915#1982])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11544/shard-skl7/igt@gem_ringfill@engines-basic@vecs0.html
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-skl7/igt@gem_ringfill@engines-basic@vecs0.html
* igt@gen9_exec_parse@cmd-crossing-page:
- shard-iclb: NOTRUN -> [SKIP][78] ([i915#2856])
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-iclb8/igt@gen9_exec_parse@cmd-crossing-page.html
* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [PASS][79] -> [FAIL][80] ([i915#454])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11544/shard-iclb8/igt@i915_pm_dc@dc6-psr.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-iclb3/igt@i915_pm_dc@dc6-psr.html
* igt@i915_pm_rpm@pc8-residency:
- shard-iclb: NOTRUN -> [SKIP][81] ([fdo#109293] / [fdo#109506])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-iclb8/igt@i915_pm_rpm@pc8-residency.html
* igt@i915_pm_rpm@system-suspend-modeset:
- shard-skl: [PASS][82] -> [INCOMPLETE][83] ([i915#5420])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11544/shard-skl1/igt@i915_pm_rpm@system-suspend-modeset.html
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-skl10/igt@i915_pm_rpm@system-suspend-modeset.html
* igt@kms_addfb_basic@invalid-smem-bo-on-discrete:
- shard-iclb: NOTRUN -> [SKIP][84] ([i915#3826])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-iclb8/igt@kms_addfb_basic@invalid-smem-bo-on-discrete.html
* igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-async-flip:
- shard-iclb: NOTRUN -> [SKIP][85] ([i915#5286]) +1 similar issue
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-iclb8/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-async-flip.html
* igt@kms_big_fb@x-tiled-16bpp-rotate-90:
- shard-iclb: NOTRUN -> [SKIP][86] ([fdo#110725] / [fdo#111614])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-iclb8/igt@kms_big_fb@x-tiled-16bpp-rotate-90.html
* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip:
- shard-skl: NOTRUN -> [SKIP][87] ([fdo#109271] / [i915#3777])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-skl8/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip.html
* igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-hflip:
- shard-glk: NOTRUN -> [SKIP][88] ([fdo#109271] / [i915#3777]) +3 similar issues
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-glk6/igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-hflip.html
* igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip:
- shard-apl: NOTRUN -> [SKIP][89] ([fdo#109271] / [i915#3777]) +2 similar issues
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-apl7/igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip.html
* igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0-hflip:
- shard-iclb: NOTRUN -> [SKIP][90] ([fdo#110723])
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-iclb7/igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0-hflip.html
* igt@kms_ccs@pipe-a-bad-aux-stride-y_tiled_gen12_rc_ccs_cc:
- shard-iclb: NOTRUN -> [SKIP][91] ([fdo#109278] / [i915#3886]) +4 similar issues
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-iclb8/igt@kms_ccs@pipe-a-bad-aux-stride-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_mc_ccs:
- shard-glk: NOTRUN -> [SKIP][92] ([fdo#109271] / [i915#3886]) +7 similar issues
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-glk7/igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-c-crc-primary-basic-y_tiled_gen12_rc_ccs_cc:
- shard-skl: NOTRUN -> [SKIP][93] ([fdo#109271] / [i915#3886])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-skl8/igt@kms_ccs@pipe-c-crc-primary-basic-y_tiled_gen12_rc_ccs_cc.html
- shard-apl: NOTRUN -> [SKIP][94] ([fdo#109271] / [i915#3886]) +1 similar issue
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-apl3/igt@kms_ccs@pipe-c-crc-primary-basic-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-d-bad-rotation-90-y_tiled_gen12_rc_ccs_cc:
- shard-iclb: NOTRUN -> [SKIP][95] ([fdo#109278]) +22 similar issues
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-iclb7/igt@kms_ccs@pipe-d-bad-rotation-90-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_chamelium@hdmi-edid-read:
- shard-skl: NOTRUN -> [SKIP][96] ([fdo#109271] / [fdo#111827]) +3 similar issues
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-skl10/igt@kms_chamelium@hdmi-edid-read.html
* igt@kms_chamelium@vga-hpd:
- shard-apl: NOTRUN -> [SKIP][97] ([fdo#109271] / [fdo#111827]) +1 similar issue
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-apl7/igt@kms_chamelium@vga-hpd.html
* igt@kms_color@pipe-d-ctm-0-5:
- shard-iclb: NOTRUN -> [SKIP][98] ([fdo#109278] / [i915#1149])
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-iclb6/igt@kms_color@pipe-d-ctm-0-5.html
* igt@kms_color_chamelium@pipe-a-ctm-green-to-red:
- shard-glk: NOTRUN -> [SKIP][99] ([fdo#109271] / [fdo#111827]) +12 similar issues
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-glk3/igt@kms_color_chamelium@pipe-a-ctm-green-to-red.html
* igt@kms_color_chamelium@pipe-b-ctm-red-to-blue:
- shard-iclb: NOTRUN -> [SKIP][100] ([fdo#109284] / [fdo#111827]) +6 similar issues
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-iclb8/igt@kms_color_chamelium@pipe-b-ctm-red-to-blue.html
* igt@kms_color_chamelium@pipe-d-ctm-negative:
- shard-iclb: NOTRUN -> [SKIP][101] ([fdo#109278] / [fdo#109284] / [fdo#111827])
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-iclb6/igt@kms_color_chamelium@pipe-d-ctm-negative.html
* igt@kms_content_protection@uevent:
- shard-iclb: NOTRUN -> [SKIP][102] ([fdo#109300] / [fdo#111066])
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-iclb8/igt@kms_content_protection@uevent.html
* igt@kms_cursor_crc@pipe-b-cursor-512x512-offscreen:
- shard-iclb: NOTRUN -> [SKIP][103] ([fdo#109278] / [fdo#109279]) +2 similar issues
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-iclb7/igt@kms_cursor_crc@pipe-b-cursor-512x512-offscreen.html
* igt@kms_cursor_crc@pipe-b-cursor-max-size-onscreen:
- shard-kbl: NOTRUN -> [SKIP][104] ([fdo#109271]) +1 similar issue
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-kbl6/igt@kms_cursor_crc@pipe-b-cursor-max-size-onscreen.html
* igt@kms_cursor_edge_walk@pipe-d-128x128-left-edge:
- shard-apl: NOTRUN -> [SKIP][105] ([fdo#109271]) +38 similar issues
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-apl7/igt@kms_cursor_edge_walk@pipe-d-128x128-left-edge.html
* igt@kms_cursor_legacy@cursorb-vs-flipb-atomic-transitions-varying-size:
- shard-iclb: NOTRUN -> [SKIP][106] ([fdo#109274] / [fdo#109278]) +1 similar issue
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-iclb8/igt@kms_cursor_legacy@cursorb-vs-flipb-atomic-transitions-varying-size.html
* igt@kms_dp_tiled_display@basic-test-pattern:
- shard-iclb: NOTRUN -> [SKIP][107] ([i915#426])
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-iclb7/igt@kms_dp_tiled_display@basic-test-pattern.html
* igt@kms_draw_crc@draw-method-rgb565-mmap-cpu-4tiled:
- shard-iclb: NOTRUN -> [SKIP][108] ([i915#5287])
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-iclb8/igt@kms_draw_crc@draw-method-rgb565-mmap-cpu-4tiled.html
* igt@kms_dsc@xrgb8888-dsc-compression:
- shard-iclb: NOTRUN -> [SKIP][109] ([i915#3828])
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-iclb8/igt@kms_dsc@xrgb8888-dsc-compression.html
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-glk: NOTRUN -> [FAIL][110] ([i915#4767])
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-glk6/igt@kms_fbcon_fbt@fbc-suspend.html
* igt@kms_fbcon_fbt@psr-suspend:
- shard-skl: [PASS][111] -> [FAIL][112] ([i915#4767])
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11544/shard-skl8/igt@kms_fbcon_fbt@psr-suspend.html
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-skl6/igt@kms_fbcon_fbt@psr-suspend.html
* igt@kms_flip@2x-flip-vs-modeset-vs-hang:
- shard-iclb: NOTRUN -> [SKIP][113] ([fdo#109274]) +5 similar issues
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-iclb6/igt@kms_flip@2x-flip-vs-modeset-vs-hang.html
* igt@kms_flip@flip-vs-expired-vblank@c-hdmi-a2:
- shard-glk: [PASS][114] -> [FAIL][115] ([i915#79])
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11544/shard-glk4/igt@kms_flip@flip-vs-expired-vblank@c-hdmi-a2.html
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-glk5/igt@kms_flip@flip-vs-expired-vblank@c-hdmi-a2.html
* igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-shrfb-draw-mmap-wc:
- shard-iclb: NOTRUN -> [SKIP][116] ([fdo#109280]) +11 similar issues
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-iclb8/igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-shrfb-draw-mmap-wc.html
* igt@kms_hdr@bpc-switch-dpms@bpc-switch-dpms-edp-1-pipe-a:
- shard-skl: [PASS][117] -> [FAIL][118] ([i915#1188])
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11544/shard-skl1/igt@kms_hdr@bpc-switch-dpms@bpc-switch-dpms-edp-1-pipe-a.html
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-skl1/igt@kms_hdr@bpc-switch-dpms@bpc-switch-dpms-edp-1-pipe-a.html
* igt@kms_hdr@static-toggle-dpms:
- shard-iclb: NOTRUN -> [SKIP][119] ([i915#3555])
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-iclb6/igt@kms_hdr@static-toggle-dpms.html
* igt@kms_invalid_mode@clock-too-high:
- shard-skl: NOTRUN -> [SKIP][120] ([fdo#109271]) +36 similar issues
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-skl10/igt@kms_invalid_mode@clock-too-high.html
* igt@kms_plane_alpha_blend@pipe-a-alpha-transparent-fb:
- shard-glk: NOTRUN -> [FAIL][121] ([i915#265])
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-glk6/igt@kms_plane_alpha_blend@pipe-a-alpha-transparent-fb.html
* igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
- shard-skl: [PASS][122] -> [FAIL][123] ([fdo#108145] / [i915#265])
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11544/shard-skl7/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-skl9/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max:
- shard-glk: NOTRUN -> [FAIL][124] ([fdo#108145] / [i915#265]) +1 similar issue
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-glk6/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max.html
* igt@kms_plane_lowres@pipe-a-tiling-x:
- shard-iclb: NOTRUN -> [SKIP][125] ([i915#3536])
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-iclb8/igt@kms_plane_lowres@pipe-a-tiling-x.html
* igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-25@pipe-a-edp-1-planes-upscale-downscale:
- shard-iclb: NOTRUN -> [SKIP][126] ([i915#5235]) +2 similar issues
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-iclb8/igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-25@pipe-a-edp-1-planes-upscale-downscale.html
* igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-5@pipe-a-edp-1-planes-upscale-downscale:
- shard-iclb: [PASS][127] -> [SKIP][128] ([i915#5235]) +2 similar issues
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11544/shard-iclb6/igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-5@pipe-a-edp-1-planes-upscale-downscale.html
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-iclb2/igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-5@pipe-a-edp-1-planes-upscale-downscale.html
* igt@kms_plane_scaling@upscale-with-rotation-20x20@pipe-a-edp-1-upscale-with-rotation:
- shard-iclb: NOTRUN -> [SKIP][129] ([i915#5176]) +5 similar issues
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-iclb6/igt@kms_plane_scaling@upscale-with-rotation-20x20@pipe-a-edp-1-upscale-with-rotation.html
* igt@kms_psr2_sf@cursor-plane-update-sf:
- shard-iclb: NOTRUN -> [SKIP][130] ([fdo#111068] / [i915#658])
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-iclb7/igt@kms_psr2_sf@cursor-plane-update-sf.html
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area:
- shard-glk: NOTRUN -> [SKIP][131] ([fdo#109271] / [i915#658])
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-glk6/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area.html
* igt@kms_psr@psr2_cursor_mmap_cpu:
- shard-iclb: [PASS][132] -> [SKIP][133] ([fdo#109441]) +1 similar issue
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11544/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-iclb8/igt@kms_psr@psr2_cursor_mmap_cpu.html
* igt@kms_psr@psr2_cursor_plane_move:
- shard-iclb: NOTRUN -> [SKIP][134] ([fdo#109441])
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-iclb8/igt@kms_psr@psr2_cursor_plane_move.html
* igt@kms_vblank@pipe-b-ts-continuation-suspend:
- shard-apl: [PASS][135] -> [DMESG-WARN][136] ([i915#180]) +2 similar issues
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11544/shard-apl6/igt@kms_vblank@pipe-b-ts-continuation-suspend.html
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-apl4/igt@kms_vblank@pipe-b-ts-continuation-suspend.html
* igt@kms_writeback@writeback-check-output:
- shard-glk: NOTRUN -> [SKIP][137] ([fdo#109271] / [i915#2437])
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-glk3/igt@kms_writeback@writeback-check-output.html
* igt@kms_writeback@writeback-fb-id:
- shard-kbl: NOTRUN -> [SKIP][138] ([fdo#109271] / [i915#2437])
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-kbl6/igt@kms_writeback@writeback-fb-id.html
* igt@nouveau_crc@pipe-a-ctx-flip-detection:
- shard-iclb: NOTRUN -> [SKIP][139] ([i915#2530])
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-iclb6/igt@nouveau_crc@pipe-a-ctx-flip-detection.html
* igt@perf@gen12-mi-rpc:
- shard-iclb: NOTRUN -> [SKIP][140] ([fdo#109289]) +1 similar issue
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-iclb8/igt@perf@gen12-mi-rpc.html
* igt@perf@polling-small-buf:
- shard-skl: NOTRUN -> [FAIL][141] ([i915#1722])
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-skl8/igt@perf@polling-small-buf.html
* igt@prime_nv_api@nv_self_import_to_different_fd:
- shard-iclb: NOTRUN -> [SKIP][142] ([fdo#109291]) +1 similar issue
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-iclb7/igt@prime_nv_api@nv_self_import_to_different_fd.html
* igt@sysfs_clients@create:
- shard-glk: NOTRUN -> [SKIP][143] ([fdo#109271] / [i915#2994]) +1 similar issue
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-glk3/igt@sysfs_clients@create.html
* igt@sysfs_clients@fair-0:
- shard-iclb: NOTRUN -> [SKIP][144] ([i915#2994])
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-iclb8/igt@sysfs_clients@fair-0.html
#### Possible fixes ####
* igt@gem_ctx_isolation@preservation-s3@vecs0:
- shard-skl: [INCOMPLETE][145] ([i915#4939]) -> [PASS][146]
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11544/shard-skl4/igt@gem_ctx_isolation@preservation-s3@vecs0.html
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-skl8/igt@gem_ctx_isolation@preservation-s3@vecs0.html
* igt@gem_exec_fair@basic-deadline:
- shard-kbl: [FAIL][147] ([i915#2846]) -> [PASS][148]
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11544/shard-kbl7/igt@gem_exec_fair@basic-deadline.html
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-kbl3/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-none@vcs1:
- shard-kbl: [FAIL][149] ([i915#2842]) -> [PASS][150]
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11544/shard-kbl6/igt@gem_exec_fair@basic-none@vcs1.html
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-kbl7/igt@gem_exec_fair@basic-none@vcs1.html
* igt@gem_exec_fair@basic-none@vecs0:
- shard-apl: [FAIL][151] ([i915#2842]) -> [PASS][152]
[151]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11544/shard-apl3/igt@gem_exec_fair@basic-none@vecs0.html
[152]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-apl7/igt@gem_exec_fair@basic-none@vecs0.html
- shard-glk: [FAIL][153] ([i915#2842]) -> [PASS][154]
[153]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11544/shard-glk3/igt@gem_exec_fair@basic-none@vecs0.html
[154]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-glk9/igt@gem_exec_fair@basic-none@vecs0.html
* igt@gem_partial_pwrite_pread@write-display:
- shard-skl: [DMESG-WARN][155] ([i915#1982]) -> [PASS][156]
[155]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11544/shard-skl10/igt@gem_partial_pwrite_pread@write-display.html
[156]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-skl6/igt@gem_partial_pwrite_pread@write-display.html
* igt@gen9_exec_parse@allowed-single:
- shard-glk: [DMESG-WARN][157] ([i915#5566] / [i915#716]) -> [PASS][158]
[157]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11544/shard-glk1/igt@gen9_exec_parse@allowed-single.html
[158]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-glk1/igt@gen9_exec_parse@allowed-single.html
* igt@i915_pm_dc@dc9-dpms:
- shard-iclb: [SKIP][159] ([i915#4281]) -> [PASS][160]
[159]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11544/shard-iclb3/igt@i915_pm_dc@dc9-dpms.html
[160]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-iclb5/igt@i915_pm_dc@dc9-dpms.html
* igt@i915_pm_rpm@cursor:
- shard-iclb: [INCOMPLETE][161] ([i915#5096]) -> [PASS][162]
[161]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11544/shard-iclb7/igt@i915_pm_rpm@cursor.html
[162]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-iclb7/igt@i915_pm_rpm@cursor.html
* igt@i915_suspend@fence-restore-tiled2untiled:
- shard-apl: [DMESG-WARN][163] ([i915#180]) -> [PASS][164] +1 similar issue
[163]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11544/shard-apl4/igt@i915_suspend@fence-restore-tiled2untiled.html
[164]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-apl7/igt@i915_suspend@fence-restore-tiled2untiled.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-glk: [FAIL][165] ([i915#2346] / [i915#533]) -> [PASS][166]
[165]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11544/shard-glk4/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[166]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-glk3/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-apl: [FAIL][167] ([i915#4767]) -> [PASS][168]
[167]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11544/shard-apl4/igt@kms_fbcon_fbt@fbc-suspend.html
[168]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-apl2/igt@kms_fbcon_fbt@fbc-suspend.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-dp1:
- shard-apl: [FAIL][169] ([i915#79]) -> [PASS][170]
[169]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11544/shard-apl3/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-dp1.html
[170]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-apl7/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-dp1.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-downscaling:
- shard-iclb: [SKIP][171] -> [PASS][172] +1 similar issue
[171]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11544/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-downscaling.html
[172]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-iclb7/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-downscaling.html
* igt@kms_hdr@bpc-switch-suspend@bpc-switch-suspend-edp-1-pipe-a:
- shard-skl: [FAIL][173] ([i915#1188]) -> [PASS][174] +1 similar issue
[173]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11544/shard-skl8/igt@kms_hdr@bpc-switch-suspend@bpc-switch-suspend-edp-1-pipe-a.html
[174]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-skl1/igt@kms_hdr@bpc-switch-suspend@bpc-switch-suspend-edp-1-pipe-a.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- shard-skl: [INCOMPLETE][175] ([i915#4444]) -> [PASS][176]
[175]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11544/shard-skl4/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
[176]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-skl10/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
* igt@kms_plane_lowres@pipe-b-tiling-none:
- shard-snb: [SKIP][177] ([fdo#109271]) -> [PASS][178] +2 similar issues
[177]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11544/shard-snb2/igt@kms_plane_lowres@pipe-b-tiling-none.html
[178]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-snb6/igt@kms_plane_lowres@pipe-b-tiling-none.html
* igt@kms_psr@psr2_sprite_mmap_cpu:
- shard-iclb: [SKIP][179] ([fdo#109441]) -> [PASS][180] +1 similar issue
[179]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11544/shard-iclb6/igt@kms_psr@psr2_sprite_mmap_cpu.html
[180]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_cpu.html
* igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend:
- {shard-tglu}: [DMESG-WARN][181] -> [PASS][182]
[181]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11544/shard-tglu-1/igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend.html
[182]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-tglu-5/igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend.html
* igt@perf@polling-parameterized:
- shard-skl: [FAIL][183] ([i915#5639]) -> [PASS][184]
[183]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11544/shard-skl8/igt@perf@polling-parameterized.html
[184]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-skl1/igt@perf@polling-parameterized.html
#### Warnings ####
* igt@gem_exec_balancer@parallel:
- shard-iclb: [DMESG-WARN][185] ([i915#5614]) -> [SKIP][186] ([i915#4525]) +1 similar issue
[185]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11544/shard-iclb4/igt@gem_exec_balancer@parallel.html
[186]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-iclb6/igt@gem_exec_balancer@parallel.html
* igt@gem_exec_balancer@parallel-out-fence:
- shard-iclb: [SKIP][187] ([i915#4525]) -> [DMESG-WARN][188] ([i915#5614])
[187]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11544/shard-iclb6/igt@gem_exec_balancer@parallel-out-fence.html
[188]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-iclb2/igt@gem_exec_balancer@parallel-out-fence.html
* igt@kms_psr2_sf@plane-move-sf-dmg-area:
- shard-iclb: [SKIP][189] ([fdo#111068] / [i915#658]) -> [SKIP][190] ([i915#2920])
[189]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11544/shard-iclb6/igt@kms_psr2_sf@plane-move-sf-dmg-area.html
[190]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/shard-iclb2/igt@kms_psr2_sf@plane-move-sf-dmg-area.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109293]: https://bugs.freedesktop.org/show_bug.cgi?id=109293
[fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300
[fdo#109302]: https://bugs.freedesktop.org/show_bug.cgi?id=109302
[fdo#109303]: https://bugs.freedesktop.org/show_bug.cgi?id=109303
[fdo#109314]: https://bugs.freedesktop.org/show_bug.cgi?id=109314
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110542]: https://bugs.freedesktop.org/show_bug.cgi?id=110542
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#110725]: https://bugs.freedesktop.org/show_bug.cgi?id=110725
[fdo#111066]: https://bugs.freedesktop.org/show_bug.cgi?id=111066
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644
[fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054
[i915#1063]: https://gitlab.freedesktop.org/drm/intel/issues/1063
[i915#1149]: https://gitlab.freedesktop.org/drm/intel/issues/1149
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1722]: https://gitlab.freedesktop.org/drm/intel/issues/1722
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2530]: https://gitlab.freedesktop.org/drm/intel/issues/2530
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#2849]: https://gitlab.freedesktop.org/drm/intel/issues/2849
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3063]: https://gitlab.freedesktop.org/drm/intel/issues/3063
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3319]: https://gitlab.freedesktop.org/drm/intel/issues/3319
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3536]: https://gitlab.freedesktop.org/drm/intel/issues/3536
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3777]: https://gitlab.freedesktop.org/drm/intel/issues/3777
[i915#3826]: https://gitlab.freedesktop.org/drm/intel/issues/3826
[i915#3828]: https://gitlab.freedesktop.org/drm/intel/issues/3828
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#426]: https://gitlab.freedesktop.org/drm/intel/issues/426
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4392]: https://gitlab.freedesktop.org/drm/intel/issues/4392
[i915#4444]: https://gitlab.freedesktop.org/drm/intel/issues/4444
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767
[i915#4939]: https://gitlab.freedesktop.org/drm/intel/issues/4939
[i915#5076]: https://gitlab.freedesktop.org/drm/intel/issues/5076
[i915#5096]: https://gitlab.freedesktop.org/drm/intel/issues/5096
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5257]: https://gitlab.freedesktop.org/drm/intel/issues/5257
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5287]: https://gitlab.freedesktop.org/drm/intel/issues/5287
[i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5420]: https://gitlab.freedesktop.org/drm/intel/issues/5420
[i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#5614]: https://gitlab.freedesktop.org/drm/intel/issues/5614
[i915#5639]: https://gitlab.freedesktop.org/drm/intel/issues/5639
[i915#5723]: https://gitlab.freedesktop.org/drm/intel/issues/5723
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#768]: https://gitlab.freedesktop.org/drm/intel/issues/768
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
Build changes
-------------
* Linux: CI_DRM_11544 -> Patchwork_102995v1
CI-20190529: 20190529
CI_DRM_11544: 5f9019934f9819738661f0618a29865abed617f4 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6449: 704da775abb83faa9324a665fe2992ab90f4ab03 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_102995v1: 5f9019934f9819738661f0618a29865abed617f4 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102995v1/index.html
[-- Attachment #2: Type: text/html, Size: 49633 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Intel-gfx] [RFC] drm/i915/rc6: Access RC6 regs with forcewake
2022-04-22 15:34 ` Matt Roper
@ 2022-04-25 4:25 ` Nilawar, Badal
0 siblings, 0 replies; 5+ messages in thread
From: Nilawar, Badal @ 2022-04-25 4:25 UTC (permalink / raw)
To: Matt Roper; +Cc: intel-gfx, chris
On 22-04-2022 21:04, Matt Roper wrote:
> On Fri, Apr 22, 2022 at 07:07:52PM +0530, Badal Nilawar wrote:
>> To access RC6 related MMIO regs use intel_uncore_write(), which grabs
>> forcewake if reg requires a forcewake.
>>
>> Signed-off-by: Badal Nilawar <badal.nilawar@intel.com>
>> ---
>> drivers/gpu/drm/i915/gt/intel_rc6.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/gt/intel_rc6.c b/drivers/gpu/drm/i915/gt/intel_rc6.c
>> index b4770690e794..9edaad3f19b5 100644
>> --- a/drivers/gpu/drm/i915/gt/intel_rc6.c
>> +++ b/drivers/gpu/drm/i915/gt/intel_rc6.c
>> @@ -55,7 +55,7 @@ static struct drm_i915_private *rc6_to_i915(struct intel_rc6 *rc)
>>
>> static void set(struct intel_uncore *uncore, i915_reg_t reg, u32 val)
>> {
>> - intel_uncore_write_fw(uncore, reg, val);
>> + intel_uncore_write(uncore, reg, val);
>
> The set() function is primarily used within the *_rc6_enable() functions.
> Those are all called via intel_rc6_enable() which has already
> grabbed explicit forcewake before calling them:
>
> intel_uncore_forcewake_get(uncore, FORCEWAKE_ALL);
>
> so there's no need to grab an additional reference on every register
> access. Likewise, the call in vlv_residency_raw() doesn't need
> forcewake because its own caller (intel_rc6_residency_ns) has already
> acquired it.
>
> I think the call in intel_rc6_unpark() is the only one that might be
> questionable from a very quick skim of the code. So rather than
> needlessly grabbing forcewake in all the other spots, it's probably
> better to just replace that single call with a direct call to
> intel_uncore_write() if it actually is problematic.
>
> Even better, we might just want to drop the set() wrapper completely and
> replace all instances with the appropriate intel_uncore_write[_fw]
> calls; I don't really see the slightly shorter lines the wrapper gives
> us as being worth the deviation from the rest of the driver's code
> (especially if it's causing us confusion about what the intendended
> forcewake semantics are).
>
Thanks for clarification.
The change in set() function was done for inte_rc6_unpark/park() only
since 0xA090 RC6_CTRL is getting written without forcewake. For now as
you suggested in inte_rc6_unpark/park() I will replace set() with
intel_uncore_write().
Regards,
Badal
>
> Matt
>
>> }
>>
>> static void gen11_rc6_enable(struct intel_rc6 *rc6)
>> --
>> 2.25.1
>>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-04-25 4:26 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-22 13:37 [Intel-gfx] [RFC] drm/i915/rc6: Access RC6 regs with forcewake Badal Nilawar
2022-04-22 15:34 ` Matt Roper
2022-04-25 4:25 ` Nilawar, Badal
2022-04-22 19:20 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2022-04-22 23:03 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.