* [PATCH] x86/EFI: correct section offsets in mkreloc diagnostics
@ 2020-04-30 10:24 Jan Beulich
2020-04-30 13:36 ` Andrew Cooper
0 siblings, 1 reply; 2+ messages in thread
From: Jan Beulich @ 2020-04-30 10:24 UTC (permalink / raw)
To: xen-devel; +Cc: Andrew Cooper, Wei Liu, Roger Pau Monné
These are more helpful if they point at the address where the relocated
value starts, rather than at the specific byte of the difference.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/arch/x86/efi/mkreloc.c
+++ b/xen/arch/x86/efi/mkreloc.c
@@ -238,7 +238,7 @@ static void diff_sections(const unsigned
fprintf(stderr,
"Difference at %.8s:%08" PRIxFAST32 " is %#" PRIxFAST64
" (expected %#" PRIxFAST64 ")\n",
- sec->name, i, delta, diff);
+ sec->name, i - disp, delta, diff);
continue;
}
if ( width == 8 && (val1.u64 < base || val1.u64 > end) )
@@ -263,14 +263,14 @@ static void diff_sections(const unsigned
{
fprintf(stderr,
"Cannot handle decreasing RVA (at %.8s:%08" PRIxFAST32 ")\n",
- sec->name, i);
+ sec->name, i - disp);
exit(3);
}
if ( !(sec->flags & COFF_SECTION_WRITEABLE) )
fprintf(stderr,
"Warning: relocation to r/o section %.8s:%08" PRIxFAST32 "\n",
- sec->name, i);
+ sec->name, i - disp);
printf("\t.word (%u << 12) | 0x%03" PRIxFAST32 "\n",
reloc, sec->rva + i - disp - rva);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-30 13:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-30 10:24 [PATCH] x86/EFI: correct section offsets in mkreloc diagnostics Jan Beulich
2020-04-30 13:36 ` Andrew Cooper
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.