* [PATCH 1/2] tty: Remove unused TTY_NUMBER() macro
@ 2016-04-10 3:36 Peter Hurley
2016-04-10 3:36 ` [PATCH 2/2] tty: Remove stale parameter comment Peter Hurley
0 siblings, 1 reply; 4+ messages in thread
From: Peter Hurley @ 2016-04-10 3:36 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: Jiri Slaby, linux-kernel, Peter Hurley
TTY_NUMBER() has been unused since v2.5.71; removed by
"[PATCH] callout removal: callout is gone".
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
---
drivers/tty/tty_io.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c
index 320dc4d..3cdd63b 100644
--- a/drivers/tty/tty_io.c
+++ b/drivers/tty/tty_io.c
@@ -230,9 +230,6 @@ static void tty_del_file(struct file *file)
tty_free_file(file);
}
-
-#define TTY_NUMBER(tty) ((tty)->index + (tty)->driver->name_base)
-
/**
* tty_name - return tty naming
* @tty: tty structure
--
2.8.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] tty: Remove stale parameter comment
2016-04-10 3:36 [PATCH 1/2] tty: Remove unused TTY_NUMBER() macro Peter Hurley
@ 2016-04-10 3:36 ` Peter Hurley
2016-04-10 8:24 ` Jiri Slaby
0 siblings, 1 reply; 4+ messages in thread
From: Peter Hurley @ 2016-04-10 3:36 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: Jiri Slaby, linux-kernel, Peter Hurley
noctty was removed as a parameter by commit 216513411937586
("tty: Consolidate noctty check in tty_open()").
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
---
drivers/tty/tty_io.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c
index 3cdd63b..50979be 100644
--- a/drivers/tty/tty_io.c
+++ b/drivers/tty/tty_io.c
@@ -1960,7 +1960,6 @@ static struct tty_struct *tty_open_current_tty(dev_t device, struct file *filp)
* tty_lookup_driver - lookup a tty driver for a given device file
* @device: device number
* @filp: file pointer to tty
- * @noctty: set if the device should not become a controlling tty
* @index: index for the device in the @return driver
* @return: driver for this inode (with increased refcount)
*
--
2.8.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] tty: Remove stale parameter comment
2016-04-10 3:36 ` [PATCH 2/2] tty: Remove stale parameter comment Peter Hurley
@ 2016-04-10 8:24 ` Jiri Slaby
2016-04-10 18:49 ` Peter Hurley
0 siblings, 1 reply; 4+ messages in thread
From: Jiri Slaby @ 2016-04-10 8:24 UTC (permalink / raw)
To: Peter Hurley, Greg Kroah-Hartman; +Cc: linux-kernel
On 04/10/2016, 05:36 AM, Peter Hurley wrote:
> noctty was removed as a parameter by commit 216513411937586
It is actually 11e1d4aa4da.
> ("tty: Consolidate noctty check in tty_open()").
>
> Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
> ---
> drivers/tty/tty_io.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c
> index 3cdd63b..50979be 100644
> --- a/drivers/tty/tty_io.c
> +++ b/drivers/tty/tty_io.c
> @@ -1960,7 +1960,6 @@ static struct tty_struct *tty_open_current_tty(dev_t device, struct file *filp)
> * tty_lookup_driver - lookup a tty driver for a given device file
> * @device: device number
> * @filp: file pointer to tty
> - * @noctty: set if the device should not become a controlling tty
> * @index: index for the device in the @return driver
> * @return: driver for this inode (with increased refcount)
> *
>
--
js
suse labs
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] tty: Remove stale parameter comment
2016-04-10 8:24 ` Jiri Slaby
@ 2016-04-10 18:49 ` Peter Hurley
0 siblings, 0 replies; 4+ messages in thread
From: Peter Hurley @ 2016-04-10 18:49 UTC (permalink / raw)
To: Jiri Slaby, Greg Kroah-Hartman; +Cc: linux-kernel
On 04/10/2016 01:24 AM, Jiri Slaby wrote:
> On 04/10/2016, 05:36 AM, Peter Hurley wrote:
>> noctty was removed as a parameter by commit 216513411937586
>
> It is actually 11e1d4aa4da.
Right; not sure where that number came from.
>
>> ("tty: Consolidate noctty check in tty_open()").
>>
>> Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
>> ---
>> drivers/tty/tty_io.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c
>> index 3cdd63b..50979be 100644
>> --- a/drivers/tty/tty_io.c
>> +++ b/drivers/tty/tty_io.c
>> @@ -1960,7 +1960,6 @@ static struct tty_struct *tty_open_current_tty(dev_t device, struct file *filp)
>> * tty_lookup_driver - lookup a tty driver for a given device file
>> * @device: device number
>> * @filp: file pointer to tty
>> - * @noctty: set if the device should not become a controlling tty
>> * @index: index for the device in the @return driver
>> * @return: driver for this inode (with increased refcount)
>> *
>>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-04-10 18:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-10 3:36 [PATCH 1/2] tty: Remove unused TTY_NUMBER() macro Peter Hurley
2016-04-10 3:36 ` [PATCH 2/2] tty: Remove stale parameter comment Peter Hurley
2016-04-10 8:24 ` Jiri Slaby
2016-04-10 18:49 ` Peter Hurley
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.