All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] new package: alsacap
@ 2016-04-06  7:01 Wojciech Nizinski
  2016-04-06  7:10 ` Yegor Yefremov
  2016-04-06 22:42 ` Arnout Vandecappelle
  0 siblings, 2 replies; 8+ messages in thread
From: Wojciech Nizinski @ 2016-04-06  7:01 UTC (permalink / raw)
  To: buildroot

Alsa capability tool displays the capabilities of your sound card and
its ALSA driver

Signed-off-by: Wojciech Nizinski <niziak@spox.org>
---
 package/Config.in          |  1 +
 package/alsacap/Config.in  |  5 +++++
 package/alsacap/alsacap.mk | 22 ++++++++++++++++++++++
 3 files changed, 28 insertions(+)
 create mode 100644 package/alsacap/Config.in
 create mode 100644 package/alsacap/alsacap.mk

diff --git a/package/Config.in b/package/Config.in
index bdc3063..dd6c1d9 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -5,6 +5,7 @@ menu "Target packages"
 
 menu "Audio and video applications"
 	source "package/alsa-utils/Config.in"
+	source "package/alsacap/Config.in"
 	source "package/aumix/Config.in"
 	source "package/bellagio/Config.in"
 	source "package/dvblast/Config.in"
diff --git a/package/alsacap/Config.in b/package/alsacap/Config.in
new file mode 100644
index 0000000..d472973
--- /dev/null
+++ b/package/alsacap/Config.in
@@ -0,0 +1,5 @@
+config BR2_PACKAGE_ALSACAP
+	bool "alsacap"
+	depends on BR2_PACKAGE_ALSA_LIB
+	help 
+	    Alsa capability tool displays the capabilities of your sound card and its ALSA driver.
diff --git a/package/alsacap/alsacap.mk b/package/alsacap/alsacap.mk
new file mode 100644
index 0000000..391947c
--- /dev/null
+++ b/package/alsacap/alsacap.mk
@@ -0,0 +1,22 @@
+################################################################################
+#
+# alsacap
+#
+################################################################################
+ALSACAP_VERSION = 05968d33bd42b9550ac0892c0214edc956d09d8d
+ALSACAP_SITE = $(call github,bubbapizza,alsacap,$(ALSACAP_VERSION))
+
+ALSACAP_LICENSE = ISC licence
+ALSACAP_LICENSE_FILES = COPYING
+
+ALSACAP_DEPENDENCIES = alsa-lib
+
+define ALSACAP_BOOTSTRAP
+    cd $(@D) && ./bootstrap
+endef
+
+ALSACAP_PRE_CONFIGURE_HOOKS += ALSACAP_BOOTSTRAP
+
+$(eval $(autotools-package))
+
+
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [Buildroot] [PATCH 1/1] new package: alsacap
  2016-04-06  7:01 [Buildroot] [PATCH 1/1] new package: alsacap Wojciech Nizinski
@ 2016-04-06  7:10 ` Yegor Yefremov
  2016-04-06 14:37   ` Wojciech Niziński
  2016-04-06 22:42 ` Arnout Vandecappelle
  1 sibling, 1 reply; 8+ messages in thread
From: Yegor Yefremov @ 2016-04-06  7:10 UTC (permalink / raw)
  To: buildroot

Hi Wojciech ,

On Wed, Apr 6, 2016 at 9:01 AM, Wojciech Nizinski <niziak@spox.org> wrote:
> Alsa capability tool displays the capabilities of your sound card and
> its ALSA driver
>
> Signed-off-by: Wojciech Nizinski <niziak@spox.org>
> ---
>  package/Config.in          |  1 +
>  package/alsacap/Config.in  |  5 +++++
>  package/alsacap/alsacap.mk | 22 ++++++++++++++++++++++

hash file is missing

>  3 files changed, 28 insertions(+)
>  create mode 100644 package/alsacap/Config.in
>  create mode 100644 package/alsacap/alsacap.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index bdc3063..dd6c1d9 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -5,6 +5,7 @@ menu "Target packages"
>
>  menu "Audio and video applications"
>         source "package/alsa-utils/Config.in"
> +       source "package/alsacap/Config.in"
>         source "package/aumix/Config.in"
>         source "package/bellagio/Config.in"
>         source "package/dvblast/Config.in"
> diff --git a/package/alsacap/Config.in b/package/alsacap/Config.in
> new file mode 100644
> index 0000000..d472973
> --- /dev/null
> +++ b/package/alsacap/Config.in
> @@ -0,0 +1,5 @@
> +config BR2_PACKAGE_ALSACAP
> +       bool "alsacap"
> +       depends on BR2_PACKAGE_ALSA_LIB
> +       help
> +           Alsa capability tool displays the capabilities of your sound card and its ALSA driver.
> diff --git a/package/alsacap/alsacap.mk b/package/alsacap/alsacap.mk
> new file mode 100644
> index 0000000..391947c
> --- /dev/null
> +++ b/package/alsacap/alsacap.mk
> @@ -0,0 +1,22 @@
> +################################################################################
> +#
> +# alsacap
> +#
> +################################################################################
> +ALSACAP_VERSION = 05968d33bd42b9550ac0892c0214edc956d09d8d
> +ALSACAP_SITE = $(call github,bubbapizza,alsacap,$(ALSACAP_VERSION))
> +
> +ALSACAP_LICENSE = ISC licence

this should be just "ISC" and not "ISC licence"

> +ALSACAP_LICENSE_FILES = COPYING
> +
> +ALSACAP_DEPENDENCIES = alsa-lib
> +
> +define ALSACAP_BOOTSTRAP
> +    cd $(@D) && ./bootstrap
> +endef

have you tried specifying "ALSACAP_AUTORECONF =YES" instead of making
own boostrap hook?

See http://nightly.buildroot.org/manual.html#_infrastructure_for_autotools_based_packages
for reference.

Yegor

> +
> +ALSACAP_PRE_CONFIGURE_HOOKS += ALSACAP_BOOTSTRAP
> +
> +$(eval $(autotools-package))
> +
> +
> --
> 2.1.4
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Buildroot] [PATCH 1/1] new package: alsacap
  2016-04-06  7:10 ` Yegor Yefremov
@ 2016-04-06 14:37   ` Wojciech Niziński
  2016-04-07  7:39     ` Jerzy Grzegorek
  2016-07-03  7:36     ` Peter Korsgaard
  0 siblings, 2 replies; 8+ messages in thread
From: Wojciech Niziński @ 2016-04-06 14:37 UTC (permalink / raw)
  To: buildroot

Hello!
Corrected patch below.
Hash file added, but hash is not used, because source comes from git 
repository.


Alsa capability tool displays the capabilities of your sound card and
its ALSA driver

Signed-off-by: Wojciech Nizinski <niziak@spox.org>
---
  package/Config.in            |  1 +
  package/alsacap/Config.in    |  5 +++++
  package/alsacap/alsacap.hash |  2 ++
  package/alsacap/alsacap.mk   | 18 ++++++++++++++++++
  4 files changed, 26 insertions(+)
  create mode 100644 package/alsacap/Config.in
  create mode 100644 package/alsacap/alsacap.hash
  create mode 100644 package/alsacap/alsacap.mk

diff --git a/package/Config.in b/package/Config.in
index 64822bf..29045b2 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -5,6 +5,7 @@ menu "Target packages"

  menu "Audio and video applications"
  	source "package/alsa-utils/Config.in"
+	source "package/alsacap/Config.in"
  	source "package/aumix/Config.in"
  	source "package/bellagio/Config.in"
  	source "package/dvblast/Config.in"
diff --git a/package/alsacap/Config.in b/package/alsacap/Config.in
new file mode 100644
index 0000000..d472973
--- /dev/null
+++ b/package/alsacap/Config.in
@@ -0,0 +1,5 @@
+config BR2_PACKAGE_ALSACAP
+	bool "alsacap"
+	depends on BR2_PACKAGE_ALSA_LIB
+	help
+	    Alsa capability tool displays the capabilities of your sound card 
and its ALSA driver.
diff --git a/package/alsacap/alsacap.hash b/package/alsacap/alsacap.hash
new file mode 100644
index 0000000..293df28
--- /dev/null
+++ b/package/alsacap/alsacap.hash
@@ -0,0 +1,2 @@
+none   xxx  alsacap-05968d33bd42b9550ac0892c0214edc956d09d8d.tar.gz
+
diff --git a/package/alsacap/alsacap.mk b/package/alsacap/alsacap.mk
new file mode 100644
index 0000000..135ab87
--- /dev/null
+++ b/package/alsacap/alsacap.mk
@@ -0,0 +1,18 @@
+################################################################################
+#
+# alsacap
+#
+################################################################################
+ALSACAP_VERSION = 05968d33bd42b9550ac0892c0214edc956d09d8d
+ALSACAP_SITE = $(call github,bubbapizza,alsacap,$(ALSACAP_VERSION))
+
+ALSACAP_LICENSE = ISC
+ALSACAP_LICENSE_FILES = COPYING
+
+ALSACAP_DEPENDENCIES = alsa-lib
+
+ALSACAP_AUTORECONF = YES
+
+$(eval $(autotools-package))
+
+
-- 
2.1.4



On 2016-04-06 09:10, Yegor Yefremov wrote:
> Hi Wojciech ,
> 
> On Wed, Apr 6, 2016 at 9:01 AM, Wojciech Nizinski <niziak@spox.org> 
> wrote:
>> Alsa capability tool displays the capabilities of your sound card and
>> its ALSA driver
>> 
>> Signed-off-by: Wojciech Nizinski <niziak@spox.org>
>> ---
>>  package/Config.in          |  1 +
>>  package/alsacap/Config.in  |  5 +++++
>>  package/alsacap/alsacap.mk | 22 ++++++++++++++++++++++
> 
> hash file is missing
> 
>>  3 files changed, 28 insertions(+)
>>  create mode 100644 package/alsacap/Config.in
>>  create mode 100644 package/alsacap/alsacap.mk
>> 
>> diff --git a/package/Config.in b/package/Config.in
>> index bdc3063..dd6c1d9 100644
>> --- a/package/Config.in
>> +++ b/package/Config.in
>> @@ -5,6 +5,7 @@ menu "Target packages"
>> 
>>  menu "Audio and video applications"
>>         source "package/alsa-utils/Config.in"
>> +       source "package/alsacap/Config.in"
>>         source "package/aumix/Config.in"
>>         source "package/bellagio/Config.in"
>>         source "package/dvblast/Config.in"
>> diff --git a/package/alsacap/Config.in b/package/alsacap/Config.in
>> new file mode 100644
>> index 0000000..d472973
>> --- /dev/null
>> +++ b/package/alsacap/Config.in
>> @@ -0,0 +1,5 @@
>> +config BR2_PACKAGE_ALSACAP
>> +       bool "alsacap"
>> +       depends on BR2_PACKAGE_ALSA_LIB
>> +       help
>> +           Alsa capability tool displays the capabilities of your 
>> sound card and its ALSA driver.
>> diff --git a/package/alsacap/alsacap.mk b/package/alsacap/alsacap.mk
>> new file mode 100644
>> index 0000000..391947c
>> --- /dev/null
>> +++ b/package/alsacap/alsacap.mk
>> @@ -0,0 +1,22 @@
>> +################################################################################
>> +#
>> +# alsacap
>> +#
>> +################################################################################
>> +ALSACAP_VERSION = 05968d33bd42b9550ac0892c0214edc956d09d8d
>> +ALSACAP_SITE = $(call github,bubbapizza,alsacap,$(ALSACAP_VERSION))
>> +
>> +ALSACAP_LICENSE = ISC licence
> 
> this should be just "ISC" and not "ISC licence"
> 
>> +ALSACAP_LICENSE_FILES = COPYING
>> +
>> +ALSACAP_DEPENDENCIES = alsa-lib
>> +
>> +define ALSACAP_BOOTSTRAP
>> +    cd $(@D) && ./bootstrap
>> +endef
> 
> have you tried specifying "ALSACAP_AUTORECONF =YES" instead of making
> own boostrap hook?
> 
> See
> http://nightly.buildroot.org/manual.html#_infrastructure_for_autotools_based_packages
> for reference.
> 
> Yegor
> 
>> +
>> +ALSACAP_PRE_CONFIGURE_HOOKS += ALSACAP_BOOTSTRAP
>> +
>> +$(eval $(autotools-package))
>> +
>> +
>> --
>> 2.1.4
>> 
>> _______________________________________________
>> buildroot mailing list
>> buildroot at busybox.net
>> http://lists.busybox.net/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [Buildroot] [PATCH 1/1] new package: alsacap
  2016-04-06  7:01 [Buildroot] [PATCH 1/1] new package: alsacap Wojciech Nizinski
  2016-04-06  7:10 ` Yegor Yefremov
@ 2016-04-06 22:42 ` Arnout Vandecappelle
  2016-04-07  7:35   ` Wojciech Nizinski
  1 sibling, 1 reply; 8+ messages in thread
From: Arnout Vandecappelle @ 2016-04-06 22:42 UTC (permalink / raw)
  To: buildroot

  In addition to Yegor's comments...

On 04/06/16 09:01, Wojciech Nizinski wrote:
> Alsa capability tool displays the capabilities of your sound card and
> its ALSA driver
>
> Signed-off-by: Wojciech Nizinski <niziak@spox.org>
> ---
>   package/Config.in          |  1 +
>   package/alsacap/Config.in  |  5 +++++
>   package/alsacap/alsacap.mk | 22 ++++++++++++++++++++++
>   3 files changed, 28 insertions(+)
>   create mode 100644 package/alsacap/Config.in
>   create mode 100644 package/alsacap/alsacap.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index bdc3063..dd6c1d9 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -5,6 +5,7 @@ menu "Target packages"
>
>   menu "Audio and video applications"
>   	source "package/alsa-utils/Config.in"
> +	source "package/alsacap/Config.in"
>   	source "package/aumix/Config.in"
>   	source "package/bellagio/Config.in"
>   	source "package/dvblast/Config.in"
> diff --git a/package/alsacap/Config.in b/package/alsacap/Config.in
> new file mode 100644
> index 0000000..d472973
> --- /dev/null
> +++ b/package/alsacap/Config.in
> @@ -0,0 +1,5 @@
> +config BR2_PACKAGE_ALSACAP
> +	bool "alsacap"
> +	depends on BR2_PACKAGE_ALSA_LIB

  Use select instead of depends:

	depends on BR2_TOOLCHAIN_HAS_THREADS # alsa-lib
	select BR2_PACKAGE_ALSA_LIB

  Because there is a dependency on threads, you also need to add a comment to 
clarify that (cfr. the manual).

> +	help
> +	    Alsa capability tool displays the capabilities of your sound card and its ALSA driver.

  Indentation should be 1 tab + 2 spaces, and wrap at 72 columns (where tab 
counts for 8, so 62 characters).

> diff --git a/package/alsacap/alsacap.mk b/package/alsacap/alsacap.mk
> new file mode 100644
> index 0000000..391947c
> --- /dev/null
> +++ b/package/alsacap/alsacap.mk
> @@ -0,0 +1,22 @@
> +################################################################################
> +#
> +# alsacap
> +#
> +################################################################################
> +ALSACAP_VERSION = 05968d33bd42b9550ac0892c0214edc956d09d8d
> +ALSACAP_SITE = $(call github,bubbapizza,alsacap,$(ALSACAP_VERSION))
> +

  Remove this empty line.

> +ALSACAP_LICENSE = ISC licence
> +ALSACAP_LICENSE_FILES = COPYING
> +

  Here as well.


  Regards,
  Arnout

> +ALSACAP_DEPENDENCIES = alsa-lib
> +
> +define ALSACAP_BOOTSTRAP
> +    cd $(@D) && ./bootstrap
> +endef
> +
> +ALSACAP_PRE_CONFIGURE_HOOKS += ALSACAP_BOOTSTRAP
> +
> +$(eval $(autotools-package))
> +
> +
>


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Buildroot] [PATCH 1/1] new package: alsacap
  2016-04-06 22:42 ` Arnout Vandecappelle
@ 2016-04-07  7:35   ` Wojciech Nizinski
  2016-04-10 14:40     ` Arnout Vandecappelle
  0 siblings, 1 reply; 8+ messages in thread
From: Wojciech Nizinski @ 2016-04-07  7:35 UTC (permalink / raw)
  To: buildroot

Is any tool available to check format of BR files (something like vera++) ?

On 07.04.2016 00:42, Arnout Vandecappelle wrote:
>  In addition to Yegor's comments...
>
> On 04/06/16 09:01, Wojciech Nizinski wrote:
>> Alsa capability tool displays the capabilities of your sound card and
>> its ALSA driver
>>
>> Signed-off-by: Wojciech Nizinski <niziak@spox.org>
>> ---
>>   package/Config.in          |  1 +
>>   package/alsacap/Config.in  |  5 +++++
>>   package/alsacap/alsacap.mk | 22 ++++++++++++++++++++++
>>   3 files changed, 28 insertions(+)
>>   create mode 100644 package/alsacap/Config.in
>>   create mode 100644 package/alsacap/alsacap.mk
>>
>> diff --git a/package/Config.in b/package/Config.in
>> index bdc3063..dd6c1d9 100644
>> --- a/package/Config.in
>> +++ b/package/Config.in
>> @@ -5,6 +5,7 @@ menu "Target packages"
>>
>>   menu "Audio and video applications"
>>       source "package/alsa-utils/Config.in"
>> +    source "package/alsacap/Config.in"
>>       source "package/aumix/Config.in"
>>       source "package/bellagio/Config.in"
>>       source "package/dvblast/Config.in"
>> diff --git a/package/alsacap/Config.in b/package/alsacap/Config.in
>> new file mode 100644
>> index 0000000..d472973
>> --- /dev/null
>> +++ b/package/alsacap/Config.in
>> @@ -0,0 +1,5 @@
>> +config BR2_PACKAGE_ALSACAP
>> +    bool "alsacap"
>> +    depends on BR2_PACKAGE_ALSA_LIB
>
>  Use select instead of depends:
>
>     depends on BR2_TOOLCHAIN_HAS_THREADS # alsa-lib
>     select BR2_PACKAGE_ALSA_LIB
>
>  Because there is a dependency on threads, you also need to add a 
> comment to clarify that (cfr. the manual).
>
>> +    help
>> +        Alsa capability tool displays the capabilities of your sound 
>> card and its ALSA driver.
>
>  Indentation should be 1 tab + 2 spaces, and wrap at 72 columns (where 
> tab counts for 8, so 62 characters).
>
>> diff --git a/package/alsacap/alsacap.mk b/package/alsacap/alsacap.mk
>> new file mode 100644
>> index 0000000..391947c
>> --- /dev/null
>> +++ b/package/alsacap/alsacap.mk
>> @@ -0,0 +1,22 @@
>> +################################################################################ 
>>
>> +#
>> +# alsacap
>> +#
>> +################################################################################ 
>>
>> +ALSACAP_VERSION = 05968d33bd42b9550ac0892c0214edc956d09d8d
>> +ALSACAP_SITE = $(call github,bubbapizza,alsacap,$(ALSACAP_VERSION))
>> +
>
>  Remove this empty line.
>
>> +ALSACAP_LICENSE = ISC licence
>> +ALSACAP_LICENSE_FILES = COPYING
>> +
>
>  Here as well.
>
>
>  Regards,
>  Arnout
>
>> +ALSACAP_DEPENDENCIES = alsa-lib
>> +
>> +define ALSACAP_BOOTSTRAP
>> +    cd $(@D) && ./bootstrap
>> +endef
>> +
>> +ALSACAP_PRE_CONFIGURE_HOOKS += ALSACAP_BOOTSTRAP
>> +
>> +$(eval $(autotools-package))
>> +
>> +
>>
>
>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Buildroot] [PATCH 1/1] new package: alsacap
  2016-04-06 14:37   ` Wojciech Niziński
@ 2016-04-07  7:39     ` Jerzy Grzegorek
  2016-07-03  7:36     ` Peter Korsgaard
  1 sibling, 0 replies; 8+ messages in thread
From: Jerzy Grzegorek @ 2016-04-07  7:39 UTC (permalink / raw)
  To: buildroot

Hi Wojciech,

In addition to the previous comments...

> Hello!
> Corrected patch below.
> Hash file added, but hash is not used, because source comes from git 
> repository.
>
>
> Alsa capability tool displays the capabilities of your sound card and
> its ALSA driver
>
> Signed-off-by: Wojciech Nizinski <niziak@spox.org>
> ---
>  package/Config.in            |  1 +
>  package/alsacap/Config.in    |  5 +++++
>  package/alsacap/alsacap.hash |  2 ++
>  package/alsacap/alsacap.mk   | 18 ++++++++++++++++++
>  4 files changed, 26 insertions(+)
>  create mode 100644 package/alsacap/Config.in
>  create mode 100644 package/alsacap/alsacap.hash
>  create mode 100644 package/alsacap/alsacap.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index 64822bf..29045b2 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -5,6 +5,7 @@ menu "Target packages"
>
>  menu "Audio and video applications"
>      source "package/alsa-utils/Config.in"
> +    source "package/alsacap/Config.in"
>      source "package/aumix/Config.in"
>      source "package/bellagio/Config.in"
>      source "package/dvblast/Config.in"
> diff --git a/package/alsacap/Config.in b/package/alsacap/Config.in
> new file mode 100644
> index 0000000..d472973
> --- /dev/null
> +++ b/package/alsacap/Config.in
> @@ -0,0 +1,5 @@
> +config BR2_PACKAGE_ALSACAP
> +    bool "alsacap"
> +    depends on BR2_PACKAGE_ALSA_LIB
> +    help
> +        Alsa capability tool displays the capabilities of your sound 
> card and its ALSA driver.
> diff --git a/package/alsacap/alsacap.hash b/package/alsacap/alsacap.hash
> new file mode 100644
> index 0000000..293df28
> --- /dev/null
> +++ b/package/alsacap/alsacap.hash
> @@ -0,0 +1,2 @@
> +none   xxx alsacap-05968d33bd42b9550ac0892c0214edc956d09d8d.tar.gz
> +
> diff --git a/package/alsacap/alsacap.mk b/package/alsacap/alsacap.mk
> new file mode 100644
> index 0000000..135ab87
> --- /dev/null
> +++ b/package/alsacap/alsacap.mk
> @@ -0,0 +1,18 @@
> +################################################################################ 
>
> +#
> +# alsacap
> +#
> +################################################################################ 
>

Add empty line here.

> +ALSACAP_VERSION = 05968d33bd42b9550ac0892c0214edc956d09d8d
> +ALSACAP_SITE = $(call github,bubbapizza,alsacap,$(ALSACAP_VERSION))
> +
> +ALSACAP_LICENSE = ISC
> +ALSACAP_LICENSE_FILES = COPYING
> +
> +ALSACAP_DEPENDENCIES = alsa-lib
> +
> +ALSACAP_AUTORECONF = YES
> +
> +$(eval $(autotools-package))
> +
> +

These two empty lines are redundant.

Regards,
Jerzy

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Buildroot] [PATCH 1/1] new package: alsacap
  2016-04-07  7:35   ` Wojciech Nizinski
@ 2016-04-10 14:40     ` Arnout Vandecappelle
  0 siblings, 0 replies; 8+ messages in thread
From: Arnout Vandecappelle @ 2016-04-10 14:40 UTC (permalink / raw)
  To: buildroot

On 04/07/16 09:35, Wojciech Nizinski wrote:
> Is any tool available to check format of BR files (something like vera++) ?

  Unfortunately, not at the moment. I started on something [1] but never 
finished it to a level that it actually did something useful.

  Regards,
  Arnout

[snip]

[1] git fetch https://github.com/arnout/buildroot.git checkpackage
-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Buildroot] [PATCH 1/1] new package: alsacap
  2016-04-06 14:37   ` Wojciech Niziński
  2016-04-07  7:39     ` Jerzy Grzegorek
@ 2016-07-03  7:36     ` Peter Korsgaard
  1 sibling, 0 replies; 8+ messages in thread
From: Peter Korsgaard @ 2016-07-03  7:36 UTC (permalink / raw)
  To: buildroot

>>>>> "Wojciech" == Wojciech Nizi?ski <niziak@spox.org> writes:

 > Hello!
 > Corrected patch below.
 > Hash file added, but hash is not used, because source comes from git
 > repository.

 > Alsa capability tool displays the capabilities of your sound card and
 > its ALSA driver

 > Signed-off-by: Wojciech Nizinski <niziak@spox.org>

Care to send an updated patch with the fixes suggested by Arnout and
Jerzy? Also please add a locally calculated sha256 for the .hash file.

Looking at the upstream code I see it will need to be fixed for static
linking. Right now it is simply hardcoded to link with
-lasound. Alsa-lib provides a .pc files, so ideally it should use
pkg-config to get the right linker/compiler flags.

In the mean time I will mark this patch as changes requested in
patchwork.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2016-07-03  7:36 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-06  7:01 [Buildroot] [PATCH 1/1] new package: alsacap Wojciech Nizinski
2016-04-06  7:10 ` Yegor Yefremov
2016-04-06 14:37   ` Wojciech Niziński
2016-04-07  7:39     ` Jerzy Grzegorek
2016-07-03  7:36     ` Peter Korsgaard
2016-04-06 22:42 ` Arnout Vandecappelle
2016-04-07  7:35   ` Wojciech Nizinski
2016-04-10 14:40     ` Arnout Vandecappelle

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.