From: David Daney <ddaney@caviumnetworks.com>
To: Jayachandran C <jchandra@broadcom.com>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
Tomasz Nowicki <tn@semihalf.com>,
rafael@kernel.org, Arnd Bergmann <arnd@arndb.de>,
Will Deacon <will.deacon@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Hanjun Guo <hanjun.guo@linaro.org>,
Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>,
okaya@codeaurora.org, jiang.liu@linux.intel.com,
Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>,
robert.richter@caviumnetworks.com,
Marcin Wojtas <mw@semihalf.com>,
Liviu.Dudau@arm.com, wangyijing@huawei.com,
Suravee.Suthikulpanit@amd.com, msalter@redhat.com,
linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
linaro-acpi@lists.linaro.org, Jon Masters <jcm@redhat.com>
Subject: Re: [PATCH v2 2/4] PCI: Provide common functions for ECAM mapping
Date: Mon, 11 Apr 2016 17:24:20 -0700 [thread overview]
Message-ID: <570C4034.20105@caviumnetworks.com> (raw)
In-Reply-To: <1460414707-19153-3-git-send-email-jchandra@broadcom.com>
On 04/11/2016 03:45 PM, Jayachandran C wrote:
> Add config option PCI_GENERIC_ECAM and file drivers/pci/ecam.c to
> provide generic functions for accessing memory mapped PCI config space.
>
> The API is defined in drivers/pci/ecam.h and is written to replace the
> API in drivers/pci/host/pci-host-common.h. The file defines a new
> 'struct pci_config_window' to hold the information related to a PCI
> config area and its mapping. This structure is expected to be used as
> sysdata for controllers that have ECAM based mapping.
>
> Helper functions are provided to setup the mapping, free the mapping
> and to implement the map_bus method in 'struct pci_ops'
>
> Signed-off-by: Jayachandran C <jchandra@broadcom.com>
Tested-by: David Daney <david.daney@cavium.com>
> ---
> drivers/pci/Kconfig | 3 ++
> drivers/pci/Makefile | 2 +
> drivers/pci/ecam.c | 130 +++++++++++++++++++++++++++++++++++++++++++++++++++
> drivers/pci/ecam.h | 58 +++++++++++++++++++++++
I wonder if these files should go in drivers/pci/host ... I understand
that you still have to use them from drivers/pci/acpi though.
I will let others opine on this, but could you put the contents of
ecam.h into include/linux/pci.h along with the pci_generic_config_*()
declarations?
If you did that, the contents of ecam.c could go into
drivers/pci/access.c...
> 4 files changed, 193 insertions(+)
> create mode 100644 drivers/pci/ecam.c
> create mode 100644 drivers/pci/ecam.h
>
[...]
WARNING: multiple messages have this Message-ID (diff)
From: David Daney <ddaney@caviumnetworks.com>
To: Jayachandran C <jchandra@broadcom.com>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
Tomasz Nowicki <tn@semihalf.com>, <rafael@kernel.org>,
Arnd Bergmann <arnd@arndb.de>, Will Deacon <will.deacon@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Hanjun Guo <hanjun.guo@linaro.org>,
Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>,
<okaya@codeaurora.org>, <jiang.liu@linux.intel.com>,
Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>,
<robert.richter@caviumnetworks.com>,
Marcin Wojtas <mw@semihalf.com>, <Liviu.Dudau@arm.com>,
<wangyijing@huawei.com>, <Suravee.Suthikulpanit@amd.com>,
<msalter@redhat.com>, <linux-pci@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-acpi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linaro-acpi@lists.linaro.org>, Jon Masters <jcm@redhat.com>
Subject: Re: [PATCH v2 2/4] PCI: Provide common functions for ECAM mapping
Date: Mon, 11 Apr 2016 17:24:20 -0700 [thread overview]
Message-ID: <570C4034.20105@caviumnetworks.com> (raw)
In-Reply-To: <1460414707-19153-3-git-send-email-jchandra@broadcom.com>
On 04/11/2016 03:45 PM, Jayachandran C wrote:
> Add config option PCI_GENERIC_ECAM and file drivers/pci/ecam.c to
> provide generic functions for accessing memory mapped PCI config space.
>
> The API is defined in drivers/pci/ecam.h and is written to replace the
> API in drivers/pci/host/pci-host-common.h. The file defines a new
> 'struct pci_config_window' to hold the information related to a PCI
> config area and its mapping. This structure is expected to be used as
> sysdata for controllers that have ECAM based mapping.
>
> Helper functions are provided to setup the mapping, free the mapping
> and to implement the map_bus method in 'struct pci_ops'
>
> Signed-off-by: Jayachandran C <jchandra@broadcom.com>
Tested-by: David Daney <david.daney@cavium.com>
> ---
> drivers/pci/Kconfig | 3 ++
> drivers/pci/Makefile | 2 +
> drivers/pci/ecam.c | 130 +++++++++++++++++++++++++++++++++++++++++++++++++++
> drivers/pci/ecam.h | 58 +++++++++++++++++++++++
I wonder if these files should go in drivers/pci/host ... I understand
that you still have to use them from drivers/pci/acpi though.
I will let others opine on this, but could you put the contents of
ecam.h into include/linux/pci.h along with the pci_generic_config_*()
declarations?
If you did that, the contents of ecam.c could go into
drivers/pci/access.c...
> 4 files changed, 193 insertions(+)
> create mode 100644 drivers/pci/ecam.c
> create mode 100644 drivers/pci/ecam.h
>
[...]
WARNING: multiple messages have this Message-ID (diff)
From: ddaney@caviumnetworks.com (David Daney)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/4] PCI: Provide common functions for ECAM mapping
Date: Mon, 11 Apr 2016 17:24:20 -0700 [thread overview]
Message-ID: <570C4034.20105@caviumnetworks.com> (raw)
In-Reply-To: <1460414707-19153-3-git-send-email-jchandra@broadcom.com>
On 04/11/2016 03:45 PM, Jayachandran C wrote:
> Add config option PCI_GENERIC_ECAM and file drivers/pci/ecam.c to
> provide generic functions for accessing memory mapped PCI config space.
>
> The API is defined in drivers/pci/ecam.h and is written to replace the
> API in drivers/pci/host/pci-host-common.h. The file defines a new
> 'struct pci_config_window' to hold the information related to a PCI
> config area and its mapping. This structure is expected to be used as
> sysdata for controllers that have ECAM based mapping.
>
> Helper functions are provided to setup the mapping, free the mapping
> and to implement the map_bus method in 'struct pci_ops'
>
> Signed-off-by: Jayachandran C <jchandra@broadcom.com>
Tested-by: David Daney <david.daney@cavium.com>
> ---
> drivers/pci/Kconfig | 3 ++
> drivers/pci/Makefile | 2 +
> drivers/pci/ecam.c | 130 +++++++++++++++++++++++++++++++++++++++++++++++++++
> drivers/pci/ecam.h | 58 +++++++++++++++++++++++
I wonder if these files should go in drivers/pci/host ... I understand
that you still have to use them from drivers/pci/acpi though.
I will let others opine on this, but could you put the contents of
ecam.h into include/linux/pci.h along with the pci_generic_config_*()
declarations?
If you did that, the contents of ecam.c could go into
drivers/pci/access.c...
> 4 files changed, 193 insertions(+)
> create mode 100644 drivers/pci/ecam.c
> create mode 100644 drivers/pci/ecam.h
>
[...]
next prev parent reply other threads:[~2016-04-12 0:24 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-11 22:45 [PATCH v2 0/4] ACPI based PCI host driver with generic ECAM Jayachandran C
2016-04-11 22:45 ` Jayachandran C
2016-04-11 22:45 ` [PATCH v2 1/4] arm64: Prepare to use generic ACPI PCI implementation Jayachandran C
2016-04-11 22:45 ` Jayachandran C
2016-04-11 22:45 ` [PATCH v2 2/4] PCI: Provide common functions for ECAM mapping Jayachandran C
2016-04-11 22:45 ` Jayachandran C
2016-04-12 0:24 ` David Daney [this message]
2016-04-12 0:24 ` David Daney
2016-04-12 0:24 ` David Daney
2016-04-12 4:26 ` Jon Masters
2016-04-12 4:26 ` Jon Masters
2016-04-12 16:44 ` Lorenzo Pieralisi
2016-04-12 16:44 ` Lorenzo Pieralisi
2016-04-14 5:55 ` Jon Masters
2016-04-14 5:55 ` Jon Masters
2016-04-14 5:55 ` Jon Masters
2016-04-14 10:05 ` Lorenzo Pieralisi
2016-04-14 10:05 ` Lorenzo Pieralisi
2016-04-14 15:40 ` Jayachandran C
2016-04-14 15:40 ` Jayachandran C
2016-04-11 22:45 ` [PATCH v2 3/4] PCI: generic, thunder: update to use generic ECAM API Jayachandran C
2016-04-11 22:45 ` Jayachandran C
2016-04-12 0:34 ` David Daney
2016-04-12 0:34 ` David Daney
2016-04-12 0:34 ` David Daney
2016-04-14 14:15 ` Jayachandran C
2016-04-14 14:15 ` Jayachandran C
2016-04-11 22:45 ` [PATCH v2 4/4] ACPI: PCI: Add generic PCI host controller Jayachandran C
2016-04-11 22:45 ` Jayachandran C
2016-04-12 1:38 ` kbuild test robot
2016-04-12 1:38 ` kbuild test robot
2016-04-12 1:38 ` kbuild test robot
2016-04-14 15:53 ` Sinan Kaya
2016-04-14 15:53 ` Sinan Kaya
2016-04-14 15:58 ` Sinan Kaya
2016-04-14 15:58 ` Sinan Kaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570C4034.20105@caviumnetworks.com \
--to=ddaney@caviumnetworks.com \
--cc=Liviu.Dudau@arm.com \
--cc=Lorenzo.Pieralisi@arm.com \
--cc=Stefano.Stabellini@eu.citrix.com \
--cc=Suravee.Suthikulpanit@amd.com \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=hanjun.guo@linaro.org \
--cc=helgaas@kernel.org \
--cc=jchandra@broadcom.com \
--cc=jcm@redhat.com \
--cc=jiang.liu@linux.intel.com \
--cc=linaro-acpi@lists.linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=msalter@redhat.com \
--cc=mw@semihalf.com \
--cc=okaya@codeaurora.org \
--cc=rafael@kernel.org \
--cc=robert.richter@caviumnetworks.com \
--cc=tn@semihalf.com \
--cc=wangyijing@huawei.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.