All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] xfs: group quota is still enforced if mount v5 xfs with gqnoenforce and pqnoenforce
@ 2016-04-13 18:22 ` Zorro Lang
  0 siblings, 0 replies; 4+ messages in thread
From: Zorro Lang @ 2016-04-13 18:22 UTC (permalink / raw)
  To: xfs; +Cc: linux-fsdevel, sandeen, Zorro Lang

This's a regression bug caused by:

  2e74af0 xfs: convert mount option parsing to tokens

xfstests xfs/299 can reproduce this bug, it will fail when do
gpnoenforce test, the error output as below(diff with 299.out):

 *** push past the soft block limit
  [ROOT] 0 0 0 00 [--------] 3 0 0 00 [--------] 0 0 0 00 [--------]
  -[NAME] 140 100 500 00 [--------] 4 4 10 00 [--------] 0 0 0 00 [--------]
  +[NAME] 140 100 500 00 [7 days] 4 4 10 00 [--------] 0 0 0 00 [--------]

 *** push past the hard inode limit (expect EDQUOT)
  [ROOT] 0 0 0 00 [--------] 3 0 0 00 [--------] 0 0 0 00 [--------]
  -[NAME] 140 100 500 00 [--------] 16 4 10 00 [--none--] 0 0 0 00 [--------]
  +[NAME] 140 100 500 00 [7 days] 10 4 10 00 [7 days] 0 0 0 00 [--------]

 *** push past the hard block limit (expect EDQUOT)
  [ROOT] 0 0 0 00 [--------] 3 0 0 00 [--------] 0 0 0 00 [--------]
  -[NAME] 540 100 500 00 [--none--] 16 4 10 00 [--none--] 0 0 0 00 [--------]
  +[NAME] 500 100 500 00 [7 days] 10 4 10 00 [7 days] 0 0 0 00 [--------]

It shows that group quota is still enforced. But this bug only can
be reproduced when mount v5 xfs with gqnoenforce and pqnoenforce
options. The reason as I found is a missed "break" in xfs_parseargs()
function.

After deal with "pqnoenforce", it should break. But the code keep
running into "gquota/grpquota" lines, and make gquota enforced.

Signed-off-by: Zorro Lang <zlang@redhat.com>
---

Hi,

This's a tiny bug(only one line patch). But it's belong to
regression bug and take me a few hours to find the problem.
So I hope it can be fixed:)

Thanks,
Zorro

 fs/xfs/xfs_super.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
index 187e14b..f3c0ffc 100644
--- a/fs/xfs/xfs_super.c
+++ b/fs/xfs/xfs_super.c
@@ -350,6 +350,7 @@ xfs_parseargs(
 		case Opt_pqnoenforce:
 			mp->m_qflags |= (XFS_PQUOTA_ACCT | XFS_PQUOTA_ACTIVE);
 			mp->m_qflags &= ~XFS_PQUOTA_ENFD;
+			break;
 		case Opt_gquota:
 		case Opt_grpquota:
 			mp->m_qflags |= (XFS_GQUOTA_ACCT | XFS_GQUOTA_ACTIVE |
-- 
2.5.5


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH] xfs: group quota is still enforced if mount v5 xfs with gqnoenforce and pqnoenforce
@ 2016-04-13 18:22 ` Zorro Lang
  0 siblings, 0 replies; 4+ messages in thread
From: Zorro Lang @ 2016-04-13 18:22 UTC (permalink / raw)
  To: xfs; +Cc: linux-fsdevel, sandeen, Zorro Lang

This's a regression bug caused by:

  2e74af0 xfs: convert mount option parsing to tokens

xfstests xfs/299 can reproduce this bug, it will fail when do
gpnoenforce test, the error output as below(diff with 299.out):

 *** push past the soft block limit
  [ROOT] 0 0 0 00 [--------] 3 0 0 00 [--------] 0 0 0 00 [--------]
  -[NAME] 140 100 500 00 [--------] 4 4 10 00 [--------] 0 0 0 00 [--------]
  +[NAME] 140 100 500 00 [7 days] 4 4 10 00 [--------] 0 0 0 00 [--------]

 *** push past the hard inode limit (expect EDQUOT)
  [ROOT] 0 0 0 00 [--------] 3 0 0 00 [--------] 0 0 0 00 [--------]
  -[NAME] 140 100 500 00 [--------] 16 4 10 00 [--none--] 0 0 0 00 [--------]
  +[NAME] 140 100 500 00 [7 days] 10 4 10 00 [7 days] 0 0 0 00 [--------]

 *** push past the hard block limit (expect EDQUOT)
  [ROOT] 0 0 0 00 [--------] 3 0 0 00 [--------] 0 0 0 00 [--------]
  -[NAME] 540 100 500 00 [--none--] 16 4 10 00 [--none--] 0 0 0 00 [--------]
  +[NAME] 500 100 500 00 [7 days] 10 4 10 00 [7 days] 0 0 0 00 [--------]

It shows that group quota is still enforced. But this bug only can
be reproduced when mount v5 xfs with gqnoenforce and pqnoenforce
options. The reason as I found is a missed "break" in xfs_parseargs()
function.

After deal with "pqnoenforce", it should break. But the code keep
running into "gquota/grpquota" lines, and make gquota enforced.

Signed-off-by: Zorro Lang <zlang@redhat.com>
---

Hi,

This's a tiny bug(only one line patch). But it's belong to
regression bug and take me a few hours to find the problem.
So I hope it can be fixed:)

Thanks,
Zorro

 fs/xfs/xfs_super.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
index 187e14b..f3c0ffc 100644
--- a/fs/xfs/xfs_super.c
+++ b/fs/xfs/xfs_super.c
@@ -350,6 +350,7 @@ xfs_parseargs(
 		case Opt_pqnoenforce:
 			mp->m_qflags |= (XFS_PQUOTA_ACCT | XFS_PQUOTA_ACTIVE);
 			mp->m_qflags &= ~XFS_PQUOTA_ENFD;
+			break;
 		case Opt_gquota:
 		case Opt_grpquota:
 			mp->m_qflags |= (XFS_GQUOTA_ACCT | XFS_GQUOTA_ACTIVE |
-- 
2.5.5

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] xfs: group quota is still enforced if mount v5 xfs with gqnoenforce and pqnoenforce
  2016-04-13 18:22 ` Zorro Lang
  (?)
@ 2016-04-13 18:30 ` Eric Sandeen
  2016-04-13 19:07   ` Zorro Lang
  -1 siblings, 1 reply; 4+ messages in thread
From: Eric Sandeen @ 2016-04-13 18:30 UTC (permalink / raw)
  To: xfs

This looks fine, but I think Eryu already sent this patch on 3/31:

[PATCH] xfs: add missing break in xfs_parseargs()

-Eric

On 4/13/16 1:22 PM, Zorro Lang wrote:
> This's a regression bug caused by:
> 
>   2e74af0 xfs: convert mount option parsing to tokens
> 
> xfstests xfs/299 can reproduce this bug, it will fail when do
> gpnoenforce test, the error output as below(diff with 299.out):
> 
>  *** push past the soft block limit
>   [ROOT] 0 0 0 00 [--------] 3 0 0 00 [--------] 0 0 0 00 [--------]
>   -[NAME] 140 100 500 00 [--------] 4 4 10 00 [--------] 0 0 0 00 [--------]
>   +[NAME] 140 100 500 00 [7 days] 4 4 10 00 [--------] 0 0 0 00 [--------]
> 
>  *** push past the hard inode limit (expect EDQUOT)
>   [ROOT] 0 0 0 00 [--------] 3 0 0 00 [--------] 0 0 0 00 [--------]
>   -[NAME] 140 100 500 00 [--------] 16 4 10 00 [--none--] 0 0 0 00 [--------]
>   +[NAME] 140 100 500 00 [7 days] 10 4 10 00 [7 days] 0 0 0 00 [--------]
> 
>  *** push past the hard block limit (expect EDQUOT)
>   [ROOT] 0 0 0 00 [--------] 3 0 0 00 [--------] 0 0 0 00 [--------]
>   -[NAME] 540 100 500 00 [--none--] 16 4 10 00 [--none--] 0 0 0 00 [--------]
>   +[NAME] 500 100 500 00 [7 days] 10 4 10 00 [7 days] 0 0 0 00 [--------]
> 
> It shows that group quota is still enforced. But this bug only can
> be reproduced when mount v5 xfs with gqnoenforce and pqnoenforce
> options. The reason as I found is a missed "break" in xfs_parseargs()
> function.
> 
> After deal with "pqnoenforce", it should break. But the code keep
> running into "gquota/grpquota" lines, and make gquota enforced.
> 
> Signed-off-by: Zorro Lang <zlang@redhat.com>
> ---
> 
> Hi,
> 
> This's a tiny bug(only one line patch). But it's belong to
> regression bug and take me a few hours to find the problem.
> So I hope it can be fixed:)
> 
> Thanks,
> Zorro
> 
>  fs/xfs/xfs_super.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
> index 187e14b..f3c0ffc 100644
> --- a/fs/xfs/xfs_super.c
> +++ b/fs/xfs/xfs_super.c
> @@ -350,6 +350,7 @@ xfs_parseargs(
>  		case Opt_pqnoenforce:
>  			mp->m_qflags |= (XFS_PQUOTA_ACCT | XFS_PQUOTA_ACTIVE);
>  			mp->m_qflags &= ~XFS_PQUOTA_ENFD;
> +			break;
>  		case Opt_gquota:
>  		case Opt_grpquota:
>  			mp->m_qflags |= (XFS_GQUOTA_ACCT | XFS_GQUOTA_ACTIVE |
> 

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] xfs: group quota is still enforced if mount v5 xfs with gqnoenforce and pqnoenforce
  2016-04-13 18:30 ` Eric Sandeen
@ 2016-04-13 19:07   ` Zorro Lang
  0 siblings, 0 replies; 4+ messages in thread
From: Zorro Lang @ 2016-04-13 19:07 UTC (permalink / raw)
  To: Eric Sandeen; +Cc: xfs


[-- Attachment #1.1: Type: text/plain, Size: 2975 bytes --]

2016年4月14日 02:30，"Eric Sandeen" <sandeen@sandeen.net>写道：
>
> This looks fine, but I think Eryu already sent this patch on 3/31:
>
> [PATCH] xfs: add missing break in xfs_parseargs()

Hi,

Sorry for this duplicate patch... I think I missed that patch email from
mail list. Please ignore this DUP patch.

Thanks,
Zorro

>
> -Eric
>
> On 4/13/16 1:22 PM, Zorro Lang wrote:
> > This's a regression bug caused by:
> >
> >   2e74af0 xfs: convert mount option parsing to tokens
> >
> > xfstests xfs/299 can reproduce this bug, it will fail when do
> > gpnoenforce test, the error output as below(diff with 299.out):
> >
> >  *** push past the soft block limit
> >   [ROOT] 0 0 0 00 [--------] 3 0 0 00 [--------] 0 0 0 00 [--------]
> >   -[NAME] 140 100 500 00 [--------] 4 4 10 00 [--------] 0 0 0 00
[--------]
> >   +[NAME] 140 100 500 00 [7 days] 4 4 10 00 [--------] 0 0 0 00
[--------]
> >
> >  *** push past the hard inode limit (expect EDQUOT)
> >   [ROOT] 0 0 0 00 [--------] 3 0 0 00 [--------] 0 0 0 00 [--------]
> >   -[NAME] 140 100 500 00 [--------] 16 4 10 00 [--none--] 0 0 0 00
[--------]
> >   +[NAME] 140 100 500 00 [7 days] 10 4 10 00 [7 days] 0 0 0 00
[--------]
> >
> >  *** push past the hard block limit (expect EDQUOT)
> >   [ROOT] 0 0 0 00 [--------] 3 0 0 00 [--------] 0 0 0 00 [--------]
> >   -[NAME] 540 100 500 00 [--none--] 16 4 10 00 [--none--] 0 0 0 00
[--------]
> >   +[NAME] 500 100 500 00 [7 days] 10 4 10 00 [7 days] 0 0 0 00
[--------]
> >
> > It shows that group quota is still enforced. But this bug only can
> > be reproduced when mount v5 xfs with gqnoenforce and pqnoenforce
> > options. The reason as I found is a missed "break" in xfs_parseargs()
> > function.
> >
> > After deal with "pqnoenforce", it should break. But the code keep
> > running into "gquota/grpquota" lines, and make gquota enforced.
> >
> > Signed-off-by: Zorro Lang <zlang@redhat.com>
> > ---
> >
> > Hi,
> >
> > This's a tiny bug(only one line patch). But it's belong to
> > regression bug and take me a few hours to find the problem.
> > So I hope it can be fixed:)
> >
> > Thanks,
> > Zorro
> >
> >  fs/xfs/xfs_super.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
> > index 187e14b..f3c0ffc 100644
> > --- a/fs/xfs/xfs_super.c
> > +++ b/fs/xfs/xfs_super.c
> > @@ -350,6 +350,7 @@ xfs_parseargs(
> >               case Opt_pqnoenforce:
> >                       mp->m_qflags |= (XFS_PQUOTA_ACCT |
XFS_PQUOTA_ACTIVE);
> >                       mp->m_qflags &= ~XFS_PQUOTA_ENFD;
> > +                     break;
> >               case Opt_gquota:
> >               case Opt_grpquota:
> >                       mp->m_qflags |= (XFS_GQUOTA_ACCT |
XFS_GQUOTA_ACTIVE |
> >
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs

[-- Attachment #1.2: Type: text/html, Size: 4069 bytes --]

[-- Attachment #2: Type: text/plain, Size: 121 bytes --]

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-04-13 19:07 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-13 18:22 [PATCH] xfs: group quota is still enforced if mount v5 xfs with gqnoenforce and pqnoenforce Zorro Lang
2016-04-13 18:22 ` Zorro Lang
2016-04-13 18:30 ` Eric Sandeen
2016-04-13 19:07   ` Zorro Lang

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.