From: Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> To: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> Cc: linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Giuseppe Barba <giuseppe.barba-qxv4g6HH51o@public.gmane.org>, Denis Ciocca <denis.ciocca-qxv4g6HH51o@public.gmane.org> Subject: Re: [PATCH 4/4 v5] iio: st_sensors: support open drain mode Date: Sun, 17 Apr 2016 12:27:49 +0100 [thread overview] Message-ID: <57137335.4060605@kernel.org> (raw) In-Reply-To: <20160414170901.GA9172@rob-hp-laptop> On 14/04/16 18:09, Rob Herring wrote: > On Thu, Apr 14, 2016 at 10:45:21AM +0200, Linus Walleij wrote: >> Some types of ST Sensors can be connected to the same IRQ line >> as other peripherals using open drain. Add a device tree binding >> and a sensor data property to flip the right bit in the interrupt >> control register to enable open drain mode on the INT line. >> >> If the line is set to be open drain, also tag on IRQF_SHARED >> to the IRQ flags when requesting the interrupt, as the whole >> point of using open drain interrupt lines is to share them with >> more than one peripheral (wire-or). >> >> Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org >> Cc: Giuseppe Barba <giuseppe.barba-qxv4g6HH51o@public.gmane.org> >> Cc: Denis Ciocca <denis.ciocca-qxv4g6HH51o@public.gmane.org> >> Cc: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> >> Signed-off-by: Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> >> --- >> ChangeLog v4->v5: >> - Rename DT bool property int-pin-open-drain to drive-mode-open-drain >> reusing the pin control subsystem binding. >> ChangeLog v3->v4: >> - Rename DT bool property st,int-pin-open-drain to int-pin-open-drain >> - Rob Herring ACKed st,int-pin-open-drain but not including his ACK >> on this even though it's close >> ChangeLog v2->v3: >> - Rebase on top of the patches fixing the other issues (handling >> IRQ status check and channel reading bug). >> ChangeLog v1->v2: >> - Rebased to fit the new patch order. >> --- >> Documentation/devicetree/bindings/iio/st-sensors.txt | 4 ++++ > > Acked-by: Rob Herring <rob-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Applied to the togreg branch of iio.git - initially pushed out as testing for the autobuilders to play with it. Thanks, Jonathan > >> drivers/iio/accel/st_accel_core.c | 8 ++++++++ >> drivers/iio/common/st_sensors/st_sensors_core.c | 20 ++++++++++++++++++++ >> drivers/iio/common/st_sensors/st_sensors_trigger.c | 13 +++++++++++++ >> drivers/iio/pressure/st_pressure_core.c | 8 ++++++++ >> include/linux/iio/common/st_sensors.h | 6 ++++++ >> include/linux/platform_data/st_sensors_pdata.h | 2 ++ >> 7 files changed, 61 insertions(+)
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <jic23@kernel.org> To: Rob Herring <robh@kernel.org>, Linus Walleij <linus.walleij@linaro.org> Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, Giuseppe Barba <giuseppe.barba@st.com>, Denis Ciocca <denis.ciocca@st.com> Subject: Re: [PATCH 4/4 v5] iio: st_sensors: support open drain mode Date: Sun, 17 Apr 2016 12:27:49 +0100 [thread overview] Message-ID: <57137335.4060605@kernel.org> (raw) In-Reply-To: <20160414170901.GA9172@rob-hp-laptop> On 14/04/16 18:09, Rob Herring wrote: > On Thu, Apr 14, 2016 at 10:45:21AM +0200, Linus Walleij wrote: >> Some types of ST Sensors can be connected to the same IRQ line >> as other peripherals using open drain. Add a device tree binding >> and a sensor data property to flip the right bit in the interrupt >> control register to enable open drain mode on the INT line. >> >> If the line is set to be open drain, also tag on IRQF_SHARED >> to the IRQ flags when requesting the interrupt, as the whole >> point of using open drain interrupt lines is to share them with >> more than one peripheral (wire-or). >> >> Cc: devicetree@vger.kernel.org >> Cc: Giuseppe Barba <giuseppe.barba@st.com> >> Cc: Denis Ciocca <denis.ciocca@st.com> >> Cc: Rob Herring <robh@kernel.org> >> Signed-off-by: Linus Walleij <linus.walleij@linaro.org> >> --- >> ChangeLog v4->v5: >> - Rename DT bool property int-pin-open-drain to drive-mode-open-drain >> reusing the pin control subsystem binding. >> ChangeLog v3->v4: >> - Rename DT bool property st,int-pin-open-drain to int-pin-open-drain >> - Rob Herring ACKed st,int-pin-open-drain but not including his ACK >> on this even though it's close >> ChangeLog v2->v3: >> - Rebase on top of the patches fixing the other issues (handling >> IRQ status check and channel reading bug). >> ChangeLog v1->v2: >> - Rebased to fit the new patch order. >> --- >> Documentation/devicetree/bindings/iio/st-sensors.txt | 4 ++++ > > Acked-by: Rob Herring <rob@kernel.org> Applied to the togreg branch of iio.git - initially pushed out as testing for the autobuilders to play with it. Thanks, Jonathan > >> drivers/iio/accel/st_accel_core.c | 8 ++++++++ >> drivers/iio/common/st_sensors/st_sensors_core.c | 20 ++++++++++++++++++++ >> drivers/iio/common/st_sensors/st_sensors_trigger.c | 13 +++++++++++++ >> drivers/iio/pressure/st_pressure_core.c | 8 ++++++++ >> include/linux/iio/common/st_sensors.h | 6 ++++++ >> include/linux/platform_data/st_sensors_pdata.h | 2 ++ >> 7 files changed, 61 insertions(+)
next prev parent reply other threads:[~2016-04-17 11:27 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-04-14 8:45 [PATCH 4/4 v5] iio: st_sensors: support open drain mode Linus Walleij 2016-04-14 8:45 ` Linus Walleij [not found] ` <1460623521-8755-1-git-send-email-linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2016-04-14 17:09 ` Rob Herring 2016-04-14 17:09 ` Rob Herring 2016-04-17 11:27 ` Jonathan Cameron [this message] 2016-04-17 11:27 ` Jonathan Cameron
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=57137335.4060605@kernel.org \ --to=jic23-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \ --cc=denis.ciocca-qxv4g6HH51o@public.gmane.org \ --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=giuseppe.barba-qxv4g6HH51o@public.gmane.org \ --cc=linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \ --cc=linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.