All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915/gen9: implement WaEnableSamplerGPGPUPreemptionSupport
@ 2016-04-19 14:45 tim.gore
  2016-04-19 15:54 ` ✓ Fi.CI.BAT: success for drm/i915/gen9: implement WaEnableSamplerGPGPUPreemptionSupport (rev4) Patchwork
  2016-04-19 16:17 ` [PATCH] drm/i915/gen9: implement WaEnableSamplerGPGPUPreemptionSupport Dave Gordon
  0 siblings, 2 replies; 4+ messages in thread
From: tim.gore @ 2016-04-19 14:45 UTC (permalink / raw)
  To: intel-gfx

From: Tim Gore <tim.gore@intel.com>

WaEnableSamplerGPGPUPreemptionSupport fixes a problem
related to mid thread pre-emption.

Signed-off-by: Tim Gore <tim.gore@intel.com>
---
 drivers/gpu/drm/i915/i915_reg.h         | 1 +
 drivers/gpu/drm/i915/intel_ringbuffer.c | 7 ++++---
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index 9464ba3..2982470b 100644
--- a/drivers/gpu/drm/i915/i915_reg.h
+++ b/drivers/gpu/drm/i915/i915_reg.h
@@ -7162,6 +7162,7 @@ enum skl_disp_power_wells {
 
 #define GEN9_HALF_SLICE_CHICKEN7	_MMIO(0xe194)
 #define   GEN9_ENABLE_YV12_BUGFIX	(1<<4)
+#define   GEN9_ENABLE_GPGPU_PREEMPTION	(1<<2)
 
 /* Audio */
 #define G4X_AUD_VID_DID			_MMIO(dev_priv->info.display_mmio_offset + 0x62020)
diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c
index 0d24494..444d30a 100644
--- a/drivers/gpu/drm/i915/intel_ringbuffer.c
+++ b/drivers/gpu/drm/i915/intel_ringbuffer.c
@@ -959,9 +959,10 @@ static int gen9_init_workarounds(struct intel_engine_cs *engine)
 	}
 
 	/* WaEnableYV12BugFixInHalfSliceChicken7:skl,bxt */
-	if (IS_SKL_REVID(dev, SKL_REVID_C0, REVID_FOREVER) || IS_BROXTON(dev))
-		WA_SET_BIT_MASKED(GEN9_HALF_SLICE_CHICKEN7,
-				  GEN9_ENABLE_YV12_BUGFIX);
+	/* WaEnableSamplerGPGPUPreemptionSupport:skl,bxt */
+	WA_SET_BIT_MASKED(GEN9_HALF_SLICE_CHICKEN7,
+			  GEN9_ENABLE_YV12_BUGFIX |
+			  GEN9_ENABLE_GPGPU_PREEMPTION);
 
 	/* Wa4x4STCOptimizationDisable:skl,bxt */
 	/* WaDisablePartialResolveInVc:skl,bxt */
-- 
1.9.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915/gen9: implement WaEnableSamplerGPGPUPreemptionSupport (rev4)
  2016-04-19 14:45 [PATCH] drm/i915/gen9: implement WaEnableSamplerGPGPUPreemptionSupport tim.gore
@ 2016-04-19 15:54 ` Patchwork
  2016-04-20  9:03   ` Tvrtko Ursulin
  2016-04-19 16:17 ` [PATCH] drm/i915/gen9: implement WaEnableSamplerGPGPUPreemptionSupport Dave Gordon
  1 sibling, 1 reply; 4+ messages in thread
From: Patchwork @ 2016-04-19 15:54 UTC (permalink / raw)
  To: tim.gore; +Cc: intel-gfx

== Series Details ==

Series: drm/i915/gen9: implement WaEnableSamplerGPGPUPreemptionSupport (rev4)
URL   : https://patchwork.freedesktop.org/series/5367/
State : success

== Summary ==

Series 5367v4 drm/i915/gen9: implement WaEnableSamplerGPGPUPreemptionSupport
http://patchwork.freedesktop.org/api/1.0/series/5367/revisions/4/mbox/

Test kms_force_connector_basic:
        Subgroup force-load-detect:
                pass       -> SKIP       (ivb-t430s)

bdw-nuci7        total:192  pass:180  dwarn:0   dfail:0   fail:0   skip:12 
bdw-ultra        total:192  pass:169  dwarn:0   dfail:0   fail:0   skip:23 
bsw-nuc-2        total:191  pass:152  dwarn:0   dfail:0   fail:0   skip:39 
byt-nuc          total:191  pass:153  dwarn:0   dfail:0   fail:0   skip:38 
hsw-brixbox      total:192  pass:168  dwarn:0   dfail:0   fail:0   skip:24 
hsw-gt2          total:192  pass:173  dwarn:0   dfail:0   fail:0   skip:19 
ilk-hp8440p      total:192  pass:135  dwarn:0   dfail:0   fail:0   skip:57 
ivb-t430s        total:192  pass:163  dwarn:0   dfail:0   fail:0   skip:29 
skl-i7k-2        total:192  pass:167  dwarn:0   dfail:0   fail:0   skip:25 
skl-nuci5        total:192  pass:181  dwarn:0   dfail:0   fail:0   skip:11 
snb-dellxps      total:192  pass:154  dwarn:0   dfail:0   fail:0   skip:38 
snb-x220t        total:192  pass:154  dwarn:0   dfail:0   fail:1   skip:37 

Results at /archive/results/CI_IGT_test/Patchwork_1945/

d029fc773a2f0e8a3149626d053ab8a2e7669b11 drm-intel-nightly: 2016y-04m-19d-14h-58m-08s UTC integration manifest
de5007c drm/i915/gen9: implement WaEnableSamplerGPGPUPreemptionSupport

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] drm/i915/gen9: implement WaEnableSamplerGPGPUPreemptionSupport
  2016-04-19 14:45 [PATCH] drm/i915/gen9: implement WaEnableSamplerGPGPUPreemptionSupport tim.gore
  2016-04-19 15:54 ` ✓ Fi.CI.BAT: success for drm/i915/gen9: implement WaEnableSamplerGPGPUPreemptionSupport (rev4) Patchwork
@ 2016-04-19 16:17 ` Dave Gordon
  1 sibling, 0 replies; 4+ messages in thread
From: Dave Gordon @ 2016-04-19 16:17 UTC (permalink / raw)
  To: tim.gore, intel-gfx

On 19/04/16 15:45, tim.gore@intel.com wrote:
> From: Tim Gore <tim.gore@intel.com>
>
> WaEnableSamplerGPGPUPreemptionSupport fixes a problem
> related to mid thread pre-emption.
>
> Signed-off-by: Tim Gore <tim.gore@intel.com>

Reviewed-by: Dave Gordon <david.s.gordon@intel.com>

> ---
>   drivers/gpu/drm/i915/i915_reg.h         | 1 +
>   drivers/gpu/drm/i915/intel_ringbuffer.c | 7 ++++---
>   2 files changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> index 9464ba3..2982470b 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -7162,6 +7162,7 @@ enum skl_disp_power_wells {
>
>   #define GEN9_HALF_SLICE_CHICKEN7	_MMIO(0xe194)
>   #define   GEN9_ENABLE_YV12_BUGFIX	(1<<4)
> +#define   GEN9_ENABLE_GPGPU_PREEMPTION	(1<<2)
>
>   /* Audio */
>   #define G4X_AUD_VID_DID			_MMIO(dev_priv->info.display_mmio_offset + 0x62020)
> diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c
> index 0d24494..444d30a 100644
> --- a/drivers/gpu/drm/i915/intel_ringbuffer.c
> +++ b/drivers/gpu/drm/i915/intel_ringbuffer.c
> @@ -959,9 +959,10 @@ static int gen9_init_workarounds(struct intel_engine_cs *engine)
>   	}
>
>   	/* WaEnableYV12BugFixInHalfSliceChicken7:skl,bxt */
> -	if (IS_SKL_REVID(dev, SKL_REVID_C0, REVID_FOREVER) || IS_BROXTON(dev))
> -		WA_SET_BIT_MASKED(GEN9_HALF_SLICE_CHICKEN7,
> -				  GEN9_ENABLE_YV12_BUGFIX);
> +	/* WaEnableSamplerGPGPUPreemptionSupport:skl,bxt */
> +	WA_SET_BIT_MASKED(GEN9_HALF_SLICE_CHICKEN7,
> +			  GEN9_ENABLE_YV12_BUGFIX |
> +			  GEN9_ENABLE_GPGPU_PREEMPTION);
>
>   	/* Wa4x4STCOptimizationDisable:skl,bxt */
>   	/* WaDisablePartialResolveInVc:skl,bxt */
>

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: ✓ Fi.CI.BAT: success for drm/i915/gen9: implement WaEnableSamplerGPGPUPreemptionSupport (rev4)
  2016-04-19 15:54 ` ✓ Fi.CI.BAT: success for drm/i915/gen9: implement WaEnableSamplerGPGPUPreemptionSupport (rev4) Patchwork
@ 2016-04-20  9:03   ` Tvrtko Ursulin
  0 siblings, 0 replies; 4+ messages in thread
From: Tvrtko Ursulin @ 2016-04-20  9:03 UTC (permalink / raw)
  To: intel-gfx, tim.gore


On 19/04/16 16:54, Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915/gen9: implement WaEnableSamplerGPGPUPreemptionSupport (rev4)
> URL   : https://patchwork.freedesktop.org/series/5367/
> State : success
>
> == Summary ==
>
> Series 5367v4 drm/i915/gen9: implement WaEnableSamplerGPGPUPreemptionSupport
> http://patchwork.freedesktop.org/api/1.0/series/5367/revisions/4/mbox/
>
> Test kms_force_connector_basic:
>          Subgroup force-load-detect:
>                  pass       -> SKIP       (ivb-t430s)
>
> bdw-nuci7        total:192  pass:180  dwarn:0   dfail:0   fail:0   skip:12
> bdw-ultra        total:192  pass:169  dwarn:0   dfail:0   fail:0   skip:23
> bsw-nuc-2        total:191  pass:152  dwarn:0   dfail:0   fail:0   skip:39
> byt-nuc          total:191  pass:153  dwarn:0   dfail:0   fail:0   skip:38
> hsw-brixbox      total:192  pass:168  dwarn:0   dfail:0   fail:0   skip:24
> hsw-gt2          total:192  pass:173  dwarn:0   dfail:0   fail:0   skip:19
> ilk-hp8440p      total:192  pass:135  dwarn:0   dfail:0   fail:0   skip:57
> ivb-t430s        total:192  pass:163  dwarn:0   dfail:0   fail:0   skip:29
> skl-i7k-2        total:192  pass:167  dwarn:0   dfail:0   fail:0   skip:25
> skl-nuci5        total:192  pass:181  dwarn:0   dfail:0   fail:0   skip:11
> snb-dellxps      total:192  pass:154  dwarn:0   dfail:0   fail:0   skip:38
> snb-x220t        total:192  pass:154  dwarn:0   dfail:0   fail:1   skip:37
>
> Results at /archive/results/CI_IGT_test/Patchwork_1945/
>
> d029fc773a2f0e8a3149626d053ab8a2e7669b11 drm-intel-nightly: 2016y-04m-19d-14h-58m-08s UTC integration manifest
> de5007c drm/i915/gen9: implement WaEnableSamplerGPGPUPreemptionSupport

Merged, thanks for the patch and review!

Regards,

Tvrtko

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-04-20  9:03 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-19 14:45 [PATCH] drm/i915/gen9: implement WaEnableSamplerGPGPUPreemptionSupport tim.gore
2016-04-19 15:54 ` ✓ Fi.CI.BAT: success for drm/i915/gen9: implement WaEnableSamplerGPGPUPreemptionSupport (rev4) Patchwork
2016-04-20  9:03   ` Tvrtko Ursulin
2016-04-19 16:17 ` [PATCH] drm/i915/gen9: implement WaEnableSamplerGPGPUPreemptionSupport Dave Gordon

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.