* [PATCH] tag.c: remove extern keyword from function definition
@ 2016-04-20 15:34 Ramsay Jones
2016-04-20 15:39 ` Santiago Torres
0 siblings, 1 reply; 2+ messages in thread
From: Ramsay Jones @ 2016-04-20 15:34 UTC (permalink / raw)
To: santiago; +Cc: Junio C Hamano, GIT Mailing-list
Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---
Hi Santiago,
If you need to re-roll your 'st/verify-tag' branch, could you
please squash this into the relevant patch (commit c5213b40,
"verify-tag: move tag verification code to tag.c", 19-04-2016).
Although not actually an error, it is very unusual for an extern
keyword to be used on a function definition (it seems to be getting
quite unusual on a function declaration these days!), which causes
sparse to issue a warning.
Thanks!
ATB,
Ramsay Jones
tag.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tag.c b/tag.c
index ace619a..93c6ae6 100644
--- a/tag.c
+++ b/tag.c
@@ -30,7 +30,7 @@ static int run_gpg_verify(const char *buf, unsigned long size, unsigned flags)
return ret;
}
-extern int gpg_verify_tag(const unsigned char *sha1,
+int gpg_verify_tag(const unsigned char *sha1,
const char *name_to_report, unsigned flags)
{
enum object_type type;
--
2.8.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] tag.c: remove extern keyword from function definition
2016-04-20 15:34 [PATCH] tag.c: remove extern keyword from function definition Ramsay Jones
@ 2016-04-20 15:39 ` Santiago Torres
0 siblings, 0 replies; 2+ messages in thread
From: Santiago Torres @ 2016-04-20 15:39 UTC (permalink / raw)
To: Ramsay Jones; +Cc: Junio C Hamano, GIT Mailing-list
On Wed, Apr 20, 2016 at 04:34:25PM +0100, Ramsay Jones wrote:
>
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
>
> Hi Santiago,
>
> If you need to re-roll your 'st/verify-tag' branch, could you
> please squash this into the relevant patch (commit c5213b40,
> "verify-tag: move tag verification code to tag.c", 19-04-2016).
>
> Although not actually an error, it is very unusual for an extern
> keyword to be used on a function definition (it seems to be getting
> quite unusual on a function declaration these days!), which causes
> sparse to issue a warning.
Oh sure! I'm waiting to see if there are more reviews regarding this and
I'll re-roll. It's defintely unecessary to have the extern keyword
there.
Thanks for pointing it out!
-Santiago.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-04-20 15:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-20 15:34 [PATCH] tag.c: remove extern keyword from function definition Ramsay Jones
2016-04-20 15:39 ` Santiago Torres
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.