From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: Jisheng Zhang <jszhang@marvell.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: mika.westerberg@linux.intel.com, wsa@the-dreams.de,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/4] i2c: designware-platdrv: fix unbalanced clk enable and prepare
Date: Thu, 21 Apr 2016 10:39:50 +0300 [thread overview]
Message-ID: <571883C6.3010404@linux.intel.com> (raw)
In-Reply-To: <20160421104022.2d6549a9@xhacker>
On 04/21/2016 05:40 AM, Jisheng Zhang wrote:
> Dear Jarkko, Andy,
>
> On Wed, 20 Apr 2016 17:16:00 +0300 Andy Shevchenko wrote:
>
>> On Wed, 2016-04-20 at 15:55 +0300, Jarkko Nikula wrote:
>>> I see Andy's 1cb715ca4694 ("i2c-designware: move to managed functions
>>> (devm_*)") removed it but at quick look drivers/clk/clk-devres.c:
>>> devm_clk_release() calls only clk_put and I don't see disable is done
>>> down the path.
>>
>> The following is a mistake of the mentioned patch.
>> - clk_disable_unprepare(dev->clk);
>>
>> I did at the same mistake in dw_dmac driver which had been fixed later
>> in the commit 8be4f523b480 ("dmaengine: dw: fix regression in dw_probe()
>> function").
>>
>
> As Andy pointed out, managed devm_clk_get can only automatically put clk
> but doesn't unprepare and disable the clk
>
Ok, then it makes sense to move this fix first in the series and queue
for stable v4.5+. Then another from you, Andy or me for kernels before
b33af11de236 ("i2c: designware: Do not require clock when SSCN and FFCN
are provided") that introduced the i2c_dw_plat_prepare_clk().
--
Jarkko
WARNING: multiple messages have this Message-ID (diff)
From: jarkko.nikula@linux.intel.com (Jarkko Nikula)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] i2c: designware-platdrv: fix unbalanced clk enable and prepare
Date: Thu, 21 Apr 2016 10:39:50 +0300 [thread overview]
Message-ID: <571883C6.3010404@linux.intel.com> (raw)
In-Reply-To: <20160421104022.2d6549a9@xhacker>
On 04/21/2016 05:40 AM, Jisheng Zhang wrote:
> Dear Jarkko, Andy,
>
> On Wed, 20 Apr 2016 17:16:00 +0300 Andy Shevchenko wrote:
>
>> On Wed, 2016-04-20 at 15:55 +0300, Jarkko Nikula wrote:
>>> I see Andy's 1cb715ca4694 ("i2c-designware: move to managed functions
>>> (devm_*)") removed it but at quick look drivers/clk/clk-devres.c:
>>> devm_clk_release() calls only clk_put and I don't see disable is done
>>> down the path.
>>
>> The following is a mistake of the mentioned patch.
>> - clk_disable_unprepare(dev->clk);
>>
>> I did at the same mistake in dw_dmac driver which had been fixed later
>> in the commit 8be4f523b480 ("dmaengine: dw: fix regression in dw_probe()
>> function").
>>
>
> As Andy pointed out, managed devm_clk_get can only automatically put clk
> but doesn't unprepare and disable the clk
>
Ok, then it makes sense to move this fix first in the series and queue
for stable v4.5+. Then another from you, Andy or me for kernels before
b33af11de236 ("i2c: designware: Do not require clock when SSCN and FFCN
are provided") that introduced the i2c_dw_plat_prepare_clk().
--
Jarkko
next prev parent reply other threads:[~2016-04-21 7:39 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-14 12:53 [PATCH 0/4] i2c: designware: runtime pm fix and improve Jisheng Zhang
2016-04-14 12:53 ` Jisheng Zhang
2016-04-14 12:53 ` Jisheng Zhang
2016-04-14 12:53 ` [PATCH 1/4] i2c: designware-platdrv: Fix runtime PM initialization Jisheng Zhang
2016-04-14 12:53 ` Jisheng Zhang
2016-04-14 12:53 ` Jisheng Zhang
2016-04-20 13:53 ` Jarkko Nikula
2016-04-20 13:53 ` Jarkko Nikula
2016-04-21 3:08 ` Jisheng Zhang
2016-04-21 3:08 ` Jisheng Zhang
2016-04-21 3:08 ` Jisheng Zhang
2016-04-21 7:48 ` Jarkko Nikula
2016-04-21 7:48 ` Jarkko Nikula
2016-04-21 8:15 ` Jisheng Zhang
2016-04-21 8:15 ` Jisheng Zhang
2016-04-21 8:15 ` Jisheng Zhang
2016-04-14 12:53 ` [PATCH 2/4] i2c: designware-platdrv: fix unbalanced clk enable and prepare Jisheng Zhang
2016-04-14 12:53 ` Jisheng Zhang
2016-04-14 12:53 ` Jisheng Zhang
2016-04-20 12:55 ` Jarkko Nikula
2016-04-20 12:55 ` Jarkko Nikula
2016-04-20 14:16 ` Andy Shevchenko
2016-04-20 14:16 ` Andy Shevchenko
2016-04-21 2:40 ` Jisheng Zhang
2016-04-21 2:40 ` Jisheng Zhang
2016-04-21 2:40 ` Jisheng Zhang
2016-04-21 7:39 ` Jarkko Nikula [this message]
2016-04-21 7:39 ` Jarkko Nikula
2016-04-21 8:19 ` Jisheng Zhang
2016-04-21 8:19 ` Jisheng Zhang
2016-04-21 8:19 ` Jisheng Zhang
2016-04-14 12:53 ` [PATCH 3/4] i2c: designware-pcidrv: enable RuntimePM before registering to the core Jisheng Zhang
2016-04-14 12:53 ` Jisheng Zhang
2016-04-14 12:53 ` Jisheng Zhang
2016-04-20 13:03 ` Jarkko Nikula
2016-04-20 13:03 ` Jarkko Nikula
2016-04-14 12:53 ` [PATCH 4/4] i2c: designware: remove runtime suspend prevention during registration Jisheng Zhang
2016-04-14 12:53 ` Jisheng Zhang
2016-04-14 12:53 ` Jisheng Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=571883C6.3010404@linux.intel.com \
--to=jarkko.nikula@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jszhang@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.