All of lore.kernel.org
 help / color / mirror / Atom feed
From: Balbir Singh <bsingharora@gmail.com>
To: Nicolas Dichtel <nicolas.dichtel@6wind.com>, netdev@vger.kernel.org
Cc: davem@davemloft.net, linux-kernel@vger.kernel.org,
	linux-wpan@vger.kernel.org, aar@pengutronix.de,
	pablo@netfilter.org, kaber@trash.net, kadlec@blackhole.kfki.hu,
	pshelar@nicira.com, kuznet@ms2.inr.ac.ru, jmorris@namei.org,
	yoshfuji@linux-ipv6.org, netfilter-devel@vger.kernel.org,
	dev@openvswitch.org, steffen.klassert@secunet.com,
	herbert@gondor.apana.org.au
Subject: Re: [PATCH net-next 9/9] taskstats: use the libnl API to align nlattr on 64-bit
Date: Wed, 27 Apr 2016 11:14:47 +1000	[thread overview]
Message-ID: <57201287.80002@gmail.com> (raw)
In-Reply-To: <1461339084-3849-10-git-send-email-nicolas.dichtel@6wind.com>



On 23/04/16 01:31, Nicolas Dichtel wrote:
> Goal of this patch is to use the new libnl API to align netlink attribute
> when needed.
> The layout of the netlink message will be a bit different after the patch,
> because the padattr (TASKSTATS_TYPE_STATS) will be inside the nested
> attribute instead of before it.
> 
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>

The layout will change/break user space -- I've not tested the patch though..

Balbir Singh.
 

WARNING: multiple messages have this Message-ID (diff)
From: Balbir Singh <bsingharora-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Nicolas Dichtel
	<nicolas.dichtel-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>,
	netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: dev-yBygre7rU0TnMu66kgdUjQ@public.gmane.org,
	steffen.klassert-opNxpl+3fjRBDgjK7y7TUQ@public.gmane.org,
	herbert-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org,
	aar-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org,
	yoshfuji-VfPWfsRibaP+Ru+s062T9g@public.gmane.org,
	netfilter-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	kadlec-K40Dz/62t/MgiyqX0sVFJYdd74u8MsAO@public.gmane.org,
	kuznet-v/Mj1YrvjDBInbfyfbPRSQ@public.gmane.org,
	jmorris-gx6/JNMH7DfYtjvyW6yDsg@public.gmane.org,
	linux-wpan-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	kaber-dcUjhNyLwpNeoWH0uzbU5w@public.gmane.org,
	pablo-Cap9r6Oaw4JrovVCs/uTlw@public.gmane.org
Subject: Re: [PATCH net-next 9/9] taskstats: use the libnl API to align nlattr on 64-bit
Date: Wed, 27 Apr 2016 11:14:47 +1000	[thread overview]
Message-ID: <57201287.80002@gmail.com> (raw)
In-Reply-To: <1461339084-3849-10-git-send-email-nicolas.dichtel-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>



On 23/04/16 01:31, Nicolas Dichtel wrote:
> Goal of this patch is to use the new libnl API to align netlink attribute
> when needed.
> The layout of the netlink message will be a bit different after the patch,
> because the padattr (TASKSTATS_TYPE_STATS) will be inside the nested
> attribute instead of before it.
> 
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>

The layout will change/break user space -- I've not tested the patch though..

Balbir Singh.
 
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

  reply	other threads:[~2016-04-27  1:15 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-22 15:31 [PATCH net-next 0/9] netlink: align attributes when needed (patchset #1) Nicolas Dichtel
2016-04-22 15:31 ` [PATCH net-next 1/9] libnl: fix help of _64bit functions Nicolas Dichtel
2016-04-22 15:31 ` [PATCH net-next 2/9] libnl: nla_put_le64(): align on a 64-bit area Nicolas Dichtel
2016-04-22 16:51   ` Eric Dumazet
2016-04-22 16:51     ` Eric Dumazet
2016-04-23 17:05     ` Alexander Aring
2016-04-23 17:28       ` Alexander Aring
2016-04-25  7:41         ` Nicolas Dichtel
2016-04-25  7:41           ` Nicolas Dichtel
2016-04-22 15:31 ` [PATCH net-next 3/9] libnl: nla_put_be64(): " Nicolas Dichtel
2016-04-22 15:31 ` [PATCH net-next 4/9] libnl: nla_put_net64(): " Nicolas Dichtel
2016-04-22 15:31 ` [PATCH net-next 5/9] libnl: nla_put_s64(): " Nicolas Dichtel
2016-04-22 15:31   ` Nicolas Dichtel
2016-04-22 15:31 ` [PATCH net-next 6/9] libnl: nla_put_msecs(): " Nicolas Dichtel
2016-04-22 15:31   ` Nicolas Dichtel
2016-04-22 15:31 ` [PATCH net-next 7/9] libnl: add nla_put_u64_64bit() helper Nicolas Dichtel
2016-04-22 15:31 ` [PATCH net-next 8/9] xfrm: align nlattr properly when needed Nicolas Dichtel
2016-04-22 15:31 ` [PATCH net-next 9/9] taskstats: use the libnl API to align nlattr on 64-bit Nicolas Dichtel
2016-04-27  1:14   ` Balbir Singh [this message]
2016-04-27  1:14     ` Balbir Singh
2016-04-27  7:29     ` Nicolas Dichtel
2016-04-27  7:29       ` Nicolas Dichtel
2016-04-27 12:29       ` Balbir Singh
2016-04-27 12:29         ` Balbir Singh
2016-04-27 15:46         ` Nicolas Dichtel
2016-04-27 15:46           ` Nicolas Dichtel
2016-04-27 15:47           ` [PATCH net-next] taskstats: fix nl parsing in accounting/getdelays.c Nicolas Dichtel
2016-04-27 15:49             ` Nicolas Dichtel
2016-04-27 15:49               ` Nicolas Dichtel
2016-04-27 15:53               ` [PATCH net-next v2] " Nicolas Dichtel
2016-04-27 15:53                 ` Nicolas Dichtel
2016-04-27 16:56                 ` David Miller
2016-04-27 16:56                   ` David Miller
2016-04-27 16:41         ` [PATCH net-next 9/9] taskstats: use the libnl API to align nlattr on 64-bit David Miller
2016-04-24  0:13 ` [PATCH net-next 0/9] netlink: align attributes when needed (patchset #1) David Miller
2016-04-24  0:13   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57201287.80002@gmail.com \
    --to=bsingharora@gmail.com \
    --cc=aar@pengutronix.de \
    --cc=davem@davemloft.net \
    --cc=dev@openvswitch.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=jmorris@namei.org \
    --cc=kaber@trash.net \
    --cc=kadlec@blackhole.kfki.hu \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wpan@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=nicolas.dichtel@6wind.com \
    --cc=pablo@netfilter.org \
    --cc=pshelar@nicira.com \
    --cc=steffen.klassert@secunet.com \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.