All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tero Kristo <t-kristo@ti.com>
To: "J.D. Schroeder" <Linux.HWI@garmin.com>,
	<linux-kernel@vger.kernel.org>, <bcousson@baylibre.com>,
	<tony@atomide.com>, <robh+dt@kernel.org>, <pawel.moll@arm.com>,
	<mark.rutland@arm.com>, <ijc+devicetree@hellion.org.uk>,
	<galak@codeaurora.org>, <linux@arm.linux.org.uk>,
	<linux-omap@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>
Cc: <jay.schroeder@garmin.com>
Subject: Re: [PATCH v2 2/3] ARM: DRA7x: dts: Update the OSC_32K_CLK frequency
Date: Tue, 3 May 2016 11:16:38 +0300	[thread overview]
Message-ID: <57285E66.2000708@ti.com> (raw)
In-Reply-To: <1462209123-7332-3-git-send-email-Linux.HWI@garmin.com>

On 02/05/16 20:12, J.D. Schroeder wrote:
> From: "J.D. Schroeder" <jay.schroeder@garmin.com>
>
> This commit updates the OSC_32K_CLK (secure_32k_clk_src_ck) frequency
> from the precise 32kHz frequency (i.e., 32.768 kHz) to a more
> accurate frequency of ~34.6 kHz. Actual measured frequencies of the
> clock vary from processor to processor anywhere from 34.4 kHz up to
> 34.8 kHz. Note that the ~34 kHz frequency clock is generated
> internally by the processor, not an input to the processor. This
> change makes it more clear that the consumer of the
> secure_32k_clk_src_ck will not get a precise 32.768 kHz frequency
> output.
>
> Signed-off-by: J.D. Schroeder <jay.schroeder@garmin.com>
> Reviewed-by: Trenton Andres <trenton.andres@garmin.com>
> ---
>   arch/arm/boot/dts/dra7xx-clocks.dtsi | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/dra7xx-clocks.dtsi b/arch/arm/boot/dts/dra7xx-clocks.dtsi
> index 3f0c61d..f7ec976 100644
> --- a/arch/arm/boot/dts/dra7xx-clocks.dtsi
> +++ b/arch/arm/boot/dts/dra7xx-clocks.dtsi
> @@ -95,7 +95,7 @@
>   	secure_32k_clk_src_ck: secure_32k_clk_src_ck {
>   		#clock-cells = <0>;
>   		compatible = "fixed-clock";
> -		clock-frequency = <32768>;
> +		clock-frequency = <34600>; /* approximate frequency */
>   	};
>
>   	sys_clk32_crystal_ck: sys_clk32_crystal_ck {
>

I still don't agree with this patch. The actual frequency can drift much 
more, you are just seeing this number at your setup. There is some 
internal discussion going on in TI about this, but I can't share any 
data on this yet.

-Tero

WARNING: multiple messages have this Message-ID (diff)
From: Tero Kristo <t-kristo@ti.com>
To: "J.D. Schroeder" <Linux.HWI@garmin.com>,
	linux-kernel@vger.kernel.org, bcousson@baylibre.com,
	tony@atomide.com, robh+dt@kernel.org, pawel.moll@arm.com,
	mark.rutland@arm.com, ijc+devicetree@hellion.org.uk,
	galak@codeaurora.org, linux@arm.linux.org.uk,
	linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Cc: jay.schroeder@garmin.com
Subject: Re: [PATCH v2 2/3] ARM: DRA7x: dts: Update the OSC_32K_CLK frequency
Date: Tue, 3 May 2016 11:16:38 +0300	[thread overview]
Message-ID: <57285E66.2000708@ti.com> (raw)
In-Reply-To: <1462209123-7332-3-git-send-email-Linux.HWI@garmin.com>

On 02/05/16 20:12, J.D. Schroeder wrote:
> From: "J.D. Schroeder" <jay.schroeder@garmin.com>
>
> This commit updates the OSC_32K_CLK (secure_32k_clk_src_ck) frequency
> from the precise 32kHz frequency (i.e., 32.768 kHz) to a more
> accurate frequency of ~34.6 kHz. Actual measured frequencies of the
> clock vary from processor to processor anywhere from 34.4 kHz up to
> 34.8 kHz. Note that the ~34 kHz frequency clock is generated
> internally by the processor, not an input to the processor. This
> change makes it more clear that the consumer of the
> secure_32k_clk_src_ck will not get a precise 32.768 kHz frequency
> output.
>
> Signed-off-by: J.D. Schroeder <jay.schroeder@garmin.com>
> Reviewed-by: Trenton Andres <trenton.andres@garmin.com>
> ---
>   arch/arm/boot/dts/dra7xx-clocks.dtsi | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/dra7xx-clocks.dtsi b/arch/arm/boot/dts/dra7xx-clocks.dtsi
> index 3f0c61d..f7ec976 100644
> --- a/arch/arm/boot/dts/dra7xx-clocks.dtsi
> +++ b/arch/arm/boot/dts/dra7xx-clocks.dtsi
> @@ -95,7 +95,7 @@
>   	secure_32k_clk_src_ck: secure_32k_clk_src_ck {
>   		#clock-cells = <0>;
>   		compatible = "fixed-clock";
> -		clock-frequency = <32768>;
> +		clock-frequency = <34600>; /* approximate frequency */
>   	};
>
>   	sys_clk32_crystal_ck: sys_clk32_crystal_ck {
>

I still don't agree with this patch. The actual frequency can drift much 
more, you are just seeing this number at your setup. There is some 
internal discussion going on in TI about this, but I can't share any 
data on this yet.

-Tero

WARNING: multiple messages have this Message-ID (diff)
From: t-kristo@ti.com (Tero Kristo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/3] ARM: DRA7x: dts: Update the OSC_32K_CLK frequency
Date: Tue, 3 May 2016 11:16:38 +0300	[thread overview]
Message-ID: <57285E66.2000708@ti.com> (raw)
In-Reply-To: <1462209123-7332-3-git-send-email-Linux.HWI@garmin.com>

On 02/05/16 20:12, J.D. Schroeder wrote:
> From: "J.D. Schroeder" <jay.schroeder@garmin.com>
>
> This commit updates the OSC_32K_CLK (secure_32k_clk_src_ck) frequency
> from the precise 32kHz frequency (i.e., 32.768 kHz) to a more
> accurate frequency of ~34.6 kHz. Actual measured frequencies of the
> clock vary from processor to processor anywhere from 34.4 kHz up to
> 34.8 kHz. Note that the ~34 kHz frequency clock is generated
> internally by the processor, not an input to the processor. This
> change makes it more clear that the consumer of the
> secure_32k_clk_src_ck will not get a precise 32.768 kHz frequency
> output.
>
> Signed-off-by: J.D. Schroeder <jay.schroeder@garmin.com>
> Reviewed-by: Trenton Andres <trenton.andres@garmin.com>
> ---
>   arch/arm/boot/dts/dra7xx-clocks.dtsi | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/dra7xx-clocks.dtsi b/arch/arm/boot/dts/dra7xx-clocks.dtsi
> index 3f0c61d..f7ec976 100644
> --- a/arch/arm/boot/dts/dra7xx-clocks.dtsi
> +++ b/arch/arm/boot/dts/dra7xx-clocks.dtsi
> @@ -95,7 +95,7 @@
>   	secure_32k_clk_src_ck: secure_32k_clk_src_ck {
>   		#clock-cells = <0>;
>   		compatible = "fixed-clock";
> -		clock-frequency = <32768>;
> +		clock-frequency = <34600>; /* approximate frequency */
>   	};
>
>   	sys_clk32_crystal_ck: sys_clk32_crystal_ck {
>

I still don't agree with this patch. The actual frequency can drift much 
more, you are just seeing this number at your setup. There is some 
internal discussion going on in TI about this, but I can't share any 
data on this yet.

-Tero

  reply	other threads:[~2016-05-03  8:17 UTC|newest]

Thread overview: 85+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-26 17:54 [PATCH 0/3] AM57/DRA7 Clock Tree DTSI Fix-ups J.D. Schroeder
2016-04-26 17:54 ` J.D. Schroeder
2016-04-26 17:54 ` J.D. Schroeder
2016-04-26 17:54 ` [PATCH 1/3] DRA7: Fix clock data for gmac_gmii_ref_clk_div J.D. Schroeder
2016-04-26 17:54   ` J.D. Schroeder
2016-04-26 17:54   ` J.D. Schroeder
2016-04-27 11:21   ` Tero Kristo
2016-04-27 11:21     ` Tero Kristo
2016-04-27 11:21     ` Tero Kristo
2016-04-27 16:36     ` Tony Lindgren
2016-04-27 16:36       ` Tony Lindgren
2016-04-27 17:16       ` Tony Lindgren
2016-04-27 17:16         ` Tony Lindgren
2016-04-27 17:16         ` Tony Lindgren
2016-05-02 17:12         ` [PATCH v2 0/3] AM57/DRA7 Clock Tree DTSI Fix-ups J.D. Schroeder
2016-05-02 17:12           ` J.D. Schroeder
2016-05-02 17:12           ` J.D. Schroeder
2016-05-02 17:12           ` [PATCH v2 1/3] DRA7: Fix clock data for gmac_gmii_ref_clk_div J.D. Schroeder
2016-05-02 17:12             ` J.D. Schroeder
2016-05-02 17:12             ` J.D. Schroeder
2016-05-02 17:12           ` [PATCH v2 2/3] ARM: DRA7x: dts: Update the OSC_32K_CLK frequency J.D. Schroeder
2016-05-02 17:12             ` J.D. Schroeder
2016-05-02 17:12             ` J.D. Schroeder
2016-05-03  8:16             ` Tero Kristo [this message]
2016-05-03  8:16               ` Tero Kristo
2016-05-03  8:16               ` Tero Kristo
2016-05-03 13:31               ` J.D. Schroeder
2016-05-03 13:31                 ` J.D. Schroeder
2016-05-03 13:31                 ` J.D. Schroeder
2016-05-03 16:43                 ` Tony Lindgren
2016-05-03 16:43                   ` Tony Lindgren
2016-05-03 17:32                   ` Tero Kristo
2016-05-03 17:32                     ` Tero Kristo
2016-05-03 17:32                     ` Tero Kristo
2016-05-03 17:49                     ` J.D. Schroeder
2016-05-03 17:49                       ` J.D. Schroeder
2016-05-03 17:49                       ` J.D. Schroeder
2016-05-03 18:08                       ` Tony Lindgren
2016-05-03 18:08                         ` Tony Lindgren
2016-05-03 18:08                         ` Tony Lindgren
2016-05-03 18:08                       ` Tero Kristo
2016-05-03 18:08                         ` Tero Kristo
2016-05-03 18:08                         ` Tero Kristo
2016-05-03 23:17                         ` Nishanth Menon
2016-05-03 23:17                           ` Nishanth Menon
2016-05-03 23:17                           ` Nishanth Menon
2016-05-04 14:09                     ` Matthijs van Duin
2016-05-04 14:09                       ` Matthijs van Duin
2016-05-04 14:09                       ` Matthijs van Duin
2016-05-02 17:12           ` [PATCH v2 3/3] ARM: dts: dra7: fix clock node definition to avoid build warning J.D. Schroeder
2016-05-02 17:12             ` J.D. Schroeder
2016-05-02 17:12             ` J.D. Schroeder
2016-05-03  4:20           ` [PATCH v2 0/3] AM57/DRA7 Clock Tree DTSI Fix-ups Lokesh Vutla
2016-05-03  4:20             ` Lokesh Vutla
2016-05-03  4:20             ` Lokesh Vutla
2016-04-26 17:54 ` [PATCH 2/3] ARM: DRA7x: dts: Fix the 32kHz clock calculation J.D. Schroeder
2016-04-26 17:54   ` J.D. Schroeder
2016-04-26 17:54   ` J.D. Schroeder
2016-04-27 11:40   ` Tero Kristo
2016-04-27 11:40     ` Tero Kristo
2016-04-27 11:40     ` Tero Kristo
2016-04-27 14:06     ` J.D. Schroeder
2016-04-27 14:06       ` J.D. Schroeder
2016-04-27 14:06       ` J.D. Schroeder
2016-04-27 19:47       ` Tero Kristo
2016-04-27 19:47         ` Tero Kristo
2016-04-27 19:47         ` Tero Kristo
2016-04-27 20:13         ` J.D. Schroeder
2016-04-27 20:13           ` J.D. Schroeder
2016-04-27 20:13           ` J.D. Schroeder
2016-04-26 17:54 ` [PATCH 3/3] ARM: DRA7x: dts: Update the OSC_32K_CLK frequency J.D. Schroeder
2016-04-26 17:54   ` J.D. Schroeder
2016-04-26 17:54   ` J.D. Schroeder
2016-04-27 11:49   ` Tero Kristo
2016-04-27 11:49     ` Tero Kristo
2016-04-27 11:49     ` Tero Kristo
2016-04-27 14:20     ` J.D. Schroeder
2016-04-27 14:20       ` J.D. Schroeder
2016-04-27 14:20       ` J.D. Schroeder
2016-04-26 18:13 ` [PATCH 0/3] AM57/DRA7 Clock Tree DTSI Fix-ups Tony Lindgren
2016-04-26 18:13   ` Tony Lindgren
2016-04-26 18:13   ` Tony Lindgren
2016-04-26 19:18   ` J.D. Schroeder
2016-04-26 19:18     ` J.D. Schroeder
2016-04-26 19:18     ` J.D. Schroeder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57285E66.2000708@ti.com \
    --to=t-kristo@ti.com \
    --cc=Linux.HWI@garmin.com \
    --cc=bcousson@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=jay.schroeder@garmin.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.