All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] mips: Fix compiler warning in cpu.c
@ 2016-05-05 18:14 Marek Vasut
  2016-05-06 10:50 ` Daniel Schwierzeck
  0 siblings, 1 reply; 2+ messages in thread
From: Marek Vasut @ 2016-05-05 18:14 UTC (permalink / raw)
  To: u-boot

There really is zero reason for including netdev.h in generic mips CPU code.
Removing the netdev.h from cpu.c also fixes the following compiler warning:

In file included from arch/mips/cpu/cpu.c:10:0:
include/netdev.h:204:41: warning: 'struct eth_device' declared inside parameter list [enabled by default]
 int fecmxc_register_mii_postcall(struct eth_device *dev, int (*cb)(int));
                                         ^
include/netdev.h:204:41: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Paul Burton <paul.burton@imgtec.com>
Cc: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
---
 arch/mips/cpu/cpu.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/mips/cpu/cpu.c b/arch/mips/cpu/cpu.c
index 8d3b2f5..391feb3 100644
--- a/arch/mips/cpu/cpu.c
+++ b/arch/mips/cpu/cpu.c
@@ -7,7 +7,6 @@
 
 #include <common.h>
 #include <command.h>
-#include <netdev.h>
 #include <linux/compiler.h>
 #include <asm/mipsregs.h>
 #include <asm/reboot.h>
-- 
2.7.0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [U-Boot] [PATCH] mips: Fix compiler warning in cpu.c
  2016-05-05 18:14 [U-Boot] [PATCH] mips: Fix compiler warning in cpu.c Marek Vasut
@ 2016-05-06 10:50 ` Daniel Schwierzeck
  0 siblings, 0 replies; 2+ messages in thread
From: Daniel Schwierzeck @ 2016-05-06 10:50 UTC (permalink / raw)
  To: u-boot



Am 05.05.2016 um 20:14 schrieb Marek Vasut:
> There really is zero reason for including netdev.h in generic mips CPU code.
> Removing the netdev.h from cpu.c also fixes the following compiler warning:
> 
> In file included from arch/mips/cpu/cpu.c:10:0:
> include/netdev.h:204:41: warning: 'struct eth_device' declared inside parameter list [enabled by default]
>  int fecmxc_register_mii_postcall(struct eth_device *dev, int (*cb)(int));
>                                          ^
> include/netdev.h:204:41: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Paul Burton <paul.burton@imgtec.com>
> Cc: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
> ---
>  arch/mips/cpu/cpu.c | 1 -
>  1 file changed, 1 deletion(-)

applied to u-boot-mips/next, thanks

-- 
- Daniel

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160506/adfa07a4/attachment.sig>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-05-06 10:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-05 18:14 [U-Boot] [PATCH] mips: Fix compiler warning in cpu.c Marek Vasut
2016-05-06 10:50 ` Daniel Schwierzeck

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.