From: Paolo Bonzini <pbonzini@redhat.com>
To: Borislav Petkov <bp@suse.de>, Brooks Moses <bmoses@google.com>
Cc: linux-kernel@vger.kernel.org, "Ian Kasprzak" <iankaz@google.com>,
"Radim Krčmář" <rkrcmar@redhat.com>
Subject: Re: Is BIT() in arch/x86/include/uapi/asm/kvm.h defined? Where?
Date: Mon, 9 May 2016 16:00:18 +0200 [thread overview]
Message-ID: <573097F2.1090406@redhat.com> (raw)
In-Reply-To: <20160505082423.GB534@pd.tnic>
On 05/05/2016 10:24, Borislav Petkov wrote:
> On Wed, May 04, 2016 at 05:49:27PM -0700, Brooks Moses wrote:
>> When I run "make ARCH=x86 headers_install", and then write a simple C
>> file that #includes "asm/kvm.h" from the resulting tree, I get a
>> compiler error: the BIT() macro used on line 219 of that file is
>> undefined:
>
> The below patch should help...
>
> @Paulo: btw, any chance we can fix that "signifcant" typo :-) in
> KVM_CPUID_FLAG_SIGNIFCANT_INDEX or is it user-visible and cast in
> stone?
Unfortuntely it is cast in stone. The patch below is good though.
Radim, please commit it
(http://article.gmane.org/gmane.linux.kernel/2215443/raw) or pass the
tree back to me so that I can. :)
Thanks,
Paolo
> ---
> From: Borislav Petkov <bp@suse.de>
> Date: Thu, 5 May 2016 10:18:23 +0200
> Subject: [PATCH] x86/kvm: Do not use BIT() in user-exported header
>
> Apparently, we're not exporting BIT() to userspace.
>
> Reported-by: Brooks Moses <bmoses@google.com>
> Signed-off-by: Borislav Petkov <bp@suse.de>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> ---
> arch/x86/include/uapi/asm/kvm.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/x86/include/uapi/asm/kvm.h b/arch/x86/include/uapi/asm/kvm.h
> index cd54147cb365..739c0c594022 100644
> --- a/arch/x86/include/uapi/asm/kvm.h
> +++ b/arch/x86/include/uapi/asm/kvm.h
> @@ -216,9 +216,9 @@ struct kvm_cpuid_entry2 {
> __u32 padding[3];
> };
>
> -#define KVM_CPUID_FLAG_SIGNIFCANT_INDEX BIT(0)
> -#define KVM_CPUID_FLAG_STATEFUL_FUNC BIT(1)
> -#define KVM_CPUID_FLAG_STATE_READ_NEXT BIT(2)
> +#define KVM_CPUID_FLAG_SIGNIFCANT_INDEX (1 << 0)
> +#define KVM_CPUID_FLAG_STATEFUL_FUNC (1 << 1)
> +#define KVM_CPUID_FLAG_STATE_READ_NEXT (1 << 2)
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
> /* for KVM_SET_CPUID2 */
> struct kvm_cpuid2 {
>
next prev parent reply other threads:[~2016-05-09 14:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-05 0:49 Is BIT() in arch/x86/include/uapi/asm/kvm.h defined? Where? Brooks Moses
2016-05-05 8:24 ` Borislav Petkov
2016-05-05 19:15 ` Brooks Moses
2016-05-09 14:00 ` Paolo Bonzini [this message]
2016-05-09 14:47 ` Radim Krčmář
2016-05-09 15:15 ` Paolo Bonzini
2016-05-09 15:25 ` Radim Krčmář
2016-05-09 15:46 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=573097F2.1090406@redhat.com \
--to=pbonzini@redhat.com \
--cc=bmoses@google.com \
--cc=bp@suse.de \
--cc=iankaz@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.