From: Brooks Moses <bmoses@google.com>
To: Borislav Petkov <bp@suse.de>
Cc: linux-kernel@vger.kernel.org, Ian Kasprzak <iankaz@google.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: Is BIT() in arch/x86/include/uapi/asm/kvm.h defined? Where?
Date: Thu, 5 May 2016 12:15:20 -0700 [thread overview]
Message-ID: <CAOxa4Kp3bhe8-PdX8wMArd5gHx9oEbjBZRv3xrt3wpLQdCzx=A@mail.gmail.com> (raw)
In-Reply-To: <20160505082423.GB534@pd.tnic>
On Thu, May 5, 2016 at 1:24 AM, Borislav Petkov <bp@suse.de> wrote:
> On Wed, May 04, 2016 at 05:49:27PM -0700, Brooks Moses wrote:
>> When I run "make ARCH=x86 headers_install", and then write a simple C
>> file that #includes "asm/kvm.h" from the resulting tree, I get a
>> compiler error: the BIT() macro used on line 219 of that file is
>> undefined:
>
> The below patch should help...
Thanks for the quick reply! Yes, this should fix things for us -- and
answers my implicit question of whether it was better to fix this by
avoiding the macro or whether bitops.h was expected to be exported.
> @Paulo: btw, any chance we can fix that "signifcant" typo :-) in
> KVM_CPUID_FLAG_SIGNIFCANT_INDEX or is it user-visible and cast in
> stone?
It's user-visible, but since it's been defined to something that
doesn't work in user-space, it seems unlikely to me that it has any
actual users....
- Brooks
next prev parent reply other threads:[~2016-05-05 19:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-05 0:49 Is BIT() in arch/x86/include/uapi/asm/kvm.h defined? Where? Brooks Moses
2016-05-05 8:24 ` Borislav Petkov
2016-05-05 19:15 ` Brooks Moses [this message]
2016-05-09 14:00 ` Paolo Bonzini
2016-05-09 14:47 ` Radim Krčmář
2016-05-09 15:15 ` Paolo Bonzini
2016-05-09 15:25 ` Radim Krčmář
2016-05-09 15:46 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOxa4Kp3bhe8-PdX8wMArd5gHx9oEbjBZRv3xrt3wpLQdCzx=A@mail.gmail.com' \
--to=bmoses@google.com \
--cc=bp@suse.de \
--cc=iankaz@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.