[PATCH v1] igu_uio: fix IOMMU domain issue

* [PATCH v1] igu_uio: fix IOMMU domain issue
@ 2016-05-10 11:21 Zhe Tao
  2016-05-10 15:59 ` Stephen Hemminger
  0 siblings, 1 reply; 6+ messages in thread
From: Zhe Tao @ 2016-05-10 11:21 UTC (permalink / raw)
  To: dev; +Cc: zhe.tao

Problem:
The following  operations will cause the igb_uio based DPDK
operation failed.
--Any device assignment through the kvm_assign_device interface,
this can be the pci-assign method in QEMU
--VFIO group attachment operation(attach to the container)
this can happens in  vfio-pci assignment in QEMU

Root cause:
For the two operation above finally will call the intel_iommu_attach_device
(e.g. for vfio/ vfio_group_set_container->
vfio_iommu_type1_attach_group->intel_iommu_attach_device)
If we use iommu=pt in the grub which means intel iommu driver will create a
static identity domain for all the PCI device,
Which will set the translation type into passthrough for all the context
entry for all the PCI devices,
But once we close QEMU process, e.g. the VFIO framework will invoke the
detach group operation and finally will call the intel_iommu_detach_device
which will clean the context entry.
(now the IOMMU entry for this device is not availablei)

For AMD iommu driver it handle this detach action right which will restore the
pt_domain (the same as static identity domain for intel) to the
corresponding entry.

Solution:
Add a work around in igb_uio driver which map one single page.
Because all the DMA related alloc and map
actions will cause the intel IOMMU driver to reload the SI domain to the context
entry, that's why the kernel driver never meets such problem.


Signed-off-by: Zhe Tao <zhe.tao@intel.com>
---
 lib/librte_eal/linuxapp/igb_uio/igb_uio.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c
index 45a5720..3fa88b0 100644
--- a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c
+++ b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c
@@ -327,6 +327,18 @@ igbuio_pci_probe(struct pci_dev *dev, const struct pci_device_id *id)
 	struct rte_uio_pci_dev *udev;
 	struct msix_entry msix_entry;
 	int err;
+	struct page *page;
+	/*
+	 * work around for Intel IOMMU implemation for SI doamin
+	 */
+
+	page = alloc_page(GFP_ATOMIC);
+	if (!page) {
+		dev_err(&dev->dev, "Cannot alloc page\n");
+	} else {
+		dma_map_page(&dev->dev, page, 0, PAGE_SIZE, DMA_FROM_DEVICE);
+		__free_page(page);
+	}
 
 	udev = kzalloc(sizeof(struct rte_uio_pci_dev), GFP_KERNEL);
 	if (!udev)
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 6+ messages in thread