All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
To: Rob Herring <robh@kernel.org>, Sebastian Reichel <sre@kernel.org>
Cc: "Pawel Moll" <pawel.moll@arm.com>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
	"Kumar Gala" <galak@codeaurora.org>,
	"Thierry Reding" <thierry.reding@gmail.com>,
	"Benoit Cousson" <bcousson@baylibre.com>,
	"Tony Lindgren" <tony@atomide.com>,
	"Russell King - ARM Linux" <linux@arm.linux.org.uk>,
	"Mauro Carvalho Chehab" <mchehab@osg.samsung.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Linux PWM List" <linux-pwm@vger.kernel.org>,
	linux-omap <linux-omap@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
	"Pali Rohár" <pali.rohar@gmail.com>
Subject: Re: [PATCH 4/7] [media] ir-rx51: add DT support to driver
Date: Fri, 13 May 2016 09:15:38 +0300	[thread overview]
Message-ID: <5735710A.6060404@gmail.com> (raw)
In-Reply-To: <20160511141429.GA5894@rob-hp-laptop>

Hi,

On 11.05.2016 17:14, Rob Herring wrote:
> On Tue, May 10, 2016 at 04:18:27AM +0200, Sebastian Reichel wrote:
>> Hi,
>>
>> On Mon, May 09, 2016 at 04:07:35PM -0500, Rob Herring wrote:
>>> There's already a pwm-led binding that can be used. Though there
>>> may be missing consumer IR to LED subsystem support in the kernel.
>>> You could list both compatibles, use the rx51 IR driver now, and
>>> then move to pwm-led driver in the future.
>>
>> Well from a purely HW point of view it's a PWM connected led. The
>> usage is completely different though. Usually PWM is used to control
>> the LED's brightness via the duty cycle (basic concept: enabling led
>> only 50% of time reduces brightness to 50%).
>>
>> In the IR led's case the aim is generating a specific serial pattern
>> instead. For this task it uses a dmtimer in PWM mode and a second
>> one to reconfigure the pwm timer.
>
> In that case, it will probably never be a generic driver.
>
>> I don't know about a good name, but rx51 should be replaced with
>> n900 in the compatible string. So maybe "nokia,n900-infrared-diode".
>
> That's fine, but the shorter '-ir' was too.
>

I prefer the shorter "nokia,n900-ir", will resend the series with it 
used, unless someone has concerns about it.

Ivo

WARNING: multiple messages have this Message-ID (diff)
From: ivo.g.dimitrov.75@gmail.com (Ivaylo Dimitrov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/7] [media] ir-rx51: add DT support to driver
Date: Fri, 13 May 2016 09:15:38 +0300	[thread overview]
Message-ID: <5735710A.6060404@gmail.com> (raw)
In-Reply-To: <20160511141429.GA5894@rob-hp-laptop>

Hi,

On 11.05.2016 17:14, Rob Herring wrote:
> On Tue, May 10, 2016 at 04:18:27AM +0200, Sebastian Reichel wrote:
>> Hi,
>>
>> On Mon, May 09, 2016 at 04:07:35PM -0500, Rob Herring wrote:
>>> There's already a pwm-led binding that can be used. Though there
>>> may be missing consumer IR to LED subsystem support in the kernel.
>>> You could list both compatibles, use the rx51 IR driver now, and
>>> then move to pwm-led driver in the future.
>>
>> Well from a purely HW point of view it's a PWM connected led. The
>> usage is completely different though. Usually PWM is used to control
>> the LED's brightness via the duty cycle (basic concept: enabling led
>> only 50% of time reduces brightness to 50%).
>>
>> In the IR led's case the aim is generating a specific serial pattern
>> instead. For this task it uses a dmtimer in PWM mode and a second
>> one to reconfigure the pwm timer.
>
> In that case, it will probably never be a generic driver.
>
>> I don't know about a good name, but rx51 should be replaced with
>> n900 in the compatible string. So maybe "nokia,n900-infrared-diode".
>
> That's fine, but the shorter '-ir' was too.
>

I prefer the shorter "nokia,n900-ir", will resend the series with it 
used, unless someone has concerns about it.

Ivo

  reply	other threads:[~2016-05-13  6:15 UTC|newest]

Thread overview: 63+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-07 15:21 [PATCH 0/7] ir-rx51 driver fixes Ivaylo Dimitrov
2016-05-07 15:21 ` Ivaylo Dimitrov
2016-05-07 15:21 ` [PATCH 1/7] ir-rx51: Fix build after multiarch changes broke it Ivaylo Dimitrov
2016-05-07 15:21   ` Ivaylo Dimitrov
2016-05-07 15:21   ` Ivaylo Dimitrov
2016-05-07 15:21 ` [PATCH 2/7] pwm: omap-dmtimer: Allow for setting dmtimer clock source Ivaylo Dimitrov
2016-05-07 15:21   ` Ivaylo Dimitrov
2016-05-07 15:21   ` Ivaylo Dimitrov
2016-05-09 20:01   ` Rob Herring
2016-05-09 20:01     ` Rob Herring
2016-05-07 15:21 ` [PATCH 3/7] [media] ir-rx51: use PWM framework instead of OMAP dmtimer Ivaylo Dimitrov
2016-05-07 15:21   ` Ivaylo Dimitrov
2016-05-07 15:21 ` [PATCH 4/7] [media] ir-rx51: add DT support to driver Ivaylo Dimitrov
2016-05-07 15:21   ` Ivaylo Dimitrov
2016-05-09 20:06   ` Rob Herring
2016-05-09 20:06     ` Rob Herring
2016-05-09 20:53     ` Ivaylo Dimitrov
2016-05-09 20:53       ` Ivaylo Dimitrov
2016-05-09 20:53       ` Ivaylo Dimitrov
2016-05-09 21:07       ` Rob Herring
2016-05-09 21:07         ` Rob Herring
2016-05-09 21:07         ` Rob Herring
2016-05-09 22:06         ` Ivaylo Dimitrov
2016-05-09 22:06           ` Ivaylo Dimitrov
2016-05-10  2:18         ` Sebastian Reichel
2016-05-10  2:18           ` Sebastian Reichel
2016-05-11 14:14           ` Rob Herring
2016-05-11 14:14             ` Rob Herring
2016-05-13  6:15             ` Ivaylo Dimitrov [this message]
2016-05-13  6:15               ` Ivaylo Dimitrov
2016-05-13 14:01               ` Sebastian Reichel
2016-05-13 14:01                 ` Sebastian Reichel
2016-05-07 15:21 ` [PATCH 5/7] ARM: OMAP: dmtimer: Do not call PM runtime functions when not needed Ivaylo Dimitrov
2016-05-07 15:21   ` Ivaylo Dimitrov
2016-05-07 15:21   ` Ivaylo Dimitrov
2016-05-09 19:36   ` Tony Lindgren
2016-05-09 19:36     ` Tony Lindgren
2016-05-09 19:36     ` Tony Lindgren
2016-05-09 20:51     ` Ivaylo Dimitrov
2016-05-09 20:51       ` Ivaylo Dimitrov
2016-06-10 10:22       ` Tony Lindgren
2016-06-10 10:22         ` Tony Lindgren
2016-06-10 21:21         ` Ivaylo Dimitrov
2016-06-10 21:21           ` Ivaylo Dimitrov
2016-06-13  7:10           ` Tony Lindgren
2016-06-13  7:10             ` Tony Lindgren
2016-06-13  7:39             ` Tony Lindgren
2016-06-13  7:39               ` Tony Lindgren
2016-06-13 18:58             ` Ivaylo Dimitrov
2016-06-13 18:58               ` Ivaylo Dimitrov
2016-06-14  7:53               ` Tony Lindgren
2016-06-14  7:53                 ` Tony Lindgren
2016-06-14  7:53                 ` Tony Lindgren
2016-05-07 15:21 ` [PATCH 6/7] [media] ir-rx51: use hrtimer instead of dmtimer Ivaylo Dimitrov
2016-05-07 15:21   ` Ivaylo Dimitrov
2016-05-07 15:21 ` [PATCH 7/7] ARM: dts: n900: enable lirc-rx51 driver Ivaylo Dimitrov
2016-05-07 15:21   ` Ivaylo Dimitrov
2016-06-10 10:20   ` Tony Lindgren
2016-06-10 10:20     ` Tony Lindgren
2016-06-13 18:17 ` [PATCH 0/7] ir-rx51 driver fixes Pali Rohár
2016-06-13 18:17   ` Pali Rohár
2016-06-13 18:48   ` Ivaylo Dimitrov
2016-06-13 18:48     ` Ivaylo Dimitrov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5735710A.6060404@gmail.com \
    --to=ivo.g.dimitrov.75@gmail.com \
    --cc=bcousson@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=mchehab@osg.samsung.com \
    --cc=pali.rohar@gmail.com \
    --cc=pawel.moll@arm.com \
    --cc=robh@kernel.org \
    --cc=sre@kernel.org \
    --cc=thierry.reding@gmail.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.