All of lore.kernel.org
 help / color / mirror / Atom feed
From: William Wu <william.wu@rock-chips.com>
To: gregkh@linuxfoundation.org, balbi@kernel.org, heiko@sntech.de
Cc: linux-rockchip@lists.infradead.org, briannorris@google.com,
	dianders@google.com, kever.yang@rock-chips.com,
	huangtao@rock-chips.com, frank.wang@rock-chips.com,
	eddie.cai@rock-chips.com, John.Youn@synopsys.com,
	linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH] usb: dwc3: add DWC3_GUCTL1 reg for debug
Date: Fri, 13 May 2016 18:07:50 +0800	[thread overview]
Message-ID: <5735A776.9050602@rock-chips.com> (raw)
In-Reply-To: <1463133926-7366-1-git-send-email-william.wu@rock-chips.com>

On 05/13/2016 06:05 PM, William Wu wrote:
> GUCTL1 reg has some useful functions which can be
> written by user. For rockchip platform, we set
> GUCTL1.DEV_FORCE_20_CLK_FOR_30_CLK (bit26, applicable
> for the core is programmed to operate in 2.0 device
> only) to 1 in bootrom, and after start the kernel,
> we want to check whether this bit can be reset to
> default 0 after the core reset. Dump GUCTL1 reg from
> debugfs is more convenient for us.
>
> Signed-off-by: William Wu <william.wu@rock-chips.com>
> ---
> Changes in v2:
> - add commit log
>
>   drivers/usb/dwc3/core.h    | 1 +
>   drivers/usb/dwc3/debugfs.c | 1 +
>   2 files changed, 2 insertions(+)
>
> diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
> index abed84f..c4758d5 100644
> --- a/drivers/usb/dwc3/core.h
> +++ b/drivers/usb/dwc3/core.h
> @@ -86,6 +86,7 @@
>   #define DWC3_GCTL		0xc110
>   #define DWC3_GEVTEN		0xc114
>   #define DWC3_GSTS		0xc118
> +#define DWC3_GUCTL1		0xc11c
>   #define DWC3_GSNPSID		0xc120
>   #define DWC3_GGPIO		0xc124
>   #define DWC3_GUID		0xc128
> diff --git a/drivers/usb/dwc3/debugfs.c b/drivers/usb/dwc3/debugfs.c
> index b1dd3c6..f3c9f44 100644
> --- a/drivers/usb/dwc3/debugfs.c
> +++ b/drivers/usb/dwc3/debugfs.c
> @@ -47,6 +47,7 @@ static const struct debugfs_reg32 dwc3_regs[] = {
>   	dump_register(GCTL),
>   	dump_register(GEVTEN),
>   	dump_register(GSTS),
> +	dump_register(GUCTL1),
>   	dump_register(GSNPSID),
>   	dump_register(GGPIO),
>   	dump_register(GUID),
I'm sorry for forgot to add v2 in commit. I'll resend it later.

WARNING: multiple messages have this Message-ID (diff)
From: William Wu <william.wu-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
To: gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org,
	balbi-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org
Cc: huangtao-TNX95d0MmH7DzftRWevZcw@public.gmane.org,
	frank.wang-TNX95d0MmH7DzftRWevZcw@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	kever.yang-TNX95d0MmH7DzftRWevZcw@public.gmane.org,
	dianders-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
	linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	eddie.cai-TNX95d0MmH7DzftRWevZcw@public.gmane.org,
	briannorris-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
	John.Youn-HKixBCOQz3hWk0Htik3J/w@public.gmane.org
Subject: Re: [PATCH] usb: dwc3: add DWC3_GUCTL1 reg for debug
Date: Fri, 13 May 2016 18:07:50 +0800	[thread overview]
Message-ID: <5735A776.9050602@rock-chips.com> (raw)
In-Reply-To: <1463133926-7366-1-git-send-email-william.wu-TNX95d0MmH7DzftRWevZcw@public.gmane.org>

On 05/13/2016 06:05 PM, William Wu wrote:
> GUCTL1 reg has some useful functions which can be
> written by user. For rockchip platform, we set
> GUCTL1.DEV_FORCE_20_CLK_FOR_30_CLK (bit26, applicable
> for the core is programmed to operate in 2.0 device
> only) to 1 in bootrom, and after start the kernel,
> we want to check whether this bit can be reset to
> default 0 after the core reset. Dump GUCTL1 reg from
> debugfs is more convenient for us.
>
> Signed-off-by: William Wu <william.wu-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
> ---
> Changes in v2:
> - add commit log
>
>   drivers/usb/dwc3/core.h    | 1 +
>   drivers/usb/dwc3/debugfs.c | 1 +
>   2 files changed, 2 insertions(+)
>
> diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
> index abed84f..c4758d5 100644
> --- a/drivers/usb/dwc3/core.h
> +++ b/drivers/usb/dwc3/core.h
> @@ -86,6 +86,7 @@
>   #define DWC3_GCTL		0xc110
>   #define DWC3_GEVTEN		0xc114
>   #define DWC3_GSTS		0xc118
> +#define DWC3_GUCTL1		0xc11c
>   #define DWC3_GSNPSID		0xc120
>   #define DWC3_GGPIO		0xc124
>   #define DWC3_GUID		0xc128
> diff --git a/drivers/usb/dwc3/debugfs.c b/drivers/usb/dwc3/debugfs.c
> index b1dd3c6..f3c9f44 100644
> --- a/drivers/usb/dwc3/debugfs.c
> +++ b/drivers/usb/dwc3/debugfs.c
> @@ -47,6 +47,7 @@ static const struct debugfs_reg32 dwc3_regs[] = {
>   	dump_register(GCTL),
>   	dump_register(GEVTEN),
>   	dump_register(GSTS),
> +	dump_register(GUCTL1),
>   	dump_register(GSNPSID),
>   	dump_register(GGPIO),
>   	dump_register(GUID),
I'm sorry for forgot to add v2 in commit. I'll resend it later.

  reply	other threads:[~2016-05-13 10:10 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-13 10:05 [PATCH] usb: dwc3: add DWC3_GUCTL1 reg for debug William Wu
2016-05-13 10:05 ` William Wu
2016-05-13 10:07 ` William Wu [this message]
2016-05-13 10:07   ` William Wu
  -- strict thread matches above, loose matches on Subject: below --
2016-05-09 12:00 William Wu
2016-05-09 12:04 ` Greg KH
2016-05-09 12:10 ` Felipe Balbi
2016-05-09 13:16   ` William Wu
2016-05-09 13:35     ` Felipe Balbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5735A776.9050602@rock-chips.com \
    --to=william.wu@rock-chips.com \
    --cc=John.Youn@synopsys.com \
    --cc=balbi@kernel.org \
    --cc=briannorris@google.com \
    --cc=dianders@google.com \
    --cc=eddie.cai@rock-chips.com \
    --cc=frank.wang@rock-chips.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=heiko@sntech.de \
    --cc=huangtao@rock-chips.com \
    --cc=kever.yang@rock-chips.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.