All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] clk: meson-gxbb: round the vdec dividers to closest
@ 2019-03-19 10:25 ` Maxime Jourdan
  0 siblings, 0 replies; 6+ messages in thread
From: Maxime Jourdan @ 2019-03-19 10:25 UTC (permalink / raw)
  To: Neil Armstrong, Jerome Brunet
  Cc: Maxime Jourdan, linux-clk, linux-amlogic, linux-arm-kernel, linux-kernel

We want the video decoder clocks to always round to closest. While the
muxes are already using CLK_MUX_ROUND_CLOSEST, the corresponding
CLK_DIVIDER_ROUND_CLOSEST was forgotten for the dividers.

Fix this by adding the flag to the two vdec dividers.

Fixes: a565242eb9fc ("clk: meson: gxbb: add the video decoder clocks")
Signed-off-by: Maxime Jourdan <mjourdan@baylibre.com>
---
 drivers/clk/meson/gxbb.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/clk/meson/gxbb.c b/drivers/clk/meson/gxbb.c
index 04df2e208ed6..29ffb4fde714 100644
--- a/drivers/clk/meson/gxbb.c
+++ b/drivers/clk/meson/gxbb.c
@@ -2216,6 +2216,7 @@ static struct clk_regmap gxbb_vdec_1_div = {
 		.offset = HHI_VDEC_CLK_CNTL,
 		.shift = 0,
 		.width = 7,
+		.flags = CLK_DIVIDER_ROUND_CLOSEST,
 	},
 	.hw.init = &(struct clk_init_data){
 		.name = "vdec_1_div",
@@ -2261,6 +2262,7 @@ static struct clk_regmap gxbb_vdec_hevc_div = {
 		.offset = HHI_VDEC2_CLK_CNTL,
 		.shift = 16,
 		.width = 7,
+		.flags = CLK_DIVIDER_ROUND_CLOSEST,
 	},
 	.hw.init = &(struct clk_init_data){
 		.name = "vdec_hevc_div",
-- 
2.21.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH] clk: meson-gxbb: round the vdec dividers to closest
@ 2019-03-19 10:25 ` Maxime Jourdan
  0 siblings, 0 replies; 6+ messages in thread
From: Maxime Jourdan @ 2019-03-19 10:25 UTC (permalink / raw)
  To: Neil Armstrong, Jerome Brunet
  Cc: Maxime Jourdan, linux-amlogic, linux-clk, linux-arm-kernel, linux-kernel

We want the video decoder clocks to always round to closest. While the
muxes are already using CLK_MUX_ROUND_CLOSEST, the corresponding
CLK_DIVIDER_ROUND_CLOSEST was forgotten for the dividers.

Fix this by adding the flag to the two vdec dividers.

Fixes: a565242eb9fc ("clk: meson: gxbb: add the video decoder clocks")
Signed-off-by: Maxime Jourdan <mjourdan@baylibre.com>
---
 drivers/clk/meson/gxbb.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/clk/meson/gxbb.c b/drivers/clk/meson/gxbb.c
index 04df2e208ed6..29ffb4fde714 100644
--- a/drivers/clk/meson/gxbb.c
+++ b/drivers/clk/meson/gxbb.c
@@ -2216,6 +2216,7 @@ static struct clk_regmap gxbb_vdec_1_div = {
 		.offset = HHI_VDEC_CLK_CNTL,
 		.shift = 0,
 		.width = 7,
+		.flags = CLK_DIVIDER_ROUND_CLOSEST,
 	},
 	.hw.init = &(struct clk_init_data){
 		.name = "vdec_1_div",
@@ -2261,6 +2262,7 @@ static struct clk_regmap gxbb_vdec_hevc_div = {
 		.offset = HHI_VDEC2_CLK_CNTL,
 		.shift = 16,
 		.width = 7,
+		.flags = CLK_DIVIDER_ROUND_CLOSEST,
 	},
 	.hw.init = &(struct clk_init_data){
 		.name = "vdec_hevc_div",
-- 
2.21.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH] clk: meson-gxbb: round the vdec dividers to closest
@ 2019-03-19 10:25 ` Maxime Jourdan
  0 siblings, 0 replies; 6+ messages in thread
From: Maxime Jourdan @ 2019-03-19 10:25 UTC (permalink / raw)
  To: Neil Armstrong, Jerome Brunet
  Cc: Maxime Jourdan, linux-amlogic, linux-clk, linux-arm-kernel, linux-kernel

We want the video decoder clocks to always round to closest. While the
muxes are already using CLK_MUX_ROUND_CLOSEST, the corresponding
CLK_DIVIDER_ROUND_CLOSEST was forgotten for the dividers.

Fix this by adding the flag to the two vdec dividers.

Fixes: a565242eb9fc ("clk: meson: gxbb: add the video decoder clocks")
Signed-off-by: Maxime Jourdan <mjourdan@baylibre.com>
---
 drivers/clk/meson/gxbb.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/clk/meson/gxbb.c b/drivers/clk/meson/gxbb.c
index 04df2e208ed6..29ffb4fde714 100644
--- a/drivers/clk/meson/gxbb.c
+++ b/drivers/clk/meson/gxbb.c
@@ -2216,6 +2216,7 @@ static struct clk_regmap gxbb_vdec_1_div = {
 		.offset = HHI_VDEC_CLK_CNTL,
 		.shift = 0,
 		.width = 7,
+		.flags = CLK_DIVIDER_ROUND_CLOSEST,
 	},
 	.hw.init = &(struct clk_init_data){
 		.name = "vdec_1_div",
@@ -2261,6 +2262,7 @@ static struct clk_regmap gxbb_vdec_hevc_div = {
 		.offset = HHI_VDEC2_CLK_CNTL,
 		.shift = 16,
 		.width = 7,
+		.flags = CLK_DIVIDER_ROUND_CLOSEST,
 	},
 	.hw.init = &(struct clk_init_data){
 		.name = "vdec_hevc_div",
-- 
2.21.0


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] clk: meson-gxbb: round the vdec dividers to closest
  2019-03-19 10:25 ` Maxime Jourdan
  (?)
@ 2019-03-19 16:32   ` Neil Armstrong
  -1 siblings, 0 replies; 6+ messages in thread
From: Neil Armstrong @ 2019-03-19 16:32 UTC (permalink / raw)
  To: Maxime Jourdan, Jerome Brunet
  Cc: linux-clk, linux-amlogic, linux-arm-kernel, linux-kernel

On 19/03/2019 11:25, Maxime Jourdan wrote:
> We want the video decoder clocks to always round to closest. While the
> muxes are already using CLK_MUX_ROUND_CLOSEST, the corresponding
> CLK_DIVIDER_ROUND_CLOSEST was forgotten for the dividers.
> 
> Fix this by adding the flag to the two vdec dividers.
> 
> Fixes: a565242eb9fc ("clk: meson: gxbb: add the video decoder clocks")
> Signed-off-by: Maxime Jourdan <mjourdan@baylibre.com>
> ---
>  drivers/clk/meson/gxbb.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/clk/meson/gxbb.c b/drivers/clk/meson/gxbb.c
> index 04df2e208ed6..29ffb4fde714 100644
> --- a/drivers/clk/meson/gxbb.c
> +++ b/drivers/clk/meson/gxbb.c
> @@ -2216,6 +2216,7 @@ static struct clk_regmap gxbb_vdec_1_div = {
>  		.offset = HHI_VDEC_CLK_CNTL,
>  		.shift = 0,
>  		.width = 7,
> +		.flags = CLK_DIVIDER_ROUND_CLOSEST,
>  	},
>  	.hw.init = &(struct clk_init_data){
>  		.name = "vdec_1_div",
> @@ -2261,6 +2262,7 @@ static struct clk_regmap gxbb_vdec_hevc_div = {
>  		.offset = HHI_VDEC2_CLK_CNTL,
>  		.shift = 16,
>  		.width = 7,
> +		.flags = CLK_DIVIDER_ROUND_CLOSEST,
>  	},
>  	.hw.init = &(struct clk_init_data){
>  		.name = "vdec_hevc_div",
> 

Acked-by: Neil Armstrong <narmstrong@baylibre.com>

Will apply to fixes/drivers for 5.1

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] clk: meson-gxbb: round the vdec dividers to closest
@ 2019-03-19 16:32   ` Neil Armstrong
  0 siblings, 0 replies; 6+ messages in thread
From: Neil Armstrong @ 2019-03-19 16:32 UTC (permalink / raw)
  To: Maxime Jourdan, Jerome Brunet
  Cc: linux-amlogic, linux-clk, linux-arm-kernel, linux-kernel

On 19/03/2019 11:25, Maxime Jourdan wrote:
> We want the video decoder clocks to always round to closest. While the
> muxes are already using CLK_MUX_ROUND_CLOSEST, the corresponding
> CLK_DIVIDER_ROUND_CLOSEST was forgotten for the dividers.
> 
> Fix this by adding the flag to the two vdec dividers.
> 
> Fixes: a565242eb9fc ("clk: meson: gxbb: add the video decoder clocks")
> Signed-off-by: Maxime Jourdan <mjourdan@baylibre.com>
> ---
>  drivers/clk/meson/gxbb.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/clk/meson/gxbb.c b/drivers/clk/meson/gxbb.c
> index 04df2e208ed6..29ffb4fde714 100644
> --- a/drivers/clk/meson/gxbb.c
> +++ b/drivers/clk/meson/gxbb.c
> @@ -2216,6 +2216,7 @@ static struct clk_regmap gxbb_vdec_1_div = {
>  		.offset = HHI_VDEC_CLK_CNTL,
>  		.shift = 0,
>  		.width = 7,
> +		.flags = CLK_DIVIDER_ROUND_CLOSEST,
>  	},
>  	.hw.init = &(struct clk_init_data){
>  		.name = "vdec_1_div",
> @@ -2261,6 +2262,7 @@ static struct clk_regmap gxbb_vdec_hevc_div = {
>  		.offset = HHI_VDEC2_CLK_CNTL,
>  		.shift = 16,
>  		.width = 7,
> +		.flags = CLK_DIVIDER_ROUND_CLOSEST,
>  	},
>  	.hw.init = &(struct clk_init_data){
>  		.name = "vdec_hevc_div",
> 

Acked-by: Neil Armstrong <narmstrong@baylibre.com>

Will apply to fixes/drivers for 5.1

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] clk: meson-gxbb: round the vdec dividers to closest
@ 2019-03-19 16:32   ` Neil Armstrong
  0 siblings, 0 replies; 6+ messages in thread
From: Neil Armstrong @ 2019-03-19 16:32 UTC (permalink / raw)
  To: Maxime Jourdan, Jerome Brunet
  Cc: linux-amlogic, linux-clk, linux-arm-kernel, linux-kernel

On 19/03/2019 11:25, Maxime Jourdan wrote:
> We want the video decoder clocks to always round to closest. While the
> muxes are already using CLK_MUX_ROUND_CLOSEST, the corresponding
> CLK_DIVIDER_ROUND_CLOSEST was forgotten for the dividers.
> 
> Fix this by adding the flag to the two vdec dividers.
> 
> Fixes: a565242eb9fc ("clk: meson: gxbb: add the video decoder clocks")
> Signed-off-by: Maxime Jourdan <mjourdan@baylibre.com>
> ---
>  drivers/clk/meson/gxbb.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/clk/meson/gxbb.c b/drivers/clk/meson/gxbb.c
> index 04df2e208ed6..29ffb4fde714 100644
> --- a/drivers/clk/meson/gxbb.c
> +++ b/drivers/clk/meson/gxbb.c
> @@ -2216,6 +2216,7 @@ static struct clk_regmap gxbb_vdec_1_div = {
>  		.offset = HHI_VDEC_CLK_CNTL,
>  		.shift = 0,
>  		.width = 7,
> +		.flags = CLK_DIVIDER_ROUND_CLOSEST,
>  	},
>  	.hw.init = &(struct clk_init_data){
>  		.name = "vdec_1_div",
> @@ -2261,6 +2262,7 @@ static struct clk_regmap gxbb_vdec_hevc_div = {
>  		.offset = HHI_VDEC2_CLK_CNTL,
>  		.shift = 16,
>  		.width = 7,
> +		.flags = CLK_DIVIDER_ROUND_CLOSEST,
>  	},
>  	.hw.init = &(struct clk_init_data){
>  		.name = "vdec_hevc_div",
> 

Acked-by: Neil Armstrong <narmstrong@baylibre.com>

Will apply to fixes/drivers for 5.1

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-03-19 16:33 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-19 10:25 [PATCH] clk: meson-gxbb: round the vdec dividers to closest Maxime Jourdan
2019-03-19 10:25 ` Maxime Jourdan
2019-03-19 10:25 ` Maxime Jourdan
2019-03-19 16:32 ` Neil Armstrong
2019-03-19 16:32   ` Neil Armstrong
2019-03-19 16:32   ` Neil Armstrong

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.