* [PATCH v2] dt-bindings: convert rockchip-drm.txt to rockchip-drm.yaml
@ 2020-01-21 12:34 ` Dafna Hirschfeld
0 siblings, 0 replies; 28+ messages in thread
From: Dafna Hirschfeld @ 2020-01-21 12:34 UTC (permalink / raw)
To: linux-arm-kernel
Cc: hjc, heiko, airlied, daniel, robh+dt, mark.rutland,
linux-rockchip, devicetree, dri-devel, dafna.hirschfeld,
helen.koike, ezequiel, kernel, dafna3
convert the binding file rockchip-drm.txt to yaml format.
This was tested and verified with:
make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
---
Changes since v1:
- fixed worng sign-off
- fixed the path of the $id property to be the path of the yaml file
.../display/rockchip/rockchip-drm.txt | 19 ----------
.../display/rockchip/rockchip-drm.yaml | 38 +++++++++++++++++++
2 files changed, 38 insertions(+), 19 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/display/rockchip/rockchip-drm.txt
create mode 100644 Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.txt b/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.txt
deleted file mode 100644
index 5707af89319d..000000000000
--- a/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.txt
+++ /dev/null
@@ -1,19 +0,0 @@
-Rockchip DRM master device
-================================
-
-The Rockchip DRM master device is a virtual device needed to list all
-vop devices or other display interface nodes that comprise the
-graphics subsystem.
-
-Required properties:
-- compatible: Should be "rockchip,display-subsystem"
-- ports: Should contain a list of phandles pointing to display interface port
- of vop devices. vop definitions as defined in
- Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
-
-example:
-
-display-subsystem {
- compatible = "rockchip,display-subsystem";
- ports = <&vopl_out>, <&vopb_out>;
-};
diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
new file mode 100644
index 000000000000..538898ada9d1
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
@@ -0,0 +1,38 @@
+# SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/rockchip/rockchip-drm.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Rockchip DRM master device
+
+maintainers:
+ - Sandy Huang <hjc@rock-chips.com
+ - Heiko Stuebner <heiko@sntech.de>
+
+description: |
+ The Rockchip DRM master device is a virtual device needed to list all
+ vop devices or other display interface nodes that comprise the
+ graphics subsystem.
+
+properties:
+ compatible:
+ const: rockchip,display-subsystem
+
+ ports:
+ $ref: /schemas/types.yaml#/definitions/phandle-array
+ description: |
+ Should contain a list of phandles pointing to display interface port
+ of vop devices. vop definitions as defined in
+ Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
+
+required:
+ - compatible
+ - ports
+
+examples:
+ - |
+ display-subsystem {
+ compatible = "rockchip,display-subsystem";
+ ports = <&vopl_out>, <&vopb_out>;
+ };
--
2.17.1
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [PATCH v2] dt-bindings: convert rockchip-drm.txt to rockchip-drm.yaml
@ 2020-01-21 12:34 ` Dafna Hirschfeld
0 siblings, 0 replies; 28+ messages in thread
From: Dafna Hirschfeld @ 2020-01-21 12:34 UTC (permalink / raw)
To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
Cc: hjc-TNX95d0MmH7DzftRWevZcw, heiko-4mtYJXux2i+zQB+pC5nmwQ,
airlied-cv59FeDIM0c, daniel-/w4YWyX8dFk,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A, mark.rutland-5wv7dgnIgG8,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
devicetree-u79uwXL29TY76Z2rM5mHXA,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
dafna.hirschfeld-ZGY8ohtN/8qB+jHODAdFcQ,
helen.koike-ZGY8ohtN/8qB+jHODAdFcQ,
ezequiel-ZGY8ohtN/8qB+jHODAdFcQ, kernel-ZGY8ohtN/8qB+jHODAdFcQ,
dafna3-Re5JQEeQqe8AvxtiuMwx3w
convert the binding file rockchip-drm.txt to yaml format.
This was tested and verified with:
make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
---
Changes since v1:
- fixed worng sign-off
- fixed the path of the $id property to be the path of the yaml file
.../display/rockchip/rockchip-drm.txt | 19 ----------
.../display/rockchip/rockchip-drm.yaml | 38 +++++++++++++++++++
2 files changed, 38 insertions(+), 19 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/display/rockchip/rockchip-drm.txt
create mode 100644 Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.txt b/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.txt
deleted file mode 100644
index 5707af89319d..000000000000
--- a/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.txt
+++ /dev/null
@@ -1,19 +0,0 @@
-Rockchip DRM master device
-================================
-
-The Rockchip DRM master device is a virtual device needed to list all
-vop devices or other display interface nodes that comprise the
-graphics subsystem.
-
-Required properties:
-- compatible: Should be "rockchip,display-subsystem"
-- ports: Should contain a list of phandles pointing to display interface port
- of vop devices. vop definitions as defined in
- Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
-
-example:
-
-display-subsystem {
- compatible = "rockchip,display-subsystem";
- ports = <&vopl_out>, <&vopb_out>;
-};
diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
new file mode 100644
index 000000000000..538898ada9d1
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
@@ -0,0 +1,38 @@
+# SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/rockchip/rockchip-drm.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Rockchip DRM master device
+
+maintainers:
+ - Sandy Huang <hjc-TNX95d0MmH7DzftRWevZcw@public.gmane.org
+ - Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
+
+description: |
+ The Rockchip DRM master device is a virtual device needed to list all
+ vop devices or other display interface nodes that comprise the
+ graphics subsystem.
+
+properties:
+ compatible:
+ const: rockchip,display-subsystem
+
+ ports:
+ $ref: /schemas/types.yaml#/definitions/phandle-array
+ description: |
+ Should contain a list of phandles pointing to display interface port
+ of vop devices. vop definitions as defined in
+ Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
+
+required:
+ - compatible
+ - ports
+
+examples:
+ - |
+ display-subsystem {
+ compatible = "rockchip,display-subsystem";
+ ports = <&vopl_out>, <&vopb_out>;
+ };
--
2.17.1
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [PATCH v2] dt-bindings: convert rockchip-drm.txt to rockchip-drm.yaml
@ 2020-01-21 12:34 ` Dafna Hirschfeld
0 siblings, 0 replies; 28+ messages in thread
From: Dafna Hirschfeld @ 2020-01-21 12:34 UTC (permalink / raw)
To: linux-arm-kernel
Cc: mark.rutland, devicetree, dafna.hirschfeld, heiko, airlied,
dafna3, hjc, dri-devel, linux-rockchip, helen.koike, robh+dt,
daniel, kernel, ezequiel
convert the binding file rockchip-drm.txt to yaml format.
This was tested and verified with:
make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
---
Changes since v1:
- fixed worng sign-off
- fixed the path of the $id property to be the path of the yaml file
.../display/rockchip/rockchip-drm.txt | 19 ----------
.../display/rockchip/rockchip-drm.yaml | 38 +++++++++++++++++++
2 files changed, 38 insertions(+), 19 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/display/rockchip/rockchip-drm.txt
create mode 100644 Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.txt b/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.txt
deleted file mode 100644
index 5707af89319d..000000000000
--- a/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.txt
+++ /dev/null
@@ -1,19 +0,0 @@
-Rockchip DRM master device
-================================
-
-The Rockchip DRM master device is a virtual device needed to list all
-vop devices or other display interface nodes that comprise the
-graphics subsystem.
-
-Required properties:
-- compatible: Should be "rockchip,display-subsystem"
-- ports: Should contain a list of phandles pointing to display interface port
- of vop devices. vop definitions as defined in
- Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
-
-example:
-
-display-subsystem {
- compatible = "rockchip,display-subsystem";
- ports = <&vopl_out>, <&vopb_out>;
-};
diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
new file mode 100644
index 000000000000..538898ada9d1
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
@@ -0,0 +1,38 @@
+# SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/rockchip/rockchip-drm.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Rockchip DRM master device
+
+maintainers:
+ - Sandy Huang <hjc@rock-chips.com
+ - Heiko Stuebner <heiko@sntech.de>
+
+description: |
+ The Rockchip DRM master device is a virtual device needed to list all
+ vop devices or other display interface nodes that comprise the
+ graphics subsystem.
+
+properties:
+ compatible:
+ const: rockchip,display-subsystem
+
+ ports:
+ $ref: /schemas/types.yaml#/definitions/phandle-array
+ description: |
+ Should contain a list of phandles pointing to display interface port
+ of vop devices. vop definitions as defined in
+ Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
+
+required:
+ - compatible
+ - ports
+
+examples:
+ - |
+ display-subsystem {
+ compatible = "rockchip,display-subsystem";
+ ports = <&vopl_out>, <&vopb_out>;
+ };
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [PATCH v2] dt-bindings: convert rockchip-drm.txt to rockchip-drm.yaml
@ 2020-01-21 12:34 ` Dafna Hirschfeld
0 siblings, 0 replies; 28+ messages in thread
From: Dafna Hirschfeld @ 2020-01-21 12:34 UTC (permalink / raw)
To: linux-arm-kernel
Cc: mark.rutland, devicetree, dafna.hirschfeld, airlied, dafna3, hjc,
dri-devel, linux-rockchip, helen.koike, robh+dt, kernel,
ezequiel
convert the binding file rockchip-drm.txt to yaml format.
This was tested and verified with:
make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
---
Changes since v1:
- fixed worng sign-off
- fixed the path of the $id property to be the path of the yaml file
.../display/rockchip/rockchip-drm.txt | 19 ----------
.../display/rockchip/rockchip-drm.yaml | 38 +++++++++++++++++++
2 files changed, 38 insertions(+), 19 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/display/rockchip/rockchip-drm.txt
create mode 100644 Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.txt b/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.txt
deleted file mode 100644
index 5707af89319d..000000000000
--- a/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.txt
+++ /dev/null
@@ -1,19 +0,0 @@
-Rockchip DRM master device
-================================
-
-The Rockchip DRM master device is a virtual device needed to list all
-vop devices or other display interface nodes that comprise the
-graphics subsystem.
-
-Required properties:
-- compatible: Should be "rockchip,display-subsystem"
-- ports: Should contain a list of phandles pointing to display interface port
- of vop devices. vop definitions as defined in
- Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
-
-example:
-
-display-subsystem {
- compatible = "rockchip,display-subsystem";
- ports = <&vopl_out>, <&vopb_out>;
-};
diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
new file mode 100644
index 000000000000..538898ada9d1
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
@@ -0,0 +1,38 @@
+# SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/rockchip/rockchip-drm.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Rockchip DRM master device
+
+maintainers:
+ - Sandy Huang <hjc@rock-chips.com
+ - Heiko Stuebner <heiko@sntech.de>
+
+description: |
+ The Rockchip DRM master device is a virtual device needed to list all
+ vop devices or other display interface nodes that comprise the
+ graphics subsystem.
+
+properties:
+ compatible:
+ const: rockchip,display-subsystem
+
+ ports:
+ $ref: /schemas/types.yaml#/definitions/phandle-array
+ description: |
+ Should contain a list of phandles pointing to display interface port
+ of vop devices. vop definitions as defined in
+ Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
+
+required:
+ - compatible
+ - ports
+
+examples:
+ - |
+ display-subsystem {
+ compatible = "rockchip,display-subsystem";
+ ports = <&vopl_out>, <&vopb_out>;
+ };
--
2.17.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 28+ messages in thread
* Re: [PATCH v2] dt-bindings: convert rockchip-drm.txt to rockchip-drm.yaml
@ 2020-01-21 13:11 ` Johan Jonker
0 siblings, 0 replies; 28+ messages in thread
From: Johan Jonker @ 2020-01-21 13:11 UTC (permalink / raw)
To: dafna.hirschfeld
Cc: airlied, dafna3, daniel, devicetree, dri-devel, ezequiel, heiko,
helen.koike, hjc, kernel, linux-arm-kernel, linux-rockchip,
mark.rutland, robh+dt
Hi Dafna,
You are checking at the wrong platforms.
Maintainers incomplete. ">" is missing.
Recheck please.
Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml:
ignoring, error in schema: maintainers: 0
make ARCH=arm CROSS_COMPILE=/usr/bin/arm-linux-gnueabi- menuconfig
# change in menuconfig to Rockchip system
make ARCH=arm dt_binding_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
make ARCH=arm dtbs_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
make ARCH=arm64 defconfig
make ARCH=arm64 menuconfig
# change in menuconfig to Rockchip platform
make ARCH=arm64 dtbs_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
> From: Dafna Hirschfeld <dafna.hirschfeld at gmail.com>
>
> convert the binding file rockchip-drm.txt to yaml format.
> This was tested and verified with:
> make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
> make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
>
> Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld at gmail.com>
> ---
> .../display/rockchip/rockchip-drm.txt | 19 ----------
> .../display/rockchip/rockchip-drm.yaml | 38 +++++++++++++++++++
> 2 files changed, 38 insertions(+), 19 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/display/rockchip/rockchip-drm.txt
> create mode 100644 Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.txt b/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.txt
> deleted file mode 100644
> index 5707af89319d..000000000000
> --- a/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.txt
> +++ /dev/null
> @@ -1,19 +0,0 @@
> -Rockchip DRM master device
> -================================
> -
> -The Rockchip DRM master device is a virtual device needed to list all
> -vop devices or other display interface nodes that comprise the
> -graphics subsystem.
> -
> -Required properties:
> -- compatible: Should be "rockchip,display-subsystem"
> -- ports: Should contain a list of phandles pointing to display interface port
> - of vop devices. vop definitions as defined in
> - Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
> -
> -example:
> -
> -display-subsystem {
> - compatible = "rockchip,display-subsystem";
> - ports = <&vopl_out>, <&vopb_out>;
> -};
> diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
> new file mode 100644
> index 000000000000..e4ef1a02196d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
> @@ -0,0 +1,38 @@
> +# SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/rockchip-drm.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Rockchip DRM master device
> +
> +maintainers:
> + - Sandy Huang <hjc at rock-chips.com
Add extra ">"
> + - Heiko Stuebner <heiko at sntech.de>
> +
> +description: |
> + The Rockchip DRM master device is a virtual device needed to list all
> + vop devices or other display interface nodes that comprise the
> + graphics subsystem.
> +
> +properties:
> + compatible:
> + const: rockchip,display-subsystem
> +
> + ports:
> + $ref: /schemas/types.yaml#/definitions/phandle-array
> + description: |
> + Should contain a list of phandles pointing to display interface port
> + of vop devices. vop definitions as defined in
> + Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
> +
> +required:
> + - compatible
> + - ports
> +
> +examples:
> + - |
> + display-subsystem {
> + compatible = "rockchip,display-subsystem";
> + ports = <&vopl_out>, <&vopb_out>;
> + };
> --
> 2.17.1
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH v2] dt-bindings: convert rockchip-drm.txt to rockchip-drm.yaml
@ 2020-01-21 13:11 ` Johan Jonker
0 siblings, 0 replies; 28+ messages in thread
From: Johan Jonker @ 2020-01-21 13:11 UTC (permalink / raw)
To: dafna.hirschfeld-ZGY8ohtN/8qB+jHODAdFcQ
Cc: airlied-cv59FeDIM0c, dafna3-Re5JQEeQqe8AvxtiuMwx3w,
daniel-/w4YWyX8dFk, devicetree-u79uwXL29TY76Z2rM5mHXA,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
ezequiel-ZGY8ohtN/8qB+jHODAdFcQ, heiko-4mtYJXux2i+zQB+pC5nmwQ,
helen.koike-ZGY8ohtN/8qB+jHODAdFcQ, hjc-TNX95d0MmH7DzftRWevZcw,
kernel-ZGY8ohtN/8qB+jHODAdFcQ,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
mark.rutland-5wv7dgnIgG8, robh+dt-DgEjT+Ai2ygdnm+yROfE0A
Hi Dafna,
You are checking at the wrong platforms.
Maintainers incomplete. ">" is missing.
Recheck please.
Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml:
ignoring, error in schema: maintainers: 0
make ARCH=arm CROSS_COMPILE=/usr/bin/arm-linux-gnueabi- menuconfig
# change in menuconfig to Rockchip system
make ARCH=arm dt_binding_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
make ARCH=arm dtbs_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
make ARCH=arm64 defconfig
make ARCH=arm64 menuconfig
# change in menuconfig to Rockchip platform
make ARCH=arm64 dtbs_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
> From: Dafna Hirschfeld <dafna.hirschfeld at gmail.com>
>
> convert the binding file rockchip-drm.txt to yaml format.
> This was tested and verified with:
> make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
> make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
>
> Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld at gmail.com>
> ---
> .../display/rockchip/rockchip-drm.txt | 19 ----------
> .../display/rockchip/rockchip-drm.yaml | 38 +++++++++++++++++++
> 2 files changed, 38 insertions(+), 19 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/display/rockchip/rockchip-drm.txt
> create mode 100644 Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.txt b/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.txt
> deleted file mode 100644
> index 5707af89319d..000000000000
> --- a/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.txt
> +++ /dev/null
> @@ -1,19 +0,0 @@
> -Rockchip DRM master device
> -================================
> -
> -The Rockchip DRM master device is a virtual device needed to list all
> -vop devices or other display interface nodes that comprise the
> -graphics subsystem.
> -
> -Required properties:
> -- compatible: Should be "rockchip,display-subsystem"
> -- ports: Should contain a list of phandles pointing to display interface port
> - of vop devices. vop definitions as defined in
> - Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
> -
> -example:
> -
> -display-subsystem {
> - compatible = "rockchip,display-subsystem";
> - ports = <&vopl_out>, <&vopb_out>;
> -};
> diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
> new file mode 100644
> index 000000000000..e4ef1a02196d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
> @@ -0,0 +1,38 @@
> +# SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/rockchip-drm.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Rockchip DRM master device
> +
> +maintainers:
> + - Sandy Huang <hjc at rock-chips.com
Add extra ">"
> + - Heiko Stuebner <heiko at sntech.de>
> +
> +description: |
> + The Rockchip DRM master device is a virtual device needed to list all
> + vop devices or other display interface nodes that comprise the
> + graphics subsystem.
> +
> +properties:
> + compatible:
> + const: rockchip,display-subsystem
> +
> + ports:
> + $ref: /schemas/types.yaml#/definitions/phandle-array
> + description: |
> + Should contain a list of phandles pointing to display interface port
> + of vop devices. vop definitions as defined in
> + Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
> +
> +required:
> + - compatible
> + - ports
> +
> +examples:
> + - |
> + display-subsystem {
> + compatible = "rockchip,display-subsystem";
> + ports = <&vopl_out>, <&vopb_out>;
> + };
> --
> 2.17.1
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH v2] dt-bindings: convert rockchip-drm.txt to rockchip-drm.yaml
@ 2020-01-21 13:11 ` Johan Jonker
0 siblings, 0 replies; 28+ messages in thread
From: Johan Jonker @ 2020-01-21 13:11 UTC (permalink / raw)
To: dafna.hirschfeld
Cc: mark.rutland, devicetree, heiko, airlied, dafna3, hjc, dri-devel,
linux-rockchip, helen.koike, robh+dt, daniel, kernel, ezequiel,
linux-arm-kernel
Hi Dafna,
You are checking at the wrong platforms.
Maintainers incomplete. ">" is missing.
Recheck please.
Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml:
ignoring, error in schema: maintainers: 0
make ARCH=arm CROSS_COMPILE=/usr/bin/arm-linux-gnueabi- menuconfig
# change in menuconfig to Rockchip system
make ARCH=arm dt_binding_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
make ARCH=arm dtbs_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
make ARCH=arm64 defconfig
make ARCH=arm64 menuconfig
# change in menuconfig to Rockchip platform
make ARCH=arm64 dtbs_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
> From: Dafna Hirschfeld <dafna.hirschfeld at gmail.com>
>
> convert the binding file rockchip-drm.txt to yaml format.
> This was tested and verified with:
> make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
> make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
>
> Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld at gmail.com>
> ---
> .../display/rockchip/rockchip-drm.txt | 19 ----------
> .../display/rockchip/rockchip-drm.yaml | 38 +++++++++++++++++++
> 2 files changed, 38 insertions(+), 19 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/display/rockchip/rockchip-drm.txt
> create mode 100644 Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.txt b/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.txt
> deleted file mode 100644
> index 5707af89319d..000000000000
> --- a/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.txt
> +++ /dev/null
> @@ -1,19 +0,0 @@
> -Rockchip DRM master device
> -================================
> -
> -The Rockchip DRM master device is a virtual device needed to list all
> -vop devices or other display interface nodes that comprise the
> -graphics subsystem.
> -
> -Required properties:
> -- compatible: Should be "rockchip,display-subsystem"
> -- ports: Should contain a list of phandles pointing to display interface port
> - of vop devices. vop definitions as defined in
> - Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
> -
> -example:
> -
> -display-subsystem {
> - compatible = "rockchip,display-subsystem";
> - ports = <&vopl_out>, <&vopb_out>;
> -};
> diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
> new file mode 100644
> index 000000000000..e4ef1a02196d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
> @@ -0,0 +1,38 @@
> +# SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/rockchip-drm.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Rockchip DRM master device
> +
> +maintainers:
> + - Sandy Huang <hjc at rock-chips.com
Add extra ">"
> + - Heiko Stuebner <heiko at sntech.de>
> +
> +description: |
> + The Rockchip DRM master device is a virtual device needed to list all
> + vop devices or other display interface nodes that comprise the
> + graphics subsystem.
> +
> +properties:
> + compatible:
> + const: rockchip,display-subsystem
> +
> + ports:
> + $ref: /schemas/types.yaml#/definitions/phandle-array
> + description: |
> + Should contain a list of phandles pointing to display interface port
> + of vop devices. vop definitions as defined in
> + Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
> +
> +required:
> + - compatible
> + - ports
> +
> +examples:
> + - |
> + display-subsystem {
> + compatible = "rockchip,display-subsystem";
> + ports = <&vopl_out>, <&vopb_out>;
> + };
> --
> 2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH v2] dt-bindings: convert rockchip-drm.txt to rockchip-drm.yaml
@ 2020-01-21 13:11 ` Johan Jonker
0 siblings, 0 replies; 28+ messages in thread
From: Johan Jonker @ 2020-01-21 13:11 UTC (permalink / raw)
To: dafna.hirschfeld
Cc: mark.rutland, devicetree, airlied, dafna3, hjc, dri-devel,
linux-rockchip, helen.koike, robh+dt, kernel, ezequiel,
linux-arm-kernel
Hi Dafna,
You are checking at the wrong platforms.
Maintainers incomplete. ">" is missing.
Recheck please.
Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml:
ignoring, error in schema: maintainers: 0
make ARCH=arm CROSS_COMPILE=/usr/bin/arm-linux-gnueabi- menuconfig
# change in menuconfig to Rockchip system
make ARCH=arm dt_binding_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
make ARCH=arm dtbs_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
make ARCH=arm64 defconfig
make ARCH=arm64 menuconfig
# change in menuconfig to Rockchip platform
make ARCH=arm64 dtbs_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
> From: Dafna Hirschfeld <dafna.hirschfeld at gmail.com>
>
> convert the binding file rockchip-drm.txt to yaml format.
> This was tested and verified with:
> make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
> make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
>
> Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld at gmail.com>
> ---
> .../display/rockchip/rockchip-drm.txt | 19 ----------
> .../display/rockchip/rockchip-drm.yaml | 38 +++++++++++++++++++
> 2 files changed, 38 insertions(+), 19 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/display/rockchip/rockchip-drm.txt
> create mode 100644 Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.txt b/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.txt
> deleted file mode 100644
> index 5707af89319d..000000000000
> --- a/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.txt
> +++ /dev/null
> @@ -1,19 +0,0 @@
> -Rockchip DRM master device
> -================================
> -
> -The Rockchip DRM master device is a virtual device needed to list all
> -vop devices or other display interface nodes that comprise the
> -graphics subsystem.
> -
> -Required properties:
> -- compatible: Should be "rockchip,display-subsystem"
> -- ports: Should contain a list of phandles pointing to display interface port
> - of vop devices. vop definitions as defined in
> - Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
> -
> -example:
> -
> -display-subsystem {
> - compatible = "rockchip,display-subsystem";
> - ports = <&vopl_out>, <&vopb_out>;
> -};
> diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
> new file mode 100644
> index 000000000000..e4ef1a02196d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
> @@ -0,0 +1,38 @@
> +# SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/rockchip-drm.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Rockchip DRM master device
> +
> +maintainers:
> + - Sandy Huang <hjc at rock-chips.com
Add extra ">"
> + - Heiko Stuebner <heiko at sntech.de>
> +
> +description: |
> + The Rockchip DRM master device is a virtual device needed to list all
> + vop devices or other display interface nodes that comprise the
> + graphics subsystem.
> +
> +properties:
> + compatible:
> + const: rockchip,display-subsystem
> +
> + ports:
> + $ref: /schemas/types.yaml#/definitions/phandle-array
> + description: |
> + Should contain a list of phandles pointing to display interface port
> + of vop devices. vop definitions as defined in
> + Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
> +
> +required:
> + - compatible
> + - ports
> +
> +examples:
> + - |
> + display-subsystem {
> + compatible = "rockchip,display-subsystem";
> + ports = <&vopl_out>, <&vopb_out>;
> + };
> --
> 2.17.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH v2] dt-bindings: convert rockchip-drm.txt to rockchip-drm.yaml
@ 2020-01-21 14:03 ` Rob Herring
0 siblings, 0 replies; 28+ messages in thread
From: Rob Herring @ 2020-01-21 14:03 UTC (permalink / raw)
To: Dafna Hirschfeld
Cc: moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
黄家钗,
heiko, David Airlie, Daniel Vetter, Mark Rutland,
open list:ARM/Rockchip SoC...,
devicetree, dri-devel, Helen Koike, Ezequiel Garcia,
Collabora Kernel ML, dafna3
On Tue, Jan 21, 2020 at 6:35 AM Dafna Hirschfeld
<dafna.hirschfeld@collabora.com> wrote:
>
> convert the binding file rockchip-drm.txt to yaml format.
> This was tested and verified with:
> make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
Also, make sure just 'make dt_binding_check' passes as that checks the
example against all schemas.
> make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
>
> Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
> ---
> Changes since v1:
> - fixed worng sign-off
> - fixed the path of the $id property to be the path of the yaml file
>
> .../display/rockchip/rockchip-drm.txt | 19 ----------
> .../display/rockchip/rockchip-drm.yaml | 38 +++++++++++++++++++
> 2 files changed, 38 insertions(+), 19 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/display/rockchip/rockchip-drm.txt
> create mode 100644 Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.txt b/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.txt
> deleted file mode 100644
> index 5707af89319d..000000000000
> --- a/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.txt
> +++ /dev/null
> @@ -1,19 +0,0 @@
> -Rockchip DRM master device
> -================================
> -
> -The Rockchip DRM master device is a virtual device needed to list all
> -vop devices or other display interface nodes that comprise the
> -graphics subsystem.
> -
> -Required properties:
> -- compatible: Should be "rockchip,display-subsystem"
> -- ports: Should contain a list of phandles pointing to display interface port
> - of vop devices. vop definitions as defined in
> - Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
> -
> -example:
> -
> -display-subsystem {
> - compatible = "rockchip,display-subsystem";
> - ports = <&vopl_out>, <&vopb_out>;
> -};
> diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
> new file mode 100644
> index 000000000000..538898ada9d1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
> @@ -0,0 +1,38 @@
> +# SPDX-License-Identifier: (GPL-2.0+ OR MIT)
Do you have rights to change the license? The default is GPL-2.0-only.
Looks like Rockchip owns the copyright.
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/rockchip/rockchip-drm.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Rockchip DRM master device
> +
> +maintainers:
> + - Sandy Huang <hjc@rock-chips.com
> + - Heiko Stuebner <heiko@sntech.de>
> +
> +description: |
> + The Rockchip DRM master device is a virtual device needed to list all
> + vop devices or other display interface nodes that comprise the
> + graphics subsystem.
> +
> +properties:
> + compatible:
> + const: rockchip,display-subsystem
> +
> + ports:
> + $ref: /schemas/types.yaml#/definitions/phandle-array
> + description: |
> + Should contain a list of phandles pointing to display interface port
> + of vop devices. vop definitions as defined in
> + Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
> +
> +required:
> + - compatible
> + - ports
Add:
additionalProperties: false
> +
> +examples:
> + - |
> + display-subsystem {
> + compatible = "rockchip,display-subsystem";
> + ports = <&vopl_out>, <&vopb_out>;
> + };
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH v2] dt-bindings: convert rockchip-drm.txt to rockchip-drm.yaml
@ 2020-01-21 14:03 ` Rob Herring
0 siblings, 0 replies; 28+ messages in thread
From: Rob Herring @ 2020-01-21 14:03 UTC (permalink / raw)
To: Dafna Hirschfeld
Cc: moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
黄家钗,
heiko-4mtYJXux2i+zQB+pC5nmwQ, David Airlie, Daniel Vetter,
Mark Rutland, open list:ARM/Rockchip SoC...,
devicetree-u79uwXL29TY76Z2rM5mHXA, dri-devel, Helen Koike,
Ezequiel Garcia, Collabora Kernel ML,
dafna3-Re5JQEeQqe8AvxtiuMwx3w
On Tue, Jan 21, 2020 at 6:35 AM Dafna Hirschfeld
<dafna.hirschfeld-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org> wrote:
>
> convert the binding file rockchip-drm.txt to yaml format.
> This was tested and verified with:
> make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
Also, make sure just 'make dt_binding_check' passes as that checks the
example against all schemas.
> make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
>
> Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
> ---
> Changes since v1:
> - fixed worng sign-off
> - fixed the path of the $id property to be the path of the yaml file
>
> .../display/rockchip/rockchip-drm.txt | 19 ----------
> .../display/rockchip/rockchip-drm.yaml | 38 +++++++++++++++++++
> 2 files changed, 38 insertions(+), 19 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/display/rockchip/rockchip-drm.txt
> create mode 100644 Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.txt b/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.txt
> deleted file mode 100644
> index 5707af89319d..000000000000
> --- a/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.txt
> +++ /dev/null
> @@ -1,19 +0,0 @@
> -Rockchip DRM master device
> -================================
> -
> -The Rockchip DRM master device is a virtual device needed to list all
> -vop devices or other display interface nodes that comprise the
> -graphics subsystem.
> -
> -Required properties:
> -- compatible: Should be "rockchip,display-subsystem"
> -- ports: Should contain a list of phandles pointing to display interface port
> - of vop devices. vop definitions as defined in
> - Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
> -
> -example:
> -
> -display-subsystem {
> - compatible = "rockchip,display-subsystem";
> - ports = <&vopl_out>, <&vopb_out>;
> -};
> diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
> new file mode 100644
> index 000000000000..538898ada9d1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
> @@ -0,0 +1,38 @@
> +# SPDX-License-Identifier: (GPL-2.0+ OR MIT)
Do you have rights to change the license? The default is GPL-2.0-only.
Looks like Rockchip owns the copyright.
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/rockchip/rockchip-drm.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Rockchip DRM master device
> +
> +maintainers:
> + - Sandy Huang <hjc-TNX95d0MmH7DzftRWevZcw@public.gmane.org
> + - Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
> +
> +description: |
> + The Rockchip DRM master device is a virtual device needed to list all
> + vop devices or other display interface nodes that comprise the
> + graphics subsystem.
> +
> +properties:
> + compatible:
> + const: rockchip,display-subsystem
> +
> + ports:
> + $ref: /schemas/types.yaml#/definitions/phandle-array
> + description: |
> + Should contain a list of phandles pointing to display interface port
> + of vop devices. vop definitions as defined in
> + Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
> +
> +required:
> + - compatible
> + - ports
Add:
additionalProperties: false
> +
> +examples:
> + - |
> + display-subsystem {
> + compatible = "rockchip,display-subsystem";
> + ports = <&vopl_out>, <&vopb_out>;
> + };
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH v2] dt-bindings: convert rockchip-drm.txt to rockchip-drm.yaml
@ 2020-01-21 14:03 ` Rob Herring
0 siblings, 0 replies; 28+ messages in thread
From: Rob Herring @ 2020-01-21 14:03 UTC (permalink / raw)
To: Dafna Hirschfeld
Cc: Mark Rutland, devicetree, heiko, David Airlie, dafna3,
黄家钗,
dri-devel, open list:ARM/Rockchip SoC...,
Helen Koike, Daniel Vetter, Collabora Kernel ML, Ezequiel Garcia,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
On Tue, Jan 21, 2020 at 6:35 AM Dafna Hirschfeld
<dafna.hirschfeld@collabora.com> wrote:
>
> convert the binding file rockchip-drm.txt to yaml format.
> This was tested and verified with:
> make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
Also, make sure just 'make dt_binding_check' passes as that checks the
example against all schemas.
> make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
>
> Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
> ---
> Changes since v1:
> - fixed worng sign-off
> - fixed the path of the $id property to be the path of the yaml file
>
> .../display/rockchip/rockchip-drm.txt | 19 ----------
> .../display/rockchip/rockchip-drm.yaml | 38 +++++++++++++++++++
> 2 files changed, 38 insertions(+), 19 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/display/rockchip/rockchip-drm.txt
> create mode 100644 Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.txt b/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.txt
> deleted file mode 100644
> index 5707af89319d..000000000000
> --- a/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.txt
> +++ /dev/null
> @@ -1,19 +0,0 @@
> -Rockchip DRM master device
> -================================
> -
> -The Rockchip DRM master device is a virtual device needed to list all
> -vop devices or other display interface nodes that comprise the
> -graphics subsystem.
> -
> -Required properties:
> -- compatible: Should be "rockchip,display-subsystem"
> -- ports: Should contain a list of phandles pointing to display interface port
> - of vop devices. vop definitions as defined in
> - Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
> -
> -example:
> -
> -display-subsystem {
> - compatible = "rockchip,display-subsystem";
> - ports = <&vopl_out>, <&vopb_out>;
> -};
> diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
> new file mode 100644
> index 000000000000..538898ada9d1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
> @@ -0,0 +1,38 @@
> +# SPDX-License-Identifier: (GPL-2.0+ OR MIT)
Do you have rights to change the license? The default is GPL-2.0-only.
Looks like Rockchip owns the copyright.
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/rockchip/rockchip-drm.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Rockchip DRM master device
> +
> +maintainers:
> + - Sandy Huang <hjc@rock-chips.com
> + - Heiko Stuebner <heiko@sntech.de>
> +
> +description: |
> + The Rockchip DRM master device is a virtual device needed to list all
> + vop devices or other display interface nodes that comprise the
> + graphics subsystem.
> +
> +properties:
> + compatible:
> + const: rockchip,display-subsystem
> +
> + ports:
> + $ref: /schemas/types.yaml#/definitions/phandle-array
> + description: |
> + Should contain a list of phandles pointing to display interface port
> + of vop devices. vop definitions as defined in
> + Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
> +
> +required:
> + - compatible
> + - ports
Add:
additionalProperties: false
> +
> +examples:
> + - |
> + display-subsystem {
> + compatible = "rockchip,display-subsystem";
> + ports = <&vopl_out>, <&vopb_out>;
> + };
> --
> 2.17.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH v2] dt-bindings: convert rockchip-drm.txt to rockchip-drm.yaml
@ 2020-01-21 14:03 ` Rob Herring
0 siblings, 0 replies; 28+ messages in thread
From: Rob Herring @ 2020-01-21 14:03 UTC (permalink / raw)
To: Dafna Hirschfeld
Cc: Mark Rutland, devicetree, David Airlie, dafna3,
黄家钗,
dri-devel, open list:ARM/Rockchip SoC...,
Helen Koike, Collabora Kernel ML, Ezequiel Garcia,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
On Tue, Jan 21, 2020 at 6:35 AM Dafna Hirschfeld
<dafna.hirschfeld@collabora.com> wrote:
>
> convert the binding file rockchip-drm.txt to yaml format.
> This was tested and verified with:
> make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
Also, make sure just 'make dt_binding_check' passes as that checks the
example against all schemas.
> make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
>
> Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
> ---
> Changes since v1:
> - fixed worng sign-off
> - fixed the path of the $id property to be the path of the yaml file
>
> .../display/rockchip/rockchip-drm.txt | 19 ----------
> .../display/rockchip/rockchip-drm.yaml | 38 +++++++++++++++++++
> 2 files changed, 38 insertions(+), 19 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/display/rockchip/rockchip-drm.txt
> create mode 100644 Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.txt b/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.txt
> deleted file mode 100644
> index 5707af89319d..000000000000
> --- a/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.txt
> +++ /dev/null
> @@ -1,19 +0,0 @@
> -Rockchip DRM master device
> -================================
> -
> -The Rockchip DRM master device is a virtual device needed to list all
> -vop devices or other display interface nodes that comprise the
> -graphics subsystem.
> -
> -Required properties:
> -- compatible: Should be "rockchip,display-subsystem"
> -- ports: Should contain a list of phandles pointing to display interface port
> - of vop devices. vop definitions as defined in
> - Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
> -
> -example:
> -
> -display-subsystem {
> - compatible = "rockchip,display-subsystem";
> - ports = <&vopl_out>, <&vopb_out>;
> -};
> diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
> new file mode 100644
> index 000000000000..538898ada9d1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
> @@ -0,0 +1,38 @@
> +# SPDX-License-Identifier: (GPL-2.0+ OR MIT)
Do you have rights to change the license? The default is GPL-2.0-only.
Looks like Rockchip owns the copyright.
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/rockchip/rockchip-drm.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Rockchip DRM master device
> +
> +maintainers:
> + - Sandy Huang <hjc@rock-chips.com
> + - Heiko Stuebner <heiko@sntech.de>
> +
> +description: |
> + The Rockchip DRM master device is a virtual device needed to list all
> + vop devices or other display interface nodes that comprise the
> + graphics subsystem.
> +
> +properties:
> + compatible:
> + const: rockchip,display-subsystem
> +
> + ports:
> + $ref: /schemas/types.yaml#/definitions/phandle-array
> + description: |
> + Should contain a list of phandles pointing to display interface port
> + of vop devices. vop definitions as defined in
> + Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
> +
> +required:
> + - compatible
> + - ports
Add:
additionalProperties: false
> +
> +examples:
> + - |
> + display-subsystem {
> + compatible = "rockchip,display-subsystem";
> + ports = <&vopl_out>, <&vopb_out>;
> + };
> --
> 2.17.1
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH v2] dt-bindings: convert rockchip-drm.txt to rockchip-drm.yaml
@ 2020-01-21 14:55 ` Dafna Hirschfeld
0 siblings, 0 replies; 28+ messages in thread
From: Dafna Hirschfeld @ 2020-01-21 14:55 UTC (permalink / raw)
To: Rob Herring
Cc: moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
黄家钗,
heiko, David Airlie, Daniel Vetter, Mark Rutland,
open list:ARM/Rockchip SoC...,
devicetree, dri-devel, Helen Koike, Ezequiel Garcia,
Collabora Kernel ML, dafna3
On 21.01.20 15:03, Rob Herring wrote:
> On Tue, Jan 21, 2020 at 6:35 AM Dafna Hirschfeld
> <dafna.hirschfeld@collabora.com> wrote:
>>
>> convert the binding file rockchip-drm.txt to yaml format.
>> This was tested and verified with:
>> make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
>
> Also, make sure just 'make dt_binding_check' passes as that checks the
> example against all schemas.
But this also checks the other schemas in general, and when running it,
it fails because of bugs in other schemas.
For example with arm=ARM I get:
DTC Documentation/devicetree/bindings/clock/qcom,gcc.example.dt.yaml
Error:
Documentation/devicetree/bindings/clock/qcom,gcc.example.dts:111.28-29
syntax error
FATAL ERROR: Unable to parse input tree
Dafna
>
>> make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
>>
>> Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
>> ---
>> Changes since v1:
>> - fixed worng sign-off
>> - fixed the path of the $id property to be the path of the yaml file
>>
>> .../display/rockchip/rockchip-drm.txt | 19 ----------
>> .../display/rockchip/rockchip-drm.yaml | 38 +++++++++++++++++++
>> 2 files changed, 38 insertions(+), 19 deletions(-)
>> delete mode 100644 Documentation/devicetree/bindings/display/rockchip/rockchip-drm.txt
>> create mode 100644 Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.txt b/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.txt
>> deleted file mode 100644
>> index 5707af89319d..000000000000
>> --- a/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.txt
>> +++ /dev/null
>> @@ -1,19 +0,0 @@
>> -Rockchip DRM master device
>> -================================
>> -
>> -The Rockchip DRM master device is a virtual device needed to list all
>> -vop devices or other display interface nodes that comprise the
>> -graphics subsystem.
>> -
>> -Required properties:
>> -- compatible: Should be "rockchip,display-subsystem"
>> -- ports: Should contain a list of phandles pointing to display interface port
>> - of vop devices. vop definitions as defined in
>> - Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
>> -
>> -example:
>> -
>> -display-subsystem {
>> - compatible = "rockchip,display-subsystem";
>> - ports = <&vopl_out>, <&vopb_out>;
>> -};
>> diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
>> new file mode 100644
>> index 000000000000..538898ada9d1
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
>> @@ -0,0 +1,38 @@
>> +# SPDX-License-Identifier: (GPL-2.0+ OR MIT)
>
> Do you have rights to change the license? The default is GPL-2.0-only.
> Looks like Rockchip owns the copyright.
>
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/display/rockchip/rockchip-drm.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Rockchip DRM master device
>> +
>> +maintainers:
>> + - Sandy Huang <hjc@rock-chips.com
>> + - Heiko Stuebner <heiko@sntech.de>
>> +
>> +description: |
>> + The Rockchip DRM master device is a virtual device needed to list all
>> + vop devices or other display interface nodes that comprise the
>> + graphics subsystem.
>> +
>> +properties:
>> + compatible:
>> + const: rockchip,display-subsystem
>> +
>> + ports:
>> + $ref: /schemas/types.yaml#/definitions/phandle-array
>> + description: |
>> + Should contain a list of phandles pointing to display interface port
>> + of vop devices. vop definitions as defined in
>> + Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
>> +
>> +required:
>> + - compatible
>> + - ports
>
> Add:
>
> additionalProperties: false
>
>> +
>> +examples:
>> + - |
>> + display-subsystem {
>> + compatible = "rockchip,display-subsystem";
>> + ports = <&vopl_out>, <&vopb_out>;
>> + };
>> --
>> 2.17.1
>>
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH v2] dt-bindings: convert rockchip-drm.txt to rockchip-drm.yaml
@ 2020-01-21 14:55 ` Dafna Hirschfeld
0 siblings, 0 replies; 28+ messages in thread
From: Dafna Hirschfeld @ 2020-01-21 14:55 UTC (permalink / raw)
To: Rob Herring
Cc: moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
黄家钗,
heiko-4mtYJXux2i+zQB+pC5nmwQ, David Airlie, Daniel Vetter,
Mark Rutland, open list:ARM/Rockchip SoC...,
devicetree-u79uwXL29TY76Z2rM5mHXA, dri-devel, Helen Koike,
Ezequiel Garcia, Collabora Kernel ML,
dafna3-Re5JQEeQqe8AvxtiuMwx3w
On 21.01.20 15:03, Rob Herring wrote:
> On Tue, Jan 21, 2020 at 6:35 AM Dafna Hirschfeld
> <dafna.hirschfeld-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org> wrote:
>>
>> convert the binding file rockchip-drm.txt to yaml format.
>> This was tested and verified with:
>> make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
>
> Also, make sure just 'make dt_binding_check' passes as that checks the
> example against all schemas.
But this also checks the other schemas in general, and when running it,
it fails because of bugs in other schemas.
For example with arm=ARM I get:
DTC Documentation/devicetree/bindings/clock/qcom,gcc.example.dt.yaml
Error:
Documentation/devicetree/bindings/clock/qcom,gcc.example.dts:111.28-29
syntax error
FATAL ERROR: Unable to parse input tree
Dafna
>
>> make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
>>
>> Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
>> ---
>> Changes since v1:
>> - fixed worng sign-off
>> - fixed the path of the $id property to be the path of the yaml file
>>
>> .../display/rockchip/rockchip-drm.txt | 19 ----------
>> .../display/rockchip/rockchip-drm.yaml | 38 +++++++++++++++++++
>> 2 files changed, 38 insertions(+), 19 deletions(-)
>> delete mode 100644 Documentation/devicetree/bindings/display/rockchip/rockchip-drm.txt
>> create mode 100644 Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.txt b/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.txt
>> deleted file mode 100644
>> index 5707af89319d..000000000000
>> --- a/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.txt
>> +++ /dev/null
>> @@ -1,19 +0,0 @@
>> -Rockchip DRM master device
>> -================================
>> -
>> -The Rockchip DRM master device is a virtual device needed to list all
>> -vop devices or other display interface nodes that comprise the
>> -graphics subsystem.
>> -
>> -Required properties:
>> -- compatible: Should be "rockchip,display-subsystem"
>> -- ports: Should contain a list of phandles pointing to display interface port
>> - of vop devices. vop definitions as defined in
>> - Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
>> -
>> -example:
>> -
>> -display-subsystem {
>> - compatible = "rockchip,display-subsystem";
>> - ports = <&vopl_out>, <&vopb_out>;
>> -};
>> diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
>> new file mode 100644
>> index 000000000000..538898ada9d1
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
>> @@ -0,0 +1,38 @@
>> +# SPDX-License-Identifier: (GPL-2.0+ OR MIT)
>
> Do you have rights to change the license? The default is GPL-2.0-only.
> Looks like Rockchip owns the copyright.
>
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/display/rockchip/rockchip-drm.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Rockchip DRM master device
>> +
>> +maintainers:
>> + - Sandy Huang <hjc-TNX95d0MmH7DzftRWevZcw@public.gmane.org
>> + - Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
>> +
>> +description: |
>> + The Rockchip DRM master device is a virtual device needed to list all
>> + vop devices or other display interface nodes that comprise the
>> + graphics subsystem.
>> +
>> +properties:
>> + compatible:
>> + const: rockchip,display-subsystem
>> +
>> + ports:
>> + $ref: /schemas/types.yaml#/definitions/phandle-array
>> + description: |
>> + Should contain a list of phandles pointing to display interface port
>> + of vop devices. vop definitions as defined in
>> + Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
>> +
>> +required:
>> + - compatible
>> + - ports
>
> Add:
>
> additionalProperties: false
>
>> +
>> +examples:
>> + - |
>> + display-subsystem {
>> + compatible = "rockchip,display-subsystem";
>> + ports = <&vopl_out>, <&vopb_out>;
>> + };
>> --
>> 2.17.1
>>
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH v2] dt-bindings: convert rockchip-drm.txt to rockchip-drm.yaml
@ 2020-01-21 14:55 ` Dafna Hirschfeld
0 siblings, 0 replies; 28+ messages in thread
From: Dafna Hirschfeld @ 2020-01-21 14:55 UTC (permalink / raw)
To: Rob Herring
Cc: Mark Rutland, devicetree, heiko, David Airlie, dafna3,
黄家钗,
dri-devel, open list:ARM/Rockchip SoC...,
Helen Koike, Daniel Vetter, Collabora Kernel ML, Ezequiel Garcia,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
On 21.01.20 15:03, Rob Herring wrote:
> On Tue, Jan 21, 2020 at 6:35 AM Dafna Hirschfeld
> <dafna.hirschfeld@collabora.com> wrote:
>>
>> convert the binding file rockchip-drm.txt to yaml format.
>> This was tested and verified with:
>> make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
>
> Also, make sure just 'make dt_binding_check' passes as that checks the
> example against all schemas.
But this also checks the other schemas in general, and when running it,
it fails because of bugs in other schemas.
For example with arm=ARM I get:
DTC Documentation/devicetree/bindings/clock/qcom,gcc.example.dt.yaml
Error:
Documentation/devicetree/bindings/clock/qcom,gcc.example.dts:111.28-29
syntax error
FATAL ERROR: Unable to parse input tree
Dafna
>
>> make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
>>
>> Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
>> ---
>> Changes since v1:
>> - fixed worng sign-off
>> - fixed the path of the $id property to be the path of the yaml file
>>
>> .../display/rockchip/rockchip-drm.txt | 19 ----------
>> .../display/rockchip/rockchip-drm.yaml | 38 +++++++++++++++++++
>> 2 files changed, 38 insertions(+), 19 deletions(-)
>> delete mode 100644 Documentation/devicetree/bindings/display/rockchip/rockchip-drm.txt
>> create mode 100644 Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.txt b/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.txt
>> deleted file mode 100644
>> index 5707af89319d..000000000000
>> --- a/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.txt
>> +++ /dev/null
>> @@ -1,19 +0,0 @@
>> -Rockchip DRM master device
>> -================================
>> -
>> -The Rockchip DRM master device is a virtual device needed to list all
>> -vop devices or other display interface nodes that comprise the
>> -graphics subsystem.
>> -
>> -Required properties:
>> -- compatible: Should be "rockchip,display-subsystem"
>> -- ports: Should contain a list of phandles pointing to display interface port
>> - of vop devices. vop definitions as defined in
>> - Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
>> -
>> -example:
>> -
>> -display-subsystem {
>> - compatible = "rockchip,display-subsystem";
>> - ports = <&vopl_out>, <&vopb_out>;
>> -};
>> diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
>> new file mode 100644
>> index 000000000000..538898ada9d1
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
>> @@ -0,0 +1,38 @@
>> +# SPDX-License-Identifier: (GPL-2.0+ OR MIT)
>
> Do you have rights to change the license? The default is GPL-2.0-only.
> Looks like Rockchip owns the copyright.
>
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/display/rockchip/rockchip-drm.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Rockchip DRM master device
>> +
>> +maintainers:
>> + - Sandy Huang <hjc@rock-chips.com
>> + - Heiko Stuebner <heiko@sntech.de>
>> +
>> +description: |
>> + The Rockchip DRM master device is a virtual device needed to list all
>> + vop devices or other display interface nodes that comprise the
>> + graphics subsystem.
>> +
>> +properties:
>> + compatible:
>> + const: rockchip,display-subsystem
>> +
>> + ports:
>> + $ref: /schemas/types.yaml#/definitions/phandle-array
>> + description: |
>> + Should contain a list of phandles pointing to display interface port
>> + of vop devices. vop definitions as defined in
>> + Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
>> +
>> +required:
>> + - compatible
>> + - ports
>
> Add:
>
> additionalProperties: false
>
>> +
>> +examples:
>> + - |
>> + display-subsystem {
>> + compatible = "rockchip,display-subsystem";
>> + ports = <&vopl_out>, <&vopb_out>;
>> + };
>> --
>> 2.17.1
>>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH v2] dt-bindings: convert rockchip-drm.txt to rockchip-drm.yaml
@ 2020-01-21 14:55 ` Dafna Hirschfeld
0 siblings, 0 replies; 28+ messages in thread
From: Dafna Hirschfeld @ 2020-01-21 14:55 UTC (permalink / raw)
To: Rob Herring
Cc: Mark Rutland, devicetree, David Airlie, dafna3,
黄家钗,
dri-devel, open list:ARM/Rockchip SoC...,
Helen Koike, Collabora Kernel ML, Ezequiel Garcia,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
On 21.01.20 15:03, Rob Herring wrote:
> On Tue, Jan 21, 2020 at 6:35 AM Dafna Hirschfeld
> <dafna.hirschfeld@collabora.com> wrote:
>>
>> convert the binding file rockchip-drm.txt to yaml format.
>> This was tested and verified with:
>> make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
>
> Also, make sure just 'make dt_binding_check' passes as that checks the
> example against all schemas.
But this also checks the other schemas in general, and when running it,
it fails because of bugs in other schemas.
For example with arm=ARM I get:
DTC Documentation/devicetree/bindings/clock/qcom,gcc.example.dt.yaml
Error:
Documentation/devicetree/bindings/clock/qcom,gcc.example.dts:111.28-29
syntax error
FATAL ERROR: Unable to parse input tree
Dafna
>
>> make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
>>
>> Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
>> ---
>> Changes since v1:
>> - fixed worng sign-off
>> - fixed the path of the $id property to be the path of the yaml file
>>
>> .../display/rockchip/rockchip-drm.txt | 19 ----------
>> .../display/rockchip/rockchip-drm.yaml | 38 +++++++++++++++++++
>> 2 files changed, 38 insertions(+), 19 deletions(-)
>> delete mode 100644 Documentation/devicetree/bindings/display/rockchip/rockchip-drm.txt
>> create mode 100644 Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.txt b/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.txt
>> deleted file mode 100644
>> index 5707af89319d..000000000000
>> --- a/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.txt
>> +++ /dev/null
>> @@ -1,19 +0,0 @@
>> -Rockchip DRM master device
>> -================================
>> -
>> -The Rockchip DRM master device is a virtual device needed to list all
>> -vop devices or other display interface nodes that comprise the
>> -graphics subsystem.
>> -
>> -Required properties:
>> -- compatible: Should be "rockchip,display-subsystem"
>> -- ports: Should contain a list of phandles pointing to display interface port
>> - of vop devices. vop definitions as defined in
>> - Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
>> -
>> -example:
>> -
>> -display-subsystem {
>> - compatible = "rockchip,display-subsystem";
>> - ports = <&vopl_out>, <&vopb_out>;
>> -};
>> diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
>> new file mode 100644
>> index 000000000000..538898ada9d1
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
>> @@ -0,0 +1,38 @@
>> +# SPDX-License-Identifier: (GPL-2.0+ OR MIT)
>
> Do you have rights to change the license? The default is GPL-2.0-only.
> Looks like Rockchip owns the copyright.
>
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/display/rockchip/rockchip-drm.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Rockchip DRM master device
>> +
>> +maintainers:
>> + - Sandy Huang <hjc@rock-chips.com
>> + - Heiko Stuebner <heiko@sntech.de>
>> +
>> +description: |
>> + The Rockchip DRM master device is a virtual device needed to list all
>> + vop devices or other display interface nodes that comprise the
>> + graphics subsystem.
>> +
>> +properties:
>> + compatible:
>> + const: rockchip,display-subsystem
>> +
>> + ports:
>> + $ref: /schemas/types.yaml#/definitions/phandle-array
>> + description: |
>> + Should contain a list of phandles pointing to display interface port
>> + of vop devices. vop definitions as defined in
>> + Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
>> +
>> +required:
>> + - compatible
>> + - ports
>
> Add:
>
> additionalProperties: false
>
>> +
>> +examples:
>> + - |
>> + display-subsystem {
>> + compatible = "rockchip,display-subsystem";
>> + ports = <&vopl_out>, <&vopb_out>;
>> + };
>> --
>> 2.17.1
>>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH v2] dt-bindings: convert rockchip-drm.txt to rockchip-drm.yaml
@ 2020-01-21 15:11 ` Johan Jonker
0 siblings, 0 replies; 28+ messages in thread
From: Johan Jonker @ 2020-01-21 15:11 UTC (permalink / raw)
To: dafna.hirschfeld
Cc: airlied, dafna3, daniel, devicetree, dri-devel, ezequiel, heiko,
helen.koike, hjc, kernel, linux-arm-kernel, linux-rockchip,
mark.rutland, robh+dt
Hi Dafna,
>
>
> On 21.01.20 15:03, Rob Herring wrote:
>> On Tue, Jan 21, 2020 at 6:35 AM Dafna Hirschfeld
>> <dafna.hirschfeld@collabora.com> wrote:
>>>
>>> convert the binding file rockchip-drm.txt to yaml format.
>>> This was tested and verified with:
>>> make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
>>
>> Also, make sure just 'make dt_binding_check' passes as that checks the
>> example against all schemas.
>
> But this also checks the other schemas in general, and when running it,
> it fails because of bugs in other schemas.
> For example with arm=ARM I get:
Use:
# enable Rockchip arm in menuconfig
make ARCH=arm menuconfig
make ARCH=arm dt_binding_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
and not:
arm=ARM
>
> DTC Documentation/devicetree/bindings/clock/qcom,gcc.example.dt.yaml
> Error:
> Documentation/devicetree/bindings/clock/qcom,gcc.example.dts:111.28-29
> syntax error
> FATAL ERROR: Unable to parse input tree
>
> Dafna
>
>>
>>> make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
>>>
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH v2] dt-bindings: convert rockchip-drm.txt to rockchip-drm.yaml
@ 2020-01-21 15:11 ` Johan Jonker
0 siblings, 0 replies; 28+ messages in thread
From: Johan Jonker @ 2020-01-21 15:11 UTC (permalink / raw)
To: dafna.hirschfeld-ZGY8ohtN/8qB+jHODAdFcQ
Cc: airlied-cv59FeDIM0c, dafna3-Re5JQEeQqe8AvxtiuMwx3w,
daniel-/w4YWyX8dFk, devicetree-u79uwXL29TY76Z2rM5mHXA,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
ezequiel-ZGY8ohtN/8qB+jHODAdFcQ, heiko-4mtYJXux2i+zQB+pC5nmwQ,
helen.koike-ZGY8ohtN/8qB+jHODAdFcQ, hjc-TNX95d0MmH7DzftRWevZcw,
kernel-ZGY8ohtN/8qB+jHODAdFcQ,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
mark.rutland-5wv7dgnIgG8, robh+dt-DgEjT+Ai2ygdnm+yROfE0A
Hi Dafna,
>
>
> On 21.01.20 15:03, Rob Herring wrote:
>> On Tue, Jan 21, 2020 at 6:35 AM Dafna Hirschfeld
>> <dafna.hirschfeld-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org> wrote:
>>>
>>> convert the binding file rockchip-drm.txt to yaml format.
>>> This was tested and verified with:
>>> make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
>>
>> Also, make sure just 'make dt_binding_check' passes as that checks the
>> example against all schemas.
>
> But this also checks the other schemas in general, and when running it,
> it fails because of bugs in other schemas.
> For example with arm=ARM I get:
Use:
# enable Rockchip arm in menuconfig
make ARCH=arm menuconfig
make ARCH=arm dt_binding_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
and not:
arm=ARM
>
> DTC Documentation/devicetree/bindings/clock/qcom,gcc.example.dt.yaml
> Error:
> Documentation/devicetree/bindings/clock/qcom,gcc.example.dts:111.28-29
> syntax error
> FATAL ERROR: Unable to parse input tree
>
> Dafna
>
>>
>>> make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
>>>
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH v2] dt-bindings: convert rockchip-drm.txt to rockchip-drm.yaml
@ 2020-01-21 15:11 ` Johan Jonker
0 siblings, 0 replies; 28+ messages in thread
From: Johan Jonker @ 2020-01-21 15:11 UTC (permalink / raw)
To: dafna.hirschfeld
Cc: mark.rutland, devicetree, heiko, airlied, dafna3, hjc, dri-devel,
linux-rockchip, helen.koike, robh+dt, daniel, kernel, ezequiel,
linux-arm-kernel
Hi Dafna,
>
>
> On 21.01.20 15:03, Rob Herring wrote:
>> On Tue, Jan 21, 2020 at 6:35 AM Dafna Hirschfeld
>> <dafna.hirschfeld@collabora.com> wrote:
>>>
>>> convert the binding file rockchip-drm.txt to yaml format.
>>> This was tested and verified with:
>>> make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
>>
>> Also, make sure just 'make dt_binding_check' passes as that checks the
>> example against all schemas.
>
> But this also checks the other schemas in general, and when running it,
> it fails because of bugs in other schemas.
> For example with arm=ARM I get:
Use:
# enable Rockchip arm in menuconfig
make ARCH=arm menuconfig
make ARCH=arm dt_binding_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
and not:
arm=ARM
>
> DTC Documentation/devicetree/bindings/clock/qcom,gcc.example.dt.yaml
> Error:
> Documentation/devicetree/bindings/clock/qcom,gcc.example.dts:111.28-29
> syntax error
> FATAL ERROR: Unable to parse input tree
>
> Dafna
>
>>
>>> make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
>>>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH v2] dt-bindings: convert rockchip-drm.txt to rockchip-drm.yaml
@ 2020-01-21 15:11 ` Johan Jonker
0 siblings, 0 replies; 28+ messages in thread
From: Johan Jonker @ 2020-01-21 15:11 UTC (permalink / raw)
To: dafna.hirschfeld
Cc: mark.rutland, devicetree, airlied, dafna3, hjc, dri-devel,
linux-rockchip, helen.koike, robh+dt, kernel, ezequiel,
linux-arm-kernel
Hi Dafna,
>
>
> On 21.01.20 15:03, Rob Herring wrote:
>> On Tue, Jan 21, 2020 at 6:35 AM Dafna Hirschfeld
>> <dafna.hirschfeld@collabora.com> wrote:
>>>
>>> convert the binding file rockchip-drm.txt to yaml format.
>>> This was tested and verified with:
>>> make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
>>
>> Also, make sure just 'make dt_binding_check' passes as that checks the
>> example against all schemas.
>
> But this also checks the other schemas in general, and when running it,
> it fails because of bugs in other schemas.
> For example with arm=ARM I get:
Use:
# enable Rockchip arm in menuconfig
make ARCH=arm menuconfig
make ARCH=arm dt_binding_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
and not:
arm=ARM
>
> DTC Documentation/devicetree/bindings/clock/qcom,gcc.example.dt.yaml
> Error:
> Documentation/devicetree/bindings/clock/qcom,gcc.example.dts:111.28-29
> syntax error
> FATAL ERROR: Unable to parse input tree
>
> Dafna
>
>>
>>> make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
>>>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH v2] dt-bindings: convert rockchip-drm.txt to rockchip-drm.yaml
@ 2020-01-21 15:26 ` Dafna Hirschfeld
0 siblings, 0 replies; 28+ messages in thread
From: Dafna Hirschfeld @ 2020-01-21 15:26 UTC (permalink / raw)
To: Johan Jonker
Cc: airlied, dafna3, daniel, devicetree, dri-devel, ezequiel, heiko,
helen.koike, hjc, kernel, linux-arm-kernel, linux-rockchip,
mark.rutland, robh+dt
On 21.01.20 16:11, Johan Jonker wrote:
> Hi Dafna,
>
>
>>
>>
>> On 21.01.20 15:03, Rob Herring wrote:
>>> On Tue, Jan 21, 2020 at 6:35 AM Dafna Hirschfeld
>>> <dafna.hirschfeld@collabora.com> wrote:
>>>>
>>>> convert the binding file rockchip-drm.txt to yaml format.
>>>> This was tested and verified with:
>>>> make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
>>>
>>> Also, make sure just 'make dt_binding_check' passes as that checks the
>>> example against all schemas.
>>
>> But this also checks the other schemas in general, and when running it,
>> it fails because of bugs in other schemas.
>
>
>> For example with arm=ARM I get:
>
> Use:
>
> # enable Rockchip arm in menuconfig
> make ARCH=arm menuconfig
>
> make ARCH=arm dt_binding_check
> DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
>
> and not:
> arm=ARM
>
yes, sorry, this is what I did. When running with the DT_SCHEMA_FILES
set then it passes both on ARM and ARM64
but when this variable is not set I get the above error.
Dafna
>
>>
>> DTC Documentation/devicetree/bindings/clock/qcom,gcc.example.dt.yaml
>> Error:
>> Documentation/devicetree/bindings/clock/qcom,gcc.example.dts:111.28-29
>> syntax error
>> FATAL ERROR: Unable to parse input tree
>>
>> Dafna
>>
>>>
>>>> make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
>>>>
>
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH v2] dt-bindings: convert rockchip-drm.txt to rockchip-drm.yaml
@ 2020-01-21 15:26 ` Dafna Hirschfeld
0 siblings, 0 replies; 28+ messages in thread
From: Dafna Hirschfeld @ 2020-01-21 15:26 UTC (permalink / raw)
To: Johan Jonker
Cc: airlied-cv59FeDIM0c, dafna3-Re5JQEeQqe8AvxtiuMwx3w,
daniel-/w4YWyX8dFk, devicetree-u79uwXL29TY76Z2rM5mHXA,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
ezequiel-ZGY8ohtN/8qB+jHODAdFcQ, heiko-4mtYJXux2i+zQB+pC5nmwQ,
helen.koike-ZGY8ohtN/8qB+jHODAdFcQ, hjc-TNX95d0MmH7DzftRWevZcw,
kernel-ZGY8ohtN/8qB+jHODAdFcQ,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
mark.rutland-5wv7dgnIgG8, robh+dt-DgEjT+Ai2ygdnm+yROfE0A
On 21.01.20 16:11, Johan Jonker wrote:
> Hi Dafna,
>
>
>>
>>
>> On 21.01.20 15:03, Rob Herring wrote:
>>> On Tue, Jan 21, 2020 at 6:35 AM Dafna Hirschfeld
>>> <dafna.hirschfeld-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org> wrote:
>>>>
>>>> convert the binding file rockchip-drm.txt to yaml format.
>>>> This was tested and verified with:
>>>> make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
>>>
>>> Also, make sure just 'make dt_binding_check' passes as that checks the
>>> example against all schemas.
>>
>> But this also checks the other schemas in general, and when running it,
>> it fails because of bugs in other schemas.
>
>
>> For example with arm=ARM I get:
>
> Use:
>
> # enable Rockchip arm in menuconfig
> make ARCH=arm menuconfig
>
> make ARCH=arm dt_binding_check
> DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
>
> and not:
> arm=ARM
>
yes, sorry, this is what I did. When running with the DT_SCHEMA_FILES
set then it passes both on ARM and ARM64
but when this variable is not set I get the above error.
Dafna
>
>>
>> DTC Documentation/devicetree/bindings/clock/qcom,gcc.example.dt.yaml
>> Error:
>> Documentation/devicetree/bindings/clock/qcom,gcc.example.dts:111.28-29
>> syntax error
>> FATAL ERROR: Unable to parse input tree
>>
>> Dafna
>>
>>>
>>>> make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
>>>>
>
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH v2] dt-bindings: convert rockchip-drm.txt to rockchip-drm.yaml
@ 2020-01-21 15:26 ` Dafna Hirschfeld
0 siblings, 0 replies; 28+ messages in thread
From: Dafna Hirschfeld @ 2020-01-21 15:26 UTC (permalink / raw)
To: Johan Jonker
Cc: mark.rutland, devicetree, heiko, airlied, dafna3, hjc, dri-devel,
linux-rockchip, helen.koike, robh+dt, daniel, kernel, ezequiel,
linux-arm-kernel
On 21.01.20 16:11, Johan Jonker wrote:
> Hi Dafna,
>
>
>>
>>
>> On 21.01.20 15:03, Rob Herring wrote:
>>> On Tue, Jan 21, 2020 at 6:35 AM Dafna Hirschfeld
>>> <dafna.hirschfeld@collabora.com> wrote:
>>>>
>>>> convert the binding file rockchip-drm.txt to yaml format.
>>>> This was tested and verified with:
>>>> make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
>>>
>>> Also, make sure just 'make dt_binding_check' passes as that checks the
>>> example against all schemas.
>>
>> But this also checks the other schemas in general, and when running it,
>> it fails because of bugs in other schemas.
>
>
>> For example with arm=ARM I get:
>
> Use:
>
> # enable Rockchip arm in menuconfig
> make ARCH=arm menuconfig
>
> make ARCH=arm dt_binding_check
> DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
>
> and not:
> arm=ARM
>
yes, sorry, this is what I did. When running with the DT_SCHEMA_FILES
set then it passes both on ARM and ARM64
but when this variable is not set I get the above error.
Dafna
>
>>
>> DTC Documentation/devicetree/bindings/clock/qcom,gcc.example.dt.yaml
>> Error:
>> Documentation/devicetree/bindings/clock/qcom,gcc.example.dts:111.28-29
>> syntax error
>> FATAL ERROR: Unable to parse input tree
>>
>> Dafna
>>
>>>
>>>> make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
>>>>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH v2] dt-bindings: convert rockchip-drm.txt to rockchip-drm.yaml
@ 2020-01-21 15:26 ` Dafna Hirschfeld
0 siblings, 0 replies; 28+ messages in thread
From: Dafna Hirschfeld @ 2020-01-21 15:26 UTC (permalink / raw)
To: Johan Jonker
Cc: mark.rutland, devicetree, airlied, dafna3, hjc, dri-devel,
linux-rockchip, helen.koike, robh+dt, kernel, ezequiel,
linux-arm-kernel
On 21.01.20 16:11, Johan Jonker wrote:
> Hi Dafna,
>
>
>>
>>
>> On 21.01.20 15:03, Rob Herring wrote:
>>> On Tue, Jan 21, 2020 at 6:35 AM Dafna Hirschfeld
>>> <dafna.hirschfeld@collabora.com> wrote:
>>>>
>>>> convert the binding file rockchip-drm.txt to yaml format.
>>>> This was tested and verified with:
>>>> make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
>>>
>>> Also, make sure just 'make dt_binding_check' passes as that checks the
>>> example against all schemas.
>>
>> But this also checks the other schemas in general, and when running it,
>> it fails because of bugs in other schemas.
>
>
>> For example with arm=ARM I get:
>
> Use:
>
> # enable Rockchip arm in menuconfig
> make ARCH=arm menuconfig
>
> make ARCH=arm dt_binding_check
> DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
>
> and not:
> arm=ARM
>
yes, sorry, this is what I did. When running with the DT_SCHEMA_FILES
set then it passes both on ARM and ARM64
but when this variable is not set I get the above error.
Dafna
>
>>
>> DTC Documentation/devicetree/bindings/clock/qcom,gcc.example.dt.yaml
>> Error:
>> Documentation/devicetree/bindings/clock/qcom,gcc.example.dts:111.28-29
>> syntax error
>> FATAL ERROR: Unable to parse input tree
>>
>> Dafna
>>
>>>
>>>> make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
>>>>
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH v2] dt-bindings: convert rockchip-drm.txt to rockchip-drm.yaml
@ 2020-01-21 16:00 ` Johan Jonker
0 siblings, 0 replies; 28+ messages in thread
From: Johan Jonker @ 2020-01-21 16:00 UTC (permalink / raw)
To: Dafna Hirschfeld
Cc: airlied, dafna3, daniel, devicetree, dri-devel, ezequiel, heiko,
helen.koike, hjc, kernel, linux-arm-kernel, linux-rockchip,
mark.rutland, robh+dt
Hi,
On 1/21/20 4:26 PM, Dafna Hirschfeld wrote:
>
>
> On 21.01.20 16:11, Johan Jonker wrote:
>> Hi Dafna,
>>
>>
>>>
>>>
>>> On 21.01.20 15:03, Rob Herring wrote:
>>>> On Tue, Jan 21, 2020 at 6:35 AM Dafna Hirschfeld
>>>> <dafna.hirschfeld@collabora.com> wrote:
>>>>>
>>>>> convert the binding file rockchip-drm.txt to yaml format.
>>>>> This was tested and verified with:
>>>>> make dt_binding_check
>>>>> DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
>>>>>
>>>>
>>>> Also, make sure just 'make dt_binding_check' passes as that checks the
>>>> example against all schemas.
>>>
>>> But this also checks the other schemas in general, and when running it,
>>> it fails because of bugs in other schemas.
>>
>>
>>> For example with arm=ARM I get:
>>
>> Use:
>>
>> # enable Rockchip arm in menuconfig
>> make ARCH=arm menuconfig
>>
>> make ARCH=arm dt_binding_check
>> DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
>>
>>
>> and not:
>> arm=ARM
>>
> yes, sorry, this is what I did. When running with the DT_SCHEMA_FILES
> set then it passes both on ARM and ARM64
> but when this variable is not set I get the above error.
# for Intel use:
make dtbs_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
# for Rockchip use:
make ARCH=arm dtbs_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
make ARCH=arm64 dtbs_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
Also change:
example:
Reduce some spaces here.
Also remove "|" from description.
See:
description: |
A more detailed multi-line description of the binding.
Details about the hardware device and any links to datasheets can go here.
Literal blocks are marked with the '|' at the beginning. The end is
marked by
indentation less than the first line of the literal block. Lines also
cannot
begin with a tab character.
>
> Dafna
>
>>
>>>
>>> DTC
>>> Documentation/devicetree/bindings/clock/qcom,gcc.example.dt.yaml
>>> Error:
>>> Documentation/devicetree/bindings/clock/qcom,gcc.example.dts:111.28-29
>>> syntax error
>>> FATAL ERROR: Unable to parse input tree
>>>
>>> Dafna
>>>
>>>>
>>>>> make dtbs_check
>>>>> DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
>>>>>
>>>>>
>>
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH v2] dt-bindings: convert rockchip-drm.txt to rockchip-drm.yaml
@ 2020-01-21 16:00 ` Johan Jonker
0 siblings, 0 replies; 28+ messages in thread
From: Johan Jonker @ 2020-01-21 16:00 UTC (permalink / raw)
To: Dafna Hirschfeld
Cc: airlied-cv59FeDIM0c, dafna3-Re5JQEeQqe8AvxtiuMwx3w,
daniel-/w4YWyX8dFk, devicetree-u79uwXL29TY76Z2rM5mHXA,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
ezequiel-ZGY8ohtN/8qB+jHODAdFcQ, heiko-4mtYJXux2i+zQB+pC5nmwQ,
helen.koike-ZGY8ohtN/8qB+jHODAdFcQ, hjc-TNX95d0MmH7DzftRWevZcw,
kernel-ZGY8ohtN/8qB+jHODAdFcQ,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
mark.rutland-5wv7dgnIgG8, robh+dt-DgEjT+Ai2ygdnm+yROfE0A
Hi,
On 1/21/20 4:26 PM, Dafna Hirschfeld wrote:
>
>
> On 21.01.20 16:11, Johan Jonker wrote:
>> Hi Dafna,
>>
>>
>>>
>>>
>>> On 21.01.20 15:03, Rob Herring wrote:
>>>> On Tue, Jan 21, 2020 at 6:35 AM Dafna Hirschfeld
>>>> <dafna.hirschfeld-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org> wrote:
>>>>>
>>>>> convert the binding file rockchip-drm.txt to yaml format.
>>>>> This was tested and verified with:
>>>>> make dt_binding_check
>>>>> DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
>>>>>
>>>>
>>>> Also, make sure just 'make dt_binding_check' passes as that checks the
>>>> example against all schemas.
>>>
>>> But this also checks the other schemas in general, and when running it,
>>> it fails because of bugs in other schemas.
>>
>>
>>> For example with arm=ARM I get:
>>
>> Use:
>>
>> # enable Rockchip arm in menuconfig
>> make ARCH=arm menuconfig
>>
>> make ARCH=arm dt_binding_check
>> DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
>>
>>
>> and not:
>> arm=ARM
>>
> yes, sorry, this is what I did. When running with the DT_SCHEMA_FILES
> set then it passes both on ARM and ARM64
> but when this variable is not set I get the above error.
# for Intel use:
make dtbs_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
# for Rockchip use:
make ARCH=arm dtbs_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
make ARCH=arm64 dtbs_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
Also change:
example:
Reduce some spaces here.
Also remove "|" from description.
See:
description: |
A more detailed multi-line description of the binding.
Details about the hardware device and any links to datasheets can go here.
Literal blocks are marked with the '|' at the beginning. The end is
marked by
indentation less than the first line of the literal block. Lines also
cannot
begin with a tab character.
>
> Dafna
>
>>
>>>
>>> DTC
>>> Documentation/devicetree/bindings/clock/qcom,gcc.example.dt.yaml
>>> Error:
>>> Documentation/devicetree/bindings/clock/qcom,gcc.example.dts:111.28-29
>>> syntax error
>>> FATAL ERROR: Unable to parse input tree
>>>
>>> Dafna
>>>
>>>>
>>>>> make dtbs_check
>>>>> DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
>>>>>
>>>>>
>>
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH v2] dt-bindings: convert rockchip-drm.txt to rockchip-drm.yaml
@ 2020-01-21 16:00 ` Johan Jonker
0 siblings, 0 replies; 28+ messages in thread
From: Johan Jonker @ 2020-01-21 16:00 UTC (permalink / raw)
To: Dafna Hirschfeld
Cc: mark.rutland, devicetree, heiko, airlied, dafna3, hjc, dri-devel,
linux-rockchip, helen.koike, robh+dt, daniel, kernel, ezequiel,
linux-arm-kernel
Hi,
On 1/21/20 4:26 PM, Dafna Hirschfeld wrote:
>
>
> On 21.01.20 16:11, Johan Jonker wrote:
>> Hi Dafna,
>>
>>
>>>
>>>
>>> On 21.01.20 15:03, Rob Herring wrote:
>>>> On Tue, Jan 21, 2020 at 6:35 AM Dafna Hirschfeld
>>>> <dafna.hirschfeld@collabora.com> wrote:
>>>>>
>>>>> convert the binding file rockchip-drm.txt to yaml format.
>>>>> This was tested and verified with:
>>>>> make dt_binding_check
>>>>> DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
>>>>>
>>>>
>>>> Also, make sure just 'make dt_binding_check' passes as that checks the
>>>> example against all schemas.
>>>
>>> But this also checks the other schemas in general, and when running it,
>>> it fails because of bugs in other schemas.
>>
>>
>>> For example with arm=ARM I get:
>>
>> Use:
>>
>> # enable Rockchip arm in menuconfig
>> make ARCH=arm menuconfig
>>
>> make ARCH=arm dt_binding_check
>> DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
>>
>>
>> and not:
>> arm=ARM
>>
> yes, sorry, this is what I did. When running with the DT_SCHEMA_FILES
> set then it passes both on ARM and ARM64
> but when this variable is not set I get the above error.
# for Intel use:
make dtbs_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
# for Rockchip use:
make ARCH=arm dtbs_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
make ARCH=arm64 dtbs_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
Also change:
example:
Reduce some spaces here.
Also remove "|" from description.
See:
description: |
A more detailed multi-line description of the binding.
Details about the hardware device and any links to datasheets can go here.
Literal blocks are marked with the '|' at the beginning. The end is
marked by
indentation less than the first line of the literal block. Lines also
cannot
begin with a tab character.
>
> Dafna
>
>>
>>>
>>> DTC
>>> Documentation/devicetree/bindings/clock/qcom,gcc.example.dt.yaml
>>> Error:
>>> Documentation/devicetree/bindings/clock/qcom,gcc.example.dts:111.28-29
>>> syntax error
>>> FATAL ERROR: Unable to parse input tree
>>>
>>> Dafna
>>>
>>>>
>>>>> make dtbs_check
>>>>> DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
>>>>>
>>>>>
>>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH v2] dt-bindings: convert rockchip-drm.txt to rockchip-drm.yaml
@ 2020-01-21 16:00 ` Johan Jonker
0 siblings, 0 replies; 28+ messages in thread
From: Johan Jonker @ 2020-01-21 16:00 UTC (permalink / raw)
To: Dafna Hirschfeld
Cc: mark.rutland, devicetree, airlied, dafna3, hjc, dri-devel,
linux-rockchip, helen.koike, robh+dt, kernel, ezequiel,
linux-arm-kernel
Hi,
On 1/21/20 4:26 PM, Dafna Hirschfeld wrote:
>
>
> On 21.01.20 16:11, Johan Jonker wrote:
>> Hi Dafna,
>>
>>
>>>
>>>
>>> On 21.01.20 15:03, Rob Herring wrote:
>>>> On Tue, Jan 21, 2020 at 6:35 AM Dafna Hirschfeld
>>>> <dafna.hirschfeld@collabora.com> wrote:
>>>>>
>>>>> convert the binding file rockchip-drm.txt to yaml format.
>>>>> This was tested and verified with:
>>>>> make dt_binding_check
>>>>> DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
>>>>>
>>>>
>>>> Also, make sure just 'make dt_binding_check' passes as that checks the
>>>> example against all schemas.
>>>
>>> But this also checks the other schemas in general, and when running it,
>>> it fails because of bugs in other schemas.
>>
>>
>>> For example with arm=ARM I get:
>>
>> Use:
>>
>> # enable Rockchip arm in menuconfig
>> make ARCH=arm menuconfig
>>
>> make ARCH=arm dt_binding_check
>> DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
>>
>>
>> and not:
>> arm=ARM
>>
> yes, sorry, this is what I did. When running with the DT_SCHEMA_FILES
> set then it passes both on ARM and ARM64
> but when this variable is not set I get the above error.
# for Intel use:
make dtbs_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
# for Rockchip use:
make ARCH=arm dtbs_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
make ARCH=arm64 dtbs_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
Also change:
example:
Reduce some spaces here.
Also remove "|" from description.
See:
description: |
A more detailed multi-line description of the binding.
Details about the hardware device and any links to datasheets can go here.
Literal blocks are marked with the '|' at the beginning. The end is
marked by
indentation less than the first line of the literal block. Lines also
cannot
begin with a tab character.
>
> Dafna
>
>>
>>>
>>> DTC
>>> Documentation/devicetree/bindings/clock/qcom,gcc.example.dt.yaml
>>> Error:
>>> Documentation/devicetree/bindings/clock/qcom,gcc.example.dts:111.28-29
>>> syntax error
>>> FATAL ERROR: Unable to parse input tree
>>>
>>> Dafna
>>>
>>>>
>>>>> make dtbs_check
>>>>> DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml
>>>>>
>>>>>
>>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 28+ messages in thread
end of thread, other threads:[~2020-01-22 8:23 UTC | newest]
Thread overview: 28+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-21 12:34 [PATCH v2] dt-bindings: convert rockchip-drm.txt to rockchip-drm.yaml Dafna Hirschfeld
2020-01-21 12:34 ` Dafna Hirschfeld
2020-01-21 12:34 ` Dafna Hirschfeld
2020-01-21 12:34 ` Dafna Hirschfeld
2020-01-21 13:11 ` Johan Jonker
2020-01-21 13:11 ` Johan Jonker
2020-01-21 13:11 ` Johan Jonker
2020-01-21 13:11 ` Johan Jonker
2020-01-21 14:03 ` Rob Herring
2020-01-21 14:03 ` Rob Herring
2020-01-21 14:03 ` Rob Herring
2020-01-21 14:03 ` Rob Herring
2020-01-21 14:55 ` Dafna Hirschfeld
2020-01-21 14:55 ` Dafna Hirschfeld
2020-01-21 14:55 ` Dafna Hirschfeld
2020-01-21 14:55 ` Dafna Hirschfeld
2020-01-21 15:11 ` Johan Jonker
2020-01-21 15:11 ` Johan Jonker
2020-01-21 15:11 ` Johan Jonker
2020-01-21 15:11 ` Johan Jonker
2020-01-21 15:26 ` Dafna Hirschfeld
2020-01-21 15:26 ` Dafna Hirschfeld
2020-01-21 15:26 ` Dafna Hirschfeld
2020-01-21 15:26 ` Dafna Hirschfeld
2020-01-21 16:00 ` Johan Jonker
2020-01-21 16:00 ` Johan Jonker
2020-01-21 16:00 ` Johan Jonker
2020-01-21 16:00 ` Johan Jonker
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.