* [PATCH] block: Declearing print_disk_stats static to remove [-Wmissing-prototypes]
@ 2021-06-30 20:37 Abd-Alrhman Masalkhi
2021-06-30 20:38 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Abd-Alrhman Masalkhi @ 2021-06-30 20:37 UTC (permalink / raw)
To: axboe; +Cc: linux-block, linux-kernel, Abd-Alrhman Masalkhi, kernel test robot
In the first patch I have not defined the print_disk_stats function
static so it triggered an [-Wmissing-prototypes] warning, fixing it
by defineing the function static.
Signed-off-by: Abd-Alrhman Masalkhi <abd.masalkhi@gmail.com>
Reported-by: kernel test robot <lkp@intel.com>
---
block/genhd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/block/genhd.c b/block/genhd.c
index 5d393b2bc62c..803c3448f09a 100644
--- a/block/genhd.c
+++ b/block/genhd.c
@@ -1107,8 +1107,8 @@ const struct device_type disk_type = {
#ifdef CONFIG_PROC_FS
-void print_disk_stats(struct seq_file *seqf,
- unsigned int inflight, struct disk_stats *stat)
+static void print_disk_stats(struct seq_file *seqf,
+ unsigned int inflight, struct disk_stats *stat)
{
seq_printf(seqf, "%lu %lu %lu %u "
"%lu %lu %lu %u "
--
2.29.0.rc1.dirty
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] block: Declearing print_disk_stats static to remove [-Wmissing-prototypes]
2021-06-30 20:37 [PATCH] block: Declearing print_disk_stats static to remove [-Wmissing-prototypes] Abd-Alrhman Masalkhi
@ 2021-06-30 20:38 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2021-06-30 20:38 UTC (permalink / raw)
To: Abd-Alrhman Masalkhi; +Cc: linux-block, linux-kernel, kernel test robot
On 6/30/21 2:37 PM, Abd-Alrhman Masalkhi wrote:
> In the first patch I have not defined the print_disk_stats function
> static so it triggered an [-Wmissing-prototypes] warning, fixing it
> by defineing the function static.
Just send a v2 of the patch, there's no point in applying a known
broken patch to then just do a followup of it.
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-30 20:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-30 20:37 [PATCH] block: Declearing print_disk_stats static to remove [-Wmissing-prototypes] Abd-Alrhman Masalkhi
2021-06-30 20:38 ` Jens Axboe
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.